Re: [PATCH 14/20] 10_linux.in 20_linux_xen.in: Don't say "GNU/Linux" in generated menus.

Official stand of FSF and GNU project is that the correct name is GNU/Linux. The only case where this could be justified is for non-GNU variants like BusyBox distros or Android Le lun. 30 sept. 2024, 20:48, Leo Sandoval a écrit : > From: Peter Jones > > [rharwood: say it even less] > --- > gru

Re: [PATCH 14/20] 10_linux.in 20_linux_xen.in: Don't say "GNU/Linux" in generated menus.

Leo Sandoval writes: > From: Peter Jones > > [rharwood: say it even less] > --- > grub-core/normal/main.c | 2 +- > tests/util/grub-shell-tester.in | 2 +- > tests/util/grub-shell.in| 2 +- > util/grub.d/10_linux.in | 4 ++-- > util/grub.d/20_linux_xen.in | 4 ++-- >

Re: [PATCH] LVM cachevol support

On Mon, Sep 30, 2024 at 3:07 PM Scottie Shore wrote: > > The +suffix format is described as a status flag here: > https://gitlab.com/lvmteam/lvm2/-/blob/main/lib/format_text/flags.c#L238 > > I've kept the match simple and in the style of the code around it. There's a > need for dedicated function

[PATCH 1/1] Detect cachevol LVs

--- grub-core/disk/lvm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/grub-core/disk/lvm.c b/grub-core/disk/lvm.c index 0c32c95f9..661280d3d 100644 --- a/grub-core/disk/lvm.c +++ b/grub-core/disk/lvm.c @@ -808,7 +808,10 @@ grub_lvm_detect (grub_disk_t disk,

[PATCH 0/1] LVM cachevol support

Sorry for missing patch. Still getting the hang of git send-email. Short patch to support LVM cachevol, LVs with segment type "cache+CACHE_USES_CACHEVOL". This extends existing cachepool support. The +suffix format is described as a status flag here: https://gitlab.com/lvmteam/lvm2/-/blob/main/l

Re: [PATCH 05/20] normal/menu: Allow "fallback" to include entries by title, not just number.

Using titles is broken concept and the only reason we support it in default is backwards compatibility. Maybe it's better to restrict it to just IDs Le lun. 30 sept. 2024, 20:48, Leo Sandoval a écrit : > From: Peter Jones > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1026084 > > Sig

Re: [PATCH 11/20] blscfg: add blscfg module to parse Boot Loader Specification snippets

This is already being reviewed in separate thread Le lun. 30 sept. 2024, 20:46, Leo Sandoval a écrit : > From: Peter Jones > > The BootLoaderSpec (BLS) defines a scheme where different bootloaders can > share a format for boot items and a configuration directory that accepts > these common conf

Re: [PATCH] LVM cachevol support

You seem to have forgotten the patch Le lun. 30 sept. 2024, 22:07, Scottie Shore a écrit : > The +suffix format is described as a status flag here: > https://gitlab.com/lvmteam/lvm2/-/blob/main/lib/format_text/flags.c#L238 > > I've kept the match simple and in the style of the code around it. Th

Re: [PATCH 03/20] ieee1275: Disable GRUB video support for IBM power machines

This needs a detailed comment in quirks code as to why we disable video mode. Le lun. 30 sept. 2024, 20:47, Leo Sandoval a écrit : > From: Paulo Flabiano Smorigo > > Should fix the problem in bugzilla: > https://bugzilla.redhat.com/show_bug.cgi?id=973205 > > Signed-off-by: Paulo Flabiano Smorig

[PATCH] LVM cachevol support

The +suffix format is described as a status flag here: https://gitlab.com/lvmteam/lvm2/-/blob/main/lib/format_text/flags.c#L238 I've kept the match simple and in the style of the code around it. There's a need for dedicated functions to iterate through the LVM MDA, but that's a much larger scope

Re: [PATCH 08/20] 20_ppc_terminfo.in: Migrate PPC from Yaboot to Grub2

Why is it ppc-specific? Le lun. 30 sept. 2024, 20:49, Leo Sandoval a écrit : > From: Mark Hamzy > > Add configuration support for serial terminal consoles. This will set > the maximum screen size so that text is not overwritten. > > Signed-off-by: Mark Hamzy > Signed-off-by: Robbie Harwood >

[PATCH 16/20] 10_linux.in: Don't require a password to boot entries generated by grub-mkconfig.

From: Peter Jones When we set a password, we just want that to mean you can't /edit/ an entry. Resolves: rhbz#1030176 Signed-off-by: Peter Jones --- util/grub.d/10_linux.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/grub.d/10_linux.in b/util/grub.d/10_linux.in in

[PATCH 08/20] 20_ppc_terminfo.in: Migrate PPC from Yaboot to Grub2

From: Mark Hamzy Add configuration support for serial terminal consoles. This will set the maximum screen size so that text is not overwritten. Signed-off-by: Mark Hamzy Signed-off-by: Robbie Harwood --- Makefile.util.def | 7 ++ util/grub.d/20_ppc_terminfo.in | 114 ++

[PATCH 20/20] normal/main: Try $prefix if $fw_path doesn't work.

From: Peter Jones Related: rhbz#1148652 Signed-off-by: Peter Jones --- grub-core/kern/ieee1275/init.c | 28 +++ grub-core/net/net.c| 2 +- grub-core/normal/main.c| 132 - 3 files changed, 81 insertions(+), 81 deletions(-) diff --git a

[PATCH 13/20] 00_header.in: Enable pager by default. (#985860)

From: Peter Jones Signed-off-by: Peter Jones --- util/grub.d/00_header.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/util/grub.d/00_header.in b/util/grub.d/00_header.in index 6a316a5ba..c2d8b0937 100644 --- a/util/grub.d/00_header.in +++ b/util/grub.d/00_header.in @@ -43,6 +43,8 @@ i

[PATCH 05/20] normal/menu: Allow "fallback" to include entries by title, not just number.

From: Peter Jones Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1026084 Signed-off-by: Peter Jones --- grub-core/normal/menu.c | 85 - 1 file changed, 58 insertions(+), 27 deletions(-) diff --git a/grub-core/normal/menu.c b/grub-core/normal/menu

[PATCH 07/20] efi/init: Make efi machines load an env block from a variable

From: Peter Jones Signed-off-by: Peter Jones --- grub-core/Makefile.core.def | 1 + grub-core/kern/efi/init.c | 34 ++ 2 files changed, 35 insertions(+) diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def index 1571421d7..0bffbfea9 100644 -

[PATCH 19/20] 10_linux.in: Generate OS and CLASS in 10_linux from /etc/os-release

From: Peter Jones This makes us use pretty names in the titles we generate in grub2-mkconfig when GRUB_DISTRIBUTOR isn't set. Resolves: rhbz#996794 Signed-off-by: Peter Jones --- util/grub.d/10_linux.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util/grub.d/10_linux

[PATCH 14/20] 10_linux.in 20_linux_xen.in: Don't say "GNU/Linux" in generated menus.

From: Peter Jones [rharwood: say it even less] --- grub-core/normal/main.c | 2 +- tests/util/grub-shell-tester.in | 2 +- tests/util/grub-shell.in| 2 +- util/grub.d/10_linux.in | 4 ++-- util/grub.d/20_linux_xen.in | 4 ++-- 5 files changed, 7 insertions(+), 7 delet

[PATCH 18/20] normal/main: Try mac/guid/etc before grub.cfg on tftp config files.

From: Peter Jones Signed-off-by: Peter Jones --- grub-core/normal/main.c | 93 ++--- 1 file changed, 49 insertions(+), 44 deletions(-) diff --git a/grub-core/normal/main.c b/grub-core/normal/main.c index 0b2bbee19..4c89892fa 100644 --- a/grub-core/normal/mai

[PATCH 12/20] 10_linux.in: Add devicetree loading

From: Peter Jones Signed-off-by: Peter Jones Switch to use APM Mustang device tree, for hardware testing. Signed-off-by: David A. Marlin Use the default device tree from the grub default file instead of hardcoding a value. Signed-off-by: David A. Marlin --- util/grub-mkconfig.in | 3 +

[PATCH 09/20] normal: Add fw_path variable (revised)

From: Paulo Flabiano Smorigo This patch makes grub look for its config file on efi where the app was found. It was originally written by Matthew Garrett, and adapted to fix the "No modules are loaded on grub2 network boot" issue: https://bugzilla.redhat.com/show_bug.cgi?id=857936 Signed-off-by:

[PATCH 03/20] ieee1275: Disable GRUB video support for IBM power machines

From: Paulo Flabiano Smorigo Should fix the problem in bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=973205 Signed-off-by: Paulo Flabiano Smorigo Signed-off-by: Robbie Harwood --- grub-core/kern/ieee1275/cmain.c | 5 - grub-core/video/ieee1275.c | 9 ++--- include/grub/

[PATCH 17/20] normal/main: fw_path prefix when fallback searching for grub config

From: Fedora Ninjas When PXE booting via UEFI firmware, grub was searching for grub.cfg in the fw_path directory where the grub application was found. If that didn't exist, a fallback search would look for config file names based on MAC and IP address. However, the search would look in the prefix

[PATCH 06/20] misc: Make "exit" take a return code.

From: Peter Jones This adds "exit" with a return code. With this patch, any "exit" command /may/ include a return code, and on platforms that support returning with an exit status, we will do so. By default we return the same exit status we did before this patch. Signed-off-by: Peter Jones --

[PATCH 10/20] commands: Pass "\x[[:hex:]][[:hex:]]" straight through unmolested.

From: Peter Jones Don't munge raw spaces when we're doing our cmdline escaping (#923374) Signed-off-by: Peter Jones --- grub-core/commands/wildcard.c | 16 - grub-core/lib/cmdline.c | 25 ++-- grub-core/script/execute.c| 43 ++--

[PATCH 11/20] blscfg: add blscfg module to parse Boot Loader Specification snippets

From: Peter Jones The BootLoaderSpec (BLS) defines a scheme where different bootloaders can share a format for boot items and a configuration directory that accepts these common configurations as drop-in files. Signed-off-by: Peter Jones Signed-off-by: Javier Martinez Canillas [wjt: some clean

[PATCH 15/20] Makefile.common: Add .eh_frame to list of relocations stripped

From: Fedora Ninjas Signed-off-by: Peter Jones --- conf/Makefile.common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/conf/Makefile.common b/conf/Makefile.common index b8f216f6c..ece9ed8a1 100644 --- a/conf/Makefile.common +++ b/conf/Makefile.common @@ -41,7 +41,7 @@ CFLAG

[PATCH 04/20] configure.ac: Move bash completion script

From: Peter Jones Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=922997 Apparently these go in a new place now. --- configure.ac | 11 +++ util/bash-completion.d/Makefile.am | 1 - 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/configure.ac

[PATCH 00/20] First Distro-agnostic series taken from Fedora Rawhide

This is the first patch series taken from Fedora Rawhide spec [1] that are distro-agnostic. The goal is to merge most them so all the community/distros would benefit. [1] https://src.fedoraproject.org/rpms/grub2 Fedora Ninjas (2): Makefile.common: Add .eh_frame to list of relocations stripped

[PATCH 02/20] term/terminfo: for ppc, reset console display attr when clear screen

From: Paulo Flabiano Smorigo v2: Also use \x0c instead of a literal ^L to make future patches less awkward. This should fix this bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=908519 Signed-off-by: Peter Jones Signed-off-by: Paulo Flabiano Smorigo Signed-off-by: Robbie Harwood --- gr

[PATCH 01/20] ieee1275/openfw: IBM client architecture (CAS) reboot support

From: Paulo Flabiano Smorigo This is an implementation of IBM client architecture (CAS) reboot for GRUB. There are cases where the POWER firmware must reboot in order to support specific features requested by a kernel. The kernel calls ibm,client-architecture-support and it may either return or

Re: [PATCH v3 8/8] i386: Add CRx, MMIO, MSR and extend CPUID definitions

Ping. 7 other patches of this series already have Reviewed-by. Best regards, Sergii On Sun, Sep 22, 2024 at 08:17:54PM +0300, Sergii Dmytruk wrote: > From: Ross Philipson > > Control registers and flags: > - CR0 read/write and flags (PE, MP, EM, TS, PG, NE, WP, AM, NW, CD) > - CR4 read/write