Re: [PATCH v3 0/4] Add support for if-none-match for cache responses

2020-09-01 Thread Christopher Faulet
Le 01/09/2020 à 18:32, Tim Duesterhus a écrit : William, Christopher, Am 01.09.20 um 10:29 schrieb Christopher Faulet: There is no applet for uncached requests. So there is no reason to call the release callback function. Looking at your 4th patch, you should manually release 'if_none_match'

stable-bot: Bugfixes waiting for a release 2.2 (23), 2.1 (15), 2.0 (8), 1.8 (6)

2020-09-01 Thread stable-bot
Hi, This is a friendly bot that watches fixes pending for the next haproxy-stable release! One such e-mail is sent periodically once patches are waiting in the last maintenance branch, and an ideal release date is computed based on the severity of these fixes and their merge date. Responses

Re: Debugging ssl handshake failures

2020-09-01 Thread Kevin McArthur
Thanks Bruno, My first step would be to setup a custom log format that uses log converters with the appropriate fetches [1]: log-format "%ci:%cp [%tr] %ft %b/%s %TR/%Tw/%Tc/%Tr/%Ta %ST %B %CC %CS %tsc %ac/%fc/%bc/%sc/%rc %sq/%bq %hr %hs %{+Q}r %[ssl_fc_protocol] %[ssl_fc_cipher]" For some

Re: Debugging ssl handshake failures

2020-09-01 Thread Bruno Henc
‐‐‐ Original Message ‐‐‐ On Tuesday, September 1, 2020 6:57 PM, Kevin McArthur wrote: > Hi haproxy > > I'm wondering if there is any way to debug the error message "www-https/1: > SSL handshake failure"? I've tried increasing log levels to debug etc, but > nothing seems to log about

Debugging ssl handshake failures

2020-09-01 Thread Kevin McArthur
Hi haproxy I'm wondering if there is any way to debug the error message "www-https/1: SSL handshake failure"? I've tried increasing log levels to debug etc, but nothing seems to log about why the failure occurred. Haproxy 2.2.2-1ppa1~focal on Ubuntu 20.04 We've had a strange regression when

Re: [PATCH 1/6] MINOR: spoa: allow MAX_FRAME_SIZE override

2020-09-01 Thread Christopher Faulet
Le 24/08/2020 à 21:21, gilchr...@dadaglo.com a écrit : From: Bertrand Jacquin MAX_FRAME_SIZE is forced to the default value of tune.bufsize, however they don't necessarily have to be tight together. --- contrib/spoa_server/spoa.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v3 1/4] MINOR: http: Add `enum etag_type http_get_etag_type(const struct ist)`

2020-09-01 Thread Tim Duesterhus
http_get_etag_type returns whether a given `etag` is a strong, weak, or invalid ETag. --- include/haproxy/http-t.h | 6 ++ include/haproxy/http.h | 21 + 2 files changed, 27 insertions(+) diff --git a/include/haproxy/http-t.h b/include/haproxy/http-t.h index

[PATCH v3 2/4] CLEANUP: compression: Make use of http_get_etag_type()

2020-09-01 Thread Tim Duesterhus
This commit makes the compressor use http_get_etag_type to validate the ETag instead of using an ad-hoc condition. --- src/flt_http_comp.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/flt_http_comp.c b/src/flt_http_comp.c index 87f359d03..0360d94be 100644 ---

[PATCH v3 3/4] MINOR: http: Add `int etag_compare(struct ist, struct ist, int)`

2020-09-01 Thread Tim Duesterhus
etag_compare compares two ETags according to RFC 7232#2.3.2. --- include/haproxy/http.h | 2 ++ src/http.c | 32 2 files changed, 34 insertions(+) diff --git a/include/haproxy/http.h b/include/haproxy/http.h index f7ac72c87..09c35e417 100644 ---

[PATCH v3 4/4] MEDIUM: cache: Add support for if-none-match for cache responses

2020-09-01 Thread Tim Duesterhus
This commit adds support for conditional requests using ETags to the cache. Specifically the cache now is able to return a 304 Not Modified to requests if the resource is unchanged according to the validation logic of RFC 7232#3.2. The implementation is not 100% according to spec: Only the first

[PATCH v3 0/4] Add support for if-none-match for cache responses

2020-09-01 Thread Tim Duesterhus
William, Christopher, Am 01.09.20 um 10:29 schrieb Christopher Faulet: >>> There is no applet for uncached requests. So there is no reason to call >>> the release callback function. Looking at your 4th patch, you should >>> manually release 'if_none_match' variable for uncached requests in the

Backend servers backup setup

2020-09-01 Thread Artur
Hello, I need your help on configuring servers backup in a backend. This is my current (simplified) backend setup : backend ws_be     mode http     option redispatch     cookie c insert indirect nocache attr "SameSite=Lax"     balance roundrobin     server s1 1.2.3.3:1234

Re: [RFC PATCH] MEDIUM: Add support for if-none-match for cache responses

2020-09-01 Thread Christopher Faulet
Le 01/09/2020 à 10:45, Tim Düsterhus a écrit : Christopher, Am 01.09.20 um 10:37 schrieb Christopher Faulet: I've also a small patch (not pushed yet) that extends the http_replace_res_status() function to pass a extra reason. It may be IST_NULL to preserve the existing one. But if set, it is

Re: [RFC PATCH] MEDIUM: Add support for if-none-match for cache responses

2020-09-01 Thread Tim Düsterhus
Christopher, Am 01.09.20 um 10:37 schrieb Christopher Faulet: > I've also a small patch (not pushed yet) that extends the > http_replace_res_status() function to pass a extra reason. It may be > IST_NULL to preserve the existing one. But if set, it is replaced. It is > a small patch so if you

Re: [RFC PATCH] MEDIUM: Add support for if-none-match for cache responses

2020-09-01 Thread Christopher Faulet
Le 31/08/2020 à 17:37, Tim Düsterhus a écrit : Christopher, Am 31.08.20 um 10:24 schrieb Christopher Faulet: No, there is no way to set the status code and the reason in one function call. But it may be good to have one. For now, we can live with two fun calls I guess. I've added such a

Re: [RFC PATCH v2 0/4] Add support for if-none-match for cache responses

2020-09-01 Thread Christopher Faulet
Le 31/08/2020 à 17:40, Tim Düsterhus a écrit : Christopher, Am 31.08.20 um 10:36 schrieb Christopher Faulet: There is no applet for uncached requests. So there is no reason to call the release callback function. Looking at your 4th patch, you should manually release 'if_none_match' variable