Re: [PATCH] BUG/MEDIUM: mworker: Fix re-exec when haproxy is started from PATH

2017-11-16 Thread William Lallemand
On Thu, Nov 16, 2017 at 05:30:05PM +0100, Tim Düsterhus wrote: > William, > > Am 15.11.2017 um 21:17 schrieb William Lallemand: > > These problems have been fixed in the master with the following commits: > > > > 75ea0a06b BUG/MEDIUM: mworker: does not close inherited FD > > fade49d8f BUG/MEDIUM:

Re: [PATCH] BUG/MEDIUM: mworker: Fix re-exec when haproxy is started from PATH

2017-11-16 Thread Tim Düsterhus
William, Am 15.11.2017 um 21:17 schrieb William Lallemand: > These problems have been fixed in the master with the following commits: > > 75ea0a06b BUG/MEDIUM: mworker: does not close inherited FD > fade49d8f BUG/MEDIUM: mworker: does not deinit anymore > 2f8b31c2c BUG/MEDIUM: mworker: wait again

Re: [PATCH] BUG/MEDIUM: mworker: Fix re-exec when haproxy is started from PATH

2017-11-15 Thread William Lallemand
Hi Tim, On Tue, Nov 14, 2017 at 08:20:25PM +0100, Tim Düsterhus wrote: > William, > > Am 14.11.2017 um 15:03 schrieb William Lallemand: > > Well, in my opinion the return value does not need to be checked because we > > should never reach the code after the exec, that means that the code after >

Re: [PATCH] BUG/MEDIUM: mworker: Fix re-exec when haproxy is started from PATH

2017-11-14 Thread Tim Düsterhus
William, Am 14.11.2017 um 15:03 schrieb William Lallemand: > Well, in my opinion the return value does not need to be checked because we > should never reach the code after the exec, that means that the code after the > exec is only reached during an exec error. But we could at least display the >

Re: [PATCH] BUG/MEDIUM: mworker: Fix re-exec when haproxy is started from PATH

2017-11-14 Thread Willy Tarreau
On Tue, Nov 14, 2017 at 03:03:20PM +0100, William Lallemand wrote: > Willy, could you please apply this patch? thanks OK now done, thanks guys. Willy

Re: [PATCH] BUG/MEDIUM: mworker: Fix re-exec when haproxy is started from PATH

2017-11-14 Thread William Lallemand
Hi Tim, On Sun, Nov 12, 2017 at 05:39:18PM +0100, Tim Düsterhus wrote: > From: Tim Duesterhus > > If haproxy is started using the name of the binary only (i.e. > not using a relative or absolute path) the `execv` in > `mworker_reload` fails with `ENOENT`, because it does not > examine the `PATH`

Fix re-exec when haproxy is started from PATH

2017-11-12 Thread Tim Düsterhus
This is a bug I noticed when preparing the official Dockerfiles for haproxy 1.8, as they make use of the PATH [1]. This is my first time contribution of actual code. I'm not sure whether my patch is the best solution for this issue: Please be extra careful when reviewing. And please let me know of

[PATCH] BUG/MEDIUM: mworker: Fix re-exec when haproxy is started from PATH

2017-11-12 Thread Tim Düsterhus
From: Tim Duesterhus If haproxy is started using the name of the binary only (i.e. not using a relative or absolute path) the `execv` in `mworker_reload` fails with `ENOENT`, because it does not examine the `PATH`: [WARNING] 315/161139 (7) : Reexecuting Master process [WARNING] 315/161139 (7