Re: 1.8.3: Slow posts on H2 (IE only?)

2018-01-04 Thread Willy Tarreau
On Thu, Jan 04, 2018 at 04:03:29PM +0100, Peter Lindegaard Hansen wrote: > Hi Willy & Lukas, > > I did on a test VM using the latest git version > # haproxy -v > HA-Proxy version 1.8.3-646d23-1 2018/01/04 > Copyright 2000-2017 Willy Tarreau > > And can confirm that the issues

Re: 1.8.3: Slow posts on H2 (IE only?)

2018-01-04 Thread Peter Lindegaard Hansen
Hi Willy & Lukas, I did on a test VM using the latest git version # haproxy -v HA-Proxy version 1.8.3-646d23-1 2018/01/04 Copyright 2000-2017 Willy Tarreau And can confirm that the issues related to post+redirects are fixed for us. And the other issue that we found seems to

Re: 1.8.3: Slow posts on H2 (IE only?)

2018-01-04 Thread Willy Tarreau
Hi Peter, On Wed, Jan 03, 2018 at 11:04:03PM +0100, Peter Lindegaard Hansen wrote: > I will try to apply the patch (i am no expert at this) and see the results. Well, don't waste your time trying to figure stuff you're not comfortable with. I've just committed the fix and backported it. If

Re: 1.8.3: Slow posts on H2 (IE only?)

2018-01-03 Thread Peter Lindegaard Hansen
Hi, What a quick response on this issue :) I will try to apply the patch (i am no expert at this) and see the results. I did find another h2-related issue, but where unable to pinpoint exactly why as it where deep in ajax application, but i will see with this patch if its the same issue.

Re: 1.8.3: Slow posts on H2 (IE only?)

2018-01-03 Thread Lukas Tribus
Hello, On Wed, Jan 3, 2018 at 9:51 PM, Willy Tarreau wrote: > On Wed, Jan 03, 2018 at 09:31:47PM +0100, Willy Tarreau wrote: >> Oh I think you've just put your finger on it. I remember taking care >> of handling 0-sized frames, and facing certain difficulties with them >> (eg:

Re: 1.8.3: Slow posts on H2 (IE only?)

2018-01-03 Thread Willy Tarreau
On Wed, Jan 03, 2018 at 09:31:47PM +0100, Willy Tarreau wrote: > Oh I think you've just put your finger on it. I remember taking care > of handling 0-sized frames, and facing certain difficulties with them > (eg: sometimes returning size 0 just means nothing was done). I sounds > very likely that

Re: 1.8.3: Slow posts on H2 (IE only?)

2018-01-03 Thread Willy Tarreau
On Wed, Jan 03, 2018 at 09:07:35PM +0100, Lukas Tribus wrote: > When the client sends the POST, haproxy responds with the 302 from the > backend (stream 3), the client follows the redirect sending a the new > GET (stream 5) which haproxy never sees. However, with this patch, > haproxy also sends

Re: 1.8.3: Slow posts on H2 (IE only?)

2018-01-03 Thread Lukas Tribus
Hello, On Wed, Jan 3, 2018 at 5:56 PM, Willy Tarreau wrote: >> When moving the affected HREM code above the "return 0" branch, Edge >> works fine again. >> >> The attached patch fixes the issue for me, please give it a try. > > The problem with doing this is that when we have to

Re: 1.8.3: Slow posts on H2 (IE only?)

2018-01-03 Thread Willy Tarreau
Hi Lukas, On Wed, Jan 03, 2018 at 05:34:36PM +0100, Lukas Tribus wrote: > Hello Peter, > > > On Wed, Jan 3, 2018 at 2:59 PM, Lukas Tribus wrote: > > I will come back later and take a deeper look at both strace and the > > capture. > > So, this is broken since c4134ba8b0

Re: 1.8.3: Slow posts on H2 (IE only?)

2018-01-03 Thread Lukas Tribus
Hello Peter, On Wed, Jan 3, 2018 at 2:59 PM, Lukas Tribus wrote: > I will come back later and take a deeper look at both strace and the capture. So, this is broken since c4134ba8b0 ("BUG/MEDIUM: h2: don't switch the state to HREM before end of DATA frame"). And indeed Edge sets

Re: 1.8.3: Slow posts on H2 (IE only?)

2018-01-03 Thread Lukas Tribus
Hello Peter, On Wed, Jan 3, 2018 at 12:00 PM, Peter Lindegaard Hansen wrote: > > Hi List, > > We updated one of our haproxy boxes to the newly released 1.8.3 - thanks! > > Then we got reports of IE being slow, when we looked into the claims we found > that it seems to