Hi Cyril,
On Mon, Nov 30, 2009 at 12:53:34AM +0100, Cyril Bonté wrote:
> > Could you please check on your side and confirm/infirm my doubts ?
> > Basically I want to ensure we never dereference the buffer past its
> > end, so begin+len bust always be below the buffer size. If you think
> > a contr
Le dimanche 29 novembre 2009 23:43:15, Willy Tarreau a écrit :
> The suggested way to to that is to enclose the values between the comment
> and the mask like here (though any other proposal might fit) :
>
> /* appsession */
> #define PR_O2_AS_REQL 0x4000 /* learn the session id from the
Hi Cyril,
On Sun, Nov 29, 2009 at 08:04:48PM +0100, Cyril Bonté wrote:
> Hello,
> considering what we said in this thread, here is the complete patch.
OK. First, let me say I'm really satisfied by the quality of this
patch, I suppose you have spent quite a part of your sunday on it.
I just have
Hello,
considering what we said in this thread, here is the complete patch.
To sum up :
- len : it's now the max number of characters for the value, preventing
garbaged results.
- a new option "prefix" is added, this allows to use dynamic cookie names (e.g.
ASPSESSIONIDXXX).
Previously in the th
On Tue, Nov 17, 2009 at 11:25:56PM +0100, Aleksandar Lazic wrote:
> >And for now, I see 2 modes :
> >- path-parameters (the default)
> >- query-string (the one that made me look at the code :-) )
> >(and if needed "weblogic")
>
> Looks ok for me.
>
> What I'am not sure now is how we can prevent t
On Mon 16.11.2009 22:52, Cyril Bonté wrote:
Le lundi 16 novembre 2009 13:41:14, Willy Tarreau a écrit :
On Mon, Nov 16, 2009 at 01:04:17PM +0100, Aleksandar Lazic wrote:
[snipp]
> For example:
>
> if in the url the delimiter changes from ';' to ',' then you should
> set the following
>
>
Le lundi 16 novembre 2009 13:41:14, Willy Tarreau a écrit :
> On Mon, Nov 16, 2009 at 01:04:17PM +0100, Aleksandar Lazic wrote:
> (...)
> > >>app* delimiterstart (default ;)
> > >>app* delimiterstop (defautl =)
> > >
> > >I'm sorry, I don't understand what you mean. Could you give an example
> > >
On Mon, Nov 16, 2009 at 01:04:17PM +0100, Aleksandar Lazic wrote:
(...)
> >>app* delimiterstart (default ;)
> >>app* delimiterstop (defautl =)
> >
> >I'm sorry, I don't understand what you mean. Could you give an example
> >of configuration using this ?
>
> For example:
>
> if in the url the del
On Mon 16.11.2009 10:22, Willy Tarreau wrote:
On Mon, Nov 16, 2009 at 10:08:56AM +0100, Aleksandar Lazic wrote:
[snipp]
For me both looks ok, mybe we use
appsession-option
or
app-op (=> for abbreviation ;-) )
Due to the fact that not only the cookie is relevant for the
application session.
On Mon, Nov 16, 2009 at 10:08:56AM +0100, Aleksandar Lazic wrote:
> >What you can do however is to create a new prefix keyword like we have
> >for "timeout" or "tcp-request" and put the flags somewhere
> >else. "appsession" would have been fine but it's already used. Maybe
> >you can use "appcooki
On Mon 16.11.2009 08:52, Willy Tarreau wrote:
Hi,
On Sun, Nov 15, 2009 at 10:28:21PM +0100, Aleksandar Lazic wrote:
Hi Cyril,
On Fre 13.11.2009 22:50, Cyril Bonté wrote:
>Hello Willy,
[snipp]
>First I added it as I did for "request-learn" but shouldn't it be
>better to define these options
Hi,
On Sun, Nov 15, 2009 at 10:28:21PM +0100, Aleksandar Lazic wrote:
> Hi Cyril,
>
> On Fre 13.11.2009 22:50, Cyril Bonté wrote:
> >Hello Willy,
> >sorry, I didn't have time to work on the patch as I wanted.
> >
> >Le jeudi 5 novembre 2009 06:19:41, Willy Tarreau a écrit :
> >>> Sorry but I can'
Hi Cyril,
On Fre 13.11.2009 22:50, Cyril Bonté wrote:
Hello Willy,
sorry, I didn't have time to work on the patch as I wanted.
Le jeudi 5 novembre 2009 06:19:41, Willy Tarreau a écrit :
> Sorry but I can't see in the haproxy sources how the cookie prefix can be
used for appsession.
> "capture
Hello Willy,
sorry, I didn't have time to work on the patch as I wanted.
Le jeudi 5 novembre 2009 06:19:41, Willy Tarreau a écrit :
> > Sorry but I can't see in the haproxy sources how the cookie prefix can be
> > used for appsession.
> > "capture cookie" allows to find this cookie prefix but it
Le lundi 2 novembre 2009 12:09:43, Willy Tarreau a écrit :
> > * it adds a verification on the '=' char :
> > currently (with appsession JSESSIONID for example), an URL like
> > http:///path;jsessionidfake=0123... matches the session id
> > "ake=0123..."
> > => with the patch, jsessionidfake won'
Hi Cyril,
On Sun, Nov 01, 2009 at 12:19:05AM +0100, Cyril Bonté wrote:
> Hello Willy and Aleksandar,
> If you agree, I would like to apply this new patch to add some more integrity
> checking on appsession.
>
> * the session value (provided by the URL or by the request/response cookie)
> is now
Le dimanche 1 novembre 2009 00:19:05, Cyril Bonté a écrit :
> Hello Willy and Aleksandar,
> If you agree, I would like to apply this new patch to add some more integrity
> checking on appsession.
Forget the previous patch file, this new one also prevents forcing the load
balancing to one server
Hello Willy and Aleksandar,
If you agree, I would like to apply this new patch to add some more integrity
checking on appsession.
* the session value (provided by the URL or by the request/response cookie) is
now well delimited :
currently, setting "len 52" on a 32 chars value has a bad effect o
On Son 18.10.2009 12:46, Cyril Bonté wrote:
Le dimanche 18 octobre 2009 12:05:55, Willy Tarreau a écrit :
Cyril, I have merged your two patches.
Thanks ! I'm thinking of working on a second patch.
The documentation says that appsession looks for the session in the
query string but this is not
Le dimanche 18 octobre 2009 12:05:55, Willy Tarreau a écrit :
> Cyril, I have merged your two patches.
Thanks ! I'm thinking of working on a second patch.
The documentation says that appsession looks for the session in the query
string but this is not really the case. Currently, it parses the fir
On Thu, Oct 15, 2009 at 12:15:40AM +0200, Cyril Bonté wrote:
> OK, here comes the 2 patch files for haproxy-1.3.21 and haproxy-1.4-dev4.
> Please note 3 minor changes in those versions (proto_http.c / proto_http.h) :
Cyril, I have merged your two patches. I applied a very minor change,
I removed t
Le mercredi 14 octobre 2009 22:39:39, Willy Tarreau a écrit :
> > > Do it for either 1.3 or 1.4, I'll do the back/forward port. If you
> > > prefer to proceed on both, of course feel free to do so :-)
> >
> > I can do both, this will let you work on something else ;)
>
> Nice, I appreciate it.
O
On Wed, Oct 14, 2009 at 10:36:49PM +0200, Cyril Bonté wrote:
> Le mercredi 14 octobre 2009 22:23:54, Willy Tarreau a écrit :
> > Cyril, care to send an updated patch with the latest changes ?
>
> OK !
>
> > Do it for either 1.3 or 1.4, I'll do the back/forward port. If you
> > prefer to proceed o
Le mercredi 14 octobre 2009 22:23:54, Willy Tarreau a écrit :
> Cyril, care to send an updated patch with the latest changes ?
OK !
> Do it for either 1.3 or 1.4, I'll do the back/forward port. If you
> prefer to proceed on both, of course feel free to do so :-)
I can do both, this will let you
On Wed, Oct 14, 2009 at 10:20:04PM +0200, Aleksandar Lazic wrote:
> On Mit 14.10.2009 21:40, Willy Tarreau wrote:
> >On Tue, Oct 13, 2009 at 10:41:59PM +0200, Aleksandar Lazic wrote:
> >>On Die 13.10.2009 21:34, Cyril Bonté wrote:
> >>>Le lundi 12 octobre 2009 23:17:43, Aleksandar Lazic a écrit :
>
On Mit 14.10.2009 21:40, Willy Tarreau wrote:
On Tue, Oct 13, 2009 at 10:41:59PM +0200, Aleksandar Lazic wrote:
On Die 13.10.2009 21:34, Cyril Bonté wrote:
>Le lundi 12 octobre 2009 23:17:43, Aleksandar Lazic a écrit :
>
>Yes, you're right, I missed it after several tests on different
>snapshots
On Tue, Oct 13, 2009 at 10:41:59PM +0200, Aleksandar Lazic wrote:
> On Die 13.10.2009 21:34, Cyril Bonté wrote:
> >Le lundi 12 octobre 2009 23:17:43, Aleksandar Lazic a écrit :
> >
> >Yes, you're right, I missed it after several tests on different
> >snapshots.
> >Here comes a second patch to reint
On Die 13.10.2009 21:34, Cyril Bonté wrote:
Le lundi 12 octobre 2009 23:17:43, Aleksandar Lazic a écrit :
Yes, you're right, I missed it after several tests on different
snapshots.
Here comes a second patch to reintroduce these debug lines :
Thanks.
Le lundi 12 octobre 2009 23:17:43, Aleksandar Lazic a écrit :
> Hi Cyril,
>
> good catch.
>
> >+}
> >+
> >+/*
> >-#if defined(DEBUG_HASH)
> >-Alert("manage_client_side_cookies\n");
> >-
> >appsession_hash_dump(&(t->be->htbl_p
Hi Cyril,
good catch.
On Mon 12.10.2009 23:03, Cyril Bonté wrote:
Hello,
as discussed previously with Willy Tarreau, I'd like to propose a patch
for the appsession code.
This patch has 2 goals :
[snipp]
diff -Naur haproxy-1.4-dev4/src/proto_http.c
haproxy-1.4-dev4-appsession/src/proto_http
Hello,
as discussed previously with Willy Tarreau, I'd like to propose a patch for the
appsession code.
This patch has 2 goals :
1. I wanted to test the appsession feature with a small PHP code, using
PHPSESSID.
The problem is that when PHP gets an unknown session id, it creates a new one
with
31 matches
Mail list logo
