[classlib]bug-to-bug compatibility: HashMap

2006-03-15 Thread Paulex Yang
Pls. try the test case on HashMap below. On RI, it print out: null null On Harmony, it print out null value1 it is definitely bad practice to reuse a object as hash key by modify its hashcode, but I DID see some similar cases before, after all, you cannot force but only can *suggest*

Re: [Fwd: Re: [jchevm] JCHEVM discussion]

2006-03-15 Thread Chris Gray
Stefano, I think we should take Geir's advice and pipe down a bit. Those whose task it is to resolve this issue are by now pretty aware of the issues involved, and our explanations to eachother serve only to increase entropy. Meanwhile we may meditate on Jorge Luís Borges' story _Pierre

Re: Excluded tests in x-net module or back to bootclasspath issue

2006-03-15 Thread Stepan Mishura
Hi Tim, On 3/14/06, Tim Ellison [EMAIL PROTECTED] wrote: I agree that they need to be reinstated Stepan, I'd just like to separate out the suite of tests that are pure API tests (and therefore expected to run on all compliant implementations, modulo their known bugs/departures) and the

Re: Location of test data files

2006-03-15 Thread Stepan Mishura
Hi George, I'd like to fix outcome of this discussion. I think a JIRA issue should filed to track tests reorg. As far as it'll be next massive reorg. and can not be applied right now (there are other massive updates pending in JIRA). And JIRA won't let us to forget about our decision. Thanks,

abstract templates (was: Re: How to deal with this kind of serialization compatibility issue?)

2006-03-15 Thread Mikhail Loenko
Hello We can discuss the problem in general and then apply the decision to serialization framework. So, can we have standard test templates i.e. abstract classes with prepared test scenarios implemented as test methods such that specific tests would extend a template (and thus inherit all test

Re: [classlib]bug-to-bug compatibility: HashMap

2006-03-15 Thread Mikhail Loenko
Hi Paulex, IMHO from compatibility point of view any behavior is legal. HashMap is mostly designed for keys that do not change over time, at least spec silent about changing the keys. So, I think implementation specsific is allowed here. But I think that aiming stability we'd better compare

Re: How to deal with this kind of serialization compatibility issue?

2006-03-15 Thread Paulex Yang
Hi, Mikhail, Mikhail Loenko wrote: Hi Paulex, 2006/3/14, Paulex Yang [EMAIL PROTECTED]: Mikhail I spent a little time on the framework, and I must say that this framework is very easy to use. Impressive! But I still have some thoughts on it: 1. Sometime assertEquals() is not enough for

Re: [tools] Eclipse JRE support

2006-03-15 Thread Thorbjørn Ravn Andersen
Tim Ellison wrote: That URL is a bit of a mouthful though, perhaps we need a redirect from http://incubator.apache.org/harmony/updates ? Personally I'd rather have a XML file to import in the Update dialogue since it gives the correct values for both fields. -- Thorbjørn

Re: How to deal with this kind of serialization compatibility issue?

2006-03-15 Thread Mikhail Loenko
Hi Paulex, 2006/3/15, Paulex Yang [EMAIL PROTECTED]: Hi, Mikhail, Mikhail Loenko wrote: Hi Paulex, 2006/3/14, Paulex Yang [EMAIL PROTECTED]: Mikhail I spent a little time on the framework, and I must say that this framework is very easy to use. Impressive! But I still have

Re: How to deal with this kind of serialization compatibility issue?

2006-03-15 Thread Paulex Yang
Hi, Mikhail, Mikhail Loenko wrote: Hi George! I need to study H-57 SerializationTester, likely it makes sense taking best ideas from both I was trying to find out how the framework works and how a test based on that framework looks like. I've taken the first class refering to

Re: How to deal with this kind of serialization compatibility issue?

2006-03-15 Thread Paulex Yang
Mikhail Mikhail Loenko wrote: Hi Paulex, 2006/3/15, Paulex Yang [EMAIL PROTECTED]: Hi, Mikhail, Mikhail Loenko wrote: Hi Paulex, 2006/3/14, Paulex Yang [EMAIL PROTECTED]: Mikhail I spent a little time on the framework, and I must say that this framework is very easy to

Re: How to deal with this kind of serialization compatibility issue?

2006-03-15 Thread Mikhail Loenko
Using serialization framework from security module, the test would look like as follows: public class CharacterCodingExceptionTest extends SerializationTest { protected Object[] getData() { return new Object[] { new CharacterCodingExceptionTest ()}; } protected void

Re: [Fwd: Re: [jchevm] JCHEVM discussion]

2006-03-15 Thread Dalibor Topic
On Mon, Mar 13, 2006 at 06:50:44PM -0500, Geir Magnusson Jr wrote: Dalibor Topic wrote: On a Harmony-unrelated side note, if you are interested in seeing your port in the Kaffe.org CVS tree, and your contract allows for it, feel free to send me the patch. :) On a harmony-related

Re: Location of test data files

2006-03-15 Thread George Harley
Hi Stepan, Good idea. I will raise it today. It will only cover the proposed layout of these test resources in a given module and not discuss how the serialization tests are carried out since that discussion is still ongoing. Best regards, George Stepan Mishura wrote: Hi George, I'd like

Re: [jira] Resolved: (HARMONY-161) Improper override method in java/util/zip/GZIPOutputStream.close()

2006-03-15 Thread Tim Ellison
Paulex, As we recently discussed, there is nothing in the spec that prevents us from (re-)implementing the method in the subclass, even though it is not specified to have any additional behavior to the inherited version. So while the point of the issue may be wrong, I've applied the patch to

Re: Location of test data files

2006-03-15 Thread Tim Ellison
Why not describe it in a doc, and submit it for the website? Regards, Tim George Harley wrote: Hi Stepan, Good idea. I will raise it today. It will only cover the proposed layout of these test resources in a given module and not discuss how the serialization tests are carried out since

Re: [tools] Eclipse JRE support

2006-03-15 Thread Tim Ellison
Just for you Thorbjørn Regards, Tim --- ?xml version=1.0 encoding=UTF-8? bookmarks site name=Apache Harmony update site url=http://svn.apache.org/viewcvs.cgi/*checkout*/incubator/harmony/enhanced/tools/trunk/eclipse/org.apache.harmony.eclipse.site; web=false

Re: [jira] Resolved: (HARMONY-88) Contribution of code and unit tests for jndi, logging, prefs and sql plus unit tests only for beans, crypto, math, regex and security

2006-03-15 Thread Tim Ellison
FYI: I noticed a few minor things that we should probably fix in this contribution, but they don't break the build and it makes sense to commit the contribution as we received it then fix it up in 'business as usual' development. Regards, Tim Tim Ellison (JIRA) wrote: [

Re: [classlib]bug-to-bug compatibility: HashMap

2006-03-15 Thread will pugh
Will Sun's implementation ever find ReusableKey if the value has been changed? It would not surprise me if this simple case Sun doesn't find the entry, because they do something like hashing the hash that ReusableKey returns, or only allocating a prime number of buckets, e.g. you ask for a

Re: svn commit: r386058 [1/49] ...

2006-03-15 Thread Leo Simons
49 commit messages for a single commit! The continuous wash-in of Really Big(tm) chunks of code scares me a little (even if its real cool) -- usually I make it policy to read every single line of code contributed to a project for which I'm on the PMC but there's no chance in hell I'm going to

Re: svn commit: r386058 [1/49] ...

2006-03-15 Thread Magnusson, Geir
Isn't this the initial commit for somwthing we just voted in? (me in car so can't see right now) -Original Message- From: Leo Simons [mailto:[EMAIL PROTECTED] Sent: Wed Mar 15 11:34:35 2006 To: harmony-dev@incubator.apache.org Subject:Re: svn commit: r386058 [1/49]

Re: svn commit: r386058 [1/49] ...

2006-03-15 Thread Tim Ellison
Yes, the log message is only shown in the first commit message in the set. That particular commit is the HARMONY-57 bulk contribution that was voted on by the -dev list. The other big commit I did today is the HARMONY-88 bulk contribution that was also accepted by the -dev list. I'm not *that*

Re: svn commit: r386058 [1/49] ...

2006-03-15 Thread Magnusson, Geir
I assume that you noted the jura entry in the commit log. -Original Message- From: Tim Ellison [mailto:[EMAIL PROTECTED] Sent: Wed Mar 15 11:44:19 2006 To: harmony-dev@incubator.apache.org Subject:Re: svn commit: r386058 [1/49] ... Yes, the log message is only shown

Re: svn commit: r386058 [1/49] ...

2006-03-15 Thread Tim Ellison
I did my usual trick, which is to mention the JIRA tag and the issue summary; in this case it was: In svn commit: r386087 [1/45] -... snip Log: Commit contribution HARMONY-88 (Contribution of code and unit tests for jndi, logging, prefs and sql plus unit tests only for beans, crypto, math, regex

Re: svn commit: r386058 [1/49] ...

2006-03-15 Thread Magnusson, Geir
That's what I fgured. Me still in car. -Original Message- From: Tim Ellison [mailto:[EMAIL PROTECTED] Sent: Wed Mar 15 11:53:57 2006 To: harmony-dev@incubator.apache.org Subject:Re: svn commit: r386058 [1/49] ... I did my usual trick, which is to mention the JIRA tag

Closing of HARMONY-88

2006-03-15 Thread Tim Ellison
Mark wrote: Of course, it shouldn't be closed yet since quite a few of the contributed test cases still need to be integrated. Well I figured I'd mark it closed it since the code is now in SVN, even if it is not fully integrated yet. I figured we could work on the final aspects of integration

Results of big commits

2006-03-15 Thread Mark Hindess
As well as the new classes, we have over 2700 tests that's nearly ten times the number we were running a week ago. And there are a few more that need some work. So if anyone is looking for something to do, take a look at the excluded tests in the modules/*/make/common/build.xml files. I've been

Re: Closing of HARMONY-88

2006-03-15 Thread Tim Ellison
No problem, I've reopened it. Let's hope that HARMONY-39 gets committed soon then we can finish the remainder. Regards, Tim Mark Hindess wrote: Not all the code is in svn. So I'd say leave it open to remind us that there's still more work to do. -Mark. On 3/15/06, Tim Ellison [EMAIL

Re: svn commit: r386171 - /incubator/harmony/enhanced/classlib/trunk/make/build-java.xml

2006-03-15 Thread Mark Hindess
Mikhail, I took a few shortcuts getting these integration done. I'm planning to factor out the acquire depends jars step in to a separate ant file. My current plan is to create a new make/depends.xml file that would be responsible for fetching the files and have the make/build.xml use that to

Subclipse Diff: Are there any way to ignore whitespace when creating patch using Subclipse in Eclipse

2006-03-15 Thread Richard Liang
Dears, If you select Spaces only as Eclipse tab policy and you format the Harmony source code in Eclipse, when you creating patch for the source code, Subclipse may regard the source code as total different with the source in SVN. Then other developers cannot know what you have changed to