Re: [classlib] Exception-throwing compatibility question

2006-07-04 Thread Andrew Zhang
George, Totally agree with you. Shall we summarize and document the discuss to Harmony exception-thrown compatibility guideline? Thanks! On 6/30/06, George Harley [EMAIL PROTECTED] wrote: Mikhail Loenko wrote: For the example I've started this thread with it seems that complying the spec

Re: [classlib] Exception-throwing compatibility question

2006-07-04 Thread Boris Kuznetsov
So, we should always follow RI? Even when RI behavior is not consistent and contradicts the spec.? Here is one example: javax.crypto.EncryptedPrivateKeyInfo(algName, encryptedData) spec. states: NoSuchAlgorithmException - if the specified algName is not supported. For code: new

Re: [classlib] Exception-throwing compatibility question

2006-07-04 Thread Boris Kuznetsov
correction: RI throws NoSuchAlgorithmException for new EncryptedPrivateKeyInfo(0, new byte[598]); On 7/4/06, Boris Kuznetsov [EMAIL PROTECTED] wrote: So, we should always follow RI? Even when RI behavior is not consistent and contradicts the spec.? Here is one example:

Re: svn commit: r418844 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src: main/java/java/util/HashMap.java test/java/tests/api/java/util/HashMapTest.java

2006-07-04 Thread Tim Ellison
Nathan, I have rolled back this commit (in r418963) because it was causing lots of test failures on Linux and Windows. Please can you take another look at it? Regards, Tim [EMAIL PROTECTED] wrote: Author: ndbeyer Date: Mon Jul 3 13:47:39 2006 New Revision: 418844 URL:

[classlib][util] EnumMap and EnumSet

2006-07-04 Thread Richard Liang
Hello Paulex, I'm looking at the component status of java.util [1]. And I find you have raised two JIRAs for java.util.EnumMap[2] and EnumSet[3], however, there is no follow-on actions. ;-) Are you still working on these classes? Thanks a lot. 1. http://wiki.apache.org/harmony/LUNI 2.

Re: [classlib][util] EnumMap and EnumSet

2006-07-04 Thread Paulex Yang
Oops...sorry for that, I had interest on them, but from then on, I've been (desperately) busy on NIO stuffs :-(((. I've updated the Wiki page and reverted the status of the two classes to Welcome Volunteer. Thank you for the reminder! Anyone else want to help? Richard Liang wrote: Hello

Re: svn commit: r418195 - /incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/java/org/apache/harmony/tools/javac/Compiler.java

2006-07-04 Thread Tim Ellison
Geir Magnusson Jr wrote: Can you get your IDE to invoke ant? Of course, but do you really want our implementation code to be closely coupled to Ant? (please answer with a question, I'm getting into the Wimbledon spirit) Regards, Tim Tim Ellison wrote: Geir Magnusson Jr wrote: Indeed not.

[classlib][security] crypto provider: implementation of SHA-1 algorithm

2006-07-04 Thread Tim Ellison
Yuri, Thanks for your contribution! Before I can take your code into Harmony please can I ask you to complete a contributors' questionnaire? The Harmony contribution policy [1] requires that we have an Authorized Contributor Questionnaire [2] on file. It should only take you a couple of

[classlib][regex] Acknowledgement of Unicode Character Database

2006-07-04 Thread George Harley
Hi, Just noticed that the source file java.util.regex.AbstractCharClass in modules/regex contains the following Javadoc comment for the PredefinedCharacterClasses inner class: /** * character classes generated from * http://www.unicode.org/reports/tr18/ *

Re: [classlib] compatibility of toString

2006-07-04 Thread Geir Magnusson Jr
Richard Liang wrote: Geir Magnusson Jr wrote: Tim Ellison wrote: Yep, if the spec tells you what the format of the string should be then follow it (since apps may be dependent upon it), otherwise I'd be inclined to invent your own useful string representation. This

Re: [classlib] Exception-throwing compatibility question

2006-07-04 Thread Geir Magnusson Jr
Boris Kuznetsov wrote: So, we should always follow RI? Even when RI behavior is not consistent and contradicts the spec.? I never think it's a case of always. I think it's a case of always discuss :) geir Here is one example: javax.crypto.EncryptedPrivateKeyInfo(algName,

Re: svn commit: r418195 - /incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/java/org/apache/harmony/tools/javac/Compiler.java

2006-07-04 Thread Geir Magnusson Jr
Tim Ellison wrote: Geir Magnusson Jr wrote: Can you get your IDE to invoke ant? Of course, but do you really want our implementation code to be closely coupled to Ant? RIght now it's coupled to a specific version number from eclipse-land that requires the code itself to change when they

Re: [classlib][regex] Acknowledgement of Unicode Character Database

2006-07-04 Thread Geir Magnusson Jr
+1 That's fine. Go for it. geir George Harley wrote: Hi, Just noticed that the source file java.util.regex.AbstractCharClass in modules/regex contains the following Javadoc comment for the PredefinedCharacterClasses inner class: /** * character classes generated from *

Re: svn commit: r418195 - /incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/java/org/apache/harmony/tools/javac/Compiler.java

2006-07-04 Thread Geir Magnusson Jr
Actually, what about some kind of SPI? Or now that JSR-199 in in public draft form, anything useful in there? (There's two more questions 40-love) geir Geir Magnusson Jr wrote: Tim Ellison wrote: Geir Magnusson Jr wrote: Can you get your IDE to invoke ant? Of course, but do you

[tools] Finding tools helper jars (was: Re: svn commit: r418195 - /incubator/harmony/enhanced/classlib/trunk/modules/tools/src/main/java/org/apache/harmony/tools/javac/Compiler.java)

2006-07-04 Thread Tim Ellison
Geir Magnusson Jr wrote: Actually, what about some kind of SPI? Or now that JSR-199 in in public draft form, anything useful in there? How would that help? We would still have to name the JAR that contains those providers wouldn't we? What do you think about simply adding all jars in jdk/lib

Re: [classlib] Modularising the native code - it begins!

2006-07-04 Thread Oliver Deakin
Hi all, I have just raised HARMONY-744 which moves the vmi and luni native code into the luni module, and the zip and zlib code into archive. AFAICS, there is only one more set of moves to do before native modularisation is complete (phew!). With the last set of changes, I plan to move the

Re: [classlib] testing guidlines -- support classes

2006-07-04 Thread Mikhail Loenko
2006/7/3, Tim Ellison [EMAIL PROTECTED]: Mikhail Loenko wrote: All: support classes, impl-classpath, impl-boot, api-classpath, and api-boot tests are compiled into separate directories. ( TestNG looking better by the hour eh? ;-) ) Support classes are compiled first, tests are compiled

[drlvm] Removing classlib-related tasks from VM build (was Doing the minimum to support Java 5 classfiles)

2006-07-04 Thread Andrey Chernyshev
4) Change the drlvm build so that its deploy tree layout has no classlib files in it. So we can do ... As a first step, I suggest that we make drlvm build completely free from the classlib-related tasks and files, this may help to avoid further confusion. For example, it doesn't have to copy

[classlib]Using APR for Harmony's native link to the OS

2006-07-04 Thread Marina Goldburt
Hi, To support the idea mentioned in the letter http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200602.mbox/[EMAIL PROTECTED], I've tried to implement the file I/O part of the Harmony portlib using APR. The JIRA issue with the patch is

Re: [classlib]Using APR for Harmony's native link to the OS

2006-07-04 Thread Garrett Rooney
On 7/4/06, Marina Goldburt [EMAIL PROTECTED] wrote: Hi, To support the idea mentioned in the letter http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200602.mbox/[EMAIL PROTECTED], I've tried to implement the file I/O part of the Harmony portlib using APR. The JIRA issue with

Re: [classlib]Using APR for Harmony's native link to the OS

2006-07-04 Thread Mladen Turk
Garrett Rooney wrote: Until a version of APR exists that doesn't require the use of memory pools, this approach is simply not reasonable to take. I pretty much agree with you. The entire tomcat-native that makes a low level network abstraction is very much slowed down by the fact that we need

Re: [drlvm/mmtk] jitrino.jet write barrier design questions

2006-07-04 Thread Weldon Washburn
On 6/30/06, Alex Astapchuk [EMAIL PROTECTED] wrote: Actually, the simplest form of write barrier would be one, single parameter -- a ref ptr to the object getting scribbled on. I suspect Hmmm... Seems I have a misunderstanding here - how comes a single ref ? What I was thinking of, is

Re: [classlib]Using APR for Harmony's native link to the OS

2006-07-04 Thread Garrett Rooney
On 7/4/06, Mladen Turk [EMAIL PROTECTED] wrote: Garrett Rooney wrote: Until a version of APR exists that doesn't require the use of memory pools, this approach is simply not reasonable to take. I pretty much agree with you. The entire tomcat-native that makes a low level network abstraction

Re: [classlib]Using APR for Harmony's native link to the OS

2006-07-04 Thread Mladen Turk
Garrett Rooney wrote: Anyway, now we're way off topic for this list ;-) Right :) -- Mladen. - Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional

Re: [classlib]Using APR for Harmony's native link to the OS

2006-07-04 Thread Tim Ellison
Garrett Rooney wrote: On 7/4/06, Mladen Turk [EMAIL PROTECTED] wrote: Garrett Rooney wrote: Until a version of APR exists that doesn't require the use of memory pools, this approach is simply not reasonable to take. I pretty much agree with you. The entire tomcat-native that makes a low

Re: [tools] Finding tools helper jars

2006-07-04 Thread Geir Magnusson Jr
Tim Ellison wrote: Geir Magnusson Jr wrote: Actually, what about some kind of SPI? Or now that JSR-199 in in public draft form, anything useful in there? How would that help? We would still have to name the JAR that contains those providers wouldn't we? No - the tool would examine

Re: [DRLVM] Integration checks (was building from svn on FC5)

2006-07-04 Thread Anton Luht
Hello, I've created an Eclipse automated test based on Salikh's code - please see http://issues.apache.org/jira/browse/HARMONY-752 I've tested it on Windows XP on Eclipse that goes with harmony VM - eclipse-SDK-3.1.1-win32.zip Sometimes (irregularry) after execution it prints some stack

Re: [drlvm] Removing classlib-related tasks from VM build (was Doing the minimum to support Java 5 classfiles)

2006-07-04 Thread Geir Magnusson Jr
Andrey Chernyshev wrote: 4) Change the drlvm build so that its deploy tree layout has no classlib files in it. So we can do ... As a first step, I suggest that we make drlvm build completely free from the classlib-related tasks and files, this may help to avoid further confusion. I

Re: [drlvm] DRLVM segfaults in hythread_tls_get()

2006-07-04 Thread Andrey Chernyshev
Hi Tim, On 7/4/06, Tim Ellison [EMAIL PROTECTED] wrote: Andrey Chernyshev wrote: I'm not sure it is just a name clash problem - drlvm won't give the hythread library if the class lib hadn't requested it. The classlib builds it's own copy of the hythread library, so there is no need for a

Re: [classlib]Using APR for Harmony's native link to the OS

2006-07-04 Thread Geir Magnusson Jr
Marina Goldburt wrote: Hi, To support the idea mentioned in the letter http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200602.mbox/[EMAIL PROTECTED], I've tried to implement the file I/O part of the Harmony portlib using APR. The JIRA issue with the patch is

RE: [classlib][regex] Acknowledgement of Unicode Character Database

2006-07-04 Thread Nathan Beyer
Shouldn't we be using Unicode 4.0.1, since Java 5 RI is 4.0-based and 4.1 is large upgrade? I've used 4.0.1 to implement some of the Character and UnicodeBlock code since it's a 4.0 patch version. Should be attempt to support a single Unicode version for all modules, regardless of which version

Re: [drlvm] Removing classlib-related tasks from VM build (was Doing the minimum to support Java 5 classfiles)

2006-07-04 Thread Andrey Chernyshev
On 7/4/06, Geir Magnusson Jr [EMAIL PROTECTED] wrote: Andrey Chernyshev wrote: 4) Change the drlvm build so that its deploy tree layout has no classlib files in it. So we can do ... As a first step, I suggest that we make drlvm build completely free from the classlib-related tasks and

[classlib] Is it OK for VM kernel class to call internal classlib API?

2006-07-04 Thread Andrey Chernyshev
I was trying to compile the kernel classes set from DRLVM independently from the classlib and found it difficult because kernel classes set currently have a dependence on the internal classlib API, e.g. org.apache.harmony.luni.internal.net.www.protocol.jar.JarURLConnection and

Re: [classlib][regex] Acknowledgement of Unicode Character Database

2006-07-04 Thread George Harley
Nathan Beyer wrote: Shouldn't we be using Unicode 4.0.1, since Java 5 RI is 4.0-based and 4.1 is large upgrade? I've used 4.0.1 to implement some of the Character and UnicodeBlock code since it's a 4.0 patch version. Should be attempt to support a single Unicode version for all modules,

RE: svn commit: r418844 - in /incubator/harmony/enhanced/classlib/trunk/modules/luni/src: main/java/java/util/HashMap.java test/java/tests/api/java/util/HashMapTest.java

2006-07-04 Thread Nathan Beyer
Sorry about that. I've applied a new fix that resolves this and my Windows build/test is working. It seems that http://issues.apache.org/jira/browse/HARMONY-403 was actually caused by the changes made for http://issues.apache.org/jira/browse/HARMONY-206. -Original Message- From: Tim

RE: [classlib] Approval for String patch for HARMONY-719

2006-07-04 Thread Nathan Beyer
-Original Message- From: Geir Magnusson Jr [mailto:[EMAIL PROTECTED] Nathan Beyer wrote: -Original Message- From: Geir Magnusson Jr [mailto:[EMAIL PROTECTED] Nathan Beyer wrote: The concern I would have about this is the scenario where it actually is a

Re: [drlvm] Signed jars cannot be used in classpath

2006-07-04 Thread Gregory Shimansky
Hello I've found a flaw in my logic (while trying to go to sleep this early in the morning) down below because it is Platform.FILE_SYSTEM which has to be uninitialized while I've written that it is Platform.NETWORK_SYSTEM. I think I've just got line lumbers shifted somehow due to attempts to

Re: [classlib] compatibility of toString

2006-07-04 Thread Richard Liang
Geir Magnusson Jr wrote: Richard Liang wrote: Geir Magnusson Jr wrote: Tim Ellison wrote: Yep, if the spec tells you what the format of the string should be then follow it (since apps may be dependent upon it), otherwise I'd be inclined to invent your own

[classlib][nio] Modify ServerSocketChannel.implConfigureBlocking() method

2006-07-04 Thread Andrew Zhang
Hello everybody, I changed the subject to make things clear. Jimmy, as you mentioned, What's more, I find some operations related to network are also written in this way, first select and then read/write/accept/connect, so I guess all implementation in java.nio.channels shall remove

Re: [classlib][nio] Platform dependent tests in SocketChannelTest

2006-07-04 Thread Andrew Zhang
Paulex, I also noticed there are several platform-dependent behaviours of FileChannel. So I can't wait to see the revised test layout. :) Will you plan to re-layout NIO test structure recently? Thank you very much! On 6/29/06, Paulex Yang [EMAIL PROTECTED] wrote: If no one objects, I'm

Re: [classlib] compatibility of toString

2006-07-04 Thread Mikhail Loenko
IIRC Geir was going to ask Sun if we are allowed to copy their exception messages Thanks, Mikhail 2006/7/5, Richard Liang [EMAIL PROTECTED]: Geir Magnusson Jr wrote: Richard Liang wrote: Geir Magnusson Jr wrote: Tim Ellison wrote: Yep, if the spec tells you what the format of the

Re: Repackaged IBM VME

2006-07-04 Thread Richard Liang
Hello Oliver, When adding Apache Harmony VM in Eclipse on Linux, an error is reported System library does not exist: ./jdk/jre/bin/default/kernel.jar. It seems that the clearvm.properties has not been upgraded to v3. The following lines:

Re: [classlib][testing] excluding the failed tests

2006-07-04 Thread Vladimir Ivanov
Yesterday I tried to add a regression test to existing in security module TestCase, but, found that the TestCase is in exclude list. I had to un-exclude it, run, check my test passes and exclude the TestCase again – it was a little bit inconvenient, besides, my new valid (I believe) regression