RE: [classlib][swing] compatibility: j.s.text.GapContent.replace() behaviour

2006-11-07 Thread Ivanov, Alexey A
>-Original Message- >From: Oleg Khaschansky [mailto:[EMAIL PROTECTED] >Sent: Thursday, November 02, 2006 3:28 PM >To: harmony-dev@incubator.apache.org >Subject: Re: [classlib][swing] compatibility: j.s.text.GapContent.replace() >behaviour > >+1. Silently doing nothi

RE: [classlib][swing] compatibility: j.s.text.GapContent.replace() behaviour

2006-11-03 Thread Ivanov, Alexey A
>-Original Message- >From: Stepan Mishura [mailto:[EMAIL PROTECTED] >Sent: Friday, November 03, 2006 1:49 PM >To: harmony-dev@incubator.apache.org >Subject: Re: [classlib][swing] compatibility: j.s.text.GapContent.replace() >behaviour > >On 11/3/06

Re: [classlib][swing] compatibility: j.s.text.GapContent.replace() behaviour

2006-11-03 Thread Stepan Mishura
On 11/3/06, Ivanov, Alexey A wrote: >-Original Message- >From: Stepan Mishura >Sent: Friday, November 03, 2006 9:43 AM >To: harmony-dev@incubator.apache.org >Subject: Re: [classlib][swing] compatibility: j.s.text.GapContent.replace() >behaviour > >On 11/2/06

RE: [classlib][swing] compatibility: j.s.text.GapContent.replace() behaviour

2006-11-02 Thread Ivanov, Alexey A
>-Original Message- >From: Stepan Mishura [mailto:[EMAIL PROTECTED] >Sent: Friday, November 03, 2006 9:43 AM >To: harmony-dev@incubator.apache.org >Subject: Re: [classlib][swing] compatibility: j.s.text.GapContent.replace() >behaviour > >On 11/2/06, Ivanov, Alex

Re: [classlib][swing] compatibility: j.s.text.GapContent.replace() behaviour

2006-11-02 Thread Stepan Mishura
On 11/2/06, Ivanov, Alexey A wrote: Hi all, I've started fixing HARMONY-1809. To remove throws clause from the declaration of replace method, as it was proposed by Oleg in HARMONY-1975, I placed removeItems() and insertItems() calls into try-catch block. This would work OK for any valid argumen

RE: [classlib][swing] compatibility: j.s.text.GapContent.replace() behaviour

2006-11-02 Thread Ivanov, Alexey A
>-Original Message- >From: Geir Magnusson Jr. [mailto:[EMAIL PROTECTED] >Sent: Thursday, November 02, 2006 5:03 PM >To: harmony-dev@incubator.apache.org >Subject: Re: [classlib][swing] compatibility: j.s.text.GapContent.replace() >behaviour > >Why not? It was deci

RE: [classlib][swing] compatibility: j.s.text.GapContent.replace() behaviour

2006-11-02 Thread Ivanov, Alexey A
>-Original Message- >From: Tim Ellison [mailto:[EMAIL PROTECTED] >Sent: Thursday, November 02, 2006 5:26 PM >To: harmony-dev@incubator.apache.org >Subject: Re: [classlib][swing] compatibility: j.s.text.GapContent.replace() >behaviour > >Ivanov, Alexey A wrote: &

Re: [classlib][swing] compatibility: j.s.text.GapContent.replace() behaviour

2006-11-02 Thread Tim Ellison
Ivanov, Alexey A wrote: >> -Original Message- >> From: Alexey Petrenko [mailto:[EMAIL PROTECTED] >> Sent: Thursday, November 02, 2006 3:50 PM >> To: harmony-dev@incubator.apache.org >> Subject: Re: [classlib][swing] compatibility: > j.s.text.GapContent.rep

Re: [classlib][swing] compatibility: j.s.text.GapContent.replace() behaviour

2006-11-02 Thread Geir Magnusson Jr.
Why not? Ivanov, Alexey A wrote: -Original Message- From: Alexey Petrenko [mailto:[EMAIL PROTECTED] Sent: Thursday, November 02, 2006 3:50 PM To: harmony-dev@incubator.apache.org Subject: Re: [classlib][swing] compatibility: j.s.text.GapContent.replace() behaviour HARMONY-1975is

RE: [classlib][swing] compatibility: j.s.text.GapContent.replace() behaviour

2006-11-02 Thread Ivanov, Alexey A
>-Original Message- >From: Alexey Petrenko [mailto:[EMAIL PROTECTED] >Sent: Thursday, November 02, 2006 3:50 PM >To: harmony-dev@incubator.apache.org >Subject: Re: [classlib][swing] compatibility: j.s.text.GapContent.replace() >behaviour > >HARMONY-1975is already ap

Re: [classlib][swing] compatibility: j.s.text.GapContent.replace() behaviour

2006-11-02 Thread Oleg Khaschansky
Could you, please, look at the unit test in #1809 also? On 11/2/06, Oleg Khaschansky <[EMAIL PROTECTED]> wrote: Yes, but the GapContent changes were not applied. On 11/2/06, Alexey Petrenko <[EMAIL PROTECTED]> wrote: > HARMONY-1975is already applied and closed ;) > > 2006/11/2, Alexey Petrenko

Re: [classlib][swing] compatibility: j.s.text.GapContent.replace() behaviour

2006-11-02 Thread Oleg Khaschansky
Yes, but the GapContent changes were not applied. On 11/2/06, Alexey Petrenko <[EMAIL PROTECTED]> wrote: HARMONY-1975is already applied and closed ;) 2006/11/2, Alexey Petrenko <[EMAIL PROTECTED]>: > I'll take care of 1975. > > SY, Alexey > > 2006/11/2, Oleg Khaschansky <[EMAIL PROTECTED]>: > >

Re: [classlib][swing] compatibility: j.s.text.GapContent.replace() behaviour

2006-11-02 Thread Alexey Petrenko
HARMONY-1975is already applied and closed ;) 2006/11/2, Alexey Petrenko <[EMAIL PROTECTED]>: I'll take care of 1975. SY, Alexey 2006/11/2, Oleg Khaschansky <[EMAIL PROTECTED]>: > +1. Silently doing nothing if invalid parameters are passed seems to > me a right behavior in this case. > > Will s

Re: [classlib][swing] compatibility: j.s.text.GapContent.replace() behaviour

2006-11-02 Thread Alexey Petrenko
I'll take care of 1975. SY, Alexey 2006/11/2, Oleg Khaschansky <[EMAIL PROTECTED]>: +1. Silently doing nothing if invalid parameters are passed seems to me a right behavior in this case. Will someone apply changes to GapContent from the harmony-1975.patch or we need to make a separate patch fo

Re: [classlib][swing] compatibility: j.s.text.GapContent.replace() behaviour

2006-11-02 Thread Oleg Khaschansky
+1. Silently doing nothing if invalid parameters are passed seems to me a right behavior in this case. Will someone apply changes to GapContent from the harmony-1975.patch or we need to make a separate patch for this? On 11/2/06, Alexey Petrenko <[EMAIL PROTECTED]> wrote: 2006/11/2, Ivanov, Ale

Re: [classlib][swing] compatibility: j.s.text.GapContent.replace() behaviour

2006-11-02 Thread Alexey Petrenko
2006/11/2, Ivanov, Alexey A <[EMAIL PROTECTED]>: Hi all, I've started fixing HARMONY-1809. To remove throws clause from the declaration of replace method, as it was proposed by Oleg in HARMONY-1975, I placed removeItems() and insertItems() calls into try-catch block. This would work OK for any v

[classlib][swing] compatibility: j.s.text.GapContent.replace() behaviour

2006-11-02 Thread Ivanov, Alexey A
Hi all, I've started fixing HARMONY-1809. To remove throws clause from the declaration of replace method, as it was proposed by Oleg in HARMONY-1975, I placed removeItems() and insertItems() calls into try-catch block. This would work OK for any valid arguments. I was going to handle invalid argu