[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666091#comment-15666091
]
Hadoop QA commented on HDFS-10872:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666024#comment-15666024
]
Hadoop QA commented on HDFS-10872:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665527#comment-15665527
]
Zhe Zhang commented on HDFS-10872:
--
Thanks Erik! I manually verified the 2 checkstyle issues. I just
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665459#comment-15665459
]
Hadoop QA commented on HDFS-10872:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664936#comment-15664936
]
Zhe Zhang commented on HDFS-10872:
--
Thanks Erik. Local cluster on branch-2 patch looks good. I just
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664853#comment-15664853
]
Hadoop QA commented on HDFS-10872:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664745#comment-15664745
]
Hudson commented on HDFS-10872:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10832 (See
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664725#comment-15664725
]
Zhe Zhang commented on HDFS-10872:
--
Actually {{FSNamesystem}} has many conflicts -- though most of them
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664718#comment-15664718
]
Zhe Zhang commented on HDFS-10872:
--
Thanks Erik. +1 on v12 patch. I did another check of the metrics from
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664641#comment-15664641
]
Hadoop QA commented on HDFS-10872:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664399#comment-15664399
]
Zhe Zhang commented on HDFS-10872:
--
Thanks for the tip Mingliang :)
> Add MutableRate metrics for
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15659347#comment-15659347
]
Hadoop QA commented on HDFS-10872:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15659343#comment-15659343
]
Hadoop QA commented on HDFS-10872:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15659125#comment-15659125
]
Mingliang Liu commented on HDFS-10872:
--
Thanks for taking care of this. I usually don't bump the
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15658608#comment-15658608
]
Mingliang Liu commented on HDFS-10872:
--
still +1 Thanks for updating the code.
> Add MutableRate
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15658378#comment-15658378
]
Hadoop QA commented on HDFS-10872:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15658355#comment-15658355
]
Mingliang Liu commented on HDFS-10872:
--
That's a good point. We can add prefix (e.g. FSNLock) in
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15658342#comment-15658342
]
Zhe Zhang commented on HDFS-10872:
--
Sorry, just realized an issue with the names of the metrics, can we
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15658299#comment-15658299
]
Mingliang Liu commented on HDFS-10872:
--
+1
> Add MutableRate metrics for FSNamesystemLock operations
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15658296#comment-15658296
]
Zhe Zhang commented on HDFS-10872:
--
Thanks [~wangda] for helping fix the npm error. Thanks Erik for
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15658252#comment-15658252
]
Erik Krogen commented on HDFS-10872:
TestDFSAdmin is a known issue tracked in HDFS-11122.
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15658222#comment-15658222
]
Hadoop QA commented on HDFS-10872:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15655560#comment-15655560
]
Hadoop QA commented on HDFS-10872:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15655243#comment-15655243
]
Hadoop QA commented on HDFS-10872:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15654931#comment-15654931
]
Erik Krogen commented on HDFS-10872:
[~zhz], thanks for the review.
(1) Yes, you are right, that is
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15654905#comment-15654905
]
Hadoop QA commented on HDFS-10872:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15654899#comment-15654899
]
Zhe Zhang commented on HDFS-10872:
--
Thanks Erik for the patch! LGTM overall. I think the added
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15652905#comment-15652905
]
Hadoop QA commented on HDFS-10872:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15595927#comment-15595927
]
Andrew Wang commented on HDFS-10872:
This looks great, thanks Erik! I was a bit worried since
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15595794#comment-15595794
]
Zhe Zhang commented on HDFS-10872:
--
Thanks for the benchmark [~xkrogen]! Results look very interesting. I
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15595792#comment-15595792
]
Zhe Zhang commented on HDFS-10872:
--
Thanks for the benchmark [~xkrogen]! Results look very interesting. I
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15595745#comment-15595745
]
Erik Krogen commented on HDFS-10872:
[~andrew.wang] I did some profiling and it seems that the
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589917#comment-15589917
]
Andrew Wang commented on HDFS-10872:
Thanks for the replies, Erik, Zhe, inline:
bq. Are we aware of
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589506#comment-15589506
]
Zhe Zhang commented on HDFS-10872:
--
Thanks for the discussion Andrew and Erik.
I agree that moving the
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15587300#comment-15587300
]
Hadoop QA commented on HDFS-10872:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15587290#comment-15587290
]
Erik Krogen commented on HDFS-10872:
[~andrew.wang], thanks for the comment.
I actually did not think
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15587087#comment-15587087
]
Andrew Wang commented on HDFS-10872:
Thanks for working on this folks, and sorry for coming to this
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15587033#comment-15587033
]
Zhe Zhang commented on HDFS-10872:
--
Thanks Erik! The v3 patch LGTM. +1 pending fixing the long line
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586511#comment-15586511
]
Hadoop QA commented on HDFS-10872:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586193#comment-15586193
]
Erik Krogen commented on HDFS-10872:
[~zhz] thanks for the detailed review!
1. Yes, if it lives
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15583802#comment-15583802
]
Zhe Zhang commented on HDFS-10872:
--
Thanks Erik for the updated patch. I think we are pretty close.
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15583197#comment-15583197
]
Hadoop QA commented on HDFS-10872:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572775#comment-15572775
]
Zhe Zhang commented on HDFS-10872:
--
Thanks Erik for the patch! The structure looks good overall. A few
[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15537392#comment-15537392
]
Erik Krogen commented on HDFS-10872:
Attaching v000 patch.
This makes {{FSNamesystemLock}} into a
44 matches
Mail list logo
