[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885752#comment-16885752 ] Takanobu Asanuma commented on HDFS-14593: - Created HDFS-14654 for the flaky test. > RBF:

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885742#comment-16885742 ] Takanobu Asanuma commented on HDFS-14593: - Thanks for your reviews, [~elgoiri], and thanks for

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885554#comment-16885554 ] Hudson commented on HDFS-14593: --- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16918 (See

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885432#comment-16885432 ] Ayush Saxena commented on HDFS-14593: - Committed to trunk. Thanx [~tasanuma] for the contribution and

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885408#comment-16885408 ] Íñigo Goiri commented on HDFS-14593: [~ayushtkn], do you mind going ahead with the commit? If you

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885406#comment-16885406 ] Ayush Saxena commented on HDFS-14593: - V011 LGTM +1 > RBF: Implement deletion feature for expired

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885387#comment-16885387 ] Íñigo Goiri commented on HDFS-14593: [~ayushtkn], any further comments? > RBF: Implement deletion

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884321#comment-16884321 ] Takanobu Asanuma commented on HDFS-14593: - I ran {{TestRouterRpc#testNamenodeMetrics}} without

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884170#comment-16884170 ] Íñigo Goiri commented on HDFS-14593: The tests related to security are expected to fail; there is a

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884100#comment-16884100 ] Hadoop QA commented on HDFS-14593: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883975#comment-16883975 ] Takanobu Asanuma commented on HDFS-14593: - 011.patch fixes a checkstyle issue. > RBF: Implement

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883807#comment-16883807 ] Hadoop QA commented on HDFS-14593: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883746#comment-16883746 ] Takanobu Asanuma commented on HDFS-14593: - {quote}I understand that now as we remove this does

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883122#comment-16883122 ] Íñigo Goiri commented on HDFS-14593: The old Collections.singleton was kind of nice. I understand

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882632#comment-16882632 ] Hadoop QA commented on HDFS-14593: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882600#comment-16882600 ] Hadoop QA commented on HDFS-14593: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882595#comment-16882595 ] Takanobu Asanuma commented on HDFS-14593: - Thanks for your help, [~ayushtkn]. Sorry, it should

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882582#comment-16882582 ] Ayush Saxena commented on HDFS-14593: - Thanx [~tasanuma] for the patch. Just started checking, A

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882560#comment-16882560 ] Takanobu Asanuma commented on HDFS-14593: - Thanks for your review, [~elgoiri]. The last patch

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882474#comment-16882474 ] Íñigo Goiri commented on HDFS-14593: Thanks [~tasanuma] for taking care of it. This looks good to me

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882443#comment-16882443 ] Hadoop QA commented on HDFS-14593: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882384#comment-16882384 ] Takanobu Asanuma commented on HDFS-14593: - Thanks, [~elgoiri]. bq. My only concern now is the

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882223#comment-16882223 ] Íñigo Goiri commented on HDFS-14593: My only concern now is the fact that we are going to the backend

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881733#comment-16881733 ] Takanobu Asanuma commented on HDFS-14593: - TestRouterFaultTolerant passed with 006 patch in my

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881723#comment-16881723 ] Hadoop QA commented on HDFS-14593: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881685#comment-16881685 ] Takanobu Asanuma commented on HDFS-14593: - Thanks for your review, [~elgoiri]. If not changing

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881392#comment-16881392 ] Íñigo Goiri commented on HDFS-14593: [^HDFS-14593.005.patch] looks pretty much it. The only sticky

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881045#comment-16881045 ] Hadoop QA commented on HDFS-14593: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880967#comment-16880967 ] Takanobu Asanuma commented on HDFS-14593: - Thanks for your review, [~elgoiri]. Uploaded the 5th

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880549#comment-16880549 ] Íñigo Goiri commented on HDFS-14593: Some comments on [^HDFS-14593.004.patch]: *

[jira] [Commented] (HDFS-14593) RBF: Implement deletion feature for expired records in State Store

[ https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880523#comment-16880523 ] Hadoop QA commented on HDFS-14593: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||