[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181374#comment-17181374
]
Ayush Saxena commented on HDFS-15535:
-
Committed to trunk.
Thanx [~elgoiri] for the review!!!
>
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181306#comment-17181306
]
Íñigo Goiri commented on HDFS-15535:
+1 on [^HDFS-15535-08.patch].
> RBF: Fix Namespace path to
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180969#comment-17180969
]
Hadoop QA commented on HDFS-15535:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180904#comment-17180904
]
Íñigo Goiri commented on HDFS-15535:
Oh, I see, my bad.
Just for simplicity and to keep it in sync
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180807#comment-17180807
]
Hadoop QA commented on HDFS-15535:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180791#comment-17180791
]
Ayush Saxena commented on HDFS-15535:
-
No, Earlier there was only {{T}} which was the return type,
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180787#comment-17180787
]
Íñigo Goiri commented on HDFS-15535:
I just realized was this broken before? We were casting the
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180770#comment-17180770
]
Ayush Saxena commented on HDFS-15535:
-
Have updated, with the Casting both params.
For the case when
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180761#comment-17180761
]
Hadoop QA commented on HDFS-15535:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180759#comment-17180759
]
Íñigo Goiri commented on HDFS-15535:
Yes, makes sense to cast both, either one is fine with me.
I
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180755#comment-17180755
]
Ayush Saxena commented on HDFS-15535:
-
Thanx [~elgoiri]
Can do this :
{code:java}
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180741#comment-17180741
]
Íñigo Goiri commented on HDFS-15535:
Thanks [~ayushtkn] for [^HDFS-15535-06.patch], this integrates
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180695#comment-17180695
]
Íñigo Goiri commented on HDFS-15535:
I tend to prefer something like [^HDFS-15535-05.patch] with the
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180526#comment-17180526
]
Ayush Saxena commented on HDFS-15535:
-
In v5 instead of a Map as return type, have added a class, can
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180465#comment-17180465
]
Hadoop QA commented on HDFS-15535:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180436#comment-17180436
]
Hadoop QA commented on HDFS-15535:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180360#comment-17180360
]
Hadoop QA commented on HDFS-15535:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180327#comment-17180327
]
Ayush Saxena commented on HDFS-15535:
-
Thanx [~elgoiri] for the review. I made changes in v3, to
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180280#comment-17180280
]
Íñigo Goiri commented on HDFS-15535:
Thanks [~ayushtkn] for the new patch.
I'm not sure of the value
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180237#comment-17180237
]
Hadoop QA commented on HDFS-15535:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180201#comment-17180201
]
Ayush Saxena commented on HDFS-15535:
-
Thanx [~elgoiri] for the review, Have made the said the
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180139#comment-17180139
]
Íñigo Goiri commented on HDFS-15535:
To minimize the changes, can we keep the old invokeSequential()
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17179180#comment-17179180
]
Ayush Saxena commented on HDFS-15535:
-
Test failures are unrelated, passes in my local
{noformat}
[
https://issues.apache.org/jira/browse/HDFS-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178647#comment-17178647
]
Hadoop QA commented on HDFS-15535:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
24 matches
Mail list logo
