[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15473070#comment-15473070 ] SammiChen commented on HDFS-8905: - Thanks, Akira Ajisaka! Sure, I will look into it. > Ref

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15473069#comment-15473069 ] SammiChen commented on HDFS-8905: - Thanks, Akira Ajisaka! Sure, I will look into it. > Ref

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15472959#comment-15472959 ] Akira Ajisaka commented on HDFS-8905: - Hi [~drankye] and [~Sammi], test_libhdfs_threade

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435007#comment-15435007 ] Hudson commented on HDFS-8905: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1033

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434723#comment-15434723 ] Hadoop QA commented on HDFS-8905: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432192#comment-15432192 ] Kai Zheng commented on HDFS-8905: - Thanks Sammi. I will commit this by end of tomorrow if

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432179#comment-15432179 ] SammiChen commented on HDFS-8905: - I run the failed unit cases locally with the latest HDFS

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432111#comment-15432111 ] Hadoop QA commented on HDFS-8905: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432076#comment-15432076 ] Kai Zheng commented on HDFS-8905: - Thanks Sammi for the update. The latest change looks goo

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430316#comment-15430316 ] Kai Zheng commented on HDFS-8905: - Another comment is, ref. the following block, it's good

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430113#comment-15430113 ] Kai Zheng commented on HDFS-8905: - Hi Sammi, The latest change looks good. One comment for

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430057#comment-15430057 ] Kai Zheng commented on HDFS-8905: - Thanks [~Sammi] for continuing working on this. Re-assig

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1543#comment-1543 ] Hadoop QA commented on HDFS-8905: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428291#comment-15428291 ] Hadoop QA commented on HDFS-8905: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428132#comment-15428132 ] Hadoop QA commented on HDFS-8905: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427992#comment-15427992 ] SammiChen commented on HDFS-8905: - fix the issue found in unit test failure > Refactor DFS

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427627#comment-15427627 ] Hadoop QA commented on HDFS-8905: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15196966#comment-15196966 ] Hadoop QA commented on HDFS-8905: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128195#comment-15128195 ] Hadoop QA commented on HDFS-8905: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041273#comment-15041273 ] Kai Zheng commented on HDFS-8905: - Hi [~zhz], the updated patch hopefully addressed your id

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041242#comment-15041242 ] Hadoop QA commented on HDFS-8905: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15039702#comment-15039702 ] Hadoop QA commented on HDFS-8905: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035404#comment-15035404 ] Kai Zheng commented on HDFS-8905: - Thanks [~zhz] for the one more time review and I will up

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032701#comment-15032701 ] Zhe Zhang commented on HDFS-8905: - Thanks Kai for the update. The new patch looks reasonabl

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013738#comment-15013738 ] Hadoop QA commented on HDFS-8905: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013209#comment-15013209 ] Hadoop QA commented on HDFS-8905: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012617#comment-15012617 ] Hadoop QA commented on HDFS-8905: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010246#comment-15010246 ] Rakesh R commented on HDFS-8905: Agreed, makes sense to me. Yes, proper javadocs/comments w

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009971#comment-15009971 ] Kai Zheng commented on HDFS-8905: - Hi [~rakeshr], I'm back to your comments. Please note th

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009925#comment-15009925 ] Kai Zheng commented on HDFS-8905: - Thanks [~zhz] for the confirm. It looks pretty good to h

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009600#comment-15009600 ] Zhe Zhang commented on HDFS-8905: - I think extract {{ReaderStrategy}} as a standalone class

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008233#comment-15008233 ] Kai Zheng commented on HDFS-8905: - Thanks [~rakeshr] for the good comments. I will look at

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008161#comment-15008161 ] Rakesh R commented on HDFS-8905: Thanks [~drankye] for the good work. Adding few thoughts,

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1454#comment-1454 ] Kai Zheng commented on HDFS-8905: - Regarding the mentioned log, it's from the following old

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14999674#comment-14999674 ] Kai Zheng commented on HDFS-8905: - Thanks [~zhz] for the great comments! You understood the

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14999127#comment-14999127 ] Zhe Zhang commented on HDFS-8905: - Thanks Kai for the work. IIUC the patch contains 2 ref

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14995869#comment-14995869 ] Hadoop QA commented on HDFS-8905: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-8905) Refactor DFSInputStream#ReaderStrategy

[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701205#comment-14701205 ] Hadoop QA commented on HDFS-8905: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo