+1 excellent.
Please continue to report any issues you see and we'll follow up with
prompt fixes.
On Wed, Dec 21, 2016 at 2:03 PM, Tal Nisan wrote:
> OK great, in any way I'm there to solve any false positives as I can
> remove those votes and as you see I notify you team immediately of any
> fa
OK great, in any way I'm there to solve any false positives as I can remove
those votes and as you see I notify you team immediately of any failure so
should be a problem
On Wed, Dec 21, 2016 at 1:40 PM, Eyal Edri wrote:
>
>
> On Wed, Dec 21, 2016 at 1:35 PM, Tal Nisan wrote:
>
>> This is how i
On Wed, Dec 21, 2016 at 1:35 PM, Tal Nisan wrote:
> This is how it always worked, and all due respect to Eyal's opinion I'm
> the one handling the branch and the grades are there to help me :)
>
The reason we didn't grade the new hooks with CR -1 or VERIFY -1 is because
we wanted to give the new
This is how it always worked, and all due respect to Eyal's opinion I'm the
one handling the branch and the grades are there to help me :)
On Wed, Dec 21, 2016 at 1:32 PM, Shlomo Ben David
wrote:
> Tal - Ok, so basically I didn't apply the verified grades on any hooks
> accept the check_bug_url
Tal - Ok, so basically I didn't apply the verified grades on any hooks
accept the check_bug_url hook.
Eyal - Is it ok to add the verify (+/-)1 grade for the check_backport hook?
(I thought that we'll grade with negative value if something went wrong)
Best Regards,
Shlomi Ben-David | Software Eng
The hook found out that the patch is open in master which precedes
ovirt-engine-4.1 and thus should have gotten -verified in 4.1
On Wed, Dec 21, 2016 at 12:55 PM, Shlomo Ben David
wrote:
> Hi Tal,
>
> I think that the Check Backport hook is doing exactly what you asking for.
> Example [1]:
>
>
Hi Tal,
I think that the Check Backport hook is doing exactly what you asking for.
Example [1]:
- Check Backport::IGNORE, The patch backported to all newer
branches.(open in 'master' branch/es) found not relevant branch/es:
'ovirt-engine-4.0' (not exist in the newer branches list)
patch
Check out this patches for instance: https://gerrit.ovirt.org/#/c/68862
https://gerrit.ovirt.org/#/c/68861
Those are 4.1 and 4.0 patches that are open on master, I'd expect to see
them get -verified from the hooks which they didn't:
- Update Tracker::#1406042::OK, status: POST
- Check Bug-Ur
