[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dp: Do not set the eDP link rate/lane count to max

2018-03-09 Thread Patchwork
== Series Details == Series: drm/i915/dp: Do not set the eDP link rate/lane count to max URL : https://patchwork.freedesktop.org/series/39662/ State : failure == Summary == Possible new issues: Test kms_cursor_crc: Subgroup cursor-64x64-suspend: pass -> FAIL

Re: [Intel-gfx] [PATCH v2 06/15] drm/i915/guc: Merge log relay file and channel creation

2018-03-09 Thread Sagar Arun Kamble
Hi Michal, One comment was missed and another comment update suggested. On 3/8/2018 9:16 PM, Michał Winiarski wrote: We have all the information we need at relay_open call time. Since there's no reason to split the process into relay_open and relay_late_setup_files, let's remove the extra code.

[Intel-gfx] [PATCH v13 02/17] drm/i915/skl+: refactor WM calculation for NV12

2018-03-09 Thread Vidya Srinivas
From: Mahesh Kumar Current code calculates DDB for planar formats in such a way that we store DDB of plane-0 in plane 1 & vice-versa. In order to make this clean this patch refactors WM/DDB calculation for NV12 planar formats. v2: Addressed review comments by Maarten v3: Rebased and addressed r

[Intel-gfx] [PATCH v13 09/17] drm/i915/skl: split skl_compute_ddb function

2018-03-09 Thread Vidya Srinivas
From: Mahesh Kumar This patch splits skl_compute_wm/ddb functions into two parts. One adds all affected pipes after the commit to atomic_state structure and second part does compute the DDB. v2: Added reviewed by tag from Shashank Sharma Reviewed-by: Shashank Sharma Signed-off-by: Mahesh Kumar

[Intel-gfx] [PATCH v13 03/17] drm/i915/skl+: add NV12 in skl_format_to_fourcc

2018-03-09 Thread Vidya Srinivas
From: Mahesh Kumar Add support of recognizing DRM_FORMAT_NV12 from plane_format register value. v2: Added reviewed by tag from Mika Kahola Reviewed-by: Mika Kahola Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/intel_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drive

[Intel-gfx] [PATCH v13 15/17] drm/i915: Add NV12 support to intel_framebuffer_init

2018-03-09 Thread Vidya Srinivas
From: Chandra Konduru This patch adds NV12 as supported format to intel_framebuffer_init and performs various checks. v2: -Fix an issue in checks added (Chandra Konduru) v3: rebased (me) v4: Review comments by Ville addressed Added platform check for NV12 in intel_framebuffer_init Removed offs

[Intel-gfx] [PATCH v13 01/17] drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values

2018-03-09 Thread Vidya Srinivas
From: Mahesh Kumar skl_wm_values struct contains values of pipe/plane DDB only. so rename it for better readability of code. Similarly skl_copy_wm_for_pipe copies DDB values. s/skl_wm_values/skl_ddb_values s/skl_copy_wm_for_pipe/skl_copy_ddb_for_pipe Changes since V1: - also change name of skl

[Intel-gfx] [PATCH v13 00/17] Add NV12 support

2018-03-09 Thread Vidya Srinivas
This patch series is adding NV12 support for Broxton display after rebasing on latest drm-tip. Initial series of the patches can be found here: https://lists.freedesktop.org/archives/intel-gfx/2015-May/066786.html Previous revision history: The first version of patches were reviewed when floated b

[Intel-gfx] [PATCH v13 14/17] drm/i915: Add NV12 as supported format for sprite plane

2018-03-09 Thread Vidya Srinivas
From: Chandra Konduru This patch adds NV12 to list of supported formats for sprite plane. v2: Rebased (me) v3: Review comments by Ville addressed - Removed skl_plane_formats_with_nv12 and added NV12 case in existing skl_plane_formats - Added the 10bpc RGB formats v4: Addressed review comments

[Intel-gfx] [PATCH v13 07/17] drm/i915/skl+: make sure higher latency level has higher wm value

2018-03-09 Thread Vidya Srinivas
From: Mahesh Kumar DDB allocation optimization algorithm requires/assumes ddb allocation for any memory C-state level DDB value to be as high as level below the current level. Render decompression requires level WM to be as high as wm level-0. This patch fulfils both the requirements. v2: Change

[Intel-gfx] [PATCH v13 04/17] drm/i915/skl+: support verification of DDB HW state for NV12

2018-03-09 Thread Vidya Srinivas
From: Mahesh Kumar For YUV 420 Planar formats like NV12, buffer allocation is done for Y and UV surfaces separately. For NV12 plane formats, the UV buffer allocation must be programmed in the Plane Buffer Config register and the Y buffer allocation must be programmed in the Plane NV12 Buffer Conf

[Intel-gfx] [PATCH v13 08/17] drm/i915/skl+: nv12 workaround disable WM level 1-7

2018-03-09 Thread Vidya Srinivas
From: Mahesh Kumar Display Workaround #0826 (SKL:ALL BXT:ALL) & #1059(CNL:A) Hardware sometimes fails to wake memory from pkg C states fetching the last few lines of planar YUV 420 (NV12) planes. This causes intermittent underflow and corruption. WA: Disable package C states or do not enable late

[Intel-gfx] [PATCH v13 12/17] drm/i915: Upscale scaler max scale for NV12

2018-03-09 Thread Vidya Srinivas
From: Chandra Konduru This patch updates scaler max limit support for NV12 v2: Rebased (me) v3: Rebased (me) v4: Missed the Tested-by/Reviewed-by in the previous series Adding the same to commit message in this version. v5: Addressed review comments from Ville and rebased - calculation of max

[Intel-gfx] [PATCH v13 11/17] drm/i915: Update format_is_yuv() to include NV12

2018-03-09 Thread Vidya Srinivas
From: Chandra Konduru This patch adds NV12 to format_is_yuv() function for sprite planes. v2: -Use intel_ prefix for format_is_yuv (Ville) v3: Rebased (me) v4: Rebased and addressed review comments from Clinton A Taylor. "static function in intel_sprite.c is not available to the primary plane

[Intel-gfx] [PATCH v13 13/17] drm/i915: Add NV12 as supported format for primary plane

2018-03-09 Thread Vidya Srinivas
From: Chandra Konduru This patch adds NV12 to list of supported formats for primary plane v2: Rebased (Chandra Konduru) v3: Rebased (me) v4: Review comments by Ville addressed Removed the skl_primary_formats_with_nv12 and added NV12 case in existing skl_primary_formats v5: Rebased (me) v6: M

[Intel-gfx] [PATCH v13 05/17] drm/i915/skl+: NV12 related changes for WM

2018-03-09 Thread Vidya Srinivas
From: Mahesh Kumar NV12 requires WM calculation for UV plane as well. UV plane WM should also fulfill all the WM related restrictions. v2: Addressed review comments from Shashank Sharma. v3: Addressed review comments from Shashank Sharma Changed plane_num to plane_id in skl_compute_plane_wm_par

[Intel-gfx] [PATCH v13 06/17] drm/i915/skl+: pass skl_wm_level struct to wm compute func

2018-03-09 Thread Vidya Srinivas
From: Mahesh Kumar This patch passes skl_wm_level structure itself to watermark computation function skl_compute_plane_wm function (instead of its internal parameters). It reduces number of arguments required to be passed. v2: Addressed review comments by Shashank Sharma v3: Adding reviewed by

[Intel-gfx] [PATCH v13 10/17] drm/i915: Set scaler mode for NV12

2018-03-09 Thread Vidya Srinivas
From: Chandra Konduru This patch sets appropriate scaler mode for NV12 format. In this mode, skylake scaler does either chroma-upsampling or chroma-upsampling and resolution scaling v2: Review comments from Ville addressed NV12 case to be checked first for setting the scaler v3: Rebased (me) v

[Intel-gfx] [PATCH v13 17/17] drm/i915: Display WA 827

2018-03-09 Thread Vidya Srinivas
Display WA 827 applies to GEN9 (excluede GLK) and CNL. Switching the plane format from NV12 to RGB and leaving system idle results in display underrun and corruption. WA: Set the bit 15 & bit 19 to 1b in the CLKGATE_DIS_PSL register for the pipe in which NV12 plane is enabled. Signed-off-by: Chand

[Intel-gfx] [PATCH v13 16/17] drm/i915: Enable YUV to RGB for Gen10 in Plane Ctrl Reg

2018-03-09 Thread Vidya Srinivas
If the fb format is YUV, enable the plane CSC mode bits for the conversion. v2: Addressed review comments from Shashank Sharma Alignment issue fixed in i915_reg.h v3: Adding Reviewed By from Shashank Sharma v4: Rebased the patch. As part of rebasing, re-using the color series defines which are a

[Intel-gfx] ✗ Fi.CI.BAT: failure for Add NV12 support

2018-03-09 Thread Patchwork
== Series Details == Series: Add NV12 support URL : https://patchwork.freedesktop.org/series/39670/ State : failure == Summary == Series 39670v1 Add NV12 support https://patchwork.freedesktop.org/api/1.0/series/39670/revisions/1/mbox/ Possible new issues: Test prime_vgem: Subgro

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove support for legacy debugfs crc interface (rev2)

2018-03-09 Thread Patchwork
== Series Details == Series: drm/i915: Remove support for legacy debugfs crc interface (rev2) URL : https://patchwork.freedesktop.org/series/33053/ State : failure == Summary == Possible new issues: Test kms_pipe_crc_basic: Subgroup bad-nb-words-1: pass -> S

Re: [Intel-gfx] [PATCH v2 00/42] drm/i915: Implement HDCP2.2

2018-03-09 Thread Daniel Vetter
On Thu, Mar 08, 2018 at 06:03:32PM +0530, Ramalingam C wrote: > On Thursday 08 March 2018 06:00 PM, Winkler, Tomas wrote: > > > > > -Original Message- > > > From: C, Ramalingam > > > Sent: Thursday, March 08, 2018 13:58 > > > To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop

Re: [Intel-gfx] [PATCH v2 07/15] drm/i915/guc: Flush directly in log unregister

2018-03-09 Thread Sagar Arun Kamble
On 3/8/2018 9:16 PM, Michał Winiarski wrote: Having both guc_flush_logs and guc_log_flush functions is confusing. While we could just rename things, guc_flush_logs implementation is quite simple. Let's get rid of it and move its content to unregister. v2: s/dev_priv/i915 (Sagar) Signed-off-by

Re: [Intel-gfx] [RFC] drm/i915: store all mmio bases in intel_engines

2018-03-09 Thread Tvrtko Ursulin
On 08/03/2018 18:46, Daniele Ceraolo Spurio wrote: On 08/03/18 01:31, Tvrtko Ursulin wrote: On 07/03/2018 19:45, Daniele Ceraolo Spurio wrote: The mmio bases we're currently storing in the intel_engines array are only valid for a subset of gens, so we need to ignore them and use different val

[Intel-gfx] [PATCH] drm/i915: Show GEM_TRACE when detecting a failed GPU idle

2018-03-09 Thread Chris Wilson
If we timeout waiting for the GPU to idle, something went seriously wrong. We currently dump the engine state, but we can also dump the ftrace buffer showing our last operations (when available). In passing, note that since commit 559e040f1f08 ("drm/i915: Show the GPU state when declaring wedged",

Re: [Intel-gfx] [PATCH v2] drm/i915: Trim gen11_gt_irq_handler

2018-03-09 Thread Tvrtko Ursulin
On 09/03/2018 01:38, Chris Wilson wrote: Quoting Chris Wilson (2018-03-09 01:33:08) gen11_gt_engine_intr(struct drm_i915_private * const i915, const unsigned int bank, const unsigned int bit) @@ -2836,10 +2798,23 @@ static void gen11_gt_irq_handler(struct drm_i915_priv

[Intel-gfx] [PATCH v2] drm/i915: Show GEM_TRACE when detecting a failed GPU idle

2018-03-09 Thread Chris Wilson
If we timeout waiting for the GPU to idle, something went seriously wrong. We currently dump the engine state, but we can also dump the ftrace buffer showing our last operations (when available). In passing, note that since commit 559e040f1f08 ("drm/i915: Show the GPU state when declaring wedged",

Re: [Intel-gfx] [PATCH v2] drm/i915: Trim gen11_gt_irq_handler

2018-03-09 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-03-09 10:06:48) > > On 09/03/2018 01:38, Chris Wilson wrote: > And in general I think too many bike-sheds on this area of code before > we are even running it on real hw. :( Come on now, it's not a proper bikeshed if the discussion is meaningful! -Chris _

Re: [Intel-gfx] [PATCH] drm/i915/dp: Do not set the eDP link rate/lane count to max

2018-03-09 Thread Jani Nikula
On Thu, 08 Mar 2018, Manasi Navare wrote: > The panels are generally designed to support only a single > clock and lane configuration, and typically these values > correspond to the native resolution of the panel. But some > panels advertise the MAX_LINK_RATE in DPCD higher than what > is required

Re: [Intel-gfx] [PATCH] drm/i915/dp: Do not set the eDP link rate/lane count to max

2018-03-09 Thread Chris Wilson
Quoting Jani Nikula (2018-03-09 10:20:37) > On Thu, 08 Mar 2018, Manasi Navare wrote: > > The panels are generally designed to support only a single > > clock and lane configuration, and typically these values > > correspond to the native resolution of the panel. But some > > panels advertise the

Re: [Intel-gfx] [PULL] gvt-next for 4.17

2018-03-09 Thread Jani Nikula
Joonas, so did this miss the deadline for v4.17? You're not making another pull request? BR, Jani. On Thu, 08 Mar 2018, Joonas Lahtinen wrote: > Pulled. > > Regards, Joonas > > Quoting Zhenyu Wang (2018-03-08 04:31:52) >> >> Hi, >> >> Here's gvt-next update for 4.17. Biggest update is for hug

Re: [Intel-gfx] [PATCH] drm/i915/icl: do not save DDI A/E sharing bit for ICL

2018-03-09 Thread Jani Nikula
On Tue, 06 Mar 2018, Ville Syrjälä wrote: > On Tue, Mar 06, 2018 at 12:41:55PM +0200, Jani Nikula wrote: >> We don't want to preserve the DDI A 4 lane bit on ICL. >> >> Fixes: 3d2011cfa41f ("drm/i915/icl: remove port A/E lane sharing >> limitation.") >> Cc: Mahesh Kumar >> Cc: Paulo Zanoni >>

Re: [Intel-gfx] [PATCH v2] drm/i915: Push irq_shift from gen8_cs_irq_handler() to caller

2018-03-09 Thread Chris Wilson
Quoting Chris Wilson (2018-03-09 01:08:08) > Originally we were inlining gen8_cs_irq_handler() and so expected the > compiler to constant-fold away the irq_shift (so we had hardcoded it as > opposed to use engine->irq_shift). However, we dropped the inline given > the proliferation of gen8_cs_irq_h

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Show GEM_TRACE when detecting a failed GPU idle (rev2)

2018-03-09 Thread Patchwork
== Series Details == Series: drm/i915: Show GEM_TRACE when detecting a failed GPU idle (rev2) URL : https://patchwork.freedesktop.org/series/39674/ State : success == Summary == Series 39674v2 drm/i915: Show GEM_TRACE when detecting a failed GPU idle https://patchwork.freedesktop.org/api/1.0/s

Re: [Intel-gfx] [PATCH v2 08/15] drm/i915/guc: Split relay control and GuC log level

2018-03-09 Thread Sagar Arun Kamble
On 3/8/2018 9:17 PM, Michał Winiarski wrote: Those two concepts are really separate. Since GuC is writing data into its own buffer and we even provide a way for userspace to read directly from it using i915_guc_log_dump debugfs, there's no real reason to tie log level with relay creation. Let's

[Intel-gfx] [PATCH igt] igt/gem_mocs_settings: Wait for RC6 EI before polling

2018-03-09 Thread Chris Wilson
On bxt, we see that the rc6 subtest flip-flops as RC6 does not restart within our desired interval. Improve the likelihood of the inspection passing by idling the GPU and waiting for 2 Evaluation Intervals before we start polling of RC6 residency. Signed-off-by: Chris Wilson --- tests/gem_mocs_s

Re: [Intel-gfx] [PATCH v2 10/15] drm/i915/guc: Get rid of GuC log runtime

2018-03-09 Thread Sagar Arun Kamble
On 3/8/2018 9:17 PM, Michał Winiarski wrote: Runtime is not a very good name. Let's also move counting relay overflows inside relay struct. v2: Rename things rather than remove the struct (Chris) Signed-off-by: Michał Winiarski Cc: Chris Wilson Cc: Daniele Ceraolo Spurio Cc: Sagar Arun Kam

Re: [Intel-gfx] [PATCH v2 08/15] drm/i915/guc: Split relay control and GuC log level

2018-03-09 Thread Michal Wajdeczko
On Thu, 08 Mar 2018 16:47:00 +0100, Michał Winiarski wrote: Those two concepts are really separate. Since GuC is writing data into its own buffer and we even provide a way for userspace to read directly from it using i915_guc_log_dump debugfs, there's no real reason to tie log level with rela

Re: [Intel-gfx] [PATCH v2 12/15] drm/i915/guc: Don't print out relay statistics when relay is disabled

2018-03-09 Thread Sagar Arun Kamble
On 3/8/2018 9:17 PM, Michał Winiarski wrote: If nobody has enabled the relay, we're not comunicating with GuC, which means that the stats don't have any meaning. Let's also remove interrupt counter and tidy the debugfs formatting. v2: Correct stats accounting (Sagar) Signed-off-by: Michał Win

Re: [Intel-gfx] [PATCH v2 14/15] drm/i915/guc: Default to non-verbose GuC logging

2018-03-09 Thread Sagar Arun Kamble
On 3/8/2018 9:17 PM, Michał Winiarski wrote: Now that we've decoupled logging from relay, GuC log level is only controlling the GuC behavior - there shouldn't be any impact on i915 behaviour. We're only going to see a single extra interrupt when log will get half full. That, and the fact that w

[Intel-gfx] [PATCH i-g-t v2] tests/perf_pmu: Use absolute tolerance in accuracy tests

2018-03-09 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We need to use absolute tolerance when asserting on percentages. Relative tolerance in this case is unfair and inaccurate since it's strictness varies with relative target busyness. v2: * Do not include spin batch edit and submit into measured time. * Open PMU before child

Re: [Intel-gfx] [PATCH 2/3] drm/i915/uc: Sanitize uC together with GEM

2018-03-09 Thread Sagar Arun Kamble
On 3/9/2018 2:30 AM, Michal Wajdeczko wrote: Instead of dancing around uC on reset/suspend/resume scenarios, explicitly sanitize uC when we sanitize GEM to force uC reload and start from known beginning. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Sagar Arun Kamble Cc: Ch

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_chamelium: Make tests run without pipe color management support.

2018-03-09 Thread Maarten Lankhorst
Op 06-03-18 om 16:57 schreef Maxime Ripard: > Hi, > > On Mon, Mar 05, 2018 at 07:14:16PM +0100, Maarten Lankhorst wrote: >> Only try to set those values if the properties are supported. >> This fixes the kms_chameium tests to run on vc4 again. >> >> Reported-by: Maxime Ripard >> Cc: Paul Kocialkow

[Intel-gfx] [PATCH] drm/i915/perf: enable perf support on ICL

2018-03-09 Thread Lionel Landwerlin
No significant changes from either context offsets, nor report formats, nor register whitelist. Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/Makefile | 3 +- drivers/gpu/drm/i915/i915_oa_icl.c | 118 + drivers/gpu/drm/i915/i915_oa_icl.h |

Re: [Intel-gfx] [PATCH] drm/i915: make edp optimize config

2018-03-09 Thread Jani Nikula
On Thu, 08 Mar 2018, matthew.s.atw...@intel.com wrote: > From: Matt Atwood > > Previously it was assumed that eDP panels would advertise the lowest link > rate required for their singular mode to function. With the introduction > of more advanced features there are advantages to a panel advertisin

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Show GEM_TRACE when detecting a failed GPU idle (rev2)

2018-03-09 Thread Patchwork
== Series Details == Series: drm/i915: Show GEM_TRACE when detecting a failed GPU idle (rev2) URL : https://patchwork.freedesktop.org/series/39674/ State : failure == Summary == Possible new issues: Test kms_cursor_legacy: Subgroup cursorb-vs-flipb-atomic-transitions-varying-size

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: enable perf support on ICL

2018-03-09 Thread Patchwork
== Series Details == Series: drm/i915/perf: enable perf support on ICL URL : https://patchwork.freedesktop.org/series/39689/ State : success == Summary == Series 39689v1 drm/i915/perf: enable perf support on ICL https://patchwork.freedesktop.org/api/1.0/series/39689/revisions/1/mbox/ Kno

[Intel-gfx] [PATCH 3/3] drm/i915/cnl: Kill _MMIO_PORT6 macro

2018-03-09 Thread Mahesh Kumar
This patch replaces use of remaining _MMIO_PORT6 macro and removes the macro. Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/i915_reg.h | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 7

[Intel-gfx] [PATCH 1/3] drm/i915/cnl; Add macro to get PORT_TX register

2018-03-09 Thread Mahesh Kumar
This patch creates a new macro to get PORT_TX register for any given DW. This will remove the need of defining register address for each port & DW. Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/i915_reg.h | 28 1 file changed, 28 insertions(+) diff --git a/dr

[Intel-gfx] [PATCH 0/3] CNL port refactoring

2018-03-09 Thread Mahesh Kumar
This series fixes CNL PORT_TX_DW5/7_LNO_D register address. This series also introduces macros to get register address of CNL_PORT_TX registers instead of defining for each DW instance. changes since V1: completely kill _MMIO_PORT6 macro Mahesh Kumar (3): drm/i915/cnl; Add macro to get PORT_TX

[Intel-gfx] [PATCH 2/3] drm/i915/cnl: Replace PORT_TX register macros with new ones

2018-03-09 Thread Mahesh Kumar
This patch replaces CNL_PORT_TX register macros with new macros defined in previous patch. Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/i915_reg.h | 107 +--- 1 file changed, 11 insertions(+), 96 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Finish the wait-for-wedge by retiring all the inflight requests

2018-03-09 Thread Mika Kuoppala
Chris Wilson writes: > Before we reset the GPU after marking the device as wedged, we wait for > all the remaining requests to be completed (and marked as EIO). > Afterwards, we should flush the request lists so the next batch start > with the driver in an idle start. s/start/state? > > Signed-

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_chamelium: Make tests run without pipe color management support.

2018-03-09 Thread Maxime Ripard
On Fri, Mar 09, 2018 at 12:55:24PM +0100, Maarten Lankhorst wrote: > Op 06-03-18 om 16:57 schreef Maxime Ripard: > > Hi, > > > > On Mon, Mar 05, 2018 at 07:14:16PM +0100, Maarten Lankhorst wrote: > >> Only try to set those values if the properties are supported. > >> This fixes the kms_chameium tes

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Reset ring space estimate after unwinding the request

2018-03-09 Thread Chris Wilson
Quoting Chris Wilson (2018-03-07 13:42:22) > With a series of unusual events (a sequence of interrupted request > allocations), we could gradually leak the ring->space estimate by > unwinding the ring back to the start of the request, but not return the > used space back to the ring. Eventually and

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Reset ring space estimate after unwinding the request

2018-03-09 Thread Mika Kuoppala
Chris Wilson writes: > With a series of unusual events (a sequence of interrupted request > allocations), we could gradually leak the ring->space estimate by > unwinding the ring back to the start of the request, but not return the > used space back to the ring. Eventually and with great misfortu

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Reset ring space estimate after unwinding the request

2018-03-09 Thread Chris Wilson
Quoting Mika Kuoppala (2018-03-09 13:17:09) > Chris Wilson writes: > > > With a series of unusual events (a sequence of interrupted request > > allocations), we could gradually leak the ring->space estimate by > > unwinding the ring back to the start of the request, but not return the > > used sp

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Update ring position from request on retiring

2018-03-09 Thread Mika Kuoppala
Chris Wilson writes: > When wedged, we do not update the ring->tail as we submit the requests > causing us to leak the ring->space upon cleaning up the wedged driver. > We can just use the value stored in rq->tail, and keep the submission > backend details away from set-wedge. > > Signed-off-by:

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Include ring->emit in debugging

2018-03-09 Thread Mika Kuoppala
Chris Wilson writes: > Include ring->emit and ring->space alongside ring->(head,tail) when > printing debug information. > > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > --- > drivers/gpu/drm/i915/i915_debugfs.c| 4 ++-- > drivers/gpu/drm/i915/intel_engine_cs.c | 10 +++--- > 2 f

Re: [Intel-gfx] [PATCH] drm/i915/perf: enable perf support on ICL

2018-03-09 Thread Matthew Auld
On 9 March 2018 at 11:58, Lionel Landwerlin wrote: > No significant changes from either context offsets, nor report > formats, nor register whitelist. > > Signed-off-by: Lionel Landwerlin > --- The usual spiel about disabling clock-ratio-change reports, do we need it? So this will need the time

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Wrap engine->schedule in RCU locks for set-wedge protection

2018-03-09 Thread Mika Kuoppala
Chris Wilson writes: > Similar to the staging around handling of engine->submit_request, we > need to stop adding to the execlists->queue prior to calling > engine->cancel_requests. cancel_requests will move requests from the > queue onto the timeline, so if we add a request onto the queue after

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Update ring position from request on retiring

2018-03-09 Thread Chris Wilson
Quoting Mika Kuoppala (2018-03-09 13:38:37) > Chris Wilson writes: > > > When wedged, we do not update the ring->tail as we submit the requests > > causing us to leak the ring->space upon cleaning up the wedged driver. > > We can just use the value stored in rq->tail, and keep the submission > >

[Intel-gfx] ✓ Fi.CI.BAT: success for CNL port refactoring (rev2)

2018-03-09 Thread Patchwork
== Series Details == Series: CNL port refactoring (rev2) URL : https://patchwork.freedesktop.org/series/38334/ State : success == Summary == Series 38334v2 CNL port refactoring https://patchwork.freedesktop.org/api/1.0/series/38334/revisions/2/mbox/ Known issues: Test kms_frontbuffer_tr

[Intel-gfx] [PATCH igt] igt: Add gem_ctx_freq to exercise requesting freq on a ctx

2018-03-09 Thread Chris Wilson
Exercise some new API that allows applications to request that individual contexts are executed within a desired frequency range. v2: Split single/continuous set_freq subtests v3: Do an up/down ramp for individual freq request, check nothing changes after each invalid request Signed-off-by: Chris

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Only call tasklet_kill() on the first prepare_reset

2018-03-09 Thread Mika Kuoppala
Chris Wilson writes: > tasklet_kill() will spin waiting for the current tasklet to be executed. > However, if tasklet_disable() has been called, then the tasklet is never > executed but permanently put back onto the runlist until > tasklet_enable() is called. Ergo, we cannot use tasklet_kill() in

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Only call tasklet_kill() on the first prepare_reset

2018-03-09 Thread Chris Wilson
Quoting Chris Wilson (2018-03-07 13:42:26) > tasklet_kill() will spin waiting for the current tasklet to be executed. > However, if tasklet_disable() has been called, then the tasklet is never > executed but permanently put back onto the runlist until > tasklet_enable() is called. Ergo, we cannot u

Re: [Intel-gfx] [PATCH] drm/i915/perf: enable perf support on ICL

2018-03-09 Thread Lionel Landwerlin
On 09/03/18 13:49, Matthew Auld wrote: On 9 March 2018 at 11:58, Lionel Landwerlin wrote: No significant changes from either context offsets, nor report formats, nor register whitelist. Signed-off-by: Lionel Landwerlin --- The usual spiel about disabling clock-ratio-change reports, do we nee

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Only call tasklet_kill() on the first prepare_reset

2018-03-09 Thread Chris Wilson
Quoting Chris Wilson (2018-03-09 14:10:34) > Quoting Chris Wilson (2018-03-07 13:42:26) > > tasklet_kill() will spin waiting for the current tasklet to be executed. > > However, if tasklet_disable() has been called, then the tasklet is never > > executed but permanently put back onto the runlist un

Re: [Intel-gfx] [igt-dev] [PATCH igt] igt/gem_mocs_settings: Wait for RC6 EI before polling

2018-03-09 Thread Michał Winiarski
On Fri, Mar 09, 2018 at 10:42:40AM +, Chris Wilson wrote: > On bxt, we see that the rc6 subtest flip-flops as RC6 does not restart > within our desired interval. Improve the likelihood of the inspection > passing by idling the GPU and waiting for 2 Evaluation Intervals before > we start polling

[Intel-gfx] [PATCH v3 1/4] drm: Add drm_any_plane_has_format()

2018-03-09 Thread Ville Syrjala
From: Ville Syrjälä Add a function to check whether there is at least one plane that supports a specific format and modifier combination. Drivers can use this to reject unsupported formats/modifiers in .fb_create(). v2: Accept anyformat if the driver doesn't do planes (Eric) s/planes_have_fo

[Intel-gfx] [PATCH v3 2/4] drm/i915: Eliminate the horrendous format check code

2018-03-09 Thread Ville Syrjala
From: Ville Syrjälä Replace the messy framebuffer format/modifier validation code with a single call to drm_any_plane_has_format(). The code was extremely annoying to maintain as you had to have a lot of platform checks for different formats. The new code requires zero maintenance. v2: Nuke the

[Intel-gfx] [PATCH 4/4] drm/vc4: Validate framebuffer pixel format/modifier

2018-03-09 Thread Ville Syrjala
From: Ville Syrjälä Only create framebuffers with supported format/modifier combinations by checking that at least one plane supports the requested combination. Using drm_any_plane_has_format() is somewhat suboptimal for vc4 since the planes have (mostly) uniform capabilities. But I was lazy and

[Intel-gfx] [PATCH 3/4] drm: Fix some coding style issues

2018-03-09 Thread Ville Syrjala
From: Ville Syrjälä Put an empty line between the variable declarations and the code, and use tabs for alignment. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_framebuffer.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_framebuffer.c b/dri

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3,1/4] drm: Add drm_any_plane_has_format()

2018-03-09 Thread Patchwork
== Series Details == Series: series starting with [v3,1/4] drm: Add drm_any_plane_has_format() URL : https://patchwork.freedesktop.org/series/39700/ State : success == Summary == Series 39700v1 series starting with [v3,1/4] drm: Add drm_any_plane_has_format() https://patchwork.freedesktop.org/

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/perf: enable perf support on ICL

2018-03-09 Thread Patchwork
== Series Details == Series: drm/i915/perf: enable perf support on ICL URL : https://patchwork.freedesktop.org/series/39689/ State : success == Summary == Known issues: Test gem_eio: Subgroup in-flight: incomplete -> PASS (shard-apl) fdo#105341 Test kms_curs

[Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT

2018-03-09 Thread Gaurav K Singh
On Apollolake, with stress test warm reboot, audio card was not getting enumerated after reboot. This was a spurious issue happening on Apollolake. HW codec and HD audio controller link was going out of sync for which there was a fix in i915 driver but was not getting invoked for BXT. Extending thi

[Intel-gfx] [PATCH v2 0/3] drm/i915/uc: Sanitize uC

2018-03-09 Thread Michal Wajdeczko
Attempt to sanitize uC for better alignment with rest of GEM driver. v2: cover reset path and sanitize uc before gem Michal Wajdeczko (3): drm/i915/uc: Sanitize uC options early drm/i915/uc: Sanitize uC together with GEM HAX: Enable GuC for CI drivers/gpu/drm/i915/i915_drv.c| 2 -- d

[Intel-gfx] [PATCH v2 1/3] drm/i915/uc: Sanitize uC options early

2018-03-09 Thread Michal Wajdeczko
We are sanitizing uC related modparams together with other driver modparams in intel_sanitize_options called from i915_driver_init_hw, but this is too late for us as we will want to use USES_GUC/USES_HUC macros at earlier stage. Since our sanitizing does not require any MMIO access, we can do it in

[Intel-gfx] [PATCH v2 2/3] drm/i915/uc: Sanitize uC together with GEM

2018-03-09 Thread Michal Wajdeczko
Instead of dancing around uC on reset/suspend/resume scenarios, explicitly sanitize uC when we sanitize GEM to force uC reload and start from known beginning. v2: don't forget about reset path (Daniele) sanitize uc before gem initiated full reset (Daniele) Signed-off-by: Michal Wajdeczko Cc:

[Intel-gfx] [PATCH v2 3/3] HAX: Enable GuC for CI

2018-03-09 Thread Michal Wajdeczko
v2: except running with HYPERVISOR Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_params.h | 2 +- drivers/gpu/drm/i915/intel_uc.c| 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h inde

Re: [Intel-gfx] [PATCH v2 0/4] drm/i915: misc fixes in headers (RESEND)

2018-03-09 Thread Arkadiusz Hiler
On Thu, Mar 08, 2018 at 04:22:55PM +0100, Michal Wajdeczko wrote: > On Thu, 08 Mar 2018 13:58:48 +0100, Petri Latvala > wrote: > > > On Thu, Mar 08, 2018 at 02:20:41PM +0200, Jani Nikula wrote: > > > On Thu, 08 Mar 2018, Chris Wilson wrote: > > > > Quoting Michal Wajdeczko (2018-03-08 09:50:33)

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: i915: Fix audio issue on BXT (rev2)

2018-03-09 Thread Patchwork
== Series Details == Series: drm: i915: Fix audio issue on BXT (rev2) URL : https://patchwork.freedesktop.org/series/35955/ State : failure == Summary == Series 35955v2 drm: i915: Fix audio issue on BXT https://patchwork.freedesktop.org/api/1.0/series/35955/revisions/2/mbox/ Possible new

Re: [Intel-gfx] [PATCH v2 08/15] drm/i915/guc: Split relay control and GuC log level

2018-03-09 Thread Michał Winiarski
On Fri, Mar 09, 2018 at 12:00:06PM +0100, Michal Wajdeczko wrote: > On Thu, 08 Mar 2018 16:47:00 +0100, Michał Winiarski > wrote: > > > Those two concepts are really separate. Since GuC is writing data into > > its own buffer and we even provide a way for userspace to read directly > > from it us

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/uc: Sanitize uC (rev2)

2018-03-09 Thread Patchwork
== Series Details == Series: drm/i915/uc: Sanitize uC (rev2) URL : https://patchwork.freedesktop.org/series/39634/ State : success == Summary == Series 39634v2 drm/i915/uc: Sanitize uC https://patchwork.freedesktop.org/api/1.0/series/39634/revisions/2/mbox/ Known issues: Test debugfs_te

Re: [Intel-gfx] [PATCH v2 08/15] drm/i915/guc: Split relay control and GuC log level

2018-03-09 Thread Chris Wilson
Quoting Michał Winiarski (2018-03-09 16:30:42) > On Fri, Mar 09, 2018 at 12:00:06PM +0100, Michal Wajdeczko wrote: > > On Thu, 08 Mar 2018 16:47:00 +0100, Michał Winiarski > > wrote: > > > > > Those two concepts are really separate. Since GuC is writing data into > > > its own buffer and we even

[Intel-gfx] [CI 4/4] HAX: Enable GuC for CI

2018-03-09 Thread Chris Wilson
From: Michal Wajdeczko v2: except running with HYPERVISOR --- drivers/gpu/drm/i915/i915_params.h | 2 +- drivers/gpu/drm/i915/intel_uc.c| 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index 430f5f9

[Intel-gfx] [CI 3/4] drm/i915/guc: Move GuC notification handling to separate function

2018-03-09 Thread Chris Wilson
From: Michal Wajdeczko To allow future code reuse. While here, fix comment style. v2: Notifications are a separate thing - rename the handler (Sagar) Suggested-by: Oscar Mateo Signed-off-by: Michal Wajdeczko Signed-off-by: Michał Winiarski Cc: Chris Wilson Cc: Daniele Ceraolo Spurio Cc: Os

[Intel-gfx] [CI 1/4] drm/i915/guc: Tidy guc_log_control

2018-03-09 Thread Chris Wilson
From: Michał Winiarski We plan to decouple log runtime (mapping + relay) from verbosity control. Let's tidy the code now to reduce the churn in the following patches. v2: Tidy macros, keep debug messages, use helper var for enable, correct typo (Michał) Fix incorrect input validaction (S

[Intel-gfx] [CI 2/4] drm/i915/guc: Create common entry points for log register/unregister

2018-03-09 Thread Chris Wilson
From: Michał Winiarski We have many functions responsible for allocating different parts of GuC log runtime called from multiple places. Let's stick with keeping everything in guc_log_register instead. v2: Use more generic intel_uc_register name, keep using "misc" suffix (Michał) s/dev_priv/

Re: [Intel-gfx] [PATCH igt] igt: Add gem_ctx_freq to exercise requesting freq on a ctx

2018-03-09 Thread Tvrtko Ursulin
On 09/03/2018 13:46, Chris Wilson wrote: Exercise some new API that allows applications to request that individual contexts are executed within a desired frequency range. v2: Split single/continuous set_freq subtests v3: Do an up/down ramp for individual freq request, check nothing changes afte

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: misc fixes in headers (RESEND)

2018-03-09 Thread Patchwork
== Series Details == Series: drm/i915: misc fixes in headers (RESEND) URL : https://patchwork.freedesktop.org/series/39589/ State : success == Summary == Series 39589v1 drm/i915: misc fixes in headers (RESEND) https://patchwork.freedesktop.org/api/1.0/series/39589/revisions/1/mbox/ Known

Re: [Intel-gfx] [PATCH] drm/i915: Remove the impedance mismatch around intel_engine_enable_signaling

2018-03-09 Thread Tvrtko Ursulin
On 08/03/2018 14:07, Chris Wilson wrote: There is some redundancy between dma_fence->ops->enable_signaling (via i915_fence_enable_signaling) and our backend, intel_engine_enable_signaling() in that both levels recheck the fence status multiple times. If we convert intel_engine_enable_signaling()

Re: [Intel-gfx] [PATCH igt] igt: Add gem_ctx_freq to exercise requesting freq on a ctx

2018-03-09 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-03-09 17:06:45) > > On 09/03/2018 13:46, Chris Wilson wrote: > > Exercise some new API that allows applications to request that > > individual contexts are executed within a desired frequency range. > > > > v2: Split single/continuous set_freq subtests > > v3: Do an u

[Intel-gfx] ✓ Fi.CI.IGT: success for CNL port refactoring (rev2)

2018-03-09 Thread Patchwork
== Series Details == Series: CNL port refactoring (rev2) URL : https://patchwork.freedesktop.org/series/38334/ State : success == Summary == Known issues: Test gem_eio: Subgroup in-flight-external: pass -> INCOMPLETE (shard-apl) fdo#105341 Test kms_cursor_cr

Re: [Intel-gfx] [PATCH] drm/i915: Remove the impedance mismatch around intel_engine_enable_signaling

2018-03-09 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-03-09 17:24:33) > > On 08/03/2018 14:07, Chris Wilson wrote: > > There is some redundancy between dma_fence->ops->enable_signaling (via > > i915_fence_enable_signaling) and our backend, > > intel_engine_enable_signaling() in that both levels recheck the fence > > statu

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/4] drm/i915/guc: Tidy guc_log_control

2018-03-09 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915/guc: Tidy guc_log_control URL : https://patchwork.freedesktop.org/series/39710/ State : success == Summary == Series 39710v1 series starting with [CI,1/4] drm/i915/guc: Tidy guc_log_control https://patchwork.freedesktop.org/ap

[Intel-gfx] ✓ Fi.CI.BAT: success for Add NV12 support

2018-03-09 Thread Patchwork
== Series Details == Series: Add NV12 support URL : https://patchwork.freedesktop.org/series/39670/ State : success == Summary == Series 39670v1 Add NV12 support https://patchwork.freedesktop.org/api/1.0/series/39670/revisions/1/mbox/ Known issues: Test debugfs_test: Subgroup re

[Intel-gfx] [PULL] drm-misc-next

2018-03-09 Thread Sean Paul
Hi Dave, Here are the -misc-next pulls for the last 2 weeks. Sorry for the hold-up last week. drm-misc-next-2018-03-09-3: drm-misc-next for 4.17: UAPI Changes: plane: Add color encoding/range properties (Jyri) nouveau: Replace iturbt_709 property with color_encoding property (Ville) Core Chan

[Intel-gfx] [RFC v3 1/8] drm: Add Enhanced Gamma LUT precision structure

2018-03-09 Thread Uma Shankar
Existing LUT precision structure is having only 16 bit precision. This is not enough for upcoming enhanced hardwares and advance usecases like HDR processing. Hence added a new structure with 32 bit precision values. Also added the code, for extracting the same from values passed from userspace. S

[Intel-gfx] [RFC v3 0/8] Add Plane Color Properties

2018-03-09 Thread Uma Shankar
This patch series adds properties for plane color features. It adds properties for degamma used to linearize data, CSC used for gamut conversion, and gamma used to again non-linearize data as per panel supported color space. These can be utilize by user space to convert planes from one format to an

  1   2   >