From: Yang Shi
issue: snd_soc_skl meet "failed to add i915 component master (-19)" when
platform don't connect any display output.
i915 do initialization before than skl_probe, but if there is no display
output connect, in function drm_dp_dpcd_access, there is a 32 retry for
aux i2c transactions
On 4/9/2018 9:02 PM, Michal Wajdeczko wrote:
On Mon, 09 Apr 2018 17:09:18 +0200, Patchwork
wrote:
== Series Details ==
Series: series starting with [v8,01/12] drm/i915: Park before
resetting the submission backend
URL : https://patchwork.freedesktop.org/series/41365/
State : failure
=
== Series Details ==
Series: series starting with [v3,1/4] drm/i915: Always do WOPCM partitioning
based on real firmware sizes
URL : https://patchwork.freedesktop.org/series/41409/
State : failure
== Summary ==
Possible new issues:
Test gem_eio:
Subgroup execbuf:
> -Original Message-
> From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com]
> Sent: Monday, April 9, 2018 5:15 PM
> To: Srinivas, Vidya ; intel-
> g...@lists.freedesktop.org
> Cc: Kamath, Sunil
> Subject: Re: [Intel-gfx] [PATCH v1 00/14] Preparation patches for NV12
>
> Op
== Series Details ==
Series: series starting with [v4] drm/i915: Enable edp psr error interrupts on
hsw (rev3)
URL : https://patchwork.freedesktop.org/series/41095/
State : success
== Summary ==
Possible new issues:
Test kms_cursor_legacy:
Subgroup pipe-c-torture-move:
== Series Details ==
Series: series starting with [v3,1/4] drm/i915: Always do WOPCM partitioning
based on real firmware sizes
URL : https://patchwork.freedesktop.org/series/41409/
State : success
== Summary ==
Series 41409v1 series starting with [v3,1/4] drm/i915: Always do WOPCM
partitioni
== Series Details ==
Series: series starting with [v4] drm/i915: Enable edp psr error interrupts on
hsw (rev3)
URL : https://patchwork.freedesktop.org/series/41095/
State : success
== Summary ==
Series 41095v3 series starting with [v4] drm/i915: Enable edp psr error
interrupts on hsw
https:/
== Series Details ==
Series: series starting with [v4] drm/i915: Enable edp psr error interrupts on
hsw (rev3)
URL : https://patchwork.freedesktop.org/series/41095/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
0a22dbbae8f8 drm/i915: Enable edp psr error interrupts on hsw
-:11
The enable_guc modparam is used to enable/disable GuC/HuC FW uploading
dynamcially during i915 module loading. If WOPCM offset register was locked
without having HUC_LOADING_AGENT_GUC bit set to 1, the module reloading
with both GuC and HuC FW will fail since we need to set this bit to 1 for
HuC FW
In current code, we only compare the locked WOPCM register values with the
calculated values. However, we can continue loading GuC/HuC firmware if the
locked (or partially locked) values were valid for current GuC/HuC firmware
sizes.
This patch added a new code path to verify whether the locked re
Signed-off-by: Jackie Li
---
drivers/gpu/drm/i915/i915_params.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_params.h
b/drivers/gpu/drm/i915/i915_params.h
index c963603..53037b5 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm
After enabled the WOPCM write-once registers locking status checking,
reloading of the i915 module will fail with modparam enable_guc set to 3
(enable GuC and HuC firmware loading) if the module was originally loaded
with enable_guc set to 1 (only enable GuC firmware loading). This is
because WOPCM
== Series Details ==
Series: series starting with [1/2] drm/i915/guc: Check that the breadcrumb irq
is enabled
URL : https://patchwork.freedesktop.org/series/41396/
State : failure
== Summary ==
Possible new issues:
Test gem_eio:
Subgroup execbuf:
pass -> I
On Wed, Mar 28, 2018 at 02:57:58PM -0700, Paulo Zanoni wrote:
> This commit introduces the definitions for the ICL clocks and adds the
> basic functions to the shared DPLL framework. It adds code for the
> Enable and Disable sequences for some PLLs, but it does not have the
> code to compute the ac
On 4/9/2018 4:20 PM, Pandiyan, Dhinakaran wrote:
On Mon, 2018-04-09 at 12:18 -0700, Kumar, Abhay wrote:
On 4/9/2018 12:10 PM, Rodrigo Vivi wrote:
On Mon, Apr 09, 2018 at 05:07:31PM +0300, Jani Nikula wrote:
On Sun, 08 Apr 2018, Gaurav K Singh wrote:
On Geminilake, sometimes audio card is
On Mon, 2018-04-09 at 12:18 -0700, Kumar, Abhay wrote:
>
> On 4/9/2018 12:10 PM, Rodrigo Vivi wrote:
> > On Mon, Apr 09, 2018 at 05:07:31PM +0300, Jani Nikula wrote:
> >> On Sun, 08 Apr 2018, Gaurav K Singh wrote:
> >>> On Geminilake, sometimes audio card is not getting
> >>> detected after re
On 4/9/2018 3:33 AM, Ville Syrjälä wrote:
On Fri, Apr 06, 2018 at 04:47:08PM +0300, Jani Nikula wrote:
On Thu, 05 Apr 2018, Abhay Kumar wrote:
In glk when device boots with 1366x768 panel, HDA codec doesn't comeup.
This result in no audio forever as cdclk is < 96Mhz.
This chagne will ensure
On 4/9/2018 12:53 PM, Chris Wilson wrote:
Quoting Oscar Mateo (2018-04-06 23:24:57)
Inherit workarounds from previous platforms that are still valid for
Icelake.
Speaking of the workarounds, where do we stand with at least landing the
split out of init_workarounds_ring()?
Rebuilding the inva
== Series Details ==
Series: drm/i915/pmu: check runtime resume vs pmu race
URL : https://patchwork.freedesktop.org/series/41380/
State : warning
== Summary ==
Possible new issues:
Test perf_pmu:
Subgroup rc6-runtime-pm:
pass -> DMESG-WARN (shard-apl)
== Series Details ==
Series: series starting with [1/2] drm/i915/guc: Check that the breadcrumb irq
is enabled
URL : https://patchwork.freedesktop.org/series/41396/
State : success
== Summary ==
Series 41396v1 series starting with [1/2] drm/i915/guc: Check that the
breadcrumb irq is enabled
== Series Details ==
Series: series starting with [1/2] drm/i915/guc: Check that the breadcrumb irq
is enabled
URL : https://patchwork.freedesktop.org/series/41396/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
2fc2ed95e6cd drm/i915/guc: Check that the breadcrumb irq is enable
Quoting Oscar Mateo (2018-04-06 23:24:57)
> Inherit workarounds from previous platforms that are still valid for
> Icelake.
Speaking of the workarounds, where do we stand with at least landing the
split out of init_workarounds_ring()?
Rebuilding the invariant wa_regs[] on every reset is annoying,
On Wed, Mar 28, 2018 at 06:20:26PM +0200, Maarten Lankhorst wrote:
> Op 28-03-18 om 12:21 schreef Jani Nikula:
> > On Wed, 28 Mar 2018, Maarten Lankhorst
> > wrote:
> >> Adding a i915_fifo_underrun_reset debugfs file will make it possible
> >> for IGT tests to clear FIFO underrun fallout at the s
---
drivers/gpu/drm/i915/i915_params.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_params.h
b/drivers/gpu/drm/i915/i915_params.h
index c96360398072..53037b5eff22 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_param
Our execlists emulation for GuC requires use of the breadcrumb following
every request as a simulcrum for the context-switch interrupt, which we
then use to drive the submission tasklet. Therefore, when we unpark the
engine for use with the GuC, we pin the breadcrumb interrupt to keep it
enabled fo
On 4/9/2018 12:10 PM, Rodrigo Vivi wrote:
On Mon, Apr 09, 2018 at 05:07:31PM +0300, Jani Nikula wrote:
On Sun, 08 Apr 2018, Gaurav K Singh wrote:
On Geminilake, sometimes audio card is not getting
detected after reboot. This is a spurious issue happening on
Geminilake. HW codec and HD audio
On Sat, Apr 07, 2018 at 10:05:25AM +0100, Chris Wilson wrote:
> Quoting Rodrigo Vivi (2018-04-06 23:18:16)
> > On Fri, Apr 06, 2018 at 11:12:27AM -0700, Souza, Jose wrote:
> > > On Thu, 2018-04-05 at 12:49 +0100, Chris Wilson wrote:
> > > > + struct drm_crtc *crtc =
> > > > +
On Mon, Apr 09, 2018 at 12:48:15PM +0300, Jani Nikula wrote:
> On Fri, 23 Mar 2018, Timo Aaltonen wrote:
> > On 30.01.2018 00:12, Rodrigo Vivi wrote:
> >> On Mon, Jan 29, 2018 at 05:42:53AM +, Kai Heng Feng wrote:
> >>>
> On 26 Jan 2018, at 6:25 AM, Rodrigo Vivi wrote:
>
> If t
On Mon, Apr 09, 2018 at 05:07:31PM +0300, Jani Nikula wrote:
> On Sun, 08 Apr 2018, Gaurav K Singh wrote:
> > On Geminilake, sometimes audio card is not getting
> > detected after reboot. This is a spurious issue happening on
> > Geminilake. HW codec and HD audio controller link was going
> > out
== Series Details ==
Series: drm/i915: Enable display workaround 827 for all planes, v2.
URL : https://patchwork.freedesktop.org/series/41371/
State : success
== Summary ==
Known issues:
Test kms_flip:
Subgroup 2x-flip-vs-expired-vblank-interruptible:
fail -
On Mon, Apr 09, 2018 at 05:12:03PM +0300, Jani Nikula wrote:
> On Thu, 05 Apr 2018, Manasi Navare wrote:
> > On Thu, Apr 05, 2018 at 05:39:04PM +0300, Jani Nikula wrote:
> >> For now, there's just the one link config selection, optimizing for slow
> >> and wide link. No functional changes.
> >>
>
On Fri, 2018-04-06 at 18:40 -0700, Dhinakaran Pandiyan wrote:
>
>
> On Sat, 2018-04-07 at 00:49 +, Souza, Jose wrote:
> > On Fri, 2018-04-06 at 16:36 -0700, José Roberto de Souza wrote:
> > > On Mon, 2018-04-02 at 15:38 -0700, Pandiyan, Dhinakaran wrote:
> > > > On Mon, 2018-04-02 at 13:51 -0
== Series Details ==
Series: series starting with [1/4] drm/i915: Change use get_new_plane_state
instead of existing plane state
URL : https://patchwork.freedesktop.org/series/41370/
State : success
== Summary ==
Known issues:
Test kms_flip:
Subgroup flip-vs-absolute-wf_vblank:
== Series Details ==
Series: Queued/runnable/running engine stats (rev7)
URL : https://patchwork.freedesktop.org/series/36926/
State : failure
== Summary ==
Series 36926v7 Queued/runnable/running engine stats
https://patchwork.freedesktop.org/api/1.0/series/36926/revisions/7/mbox/
Possib
Tvrtko Ursulin writes:
> From: Tvrtko Ursulin
>
> Back to a clean build with no warnings, at least for me.
Why c90? If that's the language we mean to target then we should
probably add it to the build system so people with gcc 5.1 and later
will see the warnings too. fwiw, my build with clang 6
== Series Details ==
Series: drm/i915/guc: Check that the breadcrumb irq is enabled
URL : https://patchwork.freedesktop.org/series/41368/
State : success
== Summary ==
Known issues:
Test kms_flip:
Subgroup 2x-wf_vblank-ts-check:
fail -> PASS (shard-hsw
From: Tvrtko Ursulin
As well as exposing active requests on engines via PMU, we can also export
the current raw values (as tracked by i915 command submission) via a
dedicated query.
This is to satisfy customers who have userspace load balancing solutions
implemented on top of their custom kernel
From: Tvrtko Ursulin
Keep a per-engine number of runnable (waiting for GPU time) requests.
We choose to mange the runnable counter at the backend level instead of at
the request submit_notify callback. The latter would be more consolidated
and less code, but it would require making the counter e
From: Tvrtko Ursulin
Keep a count of requests submitted from userspace and not yet runnable due
unresolved dependencies.
v2: Rename and move under the container struct. (Chris Wilson)
v3: Rebase.
v4: Move decrement site to the backend to shrink the window of double-
accounting as much as pos
From: Tvrtko Ursulin
Back to a clean build with no warnings, at least for me.
Signed-off-by: Tvrtko Ursulin
Cc: Jordan Justen
Cc: Scott D Phillips
---
tools/aubdump.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tools/aubdump.c b/tools/aubdump.c
index 267061b0fc
== Series Details ==
Series: drm/i915/pmu: check runtime resume vs pmu race
URL : https://patchwork.freedesktop.org/series/41380/
State : success
== Summary ==
Series 41380v1 drm/i915/pmu: check runtime resume vs pmu race
https://patchwork.freedesktop.org/api/1.0/series/41380/revisions/1/mbox/
== Series Details ==
Series: drm/i915/gen9_lp: Increase DDI PHY0 power well enabling timeout
URL : https://patchwork.freedesktop.org/series/41366/
State : success
== Summary ==
Known issues:
Test kms_flip:
Subgroup 2x-wf_vblank-ts-check:
fail -> PASS (
From: Tvrtko Ursulin
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_pmu.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c
index bd7e695fc663..9302b4abe357 100644
--- a/drivers/gpu/drm/i915/i9
On 4/9/2018 5:53 PM, Michal Wajdeczko wrote:
As we always call intel_uc_sanitize after every call to
intel_uc_fini_hw we may drop redundant call and sanitize
uC from the fini_hw function.
Signed-off-by: Michal Wajdeczko
Cc: Sagar Arun Kamble
Cc: Chris Wilson
With change to sanitize during
On Mon, 09 Apr 2018 17:09:18 +0200, Patchwork
wrote:
== Series Details ==
Series: series starting with [v8,01/12] drm/i915: Park before resetting
the submission backend
URL : https://patchwork.freedesktop.org/series/41365/
State : failure
== Summary ==
Possible new issues:
two
== Series Details ==
Series: series starting with [v8,01/12] drm/i915: Park before resetting the
submission backend
URL : https://patchwork.freedesktop.org/series/41365/
State : failure
== Summary ==
Possible new issues:
Test drm_mm:
Subgroup sanitycheck:
pass
On 4/9/2018 5:53 PM, Michal Wajdeczko wrote:
By calling i915_gem_init_hw in i915_gem_resume and not calling
i915_gem_fini_hw in i915_gem_suspend we introduced asymmetry
in init_hw/fini_hw calls. Let's fix that.
Signed-off-by: Michal Wajdeczko
Cc: Sagar Arun Kamble
Cc: Chris Wilson
Reviewed
== Series Details ==
Series: drm/i915: Enable display workaround 827 for all planes, v2.
URL : https://patchwork.freedesktop.org/series/41371/
State : success
== Summary ==
Series 41371v1 drm/i915: Enable display workaround 827 for all planes, v2.
https://patchwork.freedesktop.org/api/1.0/seri
On 4/9/2018 5:53 PM, Michal Wajdeczko wrote:
We have i915_gem_init_hw function that on failure requires some
cleanup in uC and then in other places we were trying to do
such cleanup directly. Let's fix that by adding i915_gem_fini_hw
for nice symmetry with init_hw and call it on cleanup paths.
On 4/9/2018 5:53 PM, Michal Wajdeczko wrote:
We should keep i915_gem_init/fini functions together for easier
tracking of their symmetry.
Signed-off-by: Michal Wajdeczko
Cc: Sagar Arun Kamble
Cc: Chris Wilson
Reviewed-by: Sagar Arun Kamble
---
drivers/gpu/drm/i915/i915_drv.c | 20 --
Quoting Michal Wajdeczko (2018-04-09 15:08:40)
> On Mon, 09 Apr 2018 14:42:19 +0200, Chris Wilson
> wrote:
>
> > Our execlists emulation for GuC requires use of the breadcrumb following
> > every request as a simulcrum for the context-switch interrupt, which we
> > then use to drive the submiss
== Series Details ==
Series: drm/i915: Enable display workaround 827 for all planes, v2.
URL : https://patchwork.freedesktop.org/series/41371/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
b8f0788dfd3f drm/i915: Enable display workaround 827 for all planes, v2.
-:58: CHECK:PARE
On Mon, Apr 09, 2018 at 04:21:23PM +0200, Maarten Lankhorst wrote:
> The workaround was applied only to the primary plane, but is required
> on all planes. Iterate over all planes in the crtc atomic check to see
> if the workaround is enabled, and only perform the actual toggling in
> the pre/post
The workaround was applied only to the primary plane, but is required
on all planes. Iterate over all planes in the crtc atomic check to see
if the workaround is enabled, and only perform the actual toggling in
the pre/post plane update functions.
Changes since v1:
- Track active NV12 planes in a
== Series Details ==
Series: series starting with [1/4] drm/i915: Change use get_new_plane_state
instead of existing plane state
URL : https://patchwork.freedesktop.org/series/41370/
State : success
== Summary ==
Series 41370v1 series starting with [1/4] drm/i915: Change use
get_new_plane_st
Quoting Sagar Arun Kamble (2018-03-16 06:04:03)
> i915_mch_val() called from i915_emon_status debugfs is not protected
> under rpm_get and mchdev_lock.
> Can that also be updated as part of this patch.
Actually, we can just do that unlocked since we know that debugfs
teardown is itself serialised
On Thu, 05 Apr 2018, Manasi Navare wrote:
> On Thu, Apr 05, 2018 at 05:39:04PM +0300, Jani Nikula wrote:
>> For now, there's just the one link config selection, optimizing for slow
>> and wide link. No functional changes.
>>
>> Signed-off-by: Jani Nikula
>> ---
>> drivers/gpu/drm/i915/intel_dp.
On Mon, 09 Apr 2018 14:47:24 +0200, Chris Wilson
wrote:
Quoting Michal Wajdeczko (2018-04-09 13:23:28)
As we always call intel_uc_sanitize after every call to
intel_uc_fini_hw we may drop redundant call and sanitize
uC from the fini_hw function.
Signed-off-by: Michal Wajdeczko
Cc: Sagar Ar
On Mon, 09 Apr 2018 14:42:19 +0200, Chris Wilson
wrote:
Our execlists emulation for GuC requires use of the breadcrumb following
every request as a simulcrum for the context-switch interrupt, which we
then use to drive the submission tasklet. Therefore, when we unpark the
engine for use with
Quoting Sagar Arun Kamble (2018-03-16 04:58:22)
>
>
> On 3/14/2018 3:07 PM, Chris Wilson wrote:
> > Currently Ironlake operates under the assumption that rpm awake (and its
> > error checking is disabled). As such, we have missed a few places where we
> > access registers without taking the rpm w
On Sun, 08 Apr 2018, Gaurav K Singh wrote:
> On Geminilake, sometimes audio card is not getting
> detected after reboot. This is a spurious issue happening on
> Geminilake. HW codec and HD audio controller link was going
> out of sync for which there was a fix in i915 driver but
> was not getting
Op 09-04-18 om 15:04 schreef Ville Syrjälä:
> On Mon, Apr 09, 2018 at 02:46:55PM +0200, Maarten Lankhorst wrote:
>> All the references to get_existing_state can be converted to
>> get_new_state or get_old_state, which means that i915 is now
>> get_existing_state free.
>>
>> Signed-off-by: Maarten L
Quoting Sagar Arun Kamble (2018-03-16 03:39:56)
>
>
> On 3/14/2018 3:07 PM, Chris Wilson wrote:
> > Since intel_sideband_read and intel_sideband_write differ by only a
> > couple of lines (depending on whether we feed the value in or out),
> > merge the two into a single common accessor.
> >
> >
== Series Details ==
Series: series starting with [1/4] drm/i915: Change use get_new_plane_state
instead of existing plane state
URL : https://patchwork.freedesktop.org/series/41370/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
591b58b45998 drm/i915: Change use get_new_plane_
On Fri, 06 Apr 2018, José Roberto de Souza wrote:
> A simple page flip can cause the CFB required size to increase and
> if it is bigger than the currently allocated CFB it needs to be
> resized to activate FBC again.
>
> Until now this case was not being handled but CI is starting to
> get some o
On Mon, Apr 09, 2018 at 03:27:16PM +0300, Imre Deak wrote:
> On GLK sporadic timeouts occur during PHY0 enabling. Based on logs it looks
> like they happen sometime after a system suspend/resume cycle, with the
> same power well enabling succeeding both before and after the failed
> one and no othe
== Series Details ==
Series: drm/i915/guc: Check that the breadcrumb irq is enabled
URL : https://patchwork.freedesktop.org/series/41368/
State : success
== Summary ==
Series 41368v1 drm/i915/guc: Check that the breadcrumb irq is enabled
https://patchwork.freedesktop.org/api/1.0/series/41368/r
On Fri, 06 Apr 2018, Rodrigo Vivi wrote:
> On Fri, Apr 06, 2018 at 10:58:51PM +0530, vathsala nagaraju wrote:
>> From: Vathsala Nagaraju
>>
>> For psr block #9, the vbt description has moved to options [0-3] for
>> TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt
>> structure
Quoting Sagar Arun Kamble (2018-03-15 12:06:57)
> On 3/14/2018 3:07 PM, Chris Wilson wrote:
> > struct intel_rps {
> > + struct mutex lock;
> > +
> I think this lock can now become part of struct intel_gt_pm.
Maybe, haven't decided yet. Anything but rps is so infrequent as not to
really matt
Quoting Sagar Arun Kamble (2018-03-15 09:23:25)
>
>
> On 3/14/2018 3:07 PM, Chris Wilson wrote:
> > Valleyview and Cherryview update the GPU frequency via the punit, which
> > is very expensive as we have to ensure the cores do not sleep during the
> > comms.
> But the patch 5 applies this workar
== Series Details ==
Series: series starting with [1/2] drm/i915/selftests: Extend partial vma
coverage to check parallel creation
URL : https://patchwork.freedesktop.org/series/41359/
State : failure
== Summary ==
Possible new issues:
Test drv_selftest:
Subgroup mock_vma:
== Series Details ==
Series: drm/i915/gen9_lp: Increase DDI PHY0 power well enabling timeout
URL : https://patchwork.freedesktop.org/series/41366/
State : success
== Summary ==
Series 41366v1 drm/i915/gen9_lp: Increase DDI PHY0 power well enabling timeout
https://patchwork.freedesktop.org/api/
On Mon, Apr 09, 2018 at 02:46:56PM +0200, Maarten Lankhorst wrote:
> The workaround was applied only to the primary plane, but is required
> on all planes. Iterate over all planes in the crtc atomic check to see
> if the workaround is enabled, and only perform the actual toggling in
> the pre/post
== Series Details ==
Series: series starting with [01/18] drm/i915/execlists: Set queue priority
from secondary port
URL : https://patchwork.freedesktop.org/series/41357/
State : failure
== Summary ==
Possible new issues:
Test gem_ctx_param:
Subgroup invalid-param-get:
On Mon, Apr 09, 2018 at 02:46:55PM +0200, Maarten Lankhorst wrote:
> All the references to get_existing_state can be converted to
> get_new_state or get_old_state, which means that i915 is now
> get_existing_state free.
>
> Signed-off-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/i915/intel_disp
On Mon, Apr 09, 2018 at 02:46:54PM +0200, Maarten Lankhorst wrote:
> get_existing_crtc_state is currently unused, get rid of it.
>
> Signed-off-by: Maarten Lankhorst
Reviewed-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/intel_drv.h | 14 --
> 1 file changed, 14 deletions(-)
>
>
On Mon, Apr 09, 2018 at 02:46:53PM +0200, Maarten Lankhorst wrote:
> The get_existing macros are deprecated and should be replaced by
> get_old/new_state for clarity.
>
> Signed-off-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/i915/intel_atomic.c | 5 +++--
> drivers/gpu/drm/i915/intel_drv.h
== Series Details ==
Series: series starting with [v8,01/12] drm/i915: Park before resetting the
submission backend
URL : https://patchwork.freedesktop.org/series/41365/
State : success
== Summary ==
Series 41365v1 series starting with [v8,01/12] drm/i915: Park before resetting
the submissio
get_existing_crtc_state is currently unused, get rid of it.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_drv.h | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index e545aa673bd9..9969309132d
Quoting Michal Wajdeczko (2018-04-09 13:23:28)
> As we always call intel_uc_sanitize after every call to
> intel_uc_fini_hw we may drop redundant call and sanitize
> uC from the fini_hw function.
>
> Signed-off-by: Michal Wajdeczko
> Cc: Sagar Arun Kamble
> Cc: Chris Wilson
Not that it matters
The workaround was applied only to the primary plane, but is required
on all planes. Iterate over all planes in the crtc atomic check to see
if the workaround is enabled, and only perform the actual toggling in
the pre/post plane update functions.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu
The get_existing macros are deprecated and should be replaced by
get_old/new_state for clarity.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_atomic.c | 5 +++--
drivers/gpu/drm/i915/intel_drv.h| 11 ---
drivers/gpu/drm/i915/intel_pm.c | 2 +-
3 files changed,
All the references to get_existing_state can be converted to
get_new_state or get_old_state, which means that i915 is now
get_existing_state free.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_display.c | 51
1 file changed, 23 insertions(+)
Our execlists emulation for GuC requires use of the breadcrumb following
every request as a simulcrum for the context-switch interrupt, which we
then use to drive the submission tasklet. Therefore, when we unpark the
engine for use with the GuC, we pin the breadcrumb interrupt to keep it
enabled fo
Quoting Michal Wajdeczko (2018-04-09 13:23:26)
> By calling in i915_reset only i915_gem_init_hw without previous
> i915_gem_fini_hw we introduced asymmetry. Let's fix that.
>
> Signed-off-by: Michal Wajdeczko
> Cc: Sagar Arun Kamble
> Cc: Chris Wilson
Reviewed-by: Chris Wilson
> ---
> driver
On GLK sporadic timeouts occur during PHY0 enabling. Based on logs it looks
like they happen sometime after a system suspend/resume cycle, with the
same power well enabling succeeding both before and after the failed
one and no other problems observed. The current timeout in the code is
not actuall
[Adding some people to Cc for more ack/nack type feedback.]
Executive question is ack or nack on replacing intel_gpu_top with a new
implementation which uses only perf PMU for counter gathering.
A short history on how this came to be:
There was a recent external patch contribution from Rinat
By calling i915_gem_init_hw in i915_gem_resume and not calling
i915_gem_fini_hw in i915_gem_suspend we introduced asymmetry
in init_hw/fini_hw calls. Let's fix that.
Signed-off-by: Michal Wajdeczko
Cc: Sagar Arun Kamble
Cc: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem.c | 1 +
1 file changed
Some functions already use i915 name instead of dev_priv.
Let's rename this param in all remaining functions, except
those that still use legacy macros.
v2: don't forget about function descriptions (Sagar)
v3: rebased
Signed-off-by: Michal Wajdeczko
Reviewed-by: Sagar Arun Kamble
---
drivers/g
Signed-off-by: Michal Wajdeczko
---
drivers/gpu/drm/i915/i915_params.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_params.h
b/drivers/gpu/drm/i915/i915_params.h
index c963603..53037b5 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/
We don't have to check load status values.
Signed-off-by: Michal Wajdeczko
Cc: Sagar Arun Kamble
Cc: Chris Wilson
Reviewed-by: Sagar Arun Kamble
---
drivers/gpu/drm/i915/intel_huc.c | 2 +-
drivers/gpu/drm/i915/intel_uc.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
By calling in i915_reset only i915_gem_init_hw without previous
i915_gem_fini_hw we introduced asymmetry. Let's fix that.
Signed-off-by: Michal Wajdeczko
Cc: Sagar Arun Kamble
Cc: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu
In commit 9192d4fb811e ("drm/i915/guc: Extract doorbell creation
from client allocation") we introduced asymmetry in doorbell cleanup
to avoid warnings due to failed communication with already reset GuC.
As we improved our reset/unload paths, we can restore symmetry in
doorbell cleanup, as GuC shou
As we always call intel_uc_sanitize after every call to
intel_uc_fini_hw we may drop redundant call and sanitize
uC from the fini_hw function.
Signed-off-by: Michal Wajdeczko
Cc: Sagar Arun Kamble
Cc: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem.c | 2 --
drivers/gpu/drm/i915/intel_uc.c | 9
We should keep i915_gem_init/fini functions together for easier
tracking of their symmetry.
Signed-off-by: Michal Wajdeczko
Cc: Sagar Arun Kamble
Cc: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.c | 20
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_ge
We have i915_gem_init_hw function that on failure requires some
cleanup in uC and then in other places we were trying to do
such cleanup directly. Let's fix that by adding i915_gem_fini_hw
for nice symmetry with init_hw and call it on cleanup paths.
Signed-off-by: Michal Wajdeczko
Cc: Sagar Arun
Since commit 6ca9a2beb54a ("drm/i915: Unwind i915_gem_init() failure")
we believed that we correctly handle all errors encountered during
GuC initialization, including special one that indicates request to
run driver with disabled GPU submission (-EIO).
Unfortunately since commit 121981fafe69 ("dr
In function gem_init_hw() we are calling uc_init_hw() but in case
of error later in function, we missed to call matching uc_fini_hw()
Signed-off-by: Michal Wajdeczko
Cc: Sagar Arun Kamble
Cc: Chris Wilson
Reviewed-by: Sagar Arun Kamble
---
drivers/gpu/drm/i915/i915_gem.c | 6 ++
1 file ch
From: Chris Wilson
As different backends may have different park/unpark callbacks, we
should only ever switch backends (reset_default_submission on wedge
recovery, or on enabling the guc) while parked.
v2: Remove the assert from the guc code, as we are currently trying to
modify the engine vfunc
== Series Details ==
Series: series starting with [1/2] drm/i915/selftests: Extend partial vma
coverage to check parallel creation
URL : https://patchwork.freedesktop.org/series/41359/
State : success
== Summary ==
Series 41359v1 series starting with [1/2] drm/i915/selftests: Extend partial
1 - 100 of 157 matches
Mail list logo