[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Limit MST modes based on plane size too

2019-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Limit MST modes based on plane size too URL : https://patchwork.freedesktop.org/series/67457/ State : success == Summary == CI Bug Log - changes from CI_DRM_6986_full -> Patchwork_14615_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: abstract all vgaarb access to intel_vga.[ch]

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915/display: abstract all vgaarb access to intel_vga.[ch] URL : https://patchwork.freedesktop.org/series/67456/ State : success == Summary == CI Bug Log - changes from CI_DRM_6986_full -> Patchwork_14614_full ===

Re: [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Implement Wa_1604555607

2019-10-01 Thread Ramalingam C
On 2019-10-01 at 13:16:11 -0700, Lucas De Marchi wrote: > On Tue, Oct 1, 2019 at 10:36 AM Chris Wilson wrote: > > > > Quoting Ramalingam C (2019-10-01 18:26:23) > > > From: Michel Thierry > > > > > > Implement Wa_1604555607 (set the DS pairing timer to 128 cycles). > > > FF_MODE2 is part of the r

[Intel-gfx] ✗ Fi.CI.IGT: failure for DC3CO Support for TGL (rev14)

2019-10-01 Thread Patchwork
== Series Details == Series: DC3CO Support for TGL (rev14) URL : https://patchwork.freedesktop.org/series/64923/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6985_full -> Patchwork_14612_full Summary --- **FAILURE**

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/print: add and use drm_debug_enabled() (rev3)

2019-10-01 Thread Patchwork
== Series Details == Series: drm/print: add and use drm_debug_enabled() (rev3) URL : https://patchwork.freedesktop.org/series/66656/ State : success == Summary == CI Bug Log - changes from CI_DRM_6985_full -> Patchwork_14611_full Summary --

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: split out intel_vga_client.[ch]

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915/display: split out intel_vga_client.[ch] URL : https://patchwork.freedesktop.org/series/67447/ State : success == Summary == CI Bug Log - changes from CI_DRM_6985_full -> Patchwork_14608_full Summary --

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Exercise potential false lite-restore (rev5)

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Exercise potential false lite-restore (rev5) URL : https://patchwork.freedesktop.org/series/67438/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6986 -> Patchwork_14621 Summa

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Describe structure members in documentation

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915: Describe structure members in documentation URL : https://patchwork.freedesktop.org/series/67442/ State : success == Summary == CI Bug Log - changes from CI_DRM_6985_full -> Patchwork_14607_full Summar

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Exercise potential false lite-restore (rev5)

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Exercise potential false lite-restore (rev5) URL : https://patchwork.freedesktop.org/series/67438/ State : warning == Summary == $ dim checkpatch origin/drm-tip d506cfeafc6e drm/i915/selftests: Exercise potential false lite-restore -:30: WARNING

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mg: Use tc_port instead of port parameter to MG registers

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915/mg: Use tc_port instead of port parameter to MG registers URL : https://patchwork.freedesktop.org/series/67467/ State : success == Summary == CI Bug Log - changes from CI_DRM_6986 -> Patchwork_14620 Sum

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Update H2G enable logging action definition

2019-10-01 Thread Fosha, Robert M
On 9/28/19 3:36 AM, Patchwork wrote: == Series Details == Series: drm/i915/guc: Update H2G enable logging action definition URL : https://patchwork.freedesktop.org/series/67351/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6970_full -> Patchwork_14570_full ===

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mg: Use tc_port instead of port parameter to MG registers

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915/mg: Use tc_port instead of port parameter to MG registers URL : https://patchwork.freedesktop.org/series/67467/ State : warning == Summary == $ dim checkpatch origin/drm-tip 70d2eaa029e3 drm/i915/mg: Use tc_port instead of port parameter to MG registers -:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/tgl: Implement Wa_1604555607

2019-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/tgl: Implement Wa_1604555607 URL : https://patchwork.freedesktop.org/series/67461/ State : success == Summary == CI Bug Log - changes from CI_DRM_6986 -> Patchwork_14619 Summa

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/tgl: Implement Wa_1604555607

2019-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/tgl: Implement Wa_1604555607 URL : https://patchwork.freedesktop.org/series/67461/ State : warning == Summary == $ dim checkpatch origin/drm-tip b68066e4e634 drm/i915/tgl: Implement Wa_1604555607 52edee18222b drm/i915/tgl: Skip W

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Use a modparam to restrict exposed engines (rev2)

2019-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Use a modparam to restrict exposed engines (rev2) URL : https://patchwork.freedesktop.org/series/67450/ State : success == Summary == CI Bug Log - changes from CI_DRM_6986 -> Patchwork_14618

[Intel-gfx] ✓ Fi.CI.IGT: success for RFT drm/i915/tgl: Re-enable rps (rev3)

2019-10-01 Thread Patchwork
== Series Details == Series: RFT drm/i915/tgl: Re-enable rps (rev3) URL : https://patchwork.freedesktop.org/series/67398/ State : success == Summary == CI Bug Log - changes from CI_DRM_6984_full -> Patchwork_14604_full Summary --- **

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Use a modparam to restrict exposed engines (rev2)

2019-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Use a modparam to restrict exposed engines (rev2) URL : https://patchwork.freedesktop.org/series/67450/ State : warning == Summary == $ dim checkpatch origin/drm-tip c8be7f867553 drm/i915: Use a modparam to restrict exposed eng

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix audio power up sequence for gen10/11

2019-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Fix audio power up sequence for gen10/11 URL : https://patchwork.freedesktop.org/series/67460/ State : success == Summary == CI Bug Log - changes from CI_DRM_6986 -> Patchwork_14617 =

Re: [Intel-gfx] [PATCH] drm/i915/mg: Use tc_port instead of port parameter to MG registers

2019-10-01 Thread Lucas De Marchi
On Tue, Oct 01, 2019 at 12:37:29PM -0700, Jose Souza wrote: All the MG registers is based on the tc_port not port, so MG_PHY_PORT_LN() was subtracting port and PORT_C what is very fragile. So replacing port to tc_port in all MG register macros and users like we have for DKL. Cc: Lucas De Marchi

[Intel-gfx] [PATCH v3] drm/i915/selftests: Exercise potential false lite-restore

2019-10-01 Thread Chris Wilson
If execlists's lite-restore is based on the common GEM context tag rather than the per-intel_context LRCA, then a context switch between two intel_contexts on the same engine derived from the same GEM context will perform a lite-restore instead of a full context switch. We can exploit this by poiso

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Exercise potential false lite-restore (rev4)

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Exercise potential false lite-restore (rev4) URL : https://patchwork.freedesktop.org/series/67438/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6986 -> Patchwork_14616 Summa

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Exercise potential false lite-restore (rev4)

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Exercise potential false lite-restore (rev4) URL : https://patchwork.freedesktop.org/series/67438/ State : warning == Summary == $ dim checkpatch origin/drm-tip d13633b978e3 drm/i915/selftests: Exercise potential false lite-restore -:100: CHECK:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Limit MST modes based on plane size too

2019-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Limit MST modes based on plane size too URL : https://patchwork.freedesktop.org/series/67457/ State : success == Summary == CI Bug Log - changes from CI_DRM_6986 -> Patchwork_14615 ==

Re: [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Implement Wa_1604555607

2019-10-01 Thread Lucas De Marchi
On Tue, Oct 1, 2019 at 10:36 AM Chris Wilson wrote: > > Quoting Ramalingam C (2019-10-01 18:26:23) > > From: Michel Thierry > > > > Implement Wa_1604555607 (set the DS pairing timer to 128 cycles). > > FF_MODE2 is part of the register state context, that's why it is > > implemented here. > > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: abstract all vgaarb access to intel_vga.[ch]

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915/display: abstract all vgaarb access to intel_vga.[ch] URL : https://patchwork.freedesktop.org/series/67456/ State : success == Summary == CI Bug Log - changes from CI_DRM_6986 -> Patchwork_14614 Summary

[Intel-gfx] [PATCH] drm/i915/mg: Use tc_port instead of port parameter to MG registers

2019-10-01 Thread José Roberto de Souza
All the MG registers is based on the tc_port not port, so MG_PHY_PORT_LN() was subtracting port and PORT_C what is very fragile. So replacing port to tc_port in all MG register macros and users like we have for DKL. Cc: Lucas De Marchi Cc: Imre Deak Signed-off-by: José Roberto de Souza --- dri

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: abstract all vgaarb access to intel_vga.[ch]

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915/display: abstract all vgaarb access to intel_vga.[ch] URL : https://patchwork.freedesktop.org/series/67456/ State : warning == Summary == $ dim checkpatch origin/drm-tip 43d2ea1b278a drm/i915/display: abstract all vgaarb access to intel_vga.[ch] -:254: WAR

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Conclude load -> probe naming convention switch

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915: Conclude load -> probe naming convention switch URL : https://patchwork.freedesktop.org/series/67454/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6986 -> Patchwork_14613 Summary

Re: [Intel-gfx] [PATCH] drm/i915: Fix g4x sprite scaling stride check with GTT remapping

2019-10-01 Thread Chris Wilson
Quoting Ville Syrjala (2019-09-30 19:30:45) > From: Ville Syrjälä > > I forgot to update the g4x sprite scaling stride check when GTT > remapping was introduced. The stride of the original framebuffer > is irrelevant when remapping is used and instead we want to check > the stride of the remapped

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Conclude load -> probe naming convention switch

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915: Conclude load -> probe naming convention switch URL : https://patchwork.freedesktop.org/series/67454/ State : warning == Summary == $ dim checkpatch origin/drm-tip f23ba0cec202 drm/i915: Fix i915_inject_load_error() name to read *_probe_* -:11: ERROR:GIT_

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Limit MST modes based on plane size too

2019-10-01 Thread kbuild test robot
Hi Ville, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [cannot apply to v5.4-rc1 next-20191001] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base&#x

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Limit MST modes based on plane size too

2019-10-01 Thread kbuild test robot
Hi Ville, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [cannot apply to v5.4-rc1 next-20191001] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base&#x

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Use a modparam to restrict exposed engines

2019-10-01 Thread kbuild test robot
Hi Chris, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [cannot apply to v5.4-rc1 next-20191001] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base&#x

[Intel-gfx] ✓ Fi.CI.BAT: success for DC3CO Support for TGL (rev14)

2019-10-01 Thread Patchwork
== Series Details == Series: DC3CO Support for TGL (rev14) URL : https://patchwork.freedesktop.org/series/64923/ State : success == Summary == CI Bug Log - changes from CI_DRM_6985 -> Patchwork_14612 Summary --- **SUCCESS** No reg

[Intel-gfx] [PATCH i-g-t] i915/gem_userptr_blits: Check for allowed GTT mmaps

2019-10-01 Thread Chris Wilson
Having decided to close the GTT mmap of userptr objects loophole in the kernel, we need to adjust the test suite to avoid tripping over GTT mmaps when required. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- tests/i915/gem_userptr_blits.c | 32 1 file change

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Use a modparam to restrict exposed engines

2019-10-01 Thread kbuild test robot
Hi Chris, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [cannot apply to v5.4-rc1 next-20191001] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base&#x

Re: [Intel-gfx] [PATCH 2/2] drm/i915/tgl: Skip Wa_1604555607 verification at A0

2019-10-01 Thread Chris Wilson
Quoting Ramalingam C (2019-10-01 18:26:24) > Read of FF_MODE2 register is broken at TGL A0. Hence verification of the > Wa_1604555607 associated to that register needs to be skipped. > > Signed-off-by: Ramalingam C > cc: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 22 ++

Re: [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Implement Wa_1604555607

2019-10-01 Thread Chris Wilson
Quoting Ramalingam C (2019-10-01 18:26:23) > From: Michel Thierry > > Implement Wa_1604555607 (set the DS pairing timer to 128 cycles). > FF_MODE2 is part of the register state context, that's why it is > implemented here. > > v2: Rebased on top of the WA refactoring (Oscar) > v3: Correctly add

Re: [Intel-gfx] [PATCH] drm/i915/display: abstract all vgaarb access to intel_vga.[ch]

2019-10-01 Thread Ville Syrjälä
On Tue, Oct 01, 2019 at 06:25:06PM +0300, Jani Nikula wrote: > Split out the code related to vga client and vgaarb all over the place > into new intel_vga.[ch]. No functional changes. > > Cc: Ville Syrjälä > Cc: Chris Wilson > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/Makefile

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Polish intel_tv_mode_valid()

2019-10-01 Thread Souza, Jose
On Tue, 2019-10-01 at 18:46 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Drop the tv_mode NULL check since intel_tv_mode_find() never > actually returns NULL, and flip the condition around so that > the MODE_OK case is at the end, which is customary to all > the other .mode_valid() imple

[Intel-gfx] [PATCH 2/2] drm/i915/tgl: Skip Wa_1604555607 verification at A0

2019-10-01 Thread Ramalingam C
Read of FF_MODE2 register is broken at TGL A0. Hence verification of the Wa_1604555607 associated to that register needs to be skipped. Signed-off-by: Ramalingam C cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 22 - drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH 1/2] drm/i915/tgl: Implement Wa_1604555607

2019-10-01 Thread Ramalingam C
From: Michel Thierry Implement Wa_1604555607 (set the DS pairing timer to 128 cycles). FF_MODE2 is part of the register state context, that's why it is implemented here. v2: Rebased on top of the WA refactoring (Oscar) v3: Correctly add to ctx_workarounds_init (Michel) BSpec: 19363 HSDES: 16045

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/print: add and use drm_debug_enabled() (rev3)

2019-10-01 Thread Patchwork
== Series Details == Series: drm/print: add and use drm_debug_enabled() (rev3) URL : https://patchwork.freedesktop.org/series/66656/ State : success == Summary == CI Bug Log - changes from CI_DRM_6985 -> Patchwork_14611 Summary --- *

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Limit MST modes based on plane size too

2019-10-01 Thread Souza, Jose
On Tue, 2019-10-01 at 18:46 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > When adding the max plane size checks to the .mode_valid() hooks > I naturally forgot about MST. Take care of that one as well. Reviewed-by: José Roberto de Souza > > Cc: Manasi Navare > Cc: Sean Paul > Cc: Jo

Re: [Intel-gfx] [PATCH 15/23] drm/i915: Link planes in a bigjoiner configuration.

2019-10-01 Thread Ville Syrjälä
On Tue, Oct 01, 2019 at 09:44:09AM -0700, Matt Roper wrote: > On Fri, Sep 20, 2019 at 01:42:27PM +0200, Maarten Lankhorst wrote: > > Make sure that when a plane is set in a bigjoiner mode, we will add > > their counterpart to the atomic state as well. This will allow us to > > make sure all state i

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Use a modparam to restrict exposed engines

2019-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Use a modparam to restrict exposed engines URL : https://patchwork.freedesktop.org/series/67450/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6985 -> Patchwork_14610 ===

Re: [Intel-gfx] [PATCH 15/23] drm/i915: Link planes in a bigjoiner configuration.

2019-10-01 Thread Matt Roper
On Fri, Sep 20, 2019 at 01:42:27PM +0200, Maarten Lankhorst wrote: > Make sure that when a plane is set in a bigjoiner mode, we will add > their counterpart to the atomic state as well. This will allow us to > make sure all state is available when planes are checked. > > Because of the funny inter

Re: [Intel-gfx] [PATCH 2/2] drm/i915: extend audio CDCLK>=2*BCLK constraint to more platforms

2019-10-01 Thread Chris Wilson
Quoting Kai Vehmanen (2019-10-01 17:35:55) > The CDCLK>=2*BCLK constraint applies to all generations since gen10. > Extend the constraint logic in audio get/put_power(). > > Signed-off-by: Kai Vehmanen > --- > drivers/gpu/drm/i915/display/intel_audio.c | 2 +- > 1 file changed, 1 insertion(+), 1

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: split out intel_vga_client.[ch]

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915/display: split out intel_vga_client.[ch] URL : https://patchwork.freedesktop.org/series/67447/ State : success == Summary == CI Bug Log - changes from CI_DRM_6985 -> Patchwork_14608 Summary --- *

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Use a modparam to restrict exposed engines

2019-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Use a modparam to restrict exposed engines URL : https://patchwork.freedesktop.org/series/67450/ State : warning == Summary == $ dim checkpatch origin/drm-tip d9fbdccc5cd1 drm/i915: Use a modparam to restrict exposed engines -:

[Intel-gfx] [PATCH 2/2] drm/i915: extend audio CDCLK>=2*BCLK constraint to more platforms

2019-10-01 Thread Kai Vehmanen
The CDCLK>=2*BCLK constraint applies to all generations since gen10. Extend the constraint logic in audio get/put_power(). Signed-off-by: Kai Vehmanen --- drivers/gpu/drm/i915/display/intel_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/i

[Intel-gfx] [PATCH 1/2] drm/i915: Fix audio power up sequence for gen10/11

2019-10-01 Thread Kai Vehmanen
On gen10/11 platforms, driver must set the enable bit of AUD_PIN_BUF_CTL as part of audio power up sequence. Failing to do this resulted in errors during display audio codec probe, and failures during resume from suspend. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111214 Signed-off-by

[Intel-gfx] ✗ Fi.CI.BAT: failure for Conclude load -> probe naming convention switch

2019-10-01 Thread Patchwork
== Series Details == Series: Conclude load -> probe naming convention switch URL : https://patchwork.freedesktop.org/series/67448/ State : failure == Summary == Series 67448 revision 1 Test-with: <20191001132728.14602-1-janusz.krzyszto...@linux.intel.com> not found __

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: split out intel_vga_client.[ch]

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915/display: split out intel_vga_client.[ch] URL : https://patchwork.freedesktop.org/series/67447/ State : warning == Summary == $ dim checkpatch origin/drm-tip b1b290f96d25 drm/i915/display: split out intel_vga_client.[ch] -:91: WARNING:FILE_PATH_CHANGES: add

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Describe structure members in documentation

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915: Describe structure members in documentation URL : https://patchwork.freedesktop.org/series/67442/ State : success == Summary == CI Bug Log - changes from CI_DRM_6985 -> Patchwork_14607 Summary ---

[Intel-gfx] [PATCH v2] drm/i915/selftests: Exercise potential false lite-restore

2019-10-01 Thread Chris Wilson
If execlists's lite-restore is based on the common GEM context tag rather than the per-intel_context LRCA, then a context switch between two intel_contexts on the same engine derived from the same GEM context will perform a lite-restore instead of a full context switch. We can exploit this by poiso

[Intel-gfx] [PATCH 1/2] drm/i915: Limit MST modes based on plane size too

2019-10-01 Thread Ville Syrjala
From: Ville Syrjälä When adding the max plane size checks to the .mode_valid() hooks I naturally forgot about MST. Take care of that one as well. Cc: Manasi Navare Cc: Sean Paul Cc: José Roberto de Souza Cc: Maarten Lankhorst Fixes: 2d20411e25a3 ("drm/i915: Don't advertise modes that exceed

[Intel-gfx] [PATCH 2/2] drm/i915: Polish intel_tv_mode_valid()

2019-10-01 Thread Ville Syrjala
From: Ville Syrjälä Drop the tv_mode NULL check since intel_tv_mode_find() never actually returns NULL, and flip the condition around so that the MODE_OK case is at the end, which is customary to all the other .mode_valid() implementations. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/2] drm/i915: Create dumb buffer from LMEM (rev2)

2019-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Create dumb buffer from LMEM (rev2) URL : https://patchwork.freedesktop.org/series/67428/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK incl

Re: [Intel-gfx] [PATCH] drm/i915/display: split out intel_vga_client.[ch]

2019-10-01 Thread Jani Nikula
On Tue, 01 Oct 2019, Ville Syrjälä wrote: > On Tue, Oct 01, 2019 at 05:28:51PM +0300, Jani Nikula wrote: >> On Tue, 01 Oct 2019, Ville Syrjälä wrote: >> > On Tue, Oct 01, 2019 at 03:12:49PM +0100, Chris Wilson wrote: >> >> Quoting Jani Nikula (2019-10-01 14:43:53) >> >> > Split out code related t

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Initialise breadcrumb lists on the virtual engine (rev2)

2019-10-01 Thread Patchwork
== Series Details == Series: drm/i915: Initialise breadcrumb lists on the virtual engine (rev2) URL : https://patchwork.freedesktop.org/series/67373/ State : failure == Summary == Applying: drm/i915: Initialise breadcrumb lists on the virtual engine Using index info to reconstruct a base tree.

[Intel-gfx] [PATCH] drm/i915/display: abstract all vgaarb access to intel_vga.[ch]

2019-10-01 Thread Jani Nikula
Split out the code related to vga client and vgaarb all over the place into new intel_vga.[ch]. No functional changes. Cc: Ville Syrjälä Cc: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 3 +- drivers/gpu/drm/i915/display/intel_display.c | 97 +

[Intel-gfx] ✓ Fi.CI.IGT: success for lib/string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers (rev2)

2019-10-01 Thread Patchwork
== Series Details == Series: lib/string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers (rev2) URL : https://patchwork.freedesktop.org/series/67405/ State : success == Summary == CI Bug Log - changes from CI_DRM_6981_full -> Patchwork_14602_full =

Re: [Intel-gfx] [PATCH v3] drm/print: add drm_debug_enabled()

2019-10-01 Thread Eric Engestrom
On Tuesday, 2019-10-01 17:06:14 +0300, Jani Nikula wrote: > Add helper to check if a drm debug category is enabled. Convert drm core > to use it. No functional changes. > > v2: Move unlikely() to drm_debug_enabled() (Eric) > > v3: Keep unlikely() when combined with other conditions (Eric) > > Cc

Re: [RFC PATCH] iommu/vt-d: Fix IOMMU field not populated on device hot re-plug

2019-10-01 Thread Janusz Krzysztofik
Hi Baolu, On Tuesday, September 3, 2019 9:41:23 AM CEST Janusz Krzysztofik wrote: > Hi Baolu, > > On Tuesday, September 3, 2019 3:29:40 AM CEST Lu Baolu wrote: > > Hi Janusz, > > > > On 9/2/19 4:37 PM, Janusz Krzysztofik wrote: > > >> I am not saying that keeping data is not acceptable. I just w

Re: [Intel-gfx] [PATCH 1/4] drm/rect: Add drm_rect_translate_to()

2019-10-01 Thread Ville Syrjälä
On Tue, Oct 01, 2019 at 12:26:52PM +0300, Jani Nikula wrote: > On Mon, 30 Sep 2019, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Add a helper to translate a rectangle to an absolute position. > > > > Signed-off-by: Ville Syrjälä > > The series is > > Reviewed-by: Jani Nikula > Thanks

[Intel-gfx] ✓ Fi.CI.BAT: success for RFT drm/i915/tgl: Re-enable rps (rev3)

2019-10-01 Thread Patchwork
== Series Details == Series: RFT drm/i915/tgl: Re-enable rps (rev3) URL : https://patchwork.freedesktop.org/series/67398/ State : success == Summary == CI Bug Log - changes from CI_DRM_6984 -> Patchwork_14604 Summary --- **SUCCESS**

[Intel-gfx] [PATCH v2 0/2] drm/i915: Conclude load -> probe naming convention switch

2019-10-01 Thread Janusz Krzysztofik
Test-with: <20191001142724.16472-2-janusz.krzyszto...@linux.intel.com> The purpose is: * to fix incompatible names of new functions introduced meanwhile, * to complete postponed rename of module parameter. v2: * drop unnecessary statement about custom user applications from commit message o

[Intel-gfx] [PATCH v2 2/2] drm/i915: Rename "inject_load_failure" module parameter

2019-10-01 Thread Janusz Krzysztofik
Commit f2db53f14d3d ("drm/i915: Replace "_load" with "_probe" consequently") deliberately left the name of the module parameter unchanged as that would require a corresponding change on IGT size. Now as the IGT side change has been submitted, complete the switch to the "probe" nomenclature. Sugges

Re: [Intel-gfx] [PATCH] drm/i915/display: split out intel_vga_client.[ch]

2019-10-01 Thread Ville Syrjälä
On Tue, Oct 01, 2019 at 05:28:51PM +0300, Jani Nikula wrote: > On Tue, 01 Oct 2019, Ville Syrjälä wrote: > > On Tue, Oct 01, 2019 at 03:12:49PM +0100, Chris Wilson wrote: > >> Quoting Jani Nikula (2019-10-01 14:43:53) > >> > Split out code related to vga client and vga switcheroo > >> > register/u

[Intel-gfx] [PATCH v2 1/2] drm/i915: Fix i915_inject_load_error() name to read *_probe_*

2019-10-01 Thread Janusz Krzysztofik
Commit 50d84418f586 ("drm/i915: Add i915 to i915_inject_probe_failure") introduced new functions unfortunately named incompatibly with rules established by commit f2db53f14d3d ("drm/i915: Replace "_load" with "_probe" consequently"). Fix it for consistency. Suggested-by: Michał Wajdeczko Signed-

Re: [Intel-gfx] [PATCH] drm/i915/color: fix broken display in icl+

2019-10-01 Thread Ville Syrjälä
On Tue, Oct 01, 2019 at 07:58:39PM +0530, Sharma, Swati2 wrote: > On 01-Oct-19 7:51 PM, Ville Syrjälä wrote: > > On Tue, Oct 01, 2019 at 11:03:08AM +0300, Jani Nikula wrote: > >> On Tue, 01 Oct 2019, Swati Sharma wrote: > >>> Premature gamma lut prepration and loading which was getting > >>> refle

Re: [Intel-gfx] [PATCH] drm/i915/color: fix broken display in icl+

2019-10-01 Thread Saarinen, Jani
HI, > -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjälä > Sent: tiistai 1. lokakuuta 2019 17.21 > To: Nikula, Jani > Cc: intel-gfx@lists.freedesktop.org; Nautiyal, Ankit K > > Subject: Re: [Intel-gfx] [PATCH] drm/i915/color: fix broken display in icl+ > > On Tue, Oct

Re: [Intel-gfx] [PATCH] drm/i915/display: split out intel_vga_client.[ch]

2019-10-01 Thread Chris Wilson
Quoting Jani Nikula (2019-10-01 15:28:51) > On Tue, 01 Oct 2019, Ville Syrjälä wrote: > > On Tue, Oct 01, 2019 at 03:12:49PM +0100, Chris Wilson wrote: > >> For the sake of argument, could you float the split in the other > >> direction? > > Please elaborate. Move switcheroo higher in the call ch

Re: [Intel-gfx] [PATCH] drm/i915/display: split out intel_vga_client.[ch]

2019-10-01 Thread Jani Nikula
On Tue, 01 Oct 2019, Ville Syrjälä wrote: > On Tue, Oct 01, 2019 at 03:12:49PM +0100, Chris Wilson wrote: >> Quoting Jani Nikula (2019-10-01 14:43:53) >> > Split out code related to vga client and vga switcheroo >> > register/unregister and state handling from i915_drv.c and >> > intel_display.c.

Re: [Intel-gfx] [PATCH] drm/i915/color: fix broken display in icl+

2019-10-01 Thread Sharma, Swati2
On 01-Oct-19 7:51 PM, Ville Syrjälä wrote: On Tue, Oct 01, 2019 at 11:03:08AM +0300, Jani Nikula wrote: On Tue, 01 Oct 2019, Swati Sharma wrote: Premature gamma lut prepration and loading which was getting reflected in first modeset causing different colors on screen during boot. Issue: In BI

[Intel-gfx] [PATCH v10 3/6] drm/i915/tgl: Enable DC3CO state in "DC Off" power well

2019-10-01 Thread Anshuman Gupta
Add target_dc_state and used by set_target_dc_state API in order to enable DC3CO state with existing DC states. target_dc_state will enable/disable the desired DC state in DC_STATE_EN reg when "DC Off" power well gets disable/enable. v2: commit log improvement. v3: Used intel_wait_for_register to

[Intel-gfx] [PATCH v10 5/6] drm/i915/tgl: Switch between dc3co and dc5 based on display idleness

2019-10-01 Thread Anshuman Gupta
DC3CO is useful power state, when DMC detects PSR2 idle frame while an active video playback, playing 30fps video on 60hz panel is the classic example of this use case. B.Specs:49196 has a restriction to enable DC3CO only for Video Playback. It will be worthy to enable DC3CO after completion of ea

[Intel-gfx] [PATCH v10 6/6] drm/i915/tgl: Add DC3CO counter in i915_dmc_info

2019-10-01 Thread Anshuman Gupta
Adding DC3CO counter in i915_dmc_info debugfs will be useful for DC3CO validation. DMC firmware uses DMC_DEBUG3 register as DC3CO counter register on TGL, as per B.Specs DMC_DEBUG3 is general purpose register. v1: comment modification for DMC_DBUG3. using GEN >= 12 check instead of IS_TIGERLAK

[Intel-gfx] [PATCH v10 2/6] drm/i915/tgl: Add DC3CO mask to allowed_dc_mask and gen9_dc_mask

2019-10-01 Thread Anshuman Gupta
Enable dc3co state in enable_dc module param and add dc3co enable mask to allowed_dc_mask and gen9_dc_mask. v1: Adding enable_dc=3,4 options to enable DC3CO with DC5 and DC6 independently. [Animesh] v2: Using a switch statement for cleaner code. [Animesh] Cc: Jani Nikula Cc: Imre Deak Cc: A

Re: [Intel-gfx] [PATCH] drm/i915/display: split out intel_vga_client.[ch]

2019-10-01 Thread Ville Syrjälä
On Tue, Oct 01, 2019 at 03:12:49PM +0100, Chris Wilson wrote: > Quoting Jani Nikula (2019-10-01 14:43:53) > > Split out code related to vga client and vga switcheroo > > register/unregister and state handling from i915_drv.c and > > intel_display.c. > > > > It's a bit difficult to draw the line ho

[Intel-gfx] [PATCH v10 1/6] drm/i915/tgl: Add DC3CO required register and bits

2019-10-01 Thread Anshuman Gupta
Adding following definition to i915_reg.h 1. DC_STATE_EN register DC3CO bit fields and masks. DC3CO enable bit will be used by driver to make DC3CO ready for DMC f/w and status bit will be used as DC3CO entry status. 2. Transcoder EXITLINE register and its bit fields and mask. Transcode

[Intel-gfx] [PATCH v10 4/6] drm/i915/tgl: Do modeset to enable and configure DC3CO exitline

2019-10-01 Thread Anshuman Gupta
DC3CO enabling B.Specs sequence requires to enable end configure exit scanlines to TRANS_EXITLINE register, programming this register has to be part of modeset sequence as this can't be change when transcoder or port is enabled. When system boots with only eDP panel there may not be real modeset as

[Intel-gfx] [PATCH v10 0/6] DC3CO Support for TGL

2019-10-01 Thread Anshuman Gupta
Resending this version v10 after adding Imre's RB and after fixing few code refactoring related comments provided by Imre. Anshuman Gupta (6): drm/i915/tgl: Add DC3CO required register and bits drm/i915/tgl: Add DC3CO mask to allowed_dc_mask and gen9_dc_mask drm/i915/tgl: Enable DC3CO state

Re: [Intel-gfx] [PATCH] drm/i915/color: fix broken display in icl+

2019-10-01 Thread Ville Syrjälä
On Tue, Oct 01, 2019 at 11:03:08AM +0300, Jani Nikula wrote: > On Tue, 01 Oct 2019, Swati Sharma wrote: > > Premature gamma lut prepration and loading which was getting > > reflected in first modeset causing different colors on > > screen during boot. > > > > Issue: In BIOS, gamma is disabled by d

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for RFT drm/i915/tgl: Re-enable rps (rev3)

2019-10-01 Thread Patchwork
== Series Details == Series: RFT drm/i915/tgl: Re-enable rps (rev3) URL : https://patchwork.freedesktop.org/series/67398/ State : warning == Summary == $ dim checkpatch origin/drm-tip 63d2c674198c RFT drm/i915/tgl: Re-enable rps -:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Rename "inject_load_failure" module parameter

2019-10-01 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-10-01 14:45:34) > Commit f2db53f14d3d ("drm/i915: Replace "_load" with "_probe" > consequently") deliberately left the name of the module parameter > unchanged as that would require a corresponding change on IGT size. > Now as the IGT side change has been submitted,

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix i915_inject_load_error() name to read *_probe_*

2019-10-01 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-10-01 14:45:33) > Commit 50d84418f586 ("drm/i915: Add i915 to i915_inject_probe_failure") > introduced new functions unfortunately named incompatibly with rules > established by commit f2db53f14d3d ("drm/i915: Replace "_load" with > "_probe" consequently"). Fix it

Re: [Intel-gfx] [PATCH] drm/i915/display: split out intel_vga_client.[ch]

2019-10-01 Thread Chris Wilson
Quoting Jani Nikula (2019-10-01 14:43:53) > Split out code related to vga client and vga switcheroo > register/unregister and state handling from i915_drv.c and > intel_display.c. > > It's a bit difficult to draw the line how much to move to the new file > from i915_drv.c, but it seemed to me keep

[Intel-gfx] ✗ Fi.CI.BUILD: failure for HAX: Force kmemleak off

2019-10-01 Thread Patchwork
== Series Details == Series: HAX: Force kmemleak off URL : https://patchwork.freedesktop.org/series/67436/ State : failure == Summary == Applying: HAX: Force kmemleak off Using index info to reconstruct a base tree... M mm/kmemleak.c Falling back to patching base and 3-way merge... Auto-

Re: [Intel-gfx] [PATCH] drm/i915/display: split out intel_vga_client.[ch]

2019-10-01 Thread Ville Syrjälä
On Tue, Oct 01, 2019 at 04:43:53PM +0300, Jani Nikula wrote: > Split out code related to vga client and vga switcheroo > register/unregister and state handling from i915_drv.c and > intel_display.c. The two things don't really have anything in common except both have "vga" in the name, so not sure

Re: [Intel-gfx] [PATCH v2 0/9] drm/print: add and use drm_debug_enabled()

2019-10-01 Thread Jani Nikula
On Tue, 01 Oct 2019, Eric Engestrom wrote: > On Tuesday, 2019-10-01 14:03:55 +0300, Jani Nikula wrote: >> On Thu, 26 Sep 2019, Eric Engestrom wrote: >> > On Tuesday, 2019-09-24 15:58:56 +0300, Jani Nikula wrote: >> >> Hi all, v2 of [1], a little refactoring around drm_debug access to >> >> abstra

[Intel-gfx] [PATCH v3] drm/print: add drm_debug_enabled()

2019-10-01 Thread Jani Nikula
Add helper to check if a drm debug category is enabled. Convert drm core to use it. No functional changes. v2: Move unlikely() to drm_debug_enabled() (Eric) v3: Keep unlikely() when combined with other conditions (Eric) Cc: Eric Engestrom Acked-by: Alex Deucher Signed-off-by: Jani Nikula ---

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Rename "inject_load_failure" module parameter

2019-10-01 Thread Janusz Krzysztofik
Hi Chris, On Tuesday, October 1, 2019 3:57:27 PM CEST Chris Wilson wrote: > Quoting Janusz Krzysztofik (2019-10-01 14:45:34) > > Commit f2db53f14d3d ("drm/i915: Replace "_load" with "_probe" > > consequently") deliberately left the name of the module parameter > > unchanged as that would require a

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Rename "inject_load_failure" module parameter

2019-10-01 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-10-01 14:45:34) > Commit f2db53f14d3d ("drm/i915: Replace "_load" with "_probe" > consequently") deliberately left the name of the module parameter > unchanged as that would require a corresponding change on IGT size. > Now as the IGT side change has been submitted,

[Intel-gfx] [PATCH 2/2] drm/i915/tgl: Restrict availables engines to rcs0 by default

2019-10-01 Thread Chris Wilson
CI is still unstable whenever we enable more than one engine, and we have not yet found a better hack than restricting it to using just rcs0. However, to allow testing to continue on the other engines by developers, we allow the available set of engines to be overridden on the command line with ju

[Intel-gfx] [PATCH 1/2] drm/i915: Use a modparam to restrict exposed engines

2019-10-01 Thread Chris Wilson
Allow the user to restrict the available set of engines via a module parameter. Signed-off-by: Chris Wilson Cc: Stuart Summers Cc: Andi Shyti Cc: Mika Kuoppala Cc: Tvrtko Ursulin Cc: Joonas Lahtinen Cc: Martin Peres --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 35 ---

[Intel-gfx] [PATCH 2/2] drm/i915: Rename "inject_load_failure" module parameter

2019-10-01 Thread Janusz Krzysztofik
Commit f2db53f14d3d ("drm/i915: Replace "_load" with "_probe" consequently") deliberately left the name of the module parameter unchanged as that would require a corresponding change on IGT size. Now as the IGT side change has been submitted, complete the switch to the "probe" nomenclature. May af

[Intel-gfx] [PATCH 0/2] Conclude load -> probe naming convention switch

2019-10-01 Thread Janusz Krzysztofik
Test-with: <20191001132728.14602-1-janusz.krzyszto...@linux.intel.com> The purpose is: * to fix incompatible names of new functions introduced meanwhile, * to complete postponed rename of module parameter. Will be tested with just submitted IGT counterpart using a trybot submission because I forg

[Intel-gfx] [PATCH 1/2] drm/i915: Fix i915_inject_load_error() name to read *_probe_*

2019-10-01 Thread Janusz Krzysztofik
Commit 50d84418f586 ("drm/i915: Add i915 to i915_inject_probe_failure") introduced new functions unfortunately named incompatibly with rules established by commit f2db53f14d3d ("drm/i915: Replace "_load" with "_probe" consequently"). Fix it for consistency. Suggested-by: Michał Wajdeczko Signed-

  1   2   >