[Intel-gfx] ✓ Fi.CI.BAT: success for Second round of i915_reg.h splitting

2022-01-19 Thread Patchwork
== Series Details == Series: Second round of i915_reg.h splitting URL : https://patchwork.freedesktop.org/series/99079/ State : success == Summary == CI Bug Log - changes from CI_DRM_1 -> Patchwork_22034 Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dmc: Eliminate remnant GEN references (rev2)

2022-01-19 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Eliminate remnant GEN references (rev2) URL : https://patchwork.freedesktop.org/series/98166/ State : success == Summary == CI Bug Log - changes from CI_DRM_1_full -> Patchwork_22033_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Second round of i915_reg.h splitting

2022-01-19 Thread Patchwork
== Series Details == Series: Second round of i915_reg.h splitting URL : https://patchwork.freedesktop.org/series/99079/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Second round of i915_reg.h splitting

2022-01-19 Thread Patchwork
== Series Details == Series: Second round of i915_reg.h splitting URL : https://patchwork.freedesktop.org/series/99079/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1e07c9d33aa4 drm/i915/perf: Move OA regs to their own header -:39: WARNING:FILE_PATH_CHANGES: added, moved or

[Intel-gfx] [PATCH 4/6] drm/i915: Parameterize MI_PREDICATE registers

2022-01-19 Thread Matt Roper
The various MI_PREDICATE registers have per-engine instances. Today we only utilize the RCS0 instance of each, but that will likely change in the future; switch to parameterized register definitions to make these easier to work with going forward. Of special note is MI_PREDICATE_RESULT_2; we

[Intel-gfx] [PATCH 0/6] Second round of i915_reg.h splitting

2022-01-19 Thread Matt Roper
Let's continue to split our giant i915_reg.h file into more logical domain-specific headers. In addition to a bunch of register definition segregation, the final patch of this series ensures that i915_reg.h is only #include'd from .c files that truly need its definitions (and removes all of the

[Intel-gfx] [PATCH 3/6] drm/i915: Parameterize R_PWR_CLK_STATE register definition

2022-01-19 Thread Matt Roper
At the moment we only use R_PWR_CLK_STATE in the context of the RCS engine, but upcoming support for compute engines will start using instances relative to the CCS engine base offsets. Let's parameterize the register and move it to the engine reg header. Cc: Jani Nikula Signed-off-by: Matt

[Intel-gfx] [PATCH 2/6] drm/i915/perf: Express OA register ranges with i915_range

2022-01-19 Thread Matt Roper
Let's use 'struct i915_range' to express sets of b-counter and mux registers in the perf code. This makes the code more similar to how we handle things like multicast register ranges, forcewake tables, shadow tables, etc. and also lets us avoid needing symbolic register name definitions for the

[Intel-gfx] [PATCH 1/6] drm/i915/perf: Move OA regs to their own header

2022-01-19 Thread Matt Roper
The OA unit registers are only used by the perf code; move them to their own header file. Cc: Jani Nikula Cc: Umesh Nerlige Ramappa Cc: Lionel Landwerlin Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gvt/scheduler.c | 1 + drivers/gpu/drm/i915/i915_perf.c | 1 +

[Intel-gfx] [PATCH 6/6] drm/i915: Only include i915_reg.h from .c files

2022-01-19 Thread Matt Roper
Several of our i915 header files, have been including i915_reg.h. This means that any change to i915_reg.h will trigger a full rebuild of pretty much every file of the driver, even those that don't have any kind of register access. Let's delete the i915_reg.h include from all headers and include

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix vma resource freeing (rev2)

2022-01-19 Thread Thomas Hellström
On Thu, 2022-01-20 at 01:43 +, Patchwork wrote: > Patch Details > Series:drm/i915: Fix vma resource freeing > (rev2)URL:https://patchwork.freedesktop.org/series/99055/State:failur > e > Details:https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22029/index.html > CI Bug Log - changes from

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Ensure multi-lrc fini breadcrumb math is correct (rev3)

2022-01-19 Thread Patchwork
== Series Details == Series: drm/i915/guc: Ensure multi-lrc fini breadcrumb math is correct (rev3) URL : https://patchwork.freedesktop.org/series/98816/ State : failure == Summary == CI Bug Log - changes from CI_DRM_1_full -> Patchwork_22032_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: Don't try to map and fence large scanout buffers (v4)

2022-01-19 Thread Patchwork
== Series Details == Series: drm/i915/gem: Don't try to map and fence large scanout buffers (v4) URL : https://patchwork.freedesktop.org/series/99074/ State : failure == Summary == CI Bug Log - changes from CI_DRM_1_full -> Patchwork_22031_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Eliminate remnant GEN references (rev2)

2022-01-19 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Eliminate remnant GEN references (rev2) URL : https://patchwork.freedesktop.org/series/98166/ State : success == Summary == CI Bug Log - changes from CI_DRM_1 -> Patchwork_22033 Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for Flush G2H handler during a GT reset (rev3)

2022-01-19 Thread Patchwork
== Series Details == Series: Flush G2H handler during a GT reset (rev3) URL : https://patchwork.freedesktop.org/series/98855/ State : failure == Summary == CI Bug Log - changes from CI_DRM_1_full -> Patchwork_22030_full Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Eliminate remnant GEN references

2022-01-19 Thread Tolakanahalli Pradeep, Madhumitha
On Tue, 2022-01-18 at 13:37 -0800, Lucas De Marchi wrote: > On Thu, Dec 23, 2021 at 03:18:57AM +, Tolakanahalli Pradeep, > Madhumitha wrote: > > On Fri, 2021-12-17 at 21:37 +, Yokoyama, Caz wrote: > > > On Thu, 2021-12-16 at 19:41 -0800, Madhumitha Tolakanahalli > > > Pradeep > > > wrote:

Re: [Intel-gfx] linux-next: build warning after merge of the drm-misc tree

2022-01-19 Thread Stephen Rothwell
Hi all, On Wed, 17 Nov 2021 13:49:26 +1100 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (htmldocs) > produced this warning: > > include/drm/gpu_scheduler.h:316: warning: Function parameter or member 'work' > not described in 'drm_sched_job' > >

Re: [Intel-gfx] linux-next: build warning after merge of the drm-misc tree

2022-01-19 Thread Stephen Rothwell
Hi all, On Fri, 15 Oct 2021 21:01:04 +1100 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (htmldocs) > produced this warning: > > include/drm/drm_modeset_lock.h:74: warning: Function parameter or member > 'stack_depot' not described in

Re: [Intel-gfx] linux-next: build warning after merge of the drm-misc tree

2022-01-19 Thread Stephen Rothwell
Hi all, On Fri, 15 Oct 2021 20:54:22 +1100 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (htmldocs) > produced this warning: > > Documentation/gpu/drm-kms-helpers:451: > /home/sfr/next/next/drivers/gpu/drm/drm_privacy_screen.c:270: WARNING: Inline >

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix vma resource freeing (rev2)

2022-01-19 Thread Patchwork
== Series Details == Series: drm/i915: Fix vma resource freeing (rev2) URL : https://patchwork.freedesktop.org/series/99055/ State : failure == Summary == CI Bug Log - changes from CI_DRM_0_full -> Patchwork_22029_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Ensure multi-lrc fini breadcrumb math is correct (rev3)

2022-01-19 Thread Patchwork
== Series Details == Series: drm/i915/guc: Ensure multi-lrc fini breadcrumb math is correct (rev3) URL : https://patchwork.freedesktop.org/series/98816/ State : success == Summary == CI Bug Log - changes from CI_DRM_1 -> Patchwork_22032

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Don't try to map and fence large scanout buffers (v4)

2022-01-19 Thread Patchwork
== Series Details == Series: drm/i915/gem: Don't try to map and fence large scanout buffers (v4) URL : https://patchwork.freedesktop.org/series/99074/ State : success == Summary == CI Bug Log - changes from CI_DRM_1 -> Patchwork_22031

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add support for querying hw info that UMDs need

2022-01-19 Thread John Harrison
On 1/19/2022 16:42, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* Add support for querying hw info that UMDs need *URL:* https://patchwork.freedesktop.org/series/99060/ *State:*failure *Details:*

[Intel-gfx] ✗ Fi.CI.IGT: failure for Add support for querying hw info that UMDs need

2022-01-19 Thread Patchwork
== Series Details == Series: Add support for querying hw info that UMDs need URL : https://patchwork.freedesktop.org/series/99060/ State : failure == Summary == CI Bug Log - changes from CI_DRM_0_full -> Patchwork_22027_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for Flush G2H handler during a GT reset (rev3)

2022-01-19 Thread Patchwork
== Series Details == Series: Flush G2H handler during a GT reset (rev3) URL : https://patchwork.freedesktop.org/series/98855/ State : success == Summary == CI Bug Log - changes from CI_DRM_1 -> Patchwork_22030 Summary ---

Re: [Intel-gfx] [PATCH 0/7] DRM kmap() fixes and kmap_local_page() conversions

2022-01-19 Thread Ira Weiny
On Wed, Jan 19, 2022 at 06:24:22PM +0100, Daniel Vetter wrote: > On Wed, Jan 19, 2022 at 08:53:56AM -0800, Ira Weiny wrote: > > On Fri, Dec 10, 2021 at 03:23:57PM -0800, 'Ira Weiny' wrote: > > > From: Ira Weiny > > > > > > This series starts by converting the last easy kmap() uses to > > >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Flush G2H handler during a GT reset (rev3)

2022-01-19 Thread Patchwork
== Series Details == Series: Flush G2H handler during a GT reset (rev3) URL : https://patchwork.freedesktop.org/series/98855/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH v4 RESEND] drm/i915/gem: Don't try to map and fence large scanout buffers (v4)

2022-01-19 Thread Vivek Kasireddy
On platforms capable of allowing 8K (7680 x 4320) modes, pinning 2 or more framebuffers/scanout buffers results in only one that is mappable/ fenceable. Therefore, pageflipping between these 2 FBs where only one is mappable/fenceable creates latencies large enough to miss alternate vblanks thereby

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix vma resource freeing (rev2)

2022-01-19 Thread Patchwork
== Series Details == Series: drm/i915: Fix vma resource freeing (rev2) URL : https://patchwork.freedesktop.org/series/99055/ State : success == Summary == CI Bug Log - changes from CI_DRM_0 -> Patchwork_22029 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/bios: Workaround broken video BIOS in LG Gram 2021

2022-01-19 Thread Patchwork
== Series Details == Series: drm/i915/bios: Workaround broken video BIOS in LG Gram 2021 URL : https://patchwork.freedesktop.org/series/99052/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11109_full -> Patchwork_22024_full

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread David Laight
> > except '"no\0\0yes" + v * 4' works a bit better. > > Is it a C code obfuscation contest? That would be: return &(v * 3)["no\0yes"]; :-) - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)

Re: [Intel-gfx] [PATCH 0/6] drm/i915: Extend parse_ddi_port() to all g4x+ platforms

2022-01-19 Thread Ville Syrjälä
On Fri, Dec 17, 2021 at 05:53:57PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Quick attempt at unifying the VBT DDI parsing to all g4x+ > platforms. > > Note that we'll still use the hardware straps as the primary > source of port presence information on old platforms since the >

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc: Ensure multi-lrc fini breadcrumb math is correct (rev2)

2022-01-19 Thread Patchwork
== Series Details == Series: drm/i915/guc: Ensure multi-lrc fini breadcrumb math is correct (rev2) URL : https://patchwork.freedesktop.org/series/98816/ State : failure == Summary == CI Bug Log - changes from CI_DRM_0 -> Patchwork_22028

[Intel-gfx] ✓ Fi.CI.BAT: success for Add support for querying hw info that UMDs need

2022-01-19 Thread Patchwork
== Series Details == Series: Add support for querying hw info that UMDs need URL : https://patchwork.freedesktop.org/series/99060/ State : success == Summary == CI Bug Log - changes from CI_DRM_0 -> Patchwork_22027 Summary ---

[Intel-gfx] [PATCH 3/3] drm/i915/guc: Flush G2H handler during a GT reset

2022-01-19 Thread Matthew Brost
Now that the error capture is fully decoupled from fence signalling (request retirement to free memory, which in turn depends on resets) we can safely flush the G2H handler during a GT reset. This is eliminates corner cases where GuC generated G2H (e.g. engine resets) race with a GT reset. v2:

[Intel-gfx] [PATCH 2/3] drm/i915/guc: Add work queue to trigger a GT reset

2022-01-19 Thread Matthew Brost
The G2H handler needs to be flushed during a GT reset but a G2H indicating engine reset failure can trigger a GT reset. Add a worker to trigger the GT when an engine reset failure is received to break this circular dependency. v2: (John Harrison) - Store engine reset mask - Fix typo in

[Intel-gfx] [PATCH 1/3] drm/i915: Allocate intel_engine_coredump_alloc with ALLOW_FAIL

2022-01-19 Thread Matthew Brost
Allocate intel_engine_coredump_alloc with ALLOW_FAIL rather than GFP_KERNEL to fully decouple the error capture from fence signalling. v2: (John Harrison) - Fix typo in commit message (s/do/to) Fixes: 8b91cdd4f8649 ("drm/i915: Use __GFP_KSWAPD_RECLAIM in the capture code") Signed-off-by:

[Intel-gfx] [PATCH 0/3] Flush G2H handler during a GT reset

2022-01-19 Thread Matthew Brost
After a small fix to error capture code, we now can flush G2H during a GT reset which simplifies code and seals some extreme corner case races. v2: (CI) - Don't trigger GT reset from G2H handler v3: - Address John Harrison's comments Signed-off-by: Matthew Brost Matthew Brost (3):

[Intel-gfx] [PATCH] drm/i915/guc: Ensure multi-lrc fini breadcrumb math is correct

2022-01-19 Thread Matthew Brost
Realized that the GuC multi-lrc fini breadcrumb emit code is very delicate as the math this code does relies on functions it calls to emit a certain number of DWs. Add a few GEM_BUG_ONs to assert the math is correct. v2: - Rebase + resend for CI (Checkpatch) - Fix blank line warning

Re: [Intel-gfx] [PATCH 2/3] drm/i915/guc: Add work queue to trigger a GT reset

2022-01-19 Thread Matthew Brost
On Wed, Jan 19, 2022 at 01:07:22PM -0800, John Harrison wrote: > On 1/19/2022 12:54, Matthew Brost wrote: > > On Tue, Jan 18, 2022 at 05:37:01PM -0800, John Harrison wrote: > > > On 1/18/2022 13:43, Matthew Brost wrote: > > > > The G2H handler needs to be flushed during a GT reset but a G2H > > >

Re: [Intel-gfx] [PATCH 0/3] lib/string_helpers: Add a few string helpers

2022-01-19 Thread Andy Shevchenko
On Wed, Jan 19, 2022 at 12:53:43PM -0800, Lucas De Marchi wrote: > On Wed, Jan 19, 2022 at 05:15:02PM +0100, Daniel Vetter wrote: > > On Wed, Jan 19, 2022 at 04:16:12PM +0200, Jani Nikula wrote: ... > > Yeah we can sed this anytime later we want to, but we need to get the foot > > in the door.

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add support for querying hw info that UMDs need

2022-01-19 Thread Patchwork
== Series Details == Series: Add support for querying hw info that UMDs need URL : https://patchwork.freedesktop.org/series/99060/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread Andy Shevchenko
On Wed, Jan 19, 2022 at 04:00:17PM -0500, Steven Rostedt wrote: > On Wed, 19 Jan 2022 21:25:08 +0200 > Andy Shevchenko wrote: > > > > I say keep it one line! > > > > > > Reviewed-by: Steven Rostedt (Google) > > > > I believe Sakari strongly follows the 80 rule, which means... > >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add support for querying hw info that UMDs need

2022-01-19 Thread Patchwork
== Series Details == Series: Add support for querying hw info that UMDs need URL : https://patchwork.freedesktop.org/series/99060/ State : warning == Summary == $ dim checkpatch origin/drm-tip 59215be8fef3 drm/i915/guc: Add fetch of hwconfig table -:78: WARNING:FILE_PATH_CHANGES: added, moved

Re: [Intel-gfx] [PATCH 2/3] drm/i915/guc: Add work queue to trigger a GT reset

2022-01-19 Thread Matthew Brost
On Tue, Jan 18, 2022 at 05:37:01PM -0800, John Harrison wrote: > On 1/18/2022 13:43, Matthew Brost wrote: > > The G2H handler needs to be flushed during a GT reset but a G2H > > indicating engine reset failure can trigger a GT reset. Add a worker to > > trigger the GT when a engine reset failure

Re: [Intel-gfx] [PATCH v5 1/5] x86/quirks: Fix stolen detection with integrated + discrete GPU

2022-01-19 Thread Bjorn Helgaas
On Wed, Jan 19, 2022 at 12:30:04PM -0800, Lucas De Marchi wrote: > On Tue, Jan 18, 2022 at 02:01:45PM -0600, Bjorn Helgaas wrote: > > Haha :) I was hoping not to touch it myself because I think this > > whole stolen memory thing is kind of nasty. It's not clear to me why > > we need it at all,

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Allocate intel_engine_coredump_alloc with ALLOW_FAIL

2022-01-19 Thread John Harrison
On 1/19/2022 12:47, Matthew Brost wrote: On Tue, Jan 18, 2022 at 05:29:54PM -0800, John Harrison wrote: On 1/18/2022 13:43, Matthew Brost wrote: Allocate intel_engine_coredump_alloc with ALLOW_FAIL rather than GFP_KERNEL do fully decouple the error capture from fence signalling. s/do/to/

Re: [Intel-gfx] [PATCH 0/3] lib/string_helpers: Add a few string helpers

2022-01-19 Thread Lucas De Marchi
On Wed, Jan 19, 2022 at 05:15:02PM +0100, Daniel Vetter wrote: On Wed, Jan 19, 2022 at 04:16:12PM +0200, Jani Nikula wrote: On Wed, 19 Jan 2022, Petr Mladek wrote: > On Tue 2022-01-18 23:24:47, Lucas De Marchi wrote: >> Add some helpers under lib/string_helpers.h so they can be used >>

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Allocate intel_engine_coredump_alloc with ALLOW_FAIL

2022-01-19 Thread Matthew Brost
On Tue, Jan 18, 2022 at 05:29:54PM -0800, John Harrison wrote: > On 1/18/2022 13:43, Matthew Brost wrote: > > Allocate intel_engine_coredump_alloc with ALLOW_FAIL rather than > > GFP_KERNEL do fully decouple the error capture from fence signalling. > s/do/to/ > Yep. > > > > Fixes:

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread Lucas De Marchi
On Wed, Jan 19, 2022 at 10:06:35AM -0500, Steven Rostedt wrote: On Wed, 19 Jan 2022 11:18:59 +0200 Sakari Ailus wrote: On Tue, Jan 18, 2022 at 11:24:48PM -0800, Lucas De Marchi wrote: > @@ -1354,8 +1345,7 @@ static bool tomoyo_print_condition(struct tomoyo_io_buffer *head, >case 3: >

[Intel-gfx] [PATCH v3 2/2] drm/i915/uapi: Add query for hwconfig table

2022-01-19 Thread John . C . Harrison
From: Rodrigo Vivi GuC contains a consolidated table with a bunch of information about the current device. Previously, this information was spread and hardcoded to all the components including GuC, i915 and various UMDs. The goal here is to consolidate the data into GuC in a way that all

[Intel-gfx] [PATCH v3 0/2] Add support for querying hw info that UMDs need

2022-01-19 Thread John . C . Harrison
From: John Harrison Various UMDs require hardware configuration information about the current platform. A bunch of static information is available in a fixed table that can be retrieved from the GuC. v2: Rebased to newer baseline and added a kerneldoc comment. v3: Rebased to newer baseline and

[Intel-gfx] [PATCH v3 1/2] drm/i915/guc: Add fetch of hwconfig table

2022-01-19 Thread John . C . Harrison
From: John Harrison Implement support for fetching the hardware description table from the GuC. The call is made twice - once without a destination buffer to query the size and then a second time to fill in the buffer. Note that the table is only available on ADL-P and later platforms. Cc:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bios: Workaround broken video BIOS in LG Gram 2021 (rev2)

2022-01-19 Thread Patchwork
== Series Details == Series: drm/i915/bios: Workaround broken video BIOS in LG Gram 2021 (rev2) URL : https://patchwork.freedesktop.org/series/99052/ State : failure == Summary == CI Bug Log - changes from CI_DRM_0 -> Patchwork_22026

Re: [Intel-gfx] [PATCH v5 1/5] x86/quirks: Fix stolen detection with integrated + discrete GPU

2022-01-19 Thread Lucas De Marchi
On Tue, Jan 18, 2022 at 02:01:45PM -0600, Bjorn Helgaas wrote: On Tue, Jan 18, 2022 at 07:37:29PM +0100, Borislav Petkov wrote: On Tue, Jan 18, 2022 at 11:58:53AM -0600, Bjorn Helgaas wrote: > I don't really care much one way or the other. I think the simplest > approach is to remove

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/bios: Workaround broken video BIOS in LG Gram 2021 (rev2)

2022-01-19 Thread Patchwork
== Series Details == Series: drm/i915/bios: Workaround broken video BIOS in LG Gram 2021 (rev2) URL : https://patchwork.freedesktop.org/series/99052/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked

[Intel-gfx] [PATCH v2 i-g-t 1/1] tests/i915/query: Query, parse and validate the hwconfig table

2022-01-19 Thread John . C . Harrison
From: Rodrigo Vivi Newer platforms have an embedded table giving details about that platform's hardware configuration. This table can be retrieved from the KMD via the existing query API. So add a test for it as both an example of how to fetch the table and to validate the contents as much as is

[Intel-gfx] [PATCH v2 i-g-t 0/1] Add test for new hw info query

2022-01-19 Thread John . C . Harrison
From: John Harrison Various UMDs require hardware configuration information about the current platform. A new interface has been added to the KMD to return this information. So, add a test for the new interface. v2: Rebased to newer baseline. Signed-off-by: John Harrison Reviewed-by: Matthew

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/uapi: document behaviour for DG2 64K support

2022-01-19 Thread Robert Beckett
On 19/01/2022 18:36, Jordan Justen wrote: Robert Beckett writes: From: Matthew Auld On discrete platforms like DG2, we need to support a minimum page size of 64K when dealing with device local-memory. This is quite tricky for various reasons, so try to document the new implicit uapi for

Re: [Intel-gfx] [PATCH] drm/i915: Nuke dg2_ddi_pre_enable_dp()

2022-01-19 Thread Ville Syrjälä
On Wed, Jan 19, 2022 at 11:09:47AM -0800, Navare, Manasi wrote: > On Wed, Jan 19, 2022 at 05:17:05PM +0200, Jani Nikula wrote: > > On Wed, 19 Jan 2022, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > dg2_ddi_pre_enable_dp() has outlived its usefulness so eliminate > > > it. > > > > >

Re: [Intel-gfx] [PATCH 3/3] drm: Convert open yes/no strings to yesno()

2022-01-19 Thread Andy Shevchenko
On Tue, Jan 18, 2022 at 11:24:50PM -0800, Lucas De Marchi wrote: > linux/string_helpers.h provides a helper to return "yes"/"no" > strings. Replace the open coded versions with yesno(). The places were > identified with the following semantic patch: > > @@ > expression b; > @@ >

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread Andy Shevchenko
On Wed, Jan 19, 2022 at 04:38:26PM +, David Laight wrote: > > > > > +static inline const char *yesno(bool v) { return v ? "yes" : "no"; } > > > > return "yes\0no" + v * 4; > > > > :-) > > except '"no\0\0yes" + v * 4' works a bit better. Is it a C code obfuscation contest? -- With

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread Andy Shevchenko
On Wed, Jan 19, 2022 at 10:06:35AM -0500, Steven Rostedt wrote: > On Wed, 19 Jan 2022 11:18:59 +0200 > Sakari Ailus wrote: > > On Tue, Jan 18, 2022 at 11:24:48PM -0800, Lucas De Marchi wrote: > > > @@ -1354,8 +1345,7 @@ static bool tomoyo_print_condition(struct > > > tomoyo_io_buffer *head, > >

[Intel-gfx] [PATCH v2] drm/i915/bios: Workaround broken video BIOS in LG Gram 2021

2022-01-19 Thread H.J. Lu
LG Gram 2021 laptop 17Z95P-K.ADE9U1 OpRegion has FW size: 0x2200 VBT size: 0x2000 BDB offset: 0x30 BDB size: 0x216e Add intel_init_opregion_quirks to use FW size as VBT size on LG Gram 17Z95P-K.ADE9U1 and update intel_bios_is_valid_vbt to use FW size, instead of VBT size if the quirk is applied,

Re: [Intel-gfx] [PATCH] drm/i915: Nuke dg2_ddi_pre_enable_dp()

2022-01-19 Thread Navare, Manasi
On Wed, Jan 19, 2022 at 05:17:05PM +0200, Jani Nikula wrote: > On Wed, 19 Jan 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > dg2_ddi_pre_enable_dp() has outlived its usefulness so eliminate > > it. > > > > The one thing that tgl_ddi_pre_enable_dp() is missing that we > > need is

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/uapi: document behaviour for DG2 64K support

2022-01-19 Thread Jordan Justen
Robert Beckett writes: > From: Matthew Auld > > On discrete platforms like DG2, we need to support a minimum page size > of 64K when dealing with device local-memory. This is quite tricky for > various reasons, so try to document the new implicit uapi for this. > > v2: Fixed suggestions on

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix vma resource freeing

2022-01-19 Thread Patchwork
== Series Details == Series: drm/i915: Fix vma resource freeing URL : https://patchwork.freedesktop.org/series/99055/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11109 -> Patchwork_22025 Summary --- **FAILURE**

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bios: Workaround broken video BIOS in LG Gram 2021

2022-01-19 Thread Patchwork
== Series Details == Series: drm/i915/bios: Workaround broken video BIOS in LG Gram 2021 URL : https://patchwork.freedesktop.org/series/99052/ State : success == Summary == CI Bug Log - changes from CI_DRM_11109 -> Patchwork_22024 Summary

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/bios: Workaround broken video BIOS in LG Gram 2021

2022-01-19 Thread Patchwork
== Series Details == Series: drm/i915/bios: Workaround broken video BIOS in LG Gram 2021 URL : https://patchwork.freedesktop.org/series/99052/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_bios.c:2278: warning: Function

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/bios: Workaround broken video BIOS in LG Gram 2021

2022-01-19 Thread Patchwork
== Series Details == Series: drm/i915/bios: Workaround broken video BIOS in LG Gram 2021 URL : https://patchwork.freedesktop.org/series/99052/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/bios: Workaround broken video BIOS in LG Gram 2021

2022-01-19 Thread Patchwork
== Series Details == Series: drm/i915/bios: Workaround broken video BIOS in LG Gram 2021 URL : https://patchwork.freedesktop.org/series/99052/ State : warning == Summary == $ dim checkpatch origin/drm-tip be74e903c53e drm/i915/bios: Workaround broken video BIOS in LG Gram 2021 -:211:

Re: [Intel-gfx] [RE]: [PATCH v3 10/10] vfio/ccw: Move the lifecycle of the struct vfio_ccw_private to the mdev

2022-01-19 Thread Eric Farman
On Mon, 2022-01-17 at 11:35 -0400, Jason Gunthorpe wrote: > On Fri, Jan 14, 2022 at 11:30:36AM -0500, Eric Farman wrote: > > On Fri, 2022-01-14 at 20:28 +0800, Liu Yi L wrote: > > > Hi Eric, > > > > > > Hope you are back from new year holiday.:-) Have you got chane to > > > consider > > > this

Re: [Intel-gfx] [PATCH v9 1/6] drm: move the buddy allocator from i915 into common drm

2022-01-19 Thread Christian König
Am 18.01.22 um 11:44 schrieb Arunpravin: Move the base i915 buddy allocator code into drm - Move i915_buddy.h to include/drm - Move i915_buddy.c to drm root folder - Rename "i915" string with "drm" string wherever applicable - Rename "I915" string with "DRM" string wherever applicable - Fix

Re: [Intel-gfx] [PATCH v2 0/5] Add driver for GSC controller

2022-01-19 Thread Greg Kroah-Hartman
On Wed, Jan 19, 2022 at 05:58:02PM +0200, Alexander Usyskin wrote: > GSC is a graphics system controller, it provides > a chassis controller for graphics discrete cards. > > There are two MEI interfaces in GSC: HECI1 and HECI2. > > This series includes instantiation of the auxiliary devices for

[Intel-gfx] [PATCH] drm/i915: Fix vma resource freeing

2022-01-19 Thread Thomas Hellström
In some cases we use leftover kfree() instead of i915_vma_resource_free(). Fix this. Fixes: Fixes: 2f6b90da9192 ("drm/i915: Use vma resources for async unbinding") Reported-by: Robert Beckett Cc: Matthew Auld Signed-off-by: Thomas Hellström --- drivers/gpu/drm/i915/i915_vma.c | 4

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Add driver for GSC controller (rev2)

2022-01-19 Thread Patchwork
== Series Details == Series: Add driver for GSC controller (rev2) URL : https://patchwork.freedesktop.org/series/98066/ State : failure == Summary == Applying: drm/i915/gsc: add gsc as a mei auxiliary device Using index info to reconstruct a base tree... M drivers/gpu/drm/i915/Kconfig M

Re: [Intel-gfx] [PATCH 0/7] DRM kmap() fixes and kmap_local_page() conversions

2022-01-19 Thread Daniel Vetter
On Wed, Jan 19, 2022 at 08:53:56AM -0800, Ira Weiny wrote: > On Fri, Dec 10, 2021 at 03:23:57PM -0800, 'Ira Weiny' wrote: > > From: Ira Weiny > > > > This series starts by converting the last easy kmap() uses to > > kmap_local_page(). > > > > There is one more call to kmap() wrapped in

Re: [Intel-gfx] [PATCH 0/7] DRM kmap() fixes and kmap_local_page() conversions

2022-01-19 Thread Ira Weiny
On Fri, Dec 10, 2021 at 03:23:57PM -0800, 'Ira Weiny' wrote: > From: Ira Weiny > > This series starts by converting the last easy kmap() uses to > kmap_local_page(). > > There is one more call to kmap() wrapped in ttm_bo_kmap_ttm(). Unfortunately, > ttm_bo_kmap_ttm() is called in a number of

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread David Laight
> > > > +static inline const char *yesno(bool v) { return v ? "yes" : "no"; } > > return "yes\0no" + v * 4; > > :-) except '"no\0\0yes" + v * 4' works a bit better. - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread David Laight
> > > +static inline const char *yesno(bool v) { return v ? "yes" : "no"; } return "yes\0no" + v * 4; :-) - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)

Re: [Intel-gfx] [PATCH 0/3] lib/string_helpers: Add a few string helpers

2022-01-19 Thread Daniel Vetter
On Wed, Jan 19, 2022 at 04:16:12PM +0200, Jani Nikula wrote: > On Wed, 19 Jan 2022, Petr Mladek wrote: > > On Tue 2022-01-18 23:24:47, Lucas De Marchi wrote: > >> Add some helpers under lib/string_helpers.h so they can be used > >> throughout the kernel. When I started doing this there were 2

[Intel-gfx] [PATCH] drm/i915/bios: Workaround broken video BIOS in LG Gram 2021

2022-01-19 Thread H.J. Lu
LG Gram 2021 laptop 17Z95P-K.ADE9U1 OpRegion has FW size: 0x2200 VBT size: 0x2000 BDB offset: 0x30 BDB size: 0x216e Add intel_init_opregion_quirks to use FW size as VBT size on LG Gram 17Z95P-K.ADE9U1 and update intel_bios_is_valid_vbt to use FW size, instead of VBT size if the quirk is applied,

[Intel-gfx] [PATCH v2 5/5] mei: gsc: retrieve the firmware version

2022-01-19 Thread Alexander Usyskin
Add a hook to retrieve the firmware version of the GSC devices to bus-fixup. GSC has a different MKHI clients GUIDs but the same message structure to retrieve the firmware version as MEI so mei_fwver() can be reused. CC: Ashutosh Dixit Signed-off-by: Alexander Usyskin Signed-off-by: Tomas

[Intel-gfx] [PATCH v2 4/5] mei: gsc: add runtime pm handlers

2022-01-19 Thread Alexander Usyskin
From: Tomas Winkler Implement runtime handlers for mei-gsc, to track idle state of the device properly. CC: Rodrigo Vivi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/misc/mei/gsc-me.c | 80 ++- 1 file changed, 79

[Intel-gfx] [PATCH v2 3/5] mei: gsc: setup char driver alive in spite of firmware handshake failure

2022-01-19 Thread Alexander Usyskin
Setup char device in spite of firmware handshake failure. In order to provide host access to the firmware status registers and other information required for the manufacturing process. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/gsc-me.c | 11 ++-

[Intel-gfx] [PATCH v2 1/5] drm/i915/gsc: add gsc as a mei auxiliary device

2022-01-19 Thread Alexander Usyskin
From: Tomas Winkler GSC is a graphics system controller, it provides a chassis controller for graphics discrete cards. There are two MEI interfaces in GSC: HECI1 and HECI2. Both interfaces are on the BAR0 at offsets 0x00258000 and 0x00259000. GSC is a GT Engine (class 4: instance 6). HECI1

[Intel-gfx] [PATCH v2 0/5] Add driver for GSC controller

2022-01-19 Thread Alexander Usyskin
GSC is a graphics system controller, it provides a chassis controller for graphics discrete cards. There are two MEI interfaces in GSC: HECI1 and HECI2. This series includes instantiation of the auxiliary devices for HECI2 and mei-gsc auxiliary device driver that binds to the auxiliary device.

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Nuke dg2_ddi_pre_enable_dp()

2022-01-19 Thread Patchwork
== Series Details == Series: drm/i915: Nuke dg2_ddi_pre_enable_dp() URL : https://patchwork.freedesktop.org/series/99041/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11104_full -> Patchwork_22022_full Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: Nuke dg2_ddi_pre_enable_dp()

2022-01-19 Thread Jani Nikula
On Wed, 19 Jan 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > dg2_ddi_pre_enable_dp() has outlived its usefulness so eliminate > it. > > The one thing that tgl_ddi_pre_enable_dp() is missing that we > need is intel_ddi_config_transcoder_dp2(). So we'll bring that > over. > >

Re: [Intel-gfx] [PATCH 6/7] drm: Document fdinfo format specification

2022-01-19 Thread Daniel Vetter
On Thu, Jan 06, 2022 at 04:55:35PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Proposal to standardise the fdinfo text format as optionally output by DRM > drivers. > > Idea is that a simple but, well defined, spec will enable generic > userspace tools to be written while at the

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread Steven Rostedt
On Wed, 19 Jan 2022 11:18:59 +0200 Sakari Ailus wrote: > On Tue, Jan 18, 2022 at 11:24:48PM -0800, Lucas De Marchi wrote: > > @@ -1354,8 +1345,7 @@ static bool tomoyo_print_condition(struct > > tomoyo_io_buffer *head, > > case 3: > > if (cond->grant_log != TOMOYO_GRANTLOG_AUTO)

Re: [Intel-gfx] [PATCH] drm/i915: Remove zombie async flip vt-d w/a

2022-01-19 Thread Jani Nikula
On Wed, 08 Dec 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > This async flip vt-d w/a was moved to a different place in > commit 7d396cacaea6 ("drm/i195: Make the async flip VT-d workaround > dynamic") but the drm-intel-fixes cherry-pick commit b2d73debfdc1 > ("drm/i915: Extend the async

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread Steven Rostedt
On Wed, 19 Jan 2022 11:15:08 +0200 Andy Shevchenko wrote: > > +static inline const char *yesno(bool v) { return v ? "yes" : "no"; } > > > > Perhaps keep it on 4 lines? Yes, yes/no is short, but if we add others > (enable/disable) it will not be possible to keep on one line. And hence >

Re: [Intel-gfx] [PATCH 0/3] lib/string_helpers: Add a few string helpers

2022-01-19 Thread Jani Nikula
On Wed, 19 Jan 2022, Petr Mladek wrote: > On Tue 2022-01-18 23:24:47, Lucas De Marchi wrote: >> Add some helpers under lib/string_helpers.h so they can be used >> throughout the kernel. When I started doing this there were 2 other >> previous attempts I know of, not counting the iterations each

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Nuke dg2_ddi_pre_enable_dp()

2022-01-19 Thread Patchwork
== Series Details == Series: drm/i915: Nuke dg2_ddi_pre_enable_dp() URL : https://patchwork.freedesktop.org/series/99041/ State : success == Summary == CI Bug Log - changes from CI_DRM_11104 -> Patchwork_22022 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Nuke dg2_ddi_pre_enable_dp()

2022-01-19 Thread Patchwork
== Series Details == Series: drm/i915: Nuke dg2_ddi_pre_enable_dp() URL : https://patchwork.freedesktop.org/series/99041/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9cb5445f65a3 drm/i915: Nuke dg2_ddi_pre_enable_dp() -:19: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dpll: make intel_shared_dpll_funcs internal to intel_dpll_mgr.c

2022-01-19 Thread Patchwork
== Series Details == Series: drm/i915/dpll: make intel_shared_dpll_funcs internal to intel_dpll_mgr.c URL : https://patchwork.freedesktop.org/series/99034/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11094_full -> Patchwork_22021_full

[Intel-gfx] [PATCH] drm/i915: Nuke dg2_ddi_pre_enable_dp()

2022-01-19 Thread Ville Syrjala
From: Ville Syrjälä dg2_ddi_pre_enable_dp() has outlived its usefulness so eliminate it. The one thing that tgl_ddi_pre_enable_dp() is missing that we need is intel_ddi_config_transcoder_dp2(). So we'll bring that over. tgl_ddi_pre_enable_dp() does also have a few things that

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Don't allocate extra ddb during async flip for DG2

2022-01-19 Thread Ville Syrjälä
On Tue, Jan 18, 2022 at 12:48:39PM +0200, Stanislav Lisovskiy wrote: > In terms of async flip optimization we don't to allocate > extra ddb space, so lets skip it. > > v2: - Extracted min ddb async flip check to separate function > (Ville Syrjälä) > - Used this function to prevent false

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use wm0 only during async flips for DG2

2022-01-19 Thread Ville Syrjälä
On Tue, Jan 18, 2022 at 12:48:38PM +0200, Stanislav Lisovskiy wrote: > This optimization allows to achieve higher perfomance > during async flips. > For the first async flip we have to still temporarily > switch to sync flip, in order to reprogram plane > watermarks, so this requires taking into

  1   2   >