Re: [Intel-gfx] [PATCH 0/3] lib/string_helpers: Add a few string helpers

On Tue, 18 Jan 2022, Lucas De Marchi wrote: > Add some helpers under lib/string_helpers.h so they can be used > throughout the kernel. When I started doing this there were 2 other > previous attempts I know of, not counting the iterations each of them > had: > > 1) https://lore.kernel.org/all/2019

[Intel-gfx] ✓ Fi.CI.BAT: success for lib/string_helpers: Add a few string helpers

== Series Details == Series: lib/string_helpers: Add a few string helpers URL : https://patchwork.freedesktop.org/series/99030/ State : success == Summary == CI Bug Log - changes from CI_DRM_11094 -> Patchwork_22020 Summary --- **SUC

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/gt: make a gt sysfs group and move power management files

Hi Joonas, > > > The GT has its own properties and in sysfs they should be grouped > > > in the 'gt/' directory. > > > > > > Create a 'gt/' directory in sysfs which will contain gt0...gtN > > > directories related to each tile configured in the GPU. Move the > > > power management files inside th

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

On Wednesday, January 19, 2022, Lucas De Marchi wrote: > There are a few implementations of yesno() in the tree. Consolidate them > in include/linux/string_helpers.h. Quite a few users of open coded > yesno() could later be converted to the new function: > > $ git grep '?\s*"yes"\s*' | wc -l > 2

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

Hi Lucas, On Tue, Jan 18, 2022 at 11:24:48PM -0800, Lucas De Marchi wrote: > @@ -1354,8 +1345,7 @@ static bool tomoyo_print_condition(struct > tomoyo_io_buffer *head, > case 3: > if (cond->grant_log != TOMOYO_GRANTLOG_AUTO) > tomoyo_io_printf(head, " gran

Re: [Intel-gfx] [PATCH 2/3] lib/string_helpers: Add helpers for enable[d]/disable[d]

On Wednesday, January 19, 2022, Lucas De Marchi wrote: > Follow the yes/no logic and add helpers for enabled/disabled and > enable/disable - those are not so common throughout the kernel, > but they give a nice way to reuse the strings to log things as > enabled/disabled or enable/disable. > > Si

Re: [Intel-gfx] [PATCH 0/3] lib/string_helpers: Add a few string helpers

On Wednesday, January 19, 2022, Lucas De Marchi wrote: > Add some helpers under lib/string_helpers.h so they can be used > throughout the kernel. When I started doing this there were 2 other > previous attempts I know of, not counting the iterations each of them > had: > > 1) https://lore.kernel.

[Intel-gfx] ✗ Fi.CI.IGT: failure for lib/string_helpers: Add a few string helpers

== Series Details == Series: lib/string_helpers: Add a few string helpers URL : https://patchwork.freedesktop.org/series/99030/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11094_full -> Patchwork_22020_full Summary --

Re: [Intel-gfx] [PATCH 2/3] lib/string_helpers: Add helpers for enable[d]/disable[d]

On Wed, Jan 19, 2022 at 11:20:38AM +0200, Andy Shevchenko wrote: On Wednesday, January 19, 2022, Lucas De Marchi wrote: Follow the yes/no logic and add helpers for enabled/disabled and enable/disable - those are not so common throughout the kernel, but they give a nice way to reuse the strings

[Intel-gfx] [PATCH] drm/i915/dpll: make intel_shared_dpll_funcs internal to intel_dpll_mgr.c

Move struct intel_shared_dpll_funcs to intel_dpll_mgr.c, as no other place needs to have access to it. We also don't need to have kernel-doc documentation for file internal structures, so drop them while at it. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 35 +++

Re: [Intel-gfx] [PATCH 2/2] drm/i915/uncore: rename i915_reg_read_ioctl intel_uncore_reg_read_ioctl

On Wed, 05 Jan 2022, Tvrtko Ursulin wrote: > On 05/01/2022 13:18, Jani Nikula wrote: >> On Wed, 05 Jan 2022, Tvrtko Ursulin wrote: >>> On 05/01/2022 10:32, Jani Nikula wrote: On Wed, 05 Jan 2022, Tvrtko Ursulin wrote: > On 05/01/2022 10:05, Jani Nikula wrote: >> Follow the usual nam

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dpll: make intel_shared_dpll_funcs internal to intel_dpll_mgr.c

== Series Details == Series: drm/i915/dpll: make intel_shared_dpll_funcs internal to intel_dpll_mgr.c URL : https://patchwork.freedesktop.org/series/99034/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separ

Re: [Intel-gfx] [PATCH] drm/i915/dpll: make intel_shared_dpll_funcs internal to intel_dpll_mgr.c

On Wed, Jan 19, 2022 at 01:05:28PM +0200, Jani Nikula wrote: > Move struct intel_shared_dpll_funcs to intel_dpll_mgr.c, as no other > place needs to have access to it. We also don't need to have kernel-doc > documentation for file internal structures, so drop them while at it. > > Signed-off-by: J

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Pass plane to watermark calculation functions

On Tue, Jan 18, 2022 at 12:48:36PM +0200, Stanislav Lisovskiy wrote: > Sometimes we might need to change the way we calculate > watermarks, based on which particular plane it is calculated > for. Thus it would be convenient to pass plane struct to those > functions. > > v2: Pass plane instead of p

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Introduce do_async_flip flag to intel_plane_state

On Tue, Jan 18, 2022 at 12:48:37PM +0200, Stanislav Lisovskiy wrote: > There might be various logical contructs when we might want > to enable async flip, so lets calculate those and set this > flag, so that there is no need in long conditions in other > places. > > v2: - Set do_async_flip flag to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dpll: make intel_shared_dpll_funcs internal to intel_dpll_mgr.c

== Series Details == Series: drm/i915/dpll: make intel_shared_dpll_funcs internal to intel_dpll_mgr.c URL : https://patchwork.freedesktop.org/series/99034/ State : success == Summary == CI Bug Log - changes from CI_DRM_11094 -> Patchwork_22021 ==

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use wm0 only during async flips for DG2

On Tue, Jan 18, 2022 at 12:48:38PM +0200, Stanislav Lisovskiy wrote: > This optimization allows to achieve higher perfomance > during async flips. > For the first async flip we have to still temporarily > switch to sync flip, in order to reprogram plane > watermarks, so this requires taking into ac

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Don't allocate extra ddb during async flip for DG2

On Tue, Jan 18, 2022 at 12:48:39PM +0200, Stanislav Lisovskiy wrote: > In terms of async flip optimization we don't to allocate > extra ddb space, so lets skip it. > > v2: - Extracted min ddb async flip check to separate function > (Ville Syrjälä) > - Used this function to prevent false

[Intel-gfx] [PATCH] drm/i915: Nuke dg2_ddi_pre_enable_dp()

From: Ville Syrjälä dg2_ddi_pre_enable_dp() has outlived its usefulness so eliminate it. The one thing that tgl_ddi_pre_enable_dp() is missing that we need is intel_ddi_config_transcoder_dp2(). So we'll bring that over. tgl_ddi_pre_enable_dp() does also have a few things that dg2_ddi_pre_enable

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dpll: make intel_shared_dpll_funcs internal to intel_dpll_mgr.c

== Series Details == Series: drm/i915/dpll: make intel_shared_dpll_funcs internal to intel_dpll_mgr.c URL : https://patchwork.freedesktop.org/series/99034/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11094_full -> Patchwork_22021_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Nuke dg2_ddi_pre_enable_dp()

== Series Details == Series: drm/i915: Nuke dg2_ddi_pre_enable_dp() URL : https://patchwork.freedesktop.org/series/99041/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9cb5445f65a3 drm/i915: Nuke dg2_ddi_pre_enable_dp() -:19: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped com

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Nuke dg2_ddi_pre_enable_dp()

== Series Details == Series: drm/i915: Nuke dg2_ddi_pre_enable_dp() URL : https://patchwork.freedesktop.org/series/99041/ State : success == Summary == CI Bug Log - changes from CI_DRM_11104 -> Patchwork_22022 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 0/3] lib/string_helpers: Add a few string helpers

On Wed, 19 Jan 2022, Petr Mladek wrote: > On Tue 2022-01-18 23:24:47, Lucas De Marchi wrote: >> Add some helpers under lib/string_helpers.h so they can be used >> throughout the kernel. When I started doing this there were 2 other >> previous attempts I know of, not counting the iterations each of

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

On Wed, 19 Jan 2022 11:15:08 +0200 Andy Shevchenko wrote: > > +static inline const char *yesno(bool v) { return v ? "yes" : "no"; } > > > > Perhaps keep it on 4 lines? Yes, yes/no is short, but if we add others > (enable/disable) it will not be possible to keep on one line. And hence > style

Re: [Intel-gfx] [PATCH] drm/i915: Remove zombie async flip vt-d w/a

On Wed, 08 Dec 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > This async flip vt-d w/a was moved to a different place in > commit 7d396cacaea6 ("drm/i195: Make the async flip VT-d workaround > dynamic") but the drm-intel-fixes cherry-pick commit b2d73debfdc1 > ("drm/i915: Extend the async f

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

On Wed, 19 Jan 2022 11:18:59 +0200 Sakari Ailus wrote: > On Tue, Jan 18, 2022 at 11:24:48PM -0800, Lucas De Marchi wrote: > > @@ -1354,8 +1345,7 @@ static bool tomoyo_print_condition(struct > > tomoyo_io_buffer *head, > > case 3: > > if (cond->grant_log != TOMOYO_GRANTLOG_AUTO) >

Re: [Intel-gfx] [PATCH 6/7] drm: Document fdinfo format specification

On Thu, Jan 06, 2022 at 04:55:35PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Proposal to standardise the fdinfo text format as optionally output by DRM > drivers. > > Idea is that a simple but, well defined, spec will enable generic > userspace tools to be written while at the same

Re: [Intel-gfx] [PATCH] drm/i915: Nuke dg2_ddi_pre_enable_dp()

On Wed, 19 Jan 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > dg2_ddi_pre_enable_dp() has outlived its usefulness so eliminate > it. > > The one thing that tgl_ddi_pre_enable_dp() is missing that we > need is intel_ddi_config_transcoder_dp2(). So we'll bring that > over. > > tgl_ddi_pre_ena

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Nuke dg2_ddi_pre_enable_dp()

== Series Details == Series: drm/i915: Nuke dg2_ddi_pre_enable_dp() URL : https://patchwork.freedesktop.org/series/99041/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11104_full -> Patchwork_22022_full Summary --- *

[Intel-gfx] [PATCH v2 0/5] Add driver for GSC controller

GSC is a graphics system controller, it provides a chassis controller for graphics discrete cards. There are two MEI interfaces in GSC: HECI1 and HECI2. This series includes instantiation of the auxiliary devices for HECI2 and mei-gsc auxiliary device driver that binds to the auxiliary device. I

[Intel-gfx] [PATCH v2 1/5] drm/i915/gsc: add gsc as a mei auxiliary device

From: Tomas Winkler GSC is a graphics system controller, it provides a chassis controller for graphics discrete cards. There are two MEI interfaces in GSC: HECI1 and HECI2. Both interfaces are on the BAR0 at offsets 0x00258000 and 0x00259000. GSC is a GT Engine (class 4: instance 6). HECI1 inte

[Intel-gfx] [PATCH v2 2/5] mei: add support for graphics system controller (gsc) devices

From: Tomas Winkler GSC is a graphics system controller, based on CSE, it provides a chassis controller for graphics discrete cards, as well as it supports media protection on selected devices. mei_gsc binds to a auxiliary devices exposed by Intel discrete driver i915. Signed-off-by: Alexander

[Intel-gfx] [PATCH v2 3/5] mei: gsc: setup char driver alive in spite of firmware handshake failure

Setup char device in spite of firmware handshake failure. In order to provide host access to the firmware status registers and other information required for the manufacturing process. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/gsc-me.c | 11 ++-

[Intel-gfx] [PATCH v2 4/5] mei: gsc: add runtime pm handlers

From: Tomas Winkler Implement runtime handlers for mei-gsc, to track idle state of the device properly. CC: Rodrigo Vivi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/misc/mei/gsc-me.c | 80 ++- 1 file changed, 79 insertions(+),

[Intel-gfx] [PATCH v2 5/5] mei: gsc: retrieve the firmware version

Add a hook to retrieve the firmware version of the GSC devices to bus-fixup. GSC has a different MKHI clients GUIDs but the same message structure to retrieve the firmware version as MEI so mei_fwver() can be reused. CC: Ashutosh Dixit Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkle

[Intel-gfx] [PATCH] drm/i915/bios: Workaround broken video BIOS in LG Gram 2021

LG Gram 2021 laptop 17Z95P-K.ADE9U1 OpRegion has FW size: 0x2200 VBT size: 0x2000 BDB offset: 0x30 BDB size: 0x216e Add intel_init_opregion_quirks to use FW size as VBT size on LG Gram 17Z95P-K.ADE9U1 and update intel_bios_is_valid_vbt to use FW size, instead of VBT size if the quirk is applied,

Re: [Intel-gfx] [PATCH 0/3] lib/string_helpers: Add a few string helpers

On Wed, Jan 19, 2022 at 04:16:12PM +0200, Jani Nikula wrote: > On Wed, 19 Jan 2022, Petr Mladek wrote: > > On Tue 2022-01-18 23:24:47, Lucas De Marchi wrote: > >> Add some helpers under lib/string_helpers.h so they can be used > >> throughout the kernel. When I started doing this there were 2 othe

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

> > > +static inline const char *yesno(bool v) { return v ? "yes" : "no"; } return "yes\0no" + v * 4; :-) - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

> > > > +static inline const char *yesno(bool v) { return v ? "yes" : "no"; } > > return "yes\0no" + v * 4; > > :-) except '"no\0\0yes" + v * 4' works a bit better. - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)

Re: [Intel-gfx] [PATCH 0/7] DRM kmap() fixes and kmap_local_page() conversions

On Fri, Dec 10, 2021 at 03:23:57PM -0800, 'Ira Weiny' wrote: > From: Ira Weiny > > This series starts by converting the last easy kmap() uses to > kmap_local_page(). > > There is one more call to kmap() wrapped in ttm_bo_kmap_ttm(). Unfortunately, > ttm_bo_kmap_ttm() is called in a number of di

Re: [Intel-gfx] [PATCH 0/7] DRM kmap() fixes and kmap_local_page() conversions

On Wed, Jan 19, 2022 at 08:53:56AM -0800, Ira Weiny wrote: > On Fri, Dec 10, 2021 at 03:23:57PM -0800, 'Ira Weiny' wrote: > > From: Ira Weiny > > > > This series starts by converting the last easy kmap() uses to > > kmap_local_page(). > > > > There is one more call to kmap() wrapped in ttm_bo_km

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Add driver for GSC controller (rev2)

== Series Details == Series: Add driver for GSC controller (rev2) URL : https://patchwork.freedesktop.org/series/98066/ State : failure == Summary == Applying: drm/i915/gsc: add gsc as a mei auxiliary device Using index info to reconstruct a base tree... M drivers/gpu/drm/i915/Kconfig M

[Intel-gfx] [PATCH] drm/i915: Fix vma resource freeing

In some cases we use leftover kfree() instead of i915_vma_resource_free(). Fix this. Fixes: Fixes: 2f6b90da9192 ("drm/i915: Use vma resources for async unbinding") Reported-by: Robert Beckett Cc: Matthew Auld Signed-off-by: Thomas Hellström --- drivers/gpu/drm/i915/i915_vma.c | 4 ++--

Re: [Intel-gfx] [PATCH v2 0/5] Add driver for GSC controller

On Wed, Jan 19, 2022 at 05:58:02PM +0200, Alexander Usyskin wrote: > GSC is a graphics system controller, it provides > a chassis controller for graphics discrete cards. > > There are two MEI interfaces in GSC: HECI1 and HECI2. > > This series includes instantiation of the auxiliary devices for H

Re: [Intel-gfx] [PATCH v9 1/6] drm: move the buddy allocator from i915 into common drm

Am 18.01.22 um 11:44 schrieb Arunpravin: Move the base i915 buddy allocator code into drm - Move i915_buddy.h to include/drm - Move i915_buddy.c to drm root folder - Rename "i915" string with "drm" string wherever applicable - Rename "I915" string with "DRM" string wherever applicable - Fix heade

Re: [Intel-gfx] [RE]: [PATCH v3 10/10] vfio/ccw: Move the lifecycle of the struct vfio_ccw_private to the mdev

On Mon, 2022-01-17 at 11:35 -0400, Jason Gunthorpe wrote: > On Fri, Jan 14, 2022 at 11:30:36AM -0500, Eric Farman wrote: > > On Fri, 2022-01-14 at 20:28 +0800, Liu Yi L wrote: > > > Hi Eric, > > > > > > Hope you are back from new year holiday.:-) Have you got chane to > > > consider > > > this pat

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/bios: Workaround broken video BIOS in LG Gram 2021

== Series Details == Series: drm/i915/bios: Workaround broken video BIOS in LG Gram 2021 URL : https://patchwork.freedesktop.org/series/99052/ State : warning == Summary == $ dim checkpatch origin/drm-tip be74e903c53e drm/i915/bios: Workaround broken video BIOS in LG Gram 2021 -:211: CHECK:SPA

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/bios: Workaround broken video BIOS in LG Gram 2021

== Series Details == Series: drm/i915/bios: Workaround broken video BIOS in LG Gram 2021 URL : https://patchwork.freedesktop.org/series/99052/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/bios: Workaround broken video BIOS in LG Gram 2021

== Series Details == Series: drm/i915/bios: Workaround broken video BIOS in LG Gram 2021 URL : https://patchwork.freedesktop.org/series/99052/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_bios.c:2278: warning: Function paramete

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bios: Workaround broken video BIOS in LG Gram 2021

== Series Details == Series: drm/i915/bios: Workaround broken video BIOS in LG Gram 2021 URL : https://patchwork.freedesktop.org/series/99052/ State : success == Summary == CI Bug Log - changes from CI_DRM_11109 -> Patchwork_22024 Summary -

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix vma resource freeing

== Series Details == Series: drm/i915: Fix vma resource freeing URL : https://patchwork.freedesktop.org/series/99055/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11109 -> Patchwork_22025 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/uapi: document behaviour for DG2 64K support

Robert Beckett writes: > From: Matthew Auld > > On discrete platforms like DG2, we need to support a minimum page size > of 64K when dealing with device local-memory. This is quite tricky for > various reasons, so try to document the new implicit uapi for this. > > v2: Fixed suggestions on forma

Re: [Intel-gfx] [PATCH] drm/i915: Nuke dg2_ddi_pre_enable_dp()

On Wed, Jan 19, 2022 at 05:17:05PM +0200, Jani Nikula wrote: > On Wed, 19 Jan 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > dg2_ddi_pre_enable_dp() has outlived its usefulness so eliminate > > it. > > > > The one thing that tgl_ddi_pre_enable_dp() is missing that we > > need is intel

[Intel-gfx] [PATCH v2] drm/i915/bios: Workaround broken video BIOS in LG Gram 2021

LG Gram 2021 laptop 17Z95P-K.ADE9U1 OpRegion has FW size: 0x2200 VBT size: 0x2000 BDB offset: 0x30 BDB size: 0x216e Add intel_init_opregion_quirks to use FW size as VBT size on LG Gram 17Z95P-K.ADE9U1 and update intel_bios_is_valid_vbt to use FW size, instead of VBT size if the quirk is applied,

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

On Wed, Jan 19, 2022 at 10:06:35AM -0500, Steven Rostedt wrote: > On Wed, 19 Jan 2022 11:18:59 +0200 > Sakari Ailus wrote: > > On Tue, Jan 18, 2022 at 11:24:48PM -0800, Lucas De Marchi wrote: > > > @@ -1354,8 +1345,7 @@ static bool tomoyo_print_condition(struct > > > tomoyo_io_buffer *head, > > >

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

On Wed, Jan 19, 2022 at 04:38:26PM +, David Laight wrote: > > > > > +static inline const char *yesno(bool v) { return v ? "yes" : "no"; } > > > > return "yes\0no" + v * 4; > > > > :-) > > except '"no\0\0yes" + v * 4' works a bit better. Is it a C code obfuscation contest? -- With Best

Re: [Intel-gfx] [PATCH 3/3] drm: Convert open yes/no strings to yesno()

On Tue, Jan 18, 2022 at 11:24:50PM -0800, Lucas De Marchi wrote: > linux/string_helpers.h provides a helper to return "yes"/"no" > strings. Replace the open coded versions with yesno(). The places were > identified with the following semantic patch: > > @@ > expression b; > @@ >

Re: [Intel-gfx] [PATCH] drm/i915: Nuke dg2_ddi_pre_enable_dp()

On Wed, Jan 19, 2022 at 11:09:47AM -0800, Navare, Manasi wrote: > On Wed, Jan 19, 2022 at 05:17:05PM +0200, Jani Nikula wrote: > > On Wed, 19 Jan 2022, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > dg2_ddi_pre_enable_dp() has outlived its usefulness so eliminate > > > it. > > > > > >

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/uapi: document behaviour for DG2 64K support

On 19/01/2022 18:36, Jordan Justen wrote: Robert Beckett writes: From: Matthew Auld On discrete platforms like DG2, we need to support a minimum page size of 64K when dealing with device local-memory. This is quite tricky for various reasons, so try to document the new implicit uapi for t

[Intel-gfx] [PATCH v2 i-g-t 0/1] Add test for new hw info query

From: John Harrison Various UMDs require hardware configuration information about the current platform. A new interface has been added to the KMD to return this information. So, add a test for the new interface. v2: Rebased to newer baseline. Signed-off-by: John Harrison Reviewed-by: Matthew B

[Intel-gfx] [PATCH v2 i-g-t 1/1] tests/i915/query: Query, parse and validate the hwconfig table

From: Rodrigo Vivi Newer platforms have an embedded table giving details about that platform's hardware configuration. This table can be retrieved from the KMD via the existing query API. So add a test for it as both an example of how to fetch the table and to validate the contents as much as is

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/bios: Workaround broken video BIOS in LG Gram 2021 (rev2)

== Series Details == Series: drm/i915/bios: Workaround broken video BIOS in LG Gram 2021 (rev2) URL : https://patchwork.freedesktop.org/series/99052/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v5 1/5] x86/quirks: Fix stolen detection with integrated + discrete GPU

On Tue, Jan 18, 2022 at 02:01:45PM -0600, Bjorn Helgaas wrote: On Tue, Jan 18, 2022 at 07:37:29PM +0100, Borislav Petkov wrote: On Tue, Jan 18, 2022 at 11:58:53AM -0600, Bjorn Helgaas wrote: > I don't really care much one way or the other. I think the simplest > approach is to remove QFLAG_APPL

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bios: Workaround broken video BIOS in LG Gram 2021 (rev2)

== Series Details == Series: drm/i915/bios: Workaround broken video BIOS in LG Gram 2021 (rev2) URL : https://patchwork.freedesktop.org/series/99052/ State : failure == Summary == CI Bug Log - changes from CI_DRM_0 -> Patchwork_22026 Su

[Intel-gfx] [PATCH v3 1/2] drm/i915/guc: Add fetch of hwconfig table

From: John Harrison Implement support for fetching the hardware description table from the GuC. The call is made twice - once without a destination buffer to query the size and then a second time to fill in the buffer. Note that the table is only available on ADL-P and later platforms. Cc: Mich

[Intel-gfx] [PATCH v3 0/2] Add support for querying hw info that UMDs need

From: John Harrison Various UMDs require hardware configuration information about the current platform. A bunch of static information is available in a fixed table that can be retrieved from the GuC. v2: Rebased to newer baseline and added a kerneldoc comment. v3: Rebased to newer baseline and n

[Intel-gfx] [PATCH v3 2/2] drm/i915/uapi: Add query for hwconfig table

From: Rodrigo Vivi GuC contains a consolidated table with a bunch of information about the current device. Previously, this information was spread and hardcoded to all the components including GuC, i915 and various UMDs. The goal here is to consolidate the data into GuC in a way that all interes

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

On Wed, Jan 19, 2022 at 10:06:35AM -0500, Steven Rostedt wrote: On Wed, 19 Jan 2022 11:18:59 +0200 Sakari Ailus wrote: On Tue, Jan 18, 2022 at 11:24:48PM -0800, Lucas De Marchi wrote: > @@ -1354,8 +1345,7 @@ static bool tomoyo_print_condition(struct tomoyo_io_buffer *head, >case 3: >

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Allocate intel_engine_coredump_alloc with ALLOW_FAIL

On Tue, Jan 18, 2022 at 05:29:54PM -0800, John Harrison wrote: > On 1/18/2022 13:43, Matthew Brost wrote: > > Allocate intel_engine_coredump_alloc with ALLOW_FAIL rather than > > GFP_KERNEL do fully decouple the error capture from fence signalling. > s/do/to/ > Yep. > > > > Fixes: 8b91cdd4f8649

Re: [Intel-gfx] [PATCH 0/3] lib/string_helpers: Add a few string helpers

On Wed, Jan 19, 2022 at 05:15:02PM +0100, Daniel Vetter wrote: On Wed, Jan 19, 2022 at 04:16:12PM +0200, Jani Nikula wrote: On Wed, 19 Jan 2022, Petr Mladek wrote: > On Tue 2022-01-18 23:24:47, Lucas De Marchi wrote: >> Add some helpers under lib/string_helpers.h so they can be used >> througho

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Allocate intel_engine_coredump_alloc with ALLOW_FAIL

On 1/19/2022 12:47, Matthew Brost wrote: On Tue, Jan 18, 2022 at 05:29:54PM -0800, John Harrison wrote: On 1/18/2022 13:43, Matthew Brost wrote: Allocate intel_engine_coredump_alloc with ALLOW_FAIL rather than GFP_KERNEL do fully decouple the error capture from fence signalling. s/do/to/ Yep

Re: [Intel-gfx] [PATCH v5 1/5] x86/quirks: Fix stolen detection with integrated + discrete GPU

On Wed, Jan 19, 2022 at 12:30:04PM -0800, Lucas De Marchi wrote: > On Tue, Jan 18, 2022 at 02:01:45PM -0600, Bjorn Helgaas wrote: > > Haha :) I was hoping not to touch it myself because I think this > > whole stolen memory thing is kind of nasty. It's not clear to me why > > we need it at all, o

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

On Wed, 19 Jan 2022 21:22:57 +0200 Andy Shevchenko wrote: > On Wed, Jan 19, 2022 at 04:38:26PM +, David Laight wrote: > > > > > > +static inline const char *yesno(bool v) { return v ? "yes" : "no"; > > > > > > } > > > > > > return "yes\0no" + v * 4; > > > > > > :-) > > > > except '"

Re: [Intel-gfx] [PATCH 2/3] drm/i915/guc: Add work queue to trigger a GT reset

On Tue, Jan 18, 2022 at 05:37:01PM -0800, John Harrison wrote: > On 1/18/2022 13:43, Matthew Brost wrote: > > The G2H handler needs to be flushed during a GT reset but a G2H > > indicating engine reset failure can trigger a GT reset. Add a worker to > > trigger the GT when a engine reset failure is

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

On Wed, 19 Jan 2022 21:25:08 +0200 Andy Shevchenko wrote: > > I say keep it one line! > > > > Reviewed-by: Steven Rostedt (Google) > > I believe Sakari strongly follows the 80 rule, which means... Checkpatch says "100" I think we need to simply update the docs (the documentation always lags

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add support for querying hw info that UMDs need

== Series Details == Series: Add support for querying hw info that UMDs need URL : https://patchwork.freedesktop.org/series/99060/ State : warning == Summary == $ dim checkpatch origin/drm-tip 59215be8fef3 drm/i915/guc: Add fetch of hwconfig table -:78: WARNING:FILE_PATH_CHANGES: added, moved

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add support for querying hw info that UMDs need

== Series Details == Series: Add support for querying hw info that UMDs need URL : https://patchwork.freedesktop.org/series/99060/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

On Wed, Jan 19, 2022 at 04:00:17PM -0500, Steven Rostedt wrote: > On Wed, 19 Jan 2022 21:25:08 +0200 > Andy Shevchenko wrote: > > > > I say keep it one line! > > > > > > Reviewed-by: Steven Rostedt (Google) > > > > I believe Sakari strongly follows the 80 rule, which means... > > Checkpatch

Re: [Intel-gfx] [PATCH 2/3] drm/i915/guc: Add work queue to trigger a GT reset

On 1/19/2022 12:54, Matthew Brost wrote: On Tue, Jan 18, 2022 at 05:37:01PM -0800, John Harrison wrote: On 1/18/2022 13:43, Matthew Brost wrote: The G2H handler needs to be flushed during a GT reset but a G2H indicating engine reset failure can trigger a GT reset. Add a worker to trigger the GT

Re: [Intel-gfx] [PATCH 0/3] lib/string_helpers: Add a few string helpers

On Wed, Jan 19, 2022 at 12:53:43PM -0800, Lucas De Marchi wrote: > On Wed, Jan 19, 2022 at 05:15:02PM +0100, Daniel Vetter wrote: > > On Wed, Jan 19, 2022 at 04:16:12PM +0200, Jani Nikula wrote: ... > > Yeah we can sed this anytime later we want to, but we need to get the foot > > in the door. Th

Re: [Intel-gfx] [PATCH 2/3] drm/i915/guc: Add work queue to trigger a GT reset

On Wed, Jan 19, 2022 at 01:07:22PM -0800, John Harrison wrote: > On 1/19/2022 12:54, Matthew Brost wrote: > > On Tue, Jan 18, 2022 at 05:37:01PM -0800, John Harrison wrote: > > > On 1/18/2022 13:43, Matthew Brost wrote: > > > > The G2H handler needs to be flushed during a GT reset but a G2H > > > >

[Intel-gfx] [PATCH] drm/i915/guc: Ensure multi-lrc fini breadcrumb math is correct

Realized that the GuC multi-lrc fini breadcrumb emit code is very delicate as the math this code does relies on functions it calls to emit a certain number of DWs. Add a few GEM_BUG_ONs to assert the math is correct. v2: - Rebase + resend for CI (Checkpatch) - Fix blank line warning Signed-o

[Intel-gfx] [PATCH 0/3] Flush G2H handler during a GT reset

After a small fix to error capture code, we now can flush G2H during a GT reset which simplifies code and seals some extreme corner case races. v2: (CI) - Don't trigger GT reset from G2H handler v3: - Address John Harrison's comments Signed-off-by: Matthew Brost Matthew Brost (3): drm/i

[Intel-gfx] [PATCH 2/3] drm/i915/guc: Add work queue to trigger a GT reset

The G2H handler needs to be flushed during a GT reset but a G2H indicating engine reset failure can trigger a GT reset. Add a worker to trigger the GT when an engine reset failure is received to break this circular dependency. v2: (John Harrison) - Store engine reset mask - Fix typo in commit

[Intel-gfx] [PATCH 1/3] drm/i915: Allocate intel_engine_coredump_alloc with ALLOW_FAIL

Allocate intel_engine_coredump_alloc with ALLOW_FAIL rather than GFP_KERNEL to fully decouple the error capture from fence signalling. v2: (John Harrison) - Fix typo in commit message (s/do/to) Fixes: 8b91cdd4f8649 ("drm/i915: Use __GFP_KSWAPD_RECLAIM in the capture code") Signed-off-by: Matt

[Intel-gfx] [PATCH 3/3] drm/i915/guc: Flush G2H handler during a GT reset

Now that the error capture is fully decoupled from fence signalling (request retirement to free memory, which in turn depends on resets) we can safely flush the G2H handler during a GT reset. This is eliminates corner cases where GuC generated G2H (e.g. engine resets) race with a GT reset. v2: (J

[Intel-gfx] ✓ Fi.CI.BAT: success for Add support for querying hw info that UMDs need

== Series Details == Series: Add support for querying hw info that UMDs need URL : https://patchwork.freedesktop.org/series/99060/ State : success == Summary == CI Bug Log - changes from CI_DRM_0 -> Patchwork_22027 Summary --- **

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc: Ensure multi-lrc fini breadcrumb math is correct (rev2)

== Series Details == Series: drm/i915/guc: Ensure multi-lrc fini breadcrumb math is correct (rev2) URL : https://patchwork.freedesktop.org/series/98816/ State : failure == Summary == CI Bug Log - changes from CI_DRM_0 -> Patchwork_22028

Re: [Intel-gfx] [PATCH 0/6] drm/i915: Extend parse_ddi_port() to all g4x+ platforms

On Fri, Dec 17, 2021 at 05:53:57PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Quick attempt at unifying the VBT DDI parsing to all g4x+ > platforms. > > Note that we'll still use the hardware straps as the primary > source of port presence information on old platforms since the > dev

Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

> > except '"no\0\0yes" + v * 4' works a bit better. > > Is it a C code obfuscation contest? That would be: return &(v * 3)["no\0yes"]; :-) - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/bios: Workaround broken video BIOS in LG Gram 2021

== Series Details == Series: drm/i915/bios: Workaround broken video BIOS in LG Gram 2021 URL : https://patchwork.freedesktop.org/series/99052/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11109_full -> Patchwork_22024_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix vma resource freeing (rev2)

== Series Details == Series: drm/i915: Fix vma resource freeing (rev2) URL : https://patchwork.freedesktop.org/series/99055/ State : success == Summary == CI Bug Log - changes from CI_DRM_0 -> Patchwork_22029 Summary --- **SUCCES

[Intel-gfx] [PATCH v4 RESEND] drm/i915/gem: Don't try to map and fence large scanout buffers (v4)

On platforms capable of allowing 8K (7680 x 4320) modes, pinning 2 or more framebuffers/scanout buffers results in only one that is mappable/ fenceable. Therefore, pageflipping between these 2 FBs where only one is mappable/fenceable creates latencies large enough to miss alternate vblanks thereby

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Flush G2H handler during a GT reset (rev3)

== Series Details == Series: Flush G2H handler during a GT reset (rev3) URL : https://patchwork.freedesktop.org/series/98855/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 0/7] DRM kmap() fixes and kmap_local_page() conversions

On Wed, Jan 19, 2022 at 06:24:22PM +0100, Daniel Vetter wrote: > On Wed, Jan 19, 2022 at 08:53:56AM -0800, Ira Weiny wrote: > > On Fri, Dec 10, 2021 at 03:23:57PM -0800, 'Ira Weiny' wrote: > > > From: Ira Weiny > > > > > > This series starts by converting the last easy kmap() uses to > > > kmap_l

[Intel-gfx] ✓ Fi.CI.BAT: success for Flush G2H handler during a GT reset (rev3)

== Series Details == Series: Flush G2H handler during a GT reset (rev3) URL : https://patchwork.freedesktop.org/series/98855/ State : success == Summary == CI Bug Log - changes from CI_DRM_1 -> Patchwork_22030 Summary --- **SUCCE

[Intel-gfx] ✗ Fi.CI.IGT: failure for Add support for querying hw info that UMDs need

== Series Details == Series: Add support for querying hw info that UMDs need URL : https://patchwork.freedesktop.org/series/99060/ State : failure == Summary == CI Bug Log - changes from CI_DRM_0_full -> Patchwork_22027_full Summary ---

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Add support for querying hw info that UMDs need

On 1/19/2022 16:42, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* Add support for querying hw info that UMDs need *URL:* https://patchwork.freedesktop.org/series/99060/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22027/index.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Don't try to map and fence large scanout buffers (v4)

== Series Details == Series: drm/i915/gem: Don't try to map and fence large scanout buffers (v4) URL : https://patchwork.freedesktop.org/series/99074/ State : success == Summary == CI Bug Log - changes from CI_DRM_1 -> Patchwork_22031 S

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Ensure multi-lrc fini breadcrumb math is correct (rev3)

== Series Details == Series: drm/i915/guc: Ensure multi-lrc fini breadcrumb math is correct (rev3) URL : https://patchwork.freedesktop.org/series/98816/ State : success == Summary == CI Bug Log - changes from CI_DRM_1 -> Patchwork_22032

  1   2   >