✓ Fi.CI.BAT: success for drm/i915: Implemnt vblank sycnhronized mbus joining changes (rev4)

2024-04-03 Thread Patchwork
== Series Details == Series: drm/i915: Implemnt vblank sycnhronized mbus joining changes (rev4) URL : https://patchwork.freedesktop.org/series/131700/ State : success == Summary == CI Bug Log - changes from CI_DRM_14520 -> Patchwork_131700v4

✓ Fi.CI.BAT: success for Enable Aux Based EDP HDR

2024-04-03 Thread Patchwork
== Series Details == Series: Enable Aux Based EDP HDR URL : https://patchwork.freedesktop.org/series/132009/ State : success == Summary == CI Bug Log - changes from CI_DRM_14522 -> Patchwork_132009v1 Summary --- **SUCCESS** No reg

✗ Fi.CI.SPARSE: warning for Enable Aux Based EDP HDR

2024-04-03 Thread Patchwork
== Series Details == Series: Enable Aux Based EDP HDR URL : https://patchwork.freedesktop.org/series/132009/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1: warning: u

[PATCH 7/7] drm/i915/dp: Limit brightness level to 20

2024-04-03 Thread Suraj Kandpal
Limit minimum brightness to 20 when using aux based brightness control to avoid letting the screen going completely blank. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/display/in

[PATCH 6/7] drm/i915/dp: Write panel override luminance values

2024-04-03 Thread Suraj Kandpal
Write panel override luminance values which helps the TCON decide if tone mapping needs to be enabled or not. Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_dp_aux_backlight.c | 25 +++ 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel

[PATCH 5/7] drm/i915/dp: Enable AUX based backlight for HDR

2024-04-03 Thread Suraj Kandpal
As of now whenerver HDR is switched on we use the PWM to change the backlight as opposed to AUX based backlight changes in terms of nits. This patch writes to the appropriate DPCD registers to enable aux based backlight using values in nits. --v2 -Fix max_cll and max_fall assignment [Jani] -Fix th

[PATCH 4/7] drm/i915/dp: Fix comments on EDP HDR DPCD registers

2024-04-03 Thread Suraj Kandpal
Change comments from Pre-TGL+ to Pre-ICL as mentioned in specs Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i

[PATCH 3/7] drm/i915/dp: Fix Register bit naming

2024-04-03 Thread Suraj Kandpal
Change INTEL_EDP_HDR_TCON_SDP_COLORIMETRY enable to INTEL_EDP_HDR_TCON_SDP_OVERRIDE_AUX as this bit is tells TCON to ignore DPCD colorimetry values and take the one's sent through SDP. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 2 +- 1 file changed,

[PATCH 2/7] drm/i915/dp: Add TCON HDR capability checks

2024-04-03 Thread Suraj Kandpal
Add checks to see the HDR capability of TCON panel. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_display_types.h| 5 + drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 10 ++ 2 files changed, 15 insertions(+) diff --git a/drivers/gpu/drm/i915/displ

[PATCH 1/7] drm/i915/dp: Make has_gamut_metadata_dip() non static

2024-04-03 Thread Suraj Kandpal
Make has_gamut_metadata_dip() non static so it can also be used to at other places eg in intel_dp_aux_backlight. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp.c | 6 +++--- drivers/gpu/drm/i915/display/intel_dp.h | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) d

[PATCH 0/7] Enable Aux Based EDP HDR

2024-04-03 Thread Suraj Kandpal
This series enables Aux based EDP HDR and backlight controls. The DPCD written to are intel proprietary and are filled based on the specs that were provided to TCON vendors. Signed-off-by: Suraj Kandpal Suraj Kandpal (7): drm/i915/dp: Make has_gamut_metadata_dip() non static drm/i915/dp: Add

Re: [PATCH] drm/i915/guc: Fix the fix for reset lock confusion

2024-04-03 Thread Andi Shyti
Hi John, On Fri, Mar 29, 2024 at 04:53:05PM -0700, john.c.harri...@intel.com wrote: > From: John Harrison > > The previous fix for the circlular lock splat about the busyness > worker wasn't quite complete. Even though the reset-in-progress flag > is cleared at the start of intel_uc_reset_finish

Re: [PATCH v2 19/25] drm/i915/xe2hpd: Do not program MBUS_DBOX BW credits

2024-04-03 Thread Matt Roper
On Wed, Apr 03, 2024 at 04:52:47PM +0530, Balasubramani Vivekanandan wrote: > From: José Roberto de Souza > > Xe2_HPD doesn't have DBOX BW credits, so here programing it with > zero. > > BSpec: 49213 > Signed-off-by: José Roberto de Souza > Signed-off-by: Balasubramani Vivekanandan > > --- >

Re: [PATCH v2 13/25] drm/i915/xe2hpd: Add display info

2024-04-03 Thread Matt Roper
On Wed, Apr 03, 2024 at 04:52:41PM +0530, Balasubramani Vivekanandan wrote: > From: Lucas De Marchi > > Add initial display info for xe2hpd. It is similar to xelpd, but with no > PORT_B. > > Bspec: 67066 > Signed-off-by: Lucas De Marchi > Signed-off-by: Balasubramani Vivekanandan > > --- > .

Re: [PATCH v2 14/25] drm/i915/xe2hpd: Add missing chicken bit register programming

2024-04-03 Thread Matt Roper
On Wed, Apr 03, 2024 at 04:52:42PM +0530, Balasubramani Vivekanandan wrote: > From: Anusha Srivatsa > > Add step 9 from initialize display sequence. > > Bpsec: 49189 > Signed-off-by: Anusha Srivatsa > Signed-off-by: Balasubramani Vivekanandan > I think the title here is misleading since "mis

Re: [PATCH v2 12/25] drm/i915/xe2hpd: update pll values in sync with Bspec

2024-04-03 Thread Matt Roper
On Wed, Apr 03, 2024 at 04:52:40PM +0530, Balasubramani Vivekanandan wrote: > From: Ravi Kumar Vodapalli > > DP/eDP and HDMI pll values are updated for Xe2_HPD platform > > Bspec: 74165 > Signed-off-by: Ravi Kumar Vodapalli > Signed-off-by: Balasubramani Vivekanandan > > --- > drivers/gpu/dr

Re: [PATCH v2 11/25] drm/i915/xe2hpd: Add support for eDP PLL configuration

2024-04-03 Thread Matt Roper
On Wed, Apr 03, 2024 at 04:52:39PM +0530, Balasubramani Vivekanandan wrote: > Tables for eDP PHY PLL configuration for different link rates added for > Xe2_HPD. Previous platforms were using C10 PHY for eDP port whereas > Xe2_HPD has C20 PHY. > > Bpsec: 64568 I think 74165 would be more accurate?

Re: [PATCH v2 09/25] drm/i915/xe2hpd: Properly disable power in port A

2024-04-03 Thread Matt Roper
On Wed, Apr 03, 2024 at 04:52:37PM +0530, Balasubramani Vivekanandan wrote: > From: José Roberto de Souza > > Xe2_HPD has a different value to power down port A. > > BSpec: 65450 > CC: Matt Roper > Signed-off-by: José Roberto de Souza > Signed-off-by: Balasubramani Vivekanandan > Reviewed-b

Re: [PATCH v2 08/25] drm/i915/bmg: Extend DG2 tc check to future

2024-04-03 Thread Matt Roper
On Wed, Apr 03, 2024 at 04:52:36PM +0530, Balasubramani Vivekanandan wrote: > From: Radhakrishna Sripada > > Discrete cards use the Port numbers TC1-4 for the offsets. The regular > flow for type-c subsystem port initialization can be skipped. This check > is present in DG2. Extend this to future

Re: [PATCH v2 07/25] Revert "drm/i915/dgfx: DGFX uses direct VBT pin mapping"

2024-04-03 Thread Matt Roper
On Wed, Apr 03, 2024 at 04:52:35PM +0530, Balasubramani Vivekanandan wrote: > From: Ankit Nautiyal > > This reverts commit 562f33836f519a235e5c5e71bcc723ab1faccd2f. > For BMG it seems that the VBT to DDI mapping does not follow DG1, and > DG2, but follows ADLP mapping given in Bspec:20124. > > S

Re: [PATCH v2 06/25] drm/i915/xe2hpd: Initial cdclk table

2024-04-03 Thread Matt Roper
On Wed, Apr 03, 2024 at 04:52:34PM +0530, Balasubramani Vivekanandan wrote: > From: Clint Taylor > > Add Xe2_HPD specific CDCLK table and use MTL Funcs. > > Bspec: 65243 > Cc: Matt Roper > CC: Lucas De Marchi > Signed-off-by: Clint Taylor > Signed-off-by: Balasubramani Vivekanandan > Revie

Re: [PATCH v2 05/25] drm/i915/xe2: Skip CCS modifiers for Xe2 platforms

2024-04-03 Thread Matt Roper
On Wed, Apr 03, 2024 at 04:52:33PM +0530, Balasubramani Vivekanandan wrote: > Xe2 platforms doesn't support Aux CCS and the Flat CCS is enabled > through PAT. No CCS modifiers required for Xe2 platforms. The change looks correct, but you might want to elaborate on this description a bit to help cl

Re: [PATCH] drm/xe/display: fix potential overflow when multiplying 2 u32

2024-04-03 Thread Rodrigo Vivi
On Wed, Apr 03, 2024 at 03:39:19PM +, Murthy, Arun R wrote: > Gentle Reminder! Thanks for your patch. I'm convinced we really need something like this. At least to shout the static analyzers. Or this or using the mul_u32_u32 or casting one of the right operands, otherwise the result of the m

Re: [PATCH] drm/i915/guc: Remove bogus null check

2024-04-03 Thread Rodrigo Vivi
On Fri, Mar 29, 2024 at 07:38:11PM +0300, Dan Carpenter wrote: > On Fri, Mar 29, 2024 at 08:09:38AM +0100, Andi Shyti wrote: > > Hi Rodrigo, > > > > On Thu, Mar 28, 2024 at 09:39:17PM -0400, Rodrigo Vivi wrote: > > > On Thu, Mar 28, 2024 at 10:41:55PM +0100, Andi Shyti wrote: > > > > On Thu, Mar 2

Re: [PATCH v2 04/25] drm/i915/bmg: Define IS_BATTLEMAGE macro

2024-04-03 Thread Matt Roper
On Wed, Apr 03, 2024 at 04:52:32PM +0530, Balasubramani Vivekanandan wrote: > Display code uses IS_BATTLEMAGE macro but the platform support doesn't > still exist in i915. So fake IS_BATTLEMAGE macro defined to enable I'd drop the "still" here since that wording would incorrectly imply that i915 h

Re: [PATCH v2 03/25] drm/xe/bmg: Define IS_BATTLEMAGE macro

2024-04-03 Thread Matt Roper
On Wed, Apr 03, 2024 at 04:52:31PM +0530, Balasubramani Vivekanandan wrote: > Common display code requires IS_BATTLEMAGE macro. Defined the macro. > > Signed-off-by: Balasubramani Vivekanandan > Reviewed-by: Matt Roper > --- > drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h | 1 + > 1 file

Re: [PATCH v2 18/25] drm/i915/display: Enable RM timeout detection

2024-04-03 Thread Matt Roper
On Wed, Apr 03, 2024 at 04:52:46PM +0530, Balasubramani Vivekanandan wrote: > From: Mitul Golani > > Enable RM timeout interrupt to detect any hang during display engine > register access. This interrupt is supported only on Display version 14. This doesn't seem to be true. Bit 29 of the IIR re

[linux-next:master] BUILD REGRESSION 727900b675b749c40ba1f6669c7ae5eb7eb8e837

2024-04-03 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 727900b675b749c40ba1f6669c7ae5eb7eb8e837 Add linux-next specific files for 20240403 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202404031246.aq5yr5ko-...@intel.com https

Re: [PATCH 01/13] drm/i915/cdclk: Fix CDCLK programming order when pipes are active

2024-04-03 Thread Ville Syrjälä
On Fri, Mar 29, 2024 at 12:29:09PM -0300, Gustavo Sousa wrote: > Quoting Ville Syrjala (2024-03-27 14:45:32-03:00) > >From: Ville Syrjälä > > > >Currently we always reprogram CDCLK from the > >intel_set_cdclk_pre_plane_update() when using squahs/crawl. > >The code only works correctly for the cd2x

✗ Fi.CI.BAT: failure for drm/xe/display: check for error on drmm_mutex_init (rev4)

2024-04-03 Thread Patchwork
== Series Details == Series: drm/xe/display: check for error on drmm_mutex_init (rev4) URL : https://patchwork.freedesktop.org/series/131301/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14521 -> Patchwork_131301v4 Summary

RE: [PATCH] drm/xe/display: fix potential overflow when multiplying 2 u32

2024-04-03 Thread Murthy, Arun R
Gentle Reminder! Thanks and Regards, Arun R Murthy > -Original Message- > From: Intel-gfx On Behalf Of Murthy, > Arun R > Sent: Thursday, March 28, 2024 10:34 AM > To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org > Subject: RE: [PATCH] drm/xe/displ

Re: [PATCHv2] drm/xe/display: check for error on drmm_mutex_init

2024-04-03 Thread Lucas De Marchi
On Thu, Mar 28, 2024 at 12:33:09PM +0200, Jani Nikula wrote: On Thu, 28 Mar 2024, Andi Shyti wrote: Hi Arun, ... - drmm_mutex_init(&xe->drm, &xe->sb_lock); - drmm_mutex_init(&xe->drm, &xe->display.backlight.lock); - drmm_mutex_init(&xe->drm, &xe->display.audio.mutex); -

[PATCHv3] drm/xe/display: check for error on drmm_mutex_init

2024-04-03 Thread Arun R Murthy
Check return value for drmm_mutex_init as it can fail and return on failure. v2: Removed nested if (Lucas) v3: Revert back to nested if (Andi) Signed-off-by: Arun R Murthy --- drivers/gpu/drm/xe/display/xe_display.c | 30 - 1 file changed, 24 insertions(+), 6 deletions(-

✗ Fi.CI.SPARSE: warning for drm/i915: Implemnt vblank sycnhronized mbus joining changes (rev4)

2024-04-03 Thread Patchwork
== Series Details == Series: drm/i915: Implemnt vblank sycnhronized mbus joining changes (rev4) URL : https://patchwork.freedesktop.org/series/131700/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH v2 02/25] drm/xe/bmg: Add BMG platform definition

2024-04-03 Thread Lucas De Marchi
On Wed, Apr 03, 2024 at 04:52:30PM +0530, Balasubramani Vivekanandan wrote: diff --git a/include/drm/xe_pciids.h b/include/drm/xe_pciids.h index c7fc288dacee..73d972a8aca1 100644 --- a/include/drm/xe_pciids.h +++ b/include/drm/xe_pciids.h @@ -208,4 +208,11 @@ MACRO__(0x64A0, ## __VA_ARGS_

[PATCH v4] drm/i915: limit eDP MSO pipe only for display version 20 and below

2024-04-03 Thread Luca Coelho
The pipes that can be used for eDP MSO are limited to pipe A (and sometimes also pipe B) only for display version 20 and below. Modify the function that returns the pipe mask for eDP MSO so that these limitations only apply to version 20 and below, enabling all pipes otherwise. Bspec: 68923 Cc: J

Re: [PATCH v2 23/25] drm/xe/device: implement transient flush

2024-04-03 Thread Nirmoy Das
Hi Bala, On 4/3/2024 1:22 PM, Balasubramani Vivekanandan wrote: From: Nirmoy Das Display surfaces can be tagged as transient by mapping it using one of the various L3:XD PAT index modes on Xe2. The expectation is that KMD needs to request transient data flush at the start of flip sequence to e

Re: [PATCH v2 24/25] drm/i915/display: perform transient flush

2024-04-03 Thread Nirmoy Das
+Jouni On 4/3/2024 1:22 PM, Balasubramani Vivekanandan wrote: From: Matthew Auld Perform manual transient cache flush prior to flip and at the end of frontbuffer_flush. This is needed to ensure display engine doesn't see garbage if the surface is L3:XD dirty. Testcase: igt@xe-pat@display-vs-w

Re: [PATCH 01/11] drm/i915/dp: Fix DSC line buffer depth programming

2024-04-03 Thread Jani Nikula
On Thu, 28 Mar 2024, Imre Deak wrote: > On Wed, Mar 20, 2024 at 10:11:41PM +0200, Imre Deak wrote: >> Fix the calculation of the DSC line buffer depth. This is limited both >> by the source's and sink's maximum line buffer depth, but the former one >> was not taken into account. On all Intel platf

Re: [PATCH v2 22/25] drm/xe/gt_print: add xe_gt_err_once()

2024-04-03 Thread Nirmoy Das
On 4/3/2024 1:22 PM, Balasubramani Vivekanandan wrote: From: Matthew Auld Needed in an upcoming patch, where we want GT level print, but only which to trigger once to avoid flooding dmesg. Signed-off-by: Matthew Auld Signed-off-by: Balasubramani Vivekanandan Reviewed-by: Nirmoy Das ---

Re: [PATCH v2 10/25] drm/i915/xe2hpd: Add new C20 PLL register address

2024-04-03 Thread Jani Nikula
On Wed, 03 Apr 2024, Balasubramani Vivekanandan wrote: > Xe2_HPD has different address for C20 PLL registers. Enable the support > to use the right PLL register address based on display version. > > Note that Xe2_LPD uses the same C20 SRAM offsets used by Xe_LPDP (i.e. > MTL's display). According

Re: [PATCH v2 18/25] drm/i915/display: Enable RM timeout detection

2024-04-03 Thread Jani Nikula
On Wed, 03 Apr 2024, Balasubramani Vivekanandan wrote: > From: Mitul Golani > > Enable RM timeout interrupt to detect any hang during display engine > register access. This interrupt is supported only on Display version 14. > Current default timeout is 2ms. > > WA: 14012195489 Please don't inve

✓ Fi.CI.BAT: success for Enable dislay support for Battlemage (rev2)

2024-04-03 Thread Patchwork
== Series Details == Series: Enable dislay support for Battlemage (rev2) URL : https://patchwork.freedesktop.org/series/131984/ State : success == Summary == CI Bug Log - changes from CI_DRM_14520 -> Patchwork_131984v2 Summary --- **

Re: [PATCH v2 16/25] drm/xe/xe2hpd: Define a new DRAM type INTEL_DRAM_GDDR

2024-04-03 Thread Jani Nikula
On Wed, 03 Apr 2024, Balasubramani Vivekanandan wrote: > Defined a new DRAM type to be used in the following patches. > The following patch first makes use of this new type in the i915 > display. So without this define, build would fail when the shared > display code is built for Xe. Just make i

Re: [PATCH v2 15/25] drm/xe/display: Lane reversal requires writes to both context lanes

2024-04-03 Thread Jani Nikula
On Wed, 03 Apr 2024, Balasubramani Vivekanandan wrote: > From: Clint Taylor > > Write both CX0 Lanes for Context Toggle for all except TC pin assignment D. Seems like a fix that should be the first patch in the series, no? > BSPEC: 64539 The spelling is "Bspec". > Signed-off-by: Clint Taylor

✗ Fi.CI.SPARSE: warning for Enable dislay support for Battlemage (rev2)

2024-04-03 Thread Patchwork
== Series Details == Series: Enable dislay support for Battlemage (rev2) URL : https://patchwork.freedesktop.org/series/131984/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Enable dislay support for Battlemage (rev2)

2024-04-03 Thread Patchwork
== Series Details == Series: Enable dislay support for Battlemage (rev2) URL : https://patchwork.freedesktop.org/series/131984/ State : warning == Summary == Error: dim checkpatch failed 240c4657f7c1 drm/i915/display: Prepare to handle new C20 PLL register address -:75: WARNING:LONG_LINE: line

Re: [PATCH v2 01/25] drm/i915/display: Prepare to handle new C20 PLL register address

2024-04-03 Thread Jani Nikula
On Wed, 03 Apr 2024, Balasubramani Vivekanandan wrote: > New platforms have different addresses for C20 PLL registers. This patch > prepares the driver to work with different register addresses. > New structure `struct intel_c20pll_reg` is created to hold the register > addresses for each platfor

[PATCH v2 25/25] drm/xe/bmg: Enable the display support

2024-04-03 Thread Balasubramani Vivekanandan
Enable the display support for Battlemage Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/xe/xe_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c index b3158053baee..835c18ec8fb9 100644 --- a/drivers/gpu/drm/xe/xe_pc

[PATCH v2 24/25] drm/i915/display: perform transient flush

2024-04-03 Thread Balasubramani Vivekanandan
From: Matthew Auld Perform manual transient cache flush prior to flip and at the end of frontbuffer_flush. This is needed to ensure display engine doesn't see garbage if the surface is L3:XD dirty. Testcase: igt@xe-pat@display-vs-wb-transient Signed-off-by: Matthew Auld Signed-off-by: Balasubra

[PATCH v2 23/25] drm/xe/device: implement transient flush

2024-04-03 Thread Balasubramani Vivekanandan
From: Nirmoy Das Display surfaces can be tagged as transient by mapping it using one of the various L3:XD PAT index modes on Xe2. The expectation is that KMD needs to request transient data flush at the start of flip sequence to ensure all transient data in L3 cache is flushed to memory. Add a ro

[PATCH v2 22/25] drm/xe/gt_print: add xe_gt_err_once()

2024-04-03 Thread Balasubramani Vivekanandan
From: Matthew Auld Needed in an upcoming patch, where we want GT level print, but only which to trigger once to avoid flooding dmesg. Signed-off-by: Matthew Auld Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/xe/xe_gt_printk.h | 3 +++ 1 file changed, 3 insertions(+) diff --gi

[PATCH v2 21/25] drm/i915/xe2hpd: Set maximum DP rate to UHBR13.5

2024-04-03 Thread Balasubramani Vivekanandan
Max supported speed by xe2hpd is UHBR13.5. Limit the max DP source rate to it. Bspec: 67066 Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/display/intel_dp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i91

[PATCH v2 20/25] drm/i915/bmg: BMG should re-use MTL's south display logic

2024-04-03 Thread Balasubramani Vivekanandan
From: Matt Roper Battlemage's south display is the same as Meteor Lake's, including the need to invert the HPD pins, which Lunar Lake does not need. Signed-off-by: Matt Roper Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/soc/intel_pch.c | 4 ++-- 1 file changed, 2 inserti

[PATCH v2 19/25] drm/i915/xe2hpd: Do not program MBUS_DBOX BW credits

2024-04-03 Thread Balasubramani Vivekanandan
From: José Roberto de Souza Xe2_HPD doesn't have DBOX BW credits, so here programing it with zero. BSpec: 49213 Signed-off-by: José Roberto de Souza Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/display/skl_watermark.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2 18/25] drm/i915/display: Enable RM timeout detection

2024-04-03 Thread Balasubramani Vivekanandan
From: Mitul Golani Enable RM timeout interrupt to detect any hang during display engine register access. This interrupt is supported only on Display version 14. Current default timeout is 2ms. WA: 14012195489 Bspec: 50110 CC: Suraj Kandpal Signed-off-by: Mitul Golani Signed-off-by: Balasubram

[PATCH v2 17/25] drm/i915/xe2hpd: Add max memory bandwidth algorithm

2024-04-03 Thread Balasubramani Vivekanandan
From: Matt Roper Unlike DG2, Xe2_HPD does support multiple GV points with different maximum memory bandwidths, but uses a much simpler algorithm than igpu platforms use. Bspec: 64631 Signed-off-by: Matt Roper Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/display/intel_bw.

[PATCH v2 16/25] drm/xe/xe2hpd: Define a new DRAM type INTEL_DRAM_GDDR

2024-04-03 Thread Balasubramani Vivekanandan
Defined a new DRAM type to be used in the following patches. The following patch first makes use of this new type in the i915 display. So without this define, build would fail when the shared display code is built for Xe. Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/xe/xe_device

[PATCH v2 15/25] drm/xe/display: Lane reversal requires writes to both context lanes

2024-04-03 Thread Balasubramani Vivekanandan
From: Clint Taylor Write both CX0 Lanes for Context Toggle for all except TC pin assignment D. BSPEC: 64539 Signed-off-by: Clint Taylor Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

[PATCH v2 14/25] drm/i915/xe2hpd: Add missing chicken bit register programming

2024-04-03 Thread Balasubramani Vivekanandan
From: Anusha Srivatsa Add step 9 from initialize display sequence. Bpsec: 49189 Signed-off-by: Anusha Srivatsa Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/display/intel_display_power.c | 4 drivers/gpu/drm/i915/i915_reg.h| 1 + 2 files changed,

[PATCH v2 13/25] drm/i915/xe2hpd: Add display info

2024-04-03 Thread Balasubramani Vivekanandan
From: Lucas De Marchi Add initial display info for xe2hpd. It is similar to xelpd, but with no PORT_B. Bspec: 67066 Signed-off-by: Lucas De Marchi Signed-off-by: Balasubramani Vivekanandan --- .../gpu/drm/i915/display/intel_display_device.c | 16 1 file changed, 16 insertion

[PATCH v2 12/25] drm/i915/xe2hpd: update pll values in sync with Bspec

2024-04-03 Thread Balasubramani Vivekanandan
From: Ravi Kumar Vodapalli DP/eDP and HDMI pll values are updated for Xe2_HPD platform Bspec: 74165 Signed-off-by: Ravi Kumar Vodapalli Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 47 +++- 1 file changed, 45 insertions(+), 2 del

[PATCH v2 11/25] drm/i915/xe2hpd: Add support for eDP PLL configuration

2024-04-03 Thread Balasubramani Vivekanandan
Tables for eDP PHY PLL configuration for different link rates added for Xe2_HPD. Previous platforms were using C10 PHY for eDP port whereas Xe2_HPD has C20 PHY. Bpsec: 64568 CC: Clint Taylor Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 147 ++

[PATCH v2 10/25] drm/i915/xe2hpd: Add new C20 PLL register address

2024-04-03 Thread Balasubramani Vivekanandan
Xe2_HPD has different address for C20 PLL registers. Enable the support to use the right PLL register address based on display version. Note that Xe2_LPD uses the same C20 SRAM offsets used by Xe_LPDP (i.e. MTL's display). According to the BSpec, currently, only Xe2_HPD has different offsets, so m

[PATCH v2 09/25] drm/i915/xe2hpd: Properly disable power in port A

2024-04-03 Thread Balasubramani Vivekanandan
From: José Roberto de Souza Xe2_HPD has a different value to power down port A. BSpec: 65450 CC: Matt Roper Signed-off-by: José Roberto de Souza Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 17 ++--- 1 file changed, 14 insertions(+)

[PATCH v2 08/25] drm/i915/bmg: Extend DG2 tc check to future

2024-04-03 Thread Balasubramani Vivekanandan
From: Radhakrishna Sripada Discrete cards use the Port numbers TC1-4 for the offsets. The regular flow for type-c subsystem port initialization can be skipped. This check is present in DG2. Extend this to future discrete products. Signed-off-by: Radhakrishna Sripada Signed-off-by: Balasubramani

[PATCH v2 07/25] Revert "drm/i915/dgfx: DGFX uses direct VBT pin mapping"

2024-04-03 Thread Balasubramani Vivekanandan
From: Ankit Nautiyal This reverts commit 562f33836f519a235e5c5e71bcc723ab1faccd2f. For BMG it seems that the VBT to DDI mapping does not follow DG1, and DG2, but follows ADLP mapping given in Bspec:20124. Signed-off-by: Ankit Nautiyal Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/

[PATCH v2 06/25] drm/i915/xe2hpd: Initial cdclk table

2024-04-03 Thread Balasubramani Vivekanandan
From: Clint Taylor Add Xe2_HPD specific CDCLK table and use MTL Funcs. Bspec: 65243 Cc: Matt Roper CC: Lucas De Marchi Signed-off-by: Clint Taylor Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/display/intel_cdclk.c | 11 +++ 1 file changed, 11 insertions(+) dif

[PATCH v2 05/25] drm/i915/xe2: Skip CCS modifiers for Xe2 platforms

2024-04-03 Thread Balasubramani Vivekanandan
Xe2 platforms doesn't support Aux CCS and the Flat CCS is enabled through PAT. No CCS modifiers required for Xe2 platforms. Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/display/intel_fb.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/dr

[PATCH v2 04/25] drm/i915/bmg: Define IS_BATTLEMAGE macro

2024-04-03 Thread Balasubramani Vivekanandan
Display code uses IS_BATTLEMAGE macro but the platform support doesn't still exist in i915. So fake IS_BATTLEMAGE macro defined to enable building i915 code. We should make sure the macro parameter is used in the always-false expression so that we don't run into "unused variable" warnings from i91

[PATCH v2 03/25] drm/xe/bmg: Define IS_BATTLEMAGE macro

2024-04-03 Thread Balasubramani Vivekanandan
Common display code requires IS_BATTLEMAGE macro. Defined the macro. Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h b/drivers/gpu/drm/xe/compat-

[PATCH v2 02/25] drm/xe/bmg: Add BMG platform definition

2024-04-03 Thread Balasubramani Vivekanandan
From: Matt Roper BMG is a discrete GPU based on the Xe2 architecture. Bspec: 68090 Signed-off-by: Matt Roper Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/xe/xe_pci.c| 7 +++ drivers/gpu/drm/xe/xe_platform_types.h | 1 + include/drm/xe_pciids.h|

[PATCH v2 01/25] drm/i915/display: Prepare to handle new C20 PLL register address

2024-04-03 Thread Balasubramani Vivekanandan
New platforms have different addresses for C20 PLL registers. This patch prepares the driver to work with different register addresses. New structure `struct intel_c20pll_reg` is created to hold the register addresses for each platform with different register address. CC: Clint Taylor Signed-off-

[PATCH v2 00/25] Enable dislay support for Battlemage

2024-04-03 Thread Balasubramani Vivekanandan
Adds display support for Battlemage. Reuses the patch "drm/xe/bmg: Add BMG platform definition" from the patch series to help build this series. So that review on this series can continue without blocking on . v2: Rebased on latest drm-tip Ankit Nautiyal (1): Revert "drm/i915/dgfx: DGFX uses d

✗ Fi.CI.BUILD: failure for Enable dislay support for Battlemage

2024-04-03 Thread Patchwork
== Series Details == Series: Enable dislay support for Battlemage URL : https://patchwork.freedesktop.org/series/131984/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/131984/revisions/1/mbox/ not applied Applying: drm/i915/display: Prepare to han

Re: [PATCH 23/25] drm/xe/device: implement transient flush

2024-04-03 Thread Nirmoy Das
There is new fixup patch(PR#630) which modifies this patch. Could you please bring that in as well. Regards, Nirmoy On 4/3/2024 12:51 PM, Balasubramani Vivekanandan wrote: From: Nirmoy Das Display surfaces can be tagged as transient by mapping it using one of the various L3:XD PAT index mo

[PATCH 25/25] drm/xe/bmg: Enable the display support

2024-04-03 Thread Balasubramani Vivekanandan
Enable the display support for Battlemage Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/xe/xe_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c index b3158053baee..835c18ec8fb9 100644 --- a/drivers/gpu/drm/xe/xe_pc

[PATCH 24/25] drm/i915/display: perform transient flush

2024-04-03 Thread Balasubramani Vivekanandan
From: Matthew Auld Perform manual transient cache flush prior to flip and at the end of frontbuffer_flush. This is needed to ensure display engine doesn't see garbage if the surface is L3:XD dirty. Testcase: igt@xe-pat@display-vs-wb-transient Signed-off-by: Matthew Auld Signed-off-by: Balasubra

[PATCH 23/25] drm/xe/device: implement transient flush

2024-04-03 Thread Balasubramani Vivekanandan
From: Nirmoy Das Display surfaces can be tagged as transient by mapping it using one of the various L3:XD PAT index modes on Xe2. The expectation is that KMD needs to request transient data flush at the start of flip sequence to ensure all transient data in L3 cache is flushed to memory. Add a ro

[PATCH 22/25] drm/xe/gt_print: add xe_gt_err_once()

2024-04-03 Thread Balasubramani Vivekanandan
From: Matthew Auld Needed in an upcoming patch, where we want GT level print, but only which to trigger once to avoid flooding dmesg. Signed-off-by: Matthew Auld Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/xe/xe_gt_printk.h | 3 +++ 1 file changed, 3 insertions(+) diff --gi

[PATCH 21/25] drm/i915/xe2hpd: Set maximum DP rate to UHBR13.5

2024-04-03 Thread Balasubramani Vivekanandan
Max supported speed by xe2hpd is UHBR13.5. Limit the max DP source rate to it. Bspec: 67066 Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/display/intel_dp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i91

[PATCH 20/25] drm/i915/bmg: BMG should re-use MTL's south display logic

2024-04-03 Thread Balasubramani Vivekanandan
From: Matt Roper Battlemage's south display is the same as Meteor Lake's, including the need to invert the HPD pins, which Lunar Lake does not need. Signed-off-by: Matt Roper Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/soc/intel_pch.c | 4 ++-- 1 file changed, 2 inserti

[PATCH 19/25] drm/i915/xe2hpd: Do not program MBUS_DBOX BW credits

2024-04-03 Thread Balasubramani Vivekanandan
From: José Roberto de Souza Xe2_HPD doesn't have DBOX BW credits, so here programing it with zero. BSpec: 49213 Signed-off-by: José Roberto de Souza Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/display/skl_watermark.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 15/25] drm/xe/display: Lane reversal requires writes to both context lanes

2024-04-03 Thread Balasubramani Vivekanandan
From: Clint Taylor Write both CX0 Lanes for Context Toggle for all except TC pin assignment D. BSPEC: 64539 Signed-off-by: Clint Taylor Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

[PATCH 18/25] drm/i915/display: Enable RM timeout detection

2024-04-03 Thread Balasubramani Vivekanandan
From: Mitul Golani Enable RM timeout interrupt to detect any hang during display engine register access. This interrupt is supported only on Display version 14. Current default timeout is 2ms. WA: 14012195489 Bspec: 50110 CC: Suraj Kandpal Signed-off-by: Mitul Golani Signed-off-by: Balasubram

[PATCH 17/25] drm/i915/xe2hpd: Add max memory bandwidth algorithm

2024-04-03 Thread Balasubramani Vivekanandan
From: Matt Roper Unlike DG2, Xe2_HPD does support multiple GV points with different maximum memory bandwidths, but uses a much simpler algorithm than igpu platforms use. Bspec: 64631 Signed-off-by: Matt Roper Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/display/intel_bw.

[PATCH 16/25] drm/xe/xe2hpd: Define a new DRAM type INTEL_DRAM_GDDR

2024-04-03 Thread Balasubramani Vivekanandan
Defined a new DRAM type to be used in the following patches. The following patch first makes use of this new type in the i915 display. So without this define, build would fail when the shared display code is built for Xe. Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/xe/xe_device

[PATCH 08/25] drm/i915/bmg: Extend DG2 tc check to future

2024-04-03 Thread Balasubramani Vivekanandan
From: Radhakrishna Sripada Discrete cards use the Port numbers TC1-4 for the offsets. The regular flow for type-c subsystem port initialization can be skipped. This check is present in DG2. Extend this to future discrete products. Signed-off-by: Radhakrishna Sripada Signed-off-by: Balasubramani

[PATCH 12/25] drm/i915/xe2hpd: update pll values in sync with Bspec

2024-04-03 Thread Balasubramani Vivekanandan
From: Ravi Kumar Vodapalli DP/eDP and HDMI pll values are updated for Xe2_HPD platform Bspec: 74165 Signed-off-by: Ravi Kumar Vodapalli Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 47 +++- 1 file changed, 45 insertions(+), 2 del

[PATCH 14/25] drm/i915/xe2hpd: Add missing chicken bit register programming

2024-04-03 Thread Balasubramani Vivekanandan
From: Anusha Srivatsa Add step 9 from initialize display sequence. Bpsec: 49189 Signed-off-by: Anusha Srivatsa Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/display/intel_display_power.c | 4 drivers/gpu/drm/i915/i915_reg.h| 1 + 2 files changed,

[PATCH 09/25] drm/i915/xe2hpd: Properly disable power in port A

2024-04-03 Thread Balasubramani Vivekanandan
From: José Roberto de Souza Xe2_HPD has a different value to power down port A. BSpec: 65450 CC: Matt Roper Signed-off-by: José Roberto de Souza Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 17 ++--- 1 file changed, 14 insertions(+)

[PATCH 13/25] drm/i915/xe2hpd: Add display info

2024-04-03 Thread Balasubramani Vivekanandan
From: Lucas De Marchi Add initial display info for xe2hpd. It is similar to xelpd, but with no PORT_B. Bspec: 67066 Signed-off-by: Lucas De Marchi Signed-off-by: Balasubramani Vivekanandan --- .../gpu/drm/i915/display/intel_display_device.c | 16 1 file changed, 16 insertion

[PATCH 10/25] drm/i915/xe2hpd: Add new C20 PLL register address

2024-04-03 Thread Balasubramani Vivekanandan
Xe2_HPD has different address for C20 PLL registers. Enable the support to use the right PLL register address based on display version. Note that Xe2_LPD uses the same C20 SRAM offsets used by Xe_LPDP (i.e. MTL's display). According to the BSpec, currently, only Xe2_HPD has different offsets, so m

[PATCH 07/25] Revert "drm/i915/dgfx: DGFX uses direct VBT pin mapping"

2024-04-03 Thread Balasubramani Vivekanandan
From: Ankit Nautiyal This reverts commit 562f33836f519a235e5c5e71bcc723ab1faccd2f. For BMG it seems that the VBT to DDI mapping does not follow DG1, and DG2, but follows ADLP mapping given in Bspec:20124. Signed-off-by: Ankit Nautiyal Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/

[PATCH 11/25] drm/i915/xe2hpd: Add support for eDP PLL configuration

2024-04-03 Thread Balasubramani Vivekanandan
Tables for eDP PHY PLL configuration for different link rates added for Xe2_HPD. Previous platforms were using C10 PHY for eDP port whereas Xe2_HPD has C20 PHY. Bpsec: 64568 CC: Clint Taylor Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 147 ++

[PATCH 05/25] drm/i915/xe2: Skip CCS modifiers for Xe2 platforms

2024-04-03 Thread Balasubramani Vivekanandan
Xe2 platforms doesn't support Aux CCS and the Flat CCS is enabled through PAT. No CCS modifiers required for Xe2 platforms. Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/display/intel_fb.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/dr

[PATCH 06/25] drm/i915/xe2hpd: Initial cdclk table

2024-04-03 Thread Balasubramani Vivekanandan
From: Clint Taylor Add Xe2_HPD specific CDCLK table and use MTL Funcs. Bspec: 65243 Cc: Matt Roper CC: Lucas De Marchi Signed-off-by: Clint Taylor Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/display/intel_cdclk.c | 11 +++ 1 file changed, 11 insertions(+) dif

[PATCH 03/25] drm/xe/bmg: Define IS_BATTLEMAGE macro

2024-04-03 Thread Balasubramani Vivekanandan
Common display code requires IS_BATTLEMAGE macro. Defined the macro. Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h b/drivers/gpu/drm/xe/compat-

[PATCH 04/25] drm/i915/bmg: Define IS_BATTLEMAGE macro

2024-04-03 Thread Balasubramani Vivekanandan
Display code uses IS_BATTLEMAGE macro but the platform support doesn't still exist in i915. So fake IS_BATTLEMAGE macro defined to enable building i915 code. We should make sure the macro parameter is used in the always-false expression so that we don't run into "unused variable" warnings from i91

[PATCH 02/25] drm/xe/bmg: Add BMG platform definition

2024-04-03 Thread Balasubramani Vivekanandan
From: Matt Roper BMG is a discrete GPU based on the Xe2 architecture. Bspec: 68090 Signed-off-by: Matt Roper Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/xe/xe_pci.c| 7 +++ drivers/gpu/drm/xe/xe_platform_types.h | 1 + include/drm/xe_pciids.h|

  1   2   >