Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: remove confusing GPIO vs PCH_GPIO

2018-07-22 Thread Zhenyu Wang
On 2018.07.19 17:20:15 +, De Marchi, Lucas wrote: > CC'ing gvt maintainers (and fixing Jani's address in CC). > > See below > > On Wed, 2018-07-18 at 13:01 +0300, Ville Syrjälä wrote: > > On Tue, Jul 17, 2018 at 03:16:53PM -0700, Lucas De Marchi wrote: > > > On Fri, Jul 13, 2018 at 9:10 AM Vi

Re: [Intel-gfx] [PATCH v4] drm/i915: Remove i915.enable_ppgtt override

2018-10-08 Thread Zhenyu Wang
: Wang, Zhi A > > > Sent: Wednesday, September 26, 2018 2:01 AM > > > To: Joonas Lahtinen ; Chris Wilson > > > ; intel-gfx@lists.freedesktop.org; Zhenyu Wang > > > > > > Cc: Auld, Matthew ; He, Min > > > Subject: Re: [PATCH v4] drm/i915:

Re: [Intel-gfx] [PATCH v4] drm/i915: Remove i915.enable_ppgtt override

2018-10-08 Thread Zhenyu Wang
On 2018.10.08 13:58:25 +, Wang, Zhi A wrote: > Thanks for pointing this. My bad. > > I take a look on the code and it looks like the GVT-g context is now quite > similar with the kernel context except the force single submission and ring > buffer size. (When we upstream the code, there was n

Re: [Intel-gfx] [RFC 01/10] drm/i915/gvt: add module parameter enable_pvmmio

2018-10-08 Thread Zhenyu Wang
On 2018.09.28 14:09:45 +0800, Zhang, Xiaolin wrote: > On 09/27/2018 07:03 PM, Joonas Lahtinen wrote: > > Quoting Xiaolin Zhang (2018-09-27 19:37:46) > >> This int type module parameter is used to control the different > >> level pvmmio feature for MMIO emulation in GVT. > >> > >> This parameter is

Re: [Intel-gfx] [RFC 02/10] drm/i915/gvt: get ready of memory for pvmmio

2018-10-08 Thread Zhenyu Wang
On 2018.09.27 12:37:47 -0400, Xiaolin Zhang wrote: > To enable pvmmio feature, we need to prepare one 4K shared page > which will be accessed by both guest and backend i915 driver. > > guest i915 allocate one page memory and then the guest physical address is > passed to backend i915 driver throug

Re: [Intel-gfx] [PATCH] drm/i915: Check ppgtt validity for GVT GEM context

2018-10-10 Thread Zhenyu Wang
On 2018.10.09 14:08:20 +0800, Xiong Zhang wrote: > The guest couldn't boot up under GVT-g environment as the following call > trace exists: > [ 272.504762] BUG: unable to handle kernel NULL pointer dereference at > 0100 > [ 272.504834] Call Trace: > [ 272.504852] execlists_context_

Re: [Intel-gfx] [PATCH] drm/i915: Check ppgtt validity for GVT GEM context

2018-10-11 Thread Zhenyu Wang
On 2018.10.11 07:23:11 +0100, Chris Wilson wrote: > Quoting Zhenyu Wang (2018-10-11 03:45:07) > > On 2018.10.09 14:08:20 +0800, Xiong Zhang wrote: > > > The guest couldn't boot up under GVT-g environment as the following call > > > trace exists: > > > [

Re: [Intel-gfx] [PATCH] drm/i915: Add ppgtt to GVT GEM context

2018-10-14 Thread Zhenyu Wang
> i915_gem_object_put(wa_ctx->indirect_ctx.obj); > } > We may better add comment for this one as currently it might not be real root pointer for gvt context, so won't confuse people later. Others looks fine to me. Thanks! Reviewed-by: Zhenyu Wang > +static int set_co

Re: [Intel-gfx] [PATCH] drm/i915: Add ppgtt to GVT GEM context

2018-10-18 Thread Zhenyu Wang
w ppgtt will > be used on GPU. So GVT GEM context has valid ppgtt address. But note > that this ppgtt only contain valid ppgtt root table address, the table > entry in this ppgtt structure are invalid. > > Fixes:4a3d3f6785be("drm/i915: Match code to comment and enforce ppgtt for

[Intel-gfx] [PULL] gvt-next-fixes for 4.20

2018-10-22 Thread Zhenyu Wang
Hi, Here's gvt-next-fixes for 4.20 with three changes. Mostly to fix possible arbitrary update on guest GGTT entry and with proper invalidate of old entry. Another one for one chicken reg mask fix. thanks -- The following changes since commit 835fe6d75d14c1513910ed7f5665127fee12acc8: firmware

Re: [Intel-gfx] [PULL] gvt-next-fixes for 4.20

2018-10-25 Thread Zhenyu Wang
On 2018.10.25 11:28:28 -0700, Rodrigo Vivi wrote: > On Thu, Oct 25, 2018 at 04:07:14PM +0300, Joonas Lahtinen wrote: > > Quoting Zhenyu Wang (2018-10-23 06:46:59) > > > > > > Hi, > > > > > > Here's gvt-next-fixes for 4.20 with three changes. Most

Re: [Intel-gfx] [PULL] gvt-next-fixes for 4.20

2018-10-25 Thread Zhenyu Wang
On 2018.10.25 16:07:14 +0300, Joonas Lahtinen wrote: > Quoting Zhenyu Wang (2018-10-23 06:46:59) > > > > Hi, > > > > Here's gvt-next-fixes for 4.20 with three changes. Mostly > > to fix possible arbitrary update on guest GGTT entry and > > with proper

Re: [Intel-gfx] [PATCH v4 1/3] drm/i915: make PCH_GMBUS* definitions private to gvt

2018-07-30 Thread Zhenyu Wang
On 2018.07.27 12:36:45 -0700, Lucas De Marchi wrote: > This is the only place that they are being used - the others use the > GMBUS* macros that rely on dev_priv being already properly initialized. > Reviewed-by: Zhenyu Wang thanks! > Cc: intel-gvt-...@lists.freedesktop.org >

Re: [Intel-gfx] [PATCH v4 2/3] drm/i915/gvt: use its own define for gpio

2018-07-30 Thread Zhenyu Wang
eviewed-by: Zhenyu Wang > Cc: intel-gvt-...@lists.freedesktop.org > Cc: Zhenyu Wang > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915/gvt/handlers.c | 2 +- > drivers/gpu/drm/i915/gvt/reg.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) >

Re: [Intel-gfx] [PATCH] drm/i915/gvt: fix memory leak in intel_vgpu_ioctl()

2018-08-02 Thread Zhenyu Wang
On 2018.08.03 08:41:19 +0800, Yi Wang wrote: > The 'sparse' variable may leak when return in function > intel_vgpu_ioctl(), and this patch fixes this. > > Signed-off-by: Yi Wang > Reviewed-by: Jiang Biao > --- Looks fine to me, will queue this up. Thanks for the patch! > drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] drm/i915/kvmgt: Fix potential Spectre v1

2018-08-06 Thread Zhenyu Wang
On 2018.08.02 22:40:19 -0500, Gustavo A. R. Silva wrote: > info.index can be indirectly controlled by user-space, hence leading > to a potential exploitation of the Spectre variant 1 vulnerability. > > This issue was detected with the help of Smatch: > > drivers/gpu/drm/i915/gvt/kvmgt.c:1232 inte

Re: [Intel-gfx] [PATCH] drm/i915/kvmgt: fix an error code in gvt_dma_map_page()

2018-08-06 Thread Zhenyu Wang
On 2018.07.19 11:19:21 +0300, Dan Carpenter wrote: > The dma_mapping_error() returns true on error but we want to return > -ENOMEM here. > > Fixes: 79e542f5af79 ("drm/i915/kvmgt: Support setting dma map for huge pages") > Signed-off-by: Dan Carpenter > Applied, thanks! > diff --git a/drivers/gp

Re: [Intel-gfx] [PATCH] drm/i915/gvt: fix memory leak in intel_vgpu_ioctl()

2018-08-08 Thread Zhenyu Wang
On 2018.08.03 08:41:19 +0800, Yi Wang wrote: > The 'sparse' variable may leak when return in function > intel_vgpu_ioctl(), and this patch fixes this. > > Signed-off-by: Yi Wang > Reviewed-by: Jiang Biao > --- > drivers/gpu/drm/i915/gvt/kvmgt.c | 3 +++ > 1 file changed, 3 insertions(+) > > di

[Intel-gfx] [PULL] gvt-next-fixes

2018-08-14 Thread Zhenyu Wang
Hi, This is initial gvt fixes for 4.19 with some accumulated fixes, pls check details below. Thanks -- The following changes since commit 3237c0dbe21f8d2ca2feaa3891aff3619873cd30: drm/i915/kvmgt: Fix compilation error (2018-08-06 11:28:35 -0700) are available in the Git repository at: htt

Re: [Intel-gfx] Possible use_mm() mis-uses

2018-08-22 Thread Zhenyu Wang
vmgt_guest_exit, or maybe mmget_not_zero. > yeah, that's the clear way to fix this imo. We only depend on guest life cycle to access guest memory properly. Here's proposed fix, will verify and integrate it later. Thanks! From 5e5a8d0409aa150884adf5a4d0b956fd0b9906b3 Mon Sep 17 00:00:00 2001 From: Zhen

[Intel-gfx] [PULL] gvt-fixes for 4.19

2018-09-03 Thread Zhenyu Wang
m_get out of spin_lock in stop_schedule Xiaolin Zhang (1): drm/i915/gvt: emulate gen9 dbuf ctl register access Zhenyu Wang (2): drm/i915/gvt: Fix drm_format_mod value for vGPU plane drm/i915/gvt: Give new born vGPU higher scheduling chance drivers/gpu/drm/i915/gvt/dmabuf.c

[Intel-gfx] [PULL] gvt-next for 4.20

2018-09-03 Thread Zhenyu Wang
a fastpath for cmd parsing on MI_NOOP drm/i915/gvt: only copy the first page for restore inhibit context Zhenyu Wang (3): drm/i915/gvt: make dma map/unmap kvmgt functions as static drm/i915/gvt: Fix function comment doc errors drm/i915/gvt: Move some MMIO definition

Re: [Intel-gfx] [PULL] gvt-next for 4.20

2018-09-06 Thread Zhenyu Wang
On 2018.09.06 16:11:20 +0300, Joonas Lahtinen wrote: > Quoting Zhenyu Wang (2018-09-04 06:01:54) > > > > Hi, > > > > Here's initial gvt-next for 4.20 with two optimization for > > guest context shadowing and command parser, and with W=1 build fixes. > &g

[Intel-gfx] [PULL] gvt-fixes for 4.19-rc4

2018-09-10 Thread Zhenyu Wang
or virtual opregion (Weinan) Weinan Li (1): drm/i915/gvt: Fix the incorrect length of child_device_config issue Zhenyu Wang (1): drm/i915/gvt: Fix life cycle reference on KVM mm drivers/gpu/drm/i915/gvt/kvmgt

[Intel-gfx] [RFC PATCH] drm/i915: split GVT as separated module

2018-09-12 Thread Zhenyu Wang
Joonas Lahtinen Signed-off-by: Zhenyu Wang --- drivers/gpu/drm/i915/Kconfig | 2 +- drivers/gpu/drm/i915/Makefile | 3 - drivers/gpu/drm/i915/gvt/Makefile | 3 +- drivers/gpu/drm/i915/gvt/gvt.c| 40 +- drivers/gpu/drm/i915/gvt/gvt.h

[Intel-gfx] [PULL] gvt-fixes for 4.19-rc5

2018-09-18 Thread Zhenyu Wang
Hi, Here's more gvt fixes for 4.19. Two more BXT fixes from Colin, one srcu locking fix and one fix for GGTT clear when destroy vGPU. p.s, I'll start my vacation from tomorrow. Wang Zhi will cover for gvt pull. Thanks -- The following changes since commit 792fab2c0d45758ad3d187bd252570d2bb627fa

Re: [Intel-gfx] [PATCH v6 04/14] drm/i915/gvt: Detect 64K gtt entry by IPS bit of PDE

2018-05-10 Thread Zhenyu Wang
On 2018.05.10 16:17:35 +0100, Matthew Auld wrote: > > @@ -934,6 +944,20 @@ static int ppgtt_invalidate_spt(struct > > intel_vgpu_ppgtt_spt *spt) > > return ret; > > } > > > > +static bool vgpu_ips_enabled(struct intel_vgpu *vgpu) > > +{ > > + if (INTEL_GEN(vgpu->gvt->dev_priv) == 9)

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Use offsetofend() rather than offsetof + sizeof

2018-05-17 Thread Zhenyu Wang
On 2018.05.16 17:38:30 +0100, Chris Wilson wrote: > Quoting Mika Kuoppala (2017-03-16 09:37:44) > > Chris Wilson writes: > > > > > Compute the offset of the end of the crc32 field using offsetofend() > > > rather than open-coding. > > > > > >

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Store a pointer to intel_context in i915_request

2018-05-17 Thread Zhenyu Wang
i915/gvt/mmio_context.c | 6 +- > drivers/gpu/drm/i915/gvt/mmio_context.h | 2 +- > drivers/gpu/drm/i915/gvt/scheduler.c | 141 +++--- > drivers/gpu/drm/i915/gvt/scheduler.h | 1 - gvt change looks fine to me. Acked-by: Zhenyu Wang >

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Store a pointer to intel_context in i915_request

2018-05-18 Thread Zhenyu Wang
On 2018.05.18 09:42:47 +0100, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2018-05-18 08:43:33) > > > > On 18/05/2018 04:21, Zhenyu Wang wrote: > > > On 2018.05.17 22:26:32 +0100, Chris Wilson wrote: > > >> To ease the frequent and ugly pointer dance of

[Intel-gfx] [PATCH] drm/i915/gvt: Fix crash after request->hw_context change

2018-05-18 Thread Zhenyu Wang
to intel_context in i915_request") Cc: Chris Wilson Cc: Tvrtko Ursulin Signed-off-by: Zhenyu Wang --- drivers/gpu/drm/i915/gvt/scheduler.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/scheduler.c b/drivers/gpu/drm/i915/gvt/sched

Re: [Intel-gfx] ??? Fi.CI.BAT: failure for drm/i915/gvt: Fix crash after request->hw_context change

2018-05-18 Thread Zhenyu Wang
On 2018.05.18 12:03:02 +0100, Chris Wilson wrote: > Quoting Patchwork (2018-05-18 11:55:01) > > == Series Details == > > > > Series: drm/i915/gvt: Fix crash after request->hw_context change > > URL : https://patchwork.freedesktop.org/series/43406/ > > State : failure > > > > == Summary == > >

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Fix crash after request->hw_context change

2018-05-20 Thread Zhenyu Wang
On 2018.05.18 11:22:06 +0100, Chris Wilson wrote: > Quoting Zhenyu Wang (2018-05-18 11:13:05) > > When we do shadowing, workload's request might not be allocated yet, > > so we still require shadow context's object. And when complete workload, > > delay to zero w

[Intel-gfx] [PATCH v2] drm/i915/gvt: Fix crash after request->hw_context change

2018-05-21 Thread Zhenyu Wang
k shadow status depending on request state, which also facilitate to use request->hw_context for target engine context reference. Fixes: 1fc44d9b1afb ("drm/i915: Store a pointer to intel_context in i915_request") Cc: Chris Wilson Cc: Tvrtko Ursulin Cc: Zhi Wang Cc: Weinan Li Signed-off-b

Re: [Intel-gfx] [PATCH v4 1/2] vfio/mdev: Check globally for duplicate devices

2018-05-22 Thread Zhenyu Wang
t that sooner > rather than later if required. > > I see that __intel_gvt_create_vgpu() makes use of gvt->lock, which > would seem to already provide this level of per-parent locking. The > remove path makes use of this same lock, so I t

Re: [Intel-gfx] [PULL] gvt-fixes for 4.17

2018-06-06 Thread Zhenyu Wang
On 2018.04.19 15:39:48 +0800, Zhenyu Wang wrote: > > Hi, > > Here's current gvt fixes for 4.17 with several kernel warning > and other misc fixes as detailed below. > > p.s: I'll be on vacation from next week till May 2, Zhi will cover for me. > > Thank

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: Enable KVMGT for BXT

2018-06-12 Thread Zhenyu Wang
On 2018.06.11 10:09:52 +0100, Chris Wilson wrote: > Quoting Patchwork (2018-06-11 10:05:46) > > == Series Details == > > > > Series: drm/i915/gvt: Enable KVMGT for BXT > > URL : https://patchwork.freedesktop.org/series/44551/ > > State : success > > > > == Summary == > > > > = CI Bug Log - cha

[Intel-gfx] [PULL] gvt-next for 4.17

2018-03-07 Thread Zhenyu Wang
drm/i915/gvt: Release gvt->lock at the failure of finding page track drm/i915/gvt: Return error at the failure of finding page_track Zhenyu Wang (7): drm/i915/gvt: Fix one gvt_vgpu_error() use in dmabuf.c drm/i915/gvt: remove gvt max port definition drm/i915/gvt: F

Re: [Intel-gfx] [PATCH][drm-next] drm/i915/gvt: fix spelling mistake: "destoried" -> "destroyed"

2018-03-12 Thread Zhenyu Wang
On 2018.03.12 12:43:58 +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in gvt_err error message text. > > Signed-off-by: Colin Ian King > --- Thanks Colin, will pick up. > drivers/gpu/drm/i915/gvt/gtt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

[Intel-gfx] [PULL] more gvt-fixes for 4.16

2018-03-15 Thread Zhenyu Wang
fix (Fred) Min He (1): drm/i915/gvt: keep oa config in shadow ctx Xiong Zhang (1): drm/i915/gvt: Add runtime_pm_get/put into gvt_switch_mmio Zhenyu Wang (1): drm/i915/gvt: fix user copy warning by whitelist workload rb_tail field fred gao (1): dr

[Intel-gfx] [PULL] gvt-next-fixes for 4.17

2018-03-19 Thread Zhenyu Wang
;destoried" -> "destroyed" Colin Xu (1): drm/i915/gvt: Remove reduntant printing of untracked mmio Zhenyu Wang (1): drm/i915/gvt: force to set all context control bits from guest Zhi Wang (2): drm/i915/gvt: Invalidate vGPU PPGTT mm objects during a vGPU reset. drm/i

Re: [Intel-gfx] [PATCH] drm/i915/gvt/scheduler: Remove unnecessary NULL checks in sr_oa_regs

2018-03-22 Thread Zhenyu Wang
On 2018.03.22 21:31:33 +, Chris Wilson wrote: > Quoting Gustavo A. R. Silva (2018-03-22 18:21:54) > > The checks are misleading and not required [1]. > > > > [1] https://lkml.org/lkml/2018/3/19/1792 > > > > Addresses-Coverity-ID: 1466017 > > Cc: Chris Wilson > > Signed-off-by: Gustavo A. R.

[Intel-gfx] [PULL] more gvt-next-fixes for 4.17

2018-03-27 Thread Zhenyu Wang
Hi, Joonas Here's this week's gvt-next-fixes queued for 4.17. One notable change is to revert previous workaround for gvt context preemption, now it has full support for preemption now. Others are normal fixes and optimizations. Thanks -- The following changes since commit d8303075699292008ae5b2

Re: [Intel-gfx] [PULL] more gvt-next-fixes for 4.17

2018-03-27 Thread Zhenyu Wang
On 2018.03.27 16:42:28 +0300, Joonas Lahtinen wrote: > Quoting Zhenyu Wang (2018-03-27 11:39:42) > > > > Hi, Joonas > > > > Here's this week's gvt-next-fixes queued for 4.17. One notable change > > is to revert previous workaround for gvt context

Re: [Intel-gfx] [PULL] more gvt-next-fixes for 4.17

2018-03-28 Thread Zhenyu Wang
On 2018.03.27 17:39:53 +0300, Joonas Lahtinen wrote: > Quoting Joonas Lahtinen (2018-03-27 16:42:28) > > Quoting Zhenyu Wang (2018-03-27 11:39:42) > > > > > > Hi, Joonas > > > > > > Here's this week's gvt-next-fixes queued for 4.17. One no

Re: [Intel-gfx] [PULL] gvt-next-fixes for 4.16

2018-02-06 Thread Zhenyu Wang
On 2018.02.06 11:45:04 -0800, Rodrigo Vivi wrote: > > Hi Zhi, > > Daniel asked few weeks ago about the scripts that you run there, > but I didn't see any follow-up. > > I don't understand why yet, but apparently gvt pull request > is not going to patchwork so dim is not able to add the "Link:" >

[Intel-gfx] [PULL] git-fixes for 4.16-rc2

2018-02-13 Thread Zhenyu Wang
Hi, here's current gvt-fixes pull for 4.16-rc2, as it is close for chinese new year, team would take one week off at least, so like to send this out before vacation. This has one to fix GTT mmio 8b access from guest and two simple ones for mmio switch and typo fix. And sorry that patchwork link is

Re: [Intel-gfx] [PULL] git-fixes for 4.16-rc2

2018-02-21 Thread Zhenyu Wang
On 2018.02.20 20:15:22 +, Chris Wilson wrote: > Quoting Zhenyu Wang (2018-02-14 05:28:27) > > > > Hi, here's current gvt-fixes pull for 4.16-rc2, as it is close for > > chinese new year, team would take one week off at least, so like to > > send this out befo

[Intel-gfx] [PATCH 1/2] drm/i915: enable vGPU detection for all

2016-09-05 Thread Zhenyu Wang
From: Ping Gao vGPU capability is handled by GVT-g host driver, not needed to put extra HW check for vGPU detection. And we'll actually support vGPU from BDW. Signed-off-by: Ping Gao Signed-off-by: Zhenyu Wang --- drivers/gpu/drm/i915/i915_vgpu.c | 3 --- 1 file changed, 3 deletions(-)

[Intel-gfx] [PATCH 0/2] GVT-g guest patch for 4.8

2016-09-05 Thread Zhenyu Wang
Hi, Here're two patches for GVT-g guest to fix run against future GVT-g host driver, which try to ensure 4.8 will be ready to use for VM. thanks. Ping Gao (1): drm/i915: enable vGPU detection for all Zhi Wang (1): drm/i915: disable 48bit full PPGTT when vGPU is active drivers/gpu/drm/i915

[Intel-gfx] [PATCH 2/2] drm/i915: disable 48bit full PPGTT when vGPU is active

2016-09-05 Thread Zhenyu Wang
From: Zhi Wang Disable 48bit full PPGTT on vGPU too for now. Signed-off-by: Zhi Wang Signed-off-by: Zhenyu Wang --- drivers/gpu/drm/i915/i915_gem_gtt.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 0/2] GVT-g guest patch for 4.8

2016-09-06 Thread Zhenyu Wang
On 2016.09.06 11:33:57 +0300, Jani Nikula wrote: > On Tue, 06 Sep 2016, Chris Wilson wrote: > > On Tue, Sep 06, 2016 at 12:04:10PM +0800, Zhenyu Wang wrote: > >> Hi, > >> > >> Here're two patches for GVT-g guest to fix run against future GVT-g > >

Re: [Intel-gfx] [PATCH 0/2] drm/i915/gvt: fix compilation errors in gtt.c

2016-10-24 Thread Zhenyu Wang
On 2016.10.24 15:33:34 -0400, Jérémy Lefaure wrote: > On Mon, 24 Oct 2016 10:36:58 +0800 > Zhenyu Wang wrote: > > > On 2016.10.20 18:05:56 -0400, Jérémy Lefaure wrote: > > > This series fixes 2 compilations errors in gvt/gtt.c on 32-bits platform: > > > [PATCH

Re: [Intel-gfx] fail to build on 32-bit x86 report

2016-10-26 Thread Zhenyu Wang
On 2016.10.26 11:14:26 +1000, Dave Airlie wrote: > http://kisskb.ellerman.id.au/kisskb/buildresult/12840554/ > > Since the GVT stuff it looks like some divide should be a do_div. > yeah, we will fix 32bit build later, I plan to send another pull tomorrow or the day after which will disable 32bit

[Intel-gfx] [PULL] GVT-g device model

2016-10-27 Thread Zhenyu Wang
po in skl_decode_mi_display_flip Ping Gao (3): drm/i915/gvt: add vreg write for GDRST handler drm/i915/gvt: correct the reset logic drm/i915/gvt: add full vGPU reset support Xiaoguang Chen (1): drm/i915/gvt: fix detect_host calling logic Zhenyu Wang (3): drm/i915/gvt: Fix failure

[Intel-gfx] [PATCH] drm/i915/gvt: Fix workload status after wait

2016-11-01 Thread Zhenyu Wang
From commit e95433c73a11759203af1cae5958f998c9673370, workload status setting was changed to only capture on error path, but we need to set it properly in normal path too, otherwise we'll fail to complete workload which could lead guest VM vGPU reset. Cc: Chris Wilson Signed-off-by: Zhenyu

[Intel-gfx] [PATCH v2] drm/i915/gvt: Fix workload status after wait

2016-11-02 Thread Zhenyu Wang
Fixes: e95433c73a11 ("drm/i915: Rearrange i915_wait_request() accounting with callers") Cc: Chris Wilson Signed-off-by: Zhenyu Wang --- drivers/gpu/drm/i915/gvt/scheduler.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/gvt/scheduler.c b/drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Fix workload status after wait

2016-11-02 Thread Zhenyu Wang
On 2016.11.02 08:47:52 +0200, Joonas Lahtinen wrote: > On ke, 2016-11-02 at 13:41 +0800, Zhenyu Wang wrote: > > From commit e95433c73a11759203af1cae5958f998c9673370, workload status > > setting > > was changed to only capture on error path, but we need to set it properly i

[Intel-gfx] [PULL] GVT-g device model fixes

2016-11-07 Thread Zhenyu Wang
vt: remove unused variable 'execlist' drm/i915/gvt: add write vreg in MMIO DMA_CTRL handler drm/i915/gvt: correct the emulation in TLB control handler drm/i915/gvt: update misc ctl regs base on stepping info drm/i915/gvt: implement scratch page table tree for shado

Re: [Intel-gfx] [PATCH 0/2] extend page_track for external usage

2016-11-08 Thread Zhenyu Wang
On 2016.11.07 10:17:54 +0100, Daniel Vetter wrote: > >> Paolo, for this case, do you think it's feasible we pick them through > >> drm/i915 merge path? As currently initial KVMGT patch sets require these > >> exported symbols, that's why I ask how we should handle this dependency. > > > > Then it's

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Disable access to stolen memory as a guest

2016-11-09 Thread Zhenyu Wang
ld work for all OS gfx drivers. But I think Chris's change is fine and I would polish GMCH_CTL handling patch. > > > The actual size should be reported as zero, but > > like every other quirk we want to tell the user what is happening. > > > > Signed-off-by: Chris Wi

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Disable access to stolen memory as a guest

2016-11-09 Thread Zhenyu Wang
her quirk we want to tell the user what is happening. > > Signed-off-by: Chris Wilson > Cc: Zhenyu Wang > Cc: Joonas Lahtinen > --- > drivers/gpu/drm/i915/i915_gem_stolen.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915

Re: [Intel-gfx] [PATCH i-g-t 2/4 v5] lib/igt_gvt: Make use of libkmod helpers and fix reading gvt parameter.

2016-11-09 Thread Zhenyu Wang
On 2016.11.03 18:28:11 +0200, Marius Vlad wrote: > v2: > - use igt_sysfs_get_boolean() to get gvt status (Chris Wilson) > - do not hard-fail when i915 module could not be loaded/unloaded (Chris > Wilson) > > Signed-off-by: Marius Vlad Looks fine to me. Acked-by: Zhenyu W

[Intel-gfx] [PULL] GVT-g KVMGT framework

2016-11-10 Thread Zhenyu Wang
_init/host_exit to MPT drm/i915/gvt: allow several MPT methods to be NULL drm/i915/gvt: refactor intel_gvt_io_emulation_ops to be intel_gvt_ops drm/i915/gvt: add KVMGT support Xiaoguang Chen (1): drm/i915/gvt: use kmap instead of kmap_atomic around guest memory access

Re: [Intel-gfx] [igvt-g-dev] [bug report] drm/i915/gvt: vGPU display virtualization

2016-11-11 Thread Zhenyu Wang
On 2016.11.10 15:54:51 +0300, Dan Carpenter wrote: > Hello Zhi Wang, > > The patch 04d348ae3f0a: "drm/i915/gvt: vGPU display virtualization" > from Apr 25, 2016, leads to the following static checker warning: > > drivers/gpu/drm/i915/gvt/edid.c:506 intel_gvt_i2c_handle_aux_ch_write() >

Re: [Intel-gfx] [igvt-g-dev] [bug report] drm/i915/gvt: vGPU display virtualization

2016-11-11 Thread Zhenyu Wang
On 2016.11.11 08:28:28 +, Chris Wilson wrote: > On Fri, Nov 11, 2016 at 04:08:58PM +0800, Zhenyu Wang wrote: > > > > On 2016.11.10 15:54:51 +0300, Dan Carpenter wrote: > > > Hello Zhi Wang, > > > > > > The patch 04d348ae3f0a: "drm/i915/gvt:

[Intel-gfx] [PULL] GVT-g device model fixes

2016-11-15 Thread Zhenyu Wang
lb_control drm/i915/gvt: add more MMIO regs with command access flag Xiaoguang Chen (1): drm/i915/gvt: clear guest opregion Zhenyu Wang (1): drm/i915/gvt: Fix static checker warning on intel_gvt_i2c_handle_aux_ch_write() drivers/gpu/drm/i915/gvt/cmd_parser.c | 3 ++- drive

Re: [Intel-gfx] [PATCH] drm/i915/gvt: drop checks for early Skylake revisions

2016-11-16 Thread Zhenyu Wang
On 2016.11.16 12:13:59 +0200, Jani Nikula wrote: > We no longer cater for pre-production revisions of Skylake. > > Fixes: d4362225e8cb ("drm/i915/gvt: update misc ctl regs base on stepping > info") > Cc: Ping Gao > Cc: Zhenyu Wang > Cc: Zhi Wang >

Re: [Intel-gfx] [PATCH v3] drm/i915: fix the dequeue logic for single_port_submission context

2016-11-16 Thread Zhenyu Wang
hw context render registers. > This patch is to implement the correct logic in execlists_dequeue. > > v2: optimized code by following Chris's advice, and added more comments to > explain the patch. > v3: followed the coding style. > > Signed-off-by: Min He > Signed-off-by:

Re: [Intel-gfx] [igvt-g-dev] [PULL] GVT-g device model fixes

2016-11-16 Thread Zhenyu Wang
On 2016.11.16 15:50:27 +0800, Zhenyu Wang wrote: > > Hi, > > Please pull current GVT-g device model fixes. > Sorry, pls hold on this as found a possible conflict, as this is supposed to be last pull before 4.10 merge window, like to include the fix for that, will send update l

Re: [Intel-gfx] [igvt-g-dev] [PULL] GVT-g device model fixes

2016-11-17 Thread Zhenyu Wang
: drm/i915/gvt: fix deadlock in workload_thread drm/i915/gvt: check workload empty before real scan Ping Gao (2): drm/i915/gvt: emulate right behavior for tlb_control drm/i915/gvt: add more MMIO regs with command access flag Xiaoguang Chen (1): drm/i915/gvt:

Re: [Intel-gfx] [PATCH] drm/i915: Move the release of PT page to the upper caller

2016-11-22 Thread Zhenyu Wang
plicated. Better let the guest modify the PT entry in > > >upper level PT first, then release the PT page. > > > > > >Cc: Michał Winiarski > > >Cc: Michel Thierry > > >Cc: Joonas Lahtinen > > >Cc: Chris Wilson > > >Cc: Zhenyu Wang &g

Re: [Intel-gfx] [igvt-g-dev] [bug report] drm/i915/gvt: fix deadlock in workload_thread

2016-11-23 Thread Zhenyu Wang
On 2016.11.24 01:17:06 +0300, Dan Carpenter wrote: > Hello Pei Zhang, > > The patch 90d27a1b180e: "drm/i915/gvt: fix deadlock in > workload_thread" from Nov 14, 2016, leads to the following static > checker warning: > > drivers/gpu/drm/i915/gvt/scheduler.c:217 dispatch_workload() > wa

[Intel-gfx] [PULL] GVT-g device model core

2016-10-14 Thread Zhenyu Wang
Hi, This is first pull request to merge GVT-g device model in i915 which contains core GVT-g device model work to virtualize GPU resources. This tries to add feature of Intel GVT-g technology for full GPU virtualization. This version will support KVM based virtualization solution named as KVMGT.

Re: [Intel-gfx] [PULL] GVT-g device model core

2016-10-17 Thread Zhenyu Wang
On 2016.10.17 09:33:19 +0200, Daniel Vetter wrote: > On Mon, Oct 17, 2016 at 09:30:45AM +0200, Daniel Vetter wrote: > > On Fri, Oct 14, 2016 at 06:30:30PM +0800, Zhenyu Wang wrote: > > > > > > Hi, > > > > > > This is first pull request to merge GV

[Intel-gfx] [PATCH] drm/i915/gvt: Fix build failure after intel_engine_cs change

2016-10-17 Thread Zhenyu Wang
Change GVT-g code reference for intel_engine_cs from static array to allocated pointer after commit 3b3f1650b1ca ("drm/i915: Allocate intel_engine_cs structure only for the enabled engines"). Signed-off-by: Zhenyu Wang --- drivers/gpu/drm/i915/gvt/execlist.c | 2 +- drivers/gpu/dr

Re: [Intel-gfx] [PULL] GVT-g device model core

2016-10-17 Thread Zhenyu Wang
On 2016.10.17 16:07:50 +0200, Daniel Vetter wrote: > Yeah might be best to have a new branch with upstreaming stuff (now you > need to at least split out bugfixes for the already merged stuff) and > treat that like a mostly stable branch. And the still unmerged features > (vfio and all that) would

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gvt: Fix build failure after intel_engine_cs change

2016-10-17 Thread Zhenyu Wang
On 2016.10.18 05:39:11 +, Saarinen, Jani wrote: > > == Series Details == > > > > Series: drm/i915/gvt: Fix build failure after intel_engine_cs change > > URL : https://patchwork.freedesktop.org/series/13910/ > > State : failure > > > > == Summary == > > > > Series 13910v1 drm/i915/gvt: Fix

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Fix build failure after intel_engine_cs change

2016-10-17 Thread Zhenyu Wang
On 2016.10.18 09:47:56 +0300, Joonas Lahtinen wrote: > On ti, 2016-10-18 at 09:40 +0800, Zhenyu Wang wrote: > > @@ -134,7 +134,7 @@ static int render_mmio_to_ring_id(struct intel_gvt > > *gvt, unsigned int reg) > >   > >   reg &= ~GENMASK(11, 0); > >  

Re: [Intel-gfx] [PULL] GVT-g device model core

2016-10-18 Thread Zhenyu Wang
On 2016.10.18 14:59:14 +0300, Jani Nikula wrote: > On Mon, 17 Oct 2016, Jani Nikula wrote: > > On Mon, 17 Oct 2016, Daniel Vetter wrote: > >> Ok applied, but a few things to keep in mind before your next pull > >> request: > >> > >> - Dont rebase everything 5 seconds before sending out the pull r

Re: [Intel-gfx] linux-next: build warnings after merge of the drm-intel tree

2016-10-18 Thread Zhenyu Wang
On 2016.10.19 10:57:53 +1100, Stephen Rothwell wrote: > Hi all, > > After merging the drm-intel tree, today's linux-next build (x86_64 > allmodconfig) produced these warnings: > > drivers/gpu/drm/i915/gvt/execlist.c: In function > 'release_shadow_batch_buffer': > drivers/gpu/drm/i915/gvt/execlis

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gvt: s/drm_gem_object_unreference/i915_gem_object_put/

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 08:42:49 +0100, Chris Wilson wrote: > Deprecated functions; it is also not clear whether these are called from > the right context. > > Signed-off-by: Chris Wilson Thanks, Chris. Already did a same fix on https://github.com/01org/gvt-linux/commit/abd8dc57b13cccfa493553b4e64ba175

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: i915_gem_object_create() returns an error pointer

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 08:42:50 +0100, Chris Wilson wrote: > On failure from i915_gem_object_create(), we need to check for an error > pointer not NULL. > > Signed-off-by: Chris Wilson Reviewed-by: Zhenyu Wang Thanks, Chris. Looks good to me, will put in next pull request. -- Open Sourc

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: i915_gem_object_create() returns an error pointer

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 08:51:33 +0100, Chris Wilson wrote: > On Wed, Oct 19, 2016 at 03:45:19PM +0800, Zhenyu Wang wrote: > > On 2016.10.19 08:42:50 +0100, Chris Wilson wrote: > > > On failure from i915_gem_object_create(), we need to check for an error > > > pointer not NULL.

Re: [Intel-gfx] [PULL] GVT-g device model core

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 08:50:21 +0100, Chris Wilson wrote: > On Fri, Oct 14, 2016 at 06:30:30PM +0800, Zhenyu Wang wrote: > > > > Hi, > > > > This is first pull request to merge GVT-g device model in i915 > > which contains core GVT-g device model work to virtualize GPU

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Use the returned VMA to provide the virtual address

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 09:03:35 +0100, Chris Wilson wrote: > The purpose of returning the just-pinned VMA is so that we can use the > information within, like its address. Also it should be tracked and used > as the cookie to unpin... > > Signed-off-by: Chris Wilson Reviewed-

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gvt: Stop checking for impossible interrupts from a kthread

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 09:12:27 +0100, Chris Wilson wrote: > The kthread will not be interrupted, don't even bother checking. > > Signed-off-by: Chris Wilson Reviewed-by: Zhenyu Wang > --- > drivers/gpu/drm/i915/gvt/scheduler.c | 9 ++--- > 1 file changed, 2 ins

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Stop waiting whilst holding struct_mutex

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 09:12:28 +0100, Chris Wilson wrote: > For whatever reason, the gvt scheduler runs synchronously. At the very > least, lets run synchronously without holding the struct_mutex. > > Signed-off-by: Chris Wilson This will break current device model which assume to serve one VM context o

Re: [Intel-gfx] [PATCH v2] drm/i915/gvt: Stop waiting whilst holding struct_mutex

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 10:14:39 +0100, Chris Wilson wrote: > For whatever reason, the gvt scheduler runs synchronously. At the very > least, lets run synchronously without holding the struct_mutex. > > v2: cut'n'paste mutex_lock instead of unlock. > Replace long hold of struct_mutex with a mutex to seriali

Re: [Intel-gfx] [PATCH 10/12] drm/i915/gvt: Use common mapping routines for indirect_ctx object

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 11:11:45 +0100, Chris Wilson wrote: > We have the ability to map an object, so use it rather than opencode it > badly. > > Signed-off-by: Chris Wilson Planned to fix these mapping too, obviously not fast than you.. Reviewed-by: Zhenyu Wang > --- > driver

Re: [Intel-gfx] [PATCH 07/12] drm/i915/gvt: Hold a reference on the request

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 11:11:42 +0100, Chris Wilson wrote: > The workload took a pointer to the request, and even waited upon, > without holding a reference on the request. Take that reference > explicitly and fix up the error path following request allocation that > missed flushing the request. > > Signed

Re: [Intel-gfx] gvt gem fixes

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 11:11:35 +0100, Chris Wilson wrote: > I think this is the set required to bring gvt into line, at least to > unblock myself. Thanks a lot, Chris. I'd like to merge this in next pull request, or let me know you want to be picked up by drm-intel directly. If 4/12 would be picked up alo

Re: [Intel-gfx] [PATCH -next] drm/i915/gvt: fix return value check

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 16:18:03 +, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function i915_gem_object_create() returns > ERR_PTR() not NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Signed-off-by: Wei Yongjun Hi, Yongjun, we've already h

Re: [Intel-gfx] [PATCH 07/12] drm/i915/gvt: Hold a reference on the request

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 11:11:42 +0100, Chris Wilson wrote: > The workload took a pointer to the request, and even waited upon, > without holding a reference on the request. Take that reference > explicitly and fix up the error path following request allocation that > missed flushing the request. > > Signed

Re: [Intel-gfx] gvt gem fixes

2016-10-19 Thread Zhenyu Wang
On 2016.10.19 12:02:58 +0100, Chris Wilson wrote: > On Wed, Oct 19, 2016 at 06:45:51PM +0800, Zhenyu Wang wrote: > > On 2016.10.19 11:11:35 +0100, Chris Wilson wrote: > > > I think this is the set required to bring gvt into line, at least to > > > unblock myself. > &

Re: [Intel-gfx] gvt gem fixes

2016-10-20 Thread Zhenyu Wang
On 2016.10.20 09:02:45 +0200, Daniel Vetter wrote: > Yeah, I think anything that touches i915 code should get merged through > drm-intel directly with the usual process. Only exception is when gvt has > a functional depency and it's a small patch, then I think we can sometimes > merge i915 core pat

[Intel-gfx] [PATCH] Documentation/gpu: Add section for Intel GVT-g host support

2016-10-20 Thread Zhenyu Wang
Update with brief overview and reference for more detailed arch design documents. Add new section for Intel GVT-g host support. Signed-off-by: Zhenyu Wang --- Documentation/gpu/i915.rst | 9 + drivers/gpu/drm/i915/intel_gvt.c | 8 ++-- 2 files changed, 15 insertions(+), 2

[Intel-gfx] [PATCH] drm/i915/gvt: clean up intel_gvt.h as interface for i915 core

2016-10-20 Thread Zhenyu Wang
i915 core should only call functions and structures exposed through intel_gvt.h. Remove internal gvt.h and i915_pvinfo.h. Change for internal intel_gvt structure as private handler which not requires to expose gvt internal structure for i915 core. Signed-off-by: Zhenyu Wang --- drivers/gpu/drm

Re: [Intel-gfx] [PATCH 07/12] drm/i915/gvt: Hold a reference on the request

2016-10-20 Thread Zhenyu Wang
On 2016.10.20 07:52:18 +0100, Chris Wilson wrote: > On Thu, Oct 20, 2016 at 08:22:00AM +0800, Zhenyu Wang wrote: > > On 2016.10.19 11:11:42 +0100, Chris Wilson wrote: > > > The workload took a pointer to the request, and even waited upon, > > > without holding a referenc

[Intel-gfx] [PATCH v2] drm/i915/gvt: clean up intel_gvt.h as interface for i915 core

2016-10-20 Thread Zhenyu Wang
andle dev_priv->gvt assignment - add necessary bracket for macro helper - forward declartion struct intel_gvt - keep free operation within same file handling alloc Signed-off-by: Zhenyu Wang --- drivers/gpu/drm/i915/gvt/aperture_gm.c | 1 + drivers/gpu/drm/i915/gvt/cfg_space.c| 1 + dri

<    1   2   3   4   5   6   7   8   >