Re: [PHP-DEV] [PATCH] Allow use($var..) statement ubiquitously

2008-07-18 Thread Larry Garfield
On Thursday 17 July 2008 6:23:31 pm Moriyoshi Koizumi wrote: Hi, Attached are the patches that allow the use statement that was introduced with closures to appear within every function statement except method definitions. I think this feature is a good addition because it resolves

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/mysql php_mysql.c /ext/mysqli mysqli.c /ext/mysqlnd mysqlnd.c mysqlnd_palloc.c mysqlnd_ps.c mysqlnd_wireprotocol.c

2008-07-18 Thread Lester Caine
Ulf Wendel wrote: If mysqlnd turns out to be stable enough during the PHP 5.3 test phase, PHP 5.3+ may use mysqlnd as a default. There is no need to download an extra library when using 5.3. Lukas, this is not affecting PHP 5.3 as long as mysqlnd is stable/fast/... enough to be used as a

Re: [PHP-DEV] Apache builds

2008-07-18 Thread Pierre Joye
hi, On Fri, Jul 18, 2008 at 4:38 AM, Steph Fox [EMAIL PROTECTED] wrote: Hi all, I've been struggling a bit with Apache tonight. I'd hoped to send real patches at the end of it, but... It is not due to re2c introduction but to changes committed only in one branch and never merged to HEAD.

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/mysql php_mysql.c /ext/mysqli mysqli.c /ext/mysqlnd mysqlnd.c mysqlnd_palloc.c mysqlnd_ps.c mysqlnd_wireprotocol.c

2008-07-18 Thread Ulf Wendel
Lester Caine schrieb: Ulf Wendel wrote: If mysqlnd turns out to be stable enough during the PHP 5.3 test phase, PHP 5.3+ may use mysqlnd as a default. There is no need to download an extra library when using 5.3. Lukas, this is not affecting PHP 5.3 as long as mysqlnd is stable/fast/...

Re: [PHP-DEV] [PATCH] Allow use($var..) statement ubiquitously

2008-07-18 Thread Moriyoshi Koizumi
That's one of the motivations for the patch. I never liked the new syntax, but if it was given a go, it should also be made consistent with the another part of the syntax. Oh, I just got one important thing in mind to mention; test1.php: ?php function a() { $a = bar;

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/mysql php_mysql.c /ext/mysqli mysqli.c /ext/mysqlnd mysqlnd.c mysqlnd_palloc.c mysqlnd_ps.c mysqlnd_wireprotocol.c

2008-07-18 Thread Pierre Joye
On Fri, Jul 18, 2008 at 9:27 AM, Ulf Wendel [EMAIL PROTECTED] wrote: Lester Caine schrieb: Ulf Wendel wrote: If mysqlnd turns out to be stable enough during the PHP 5.3 test phase, PHP 5.3+ may use mysqlnd as a default. There is no need to download an extra library when using 5.3. Lukas,

Re: [PHP-DEV] [PATCH] Allow use($var..) statement ubiquitously

2008-07-18 Thread Richard Quadling
2008/7/18 Moriyoshi Koizumi [EMAIL PROTECTED]: That's one of the motivations for the patch. I never liked the new syntax, but if it was given a go, it should also be made consistent with the another part of the syntax. Oh, I just got one important thing in mind to mention; test1.php: ?php

Re: [PHP-DEV] [PATCH] Allow use($var..) statement ubiquitously

2008-07-18 Thread Moriyoshi Koizumi
On 2008/07/18, at 19:06, Richard Quadling wrote: 2008/7/18 Moriyoshi Koizumi [EMAIL PROTECTED]: running test1.php ends up with two lines of bar, surprisingly. This is somewhat confusing, but surely one of the things that could not ever be done. This might be a great help when you use a

Re: [PHP-DEV] Apache builds

2008-07-18 Thread Steph Fox
Pierre, It is not due to re2c introduction but to changes committed only in one branch and never merged to HEAD. Then good developers worked in HEAD and merged to 5.3 ending with the current mess. Y'know, attacking me every time I make a move is counterproductive. In this case, it means

Re: [PHP-DEV] Apache builds

2008-07-18 Thread Scott MacVicar
Hey Steph, John worked on apache2filter and for some reason he only made a change to do with streams on the 5.x branch [1] and never merged his change to head. It means that currently apache2filter works on HEAD but not on PHP 5.3 I've not yet had time to see if there is a way to get a

Re: [PHP-DEV] Apache builds

2008-07-18 Thread Steph Fox
Pierre, I have no idea what makes you think that my reply was a personal attack History? Let me rephrase that. Look at the actual commit. - As Scott is working in this area right now, he's volunteered to fix it as soon as possible. In that case, wouldn't it be nice if Scott were

Re: [PHP-DEV] Apache builds

2008-07-18 Thread Steph Fox
Hi Scott, thanks, John worked on apache2filter and for some reason he only made a change to do with streams on the 5.x branch [1] and never merged his change to head. It means that currently apache2filter works on HEAD but not on PHP 5.3 Ahhh it was 2 years ago in 5_2 branch. I've

Re: [PHP-DEV] Apache builds

2008-07-18 Thread Scott MacVicar
Steph, Steph Fox wrote: Hi Scott, thanks, John worked on apache2filter and for some reason he only made a change to do with streams on the 5.x branch [1] and never merged his change to head. It means that currently apache2filter works on HEAD but not on PHP 5.3 Ahhh it was 2

Re: [PHP-DEV] Apache builds

2008-07-18 Thread Pierre Joye
On Fri, Jul 18, 2008 at 12:34 PM, Steph Fox [EMAIL PROTECTED] wrote: Pierre, It is not due to re2c introduction but to changes committed only in one branch and never merged to HEAD. Then good developers worked in HEAD and merged to 5.3 ending with the current mess. Y'know, attacking me

Re: [PHP-DEV] Apache builds

2008-07-18 Thread Steph Fox
Scott, Isn't it just a case of rewriting php_apache_fteller_stream() to use the new API? I think we can actually just add an fsizer function and use apr_brigade_length(pbb-bb); I think that's what 'rewriting php_apache_fteller_stream() means ;) Why move it from pbb-total_len? That

Re: [PHP-DEV] Apache builds

2008-07-18 Thread Pierre Joye
On Fri, Jul 18, 2008 at 1:10 PM, Steph Fox [EMAIL PROTECTED] wrote: In that case, wouldn't it be nice if Scott were allowed to reply to my question without all this barracking from you? Nobody's interested in your personal vendettas. We are here to work and get things done, not to read things

Re: [PHP-DEV] Apache builds

2008-07-18 Thread Scott MacVicar
I've committed a fix now and it compiles correctly, I also removed the two warnings. Scott Steph Fox wrote: Scott, Isn't it just a case of rewriting php_apache_fteller_stream() to use the new API? I think we can actually just add an fsizer function and use apr_brigade_length(pbb-bb);

Re: [PHP-DEV] Apache builds

2008-07-18 Thread Steph Fox
I've committed a fix now and it compiles correctly, I also removed the two warnings. You're the man :) - Steph -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: cvs: php-src(PHP_5_2) / NEWS /main main.c php_ticks.c php_ticks.h

2008-07-18 Thread Markus Fischer
Hi, Now that it has been deprecated (also looking at http://wiki.php.net/doc/scratchpad/upgrade/53?s[]=ticks and http://wiki.php.net/todo/php53?s[]=ticks), I'm wondering whether there's alternative to this functionality? Or is this completely phased out from PHP without a replacement?

Re: [PHP-DEV] Re: cvs: php-src(PHP_5_2) / NEWS /main main.c php_ticks.c php_ticks.h

2008-07-18 Thread Scott MacVicar
It's been removed without a replacement since I don't believe there has been a concrete use case given for it. Apart from a profiler, and for that there is XDebug which does a far better job. Scott On 18 Jul 2008, at 18:42, Markus Fischer wrote: Hi, Now that it has been deprecated (also

Re: [PHP-DEV] Re: cvs: php-src(PHP_5_2) / NEWS /main main.c php_ticks.c php_ticks.h

2008-07-18 Thread Markus Fischer
Hi, Scott MacVicar wrote: It's been removed without a replacement since I don't believe there has been a concrete use case given for it. Probably true, I remember it having used for quite uncommon cases but it was useful (especially in CLI functions, having to work with signals and such).

Re: [PHP-DEV] Re: cvs: php-src(PHP_5_2) / NEWS /main main.c php_ticks.c php_ticks.h

2008-07-18 Thread Scott MacVicar
Markus Fischer wrote: Hi, Scott MacVicar wrote: It's been removed without a replacement since I don't believe there has been a concrete use case given for it. Probably true, I remember it having used for quite uncommon cases but it was useful (especially in CLI functions, having to work

[PHP-DEV] E_USER_DEPRECATED

2008-07-18 Thread Lars Strojny
Hello, I've create a patch to introduce E_USER_DEPRECATED for user level deprecation warnings. I think the purpose is fairly obvious and it corresponds with the rest of our user level errors (E_USER_ERROR, E_USER_WARNING). 5_3: http://lars.schokokeks.org/php/E_USER_DEPRECATED.diff HEAD: