Re: [PHP-DEV] Re: is_a() - again - a better fix

2011-10-06 Thread Jan Schneider
Zitat von Pierre Joye : On Fri, Sep 23, 2011 at 12:23 PM, Rasmus Lerdorf wrote: On 09/23/2011 12:17 PM, Pierre Joye wrote: We do 2) already (while we are working on increasing the amount of apps and frameworks being tested), as I was asking to revert this patch between 5.3.7 and 5.3.8 back

Re: [PHP-DEV] RM decision on BUG #55801 / FR #36424

2011-10-06 Thread Stas Malyshev
Hi! On 10/4/11 6:12 PM, Michael Wallner wrote: Hi, could the release manager(s) please take a decision on mentioned bug/feature request? Could you give a quick summary of what the decision point is just so I won't miss anything scanning through the discussion and these bugs? -- Stanislav Ma

Re: [PHP-DEV] [PATCH] Fix for bug #55754

2011-10-06 Thread Daniel K.
On 09/23/2011 02:06 PM, I wrote: > When a built-in function is defined with ZEND_SEND_PREFER_REF, PHP will > issue a strict warning if you use an assignment expression as the parameter. > > As an example, current() show this behaviour. > > current($foo = array("bar")); > ?> > > Presents you wit

Re: [PHP-DEV] [PATCH] Fix for bug #55754

2011-10-06 Thread Stas Malyshev
Hi! On 10/6/11 5:31 PM, Daniel K. wrote: A patch was appended, discussed, and improved, and I have uploaded a test-case, as well as a minimal patch that fixes the problem (attached) to the original bug-report. https://bugs.php.net/bug.php?id=55754 The patch still applies to trunk, and

Re: [PHP-DEV] [PATCH] Fix for bug #55754

2011-10-06 Thread Etienne Kneuss
Hi, On Thu, Oct 6, 2011 at 17:31, Daniel K. wrote: > On 09/23/2011 02:06 PM, I wrote: >> When a built-in function is defined with ZEND_SEND_PREFER_REF, PHP will >> issue a strict warning if you use an assignment expression as the parameter. >> >> As an example, current() show this behaviour. >> >

Re: [PHP-DEV] [PATCH] Fix for bug #55754

2011-10-06 Thread Daniel K.
On 10/06/2011 05:55 PM, Stas Malyshev wrote: > On 10/6/11 5:31 PM, Daniel K. wrote: >> A patch was appended, discussed, and improved, and I have uploaded a >> test-case, as well as a minimal patch that fixes the problem (attached) >> to the original bug-report. >> >> https://bugs.php.net/bug.p

Re: [PHP-DEV] [PATCH] Fix for bug #55754

2011-10-06 Thread Johannes Schlüter
On Thu, 2011-10-06 at 17:59 +0200, Daniel K. wrote: > On 10/06/2011 05:55 PM, Stas Malyshev wrote: > > On 10/6/11 5:31 PM, Daniel K. wrote: > >> A patch was appended, discussed, and improved, and I have uploaded a > >> test-case, as well as a minimal patch that fixes the problem (attached) > >> to

Re: [PHP-DEV] [PATCH] Fix for bug #55754

2011-10-06 Thread Daniel K.
On 10/06/2011 06:03 PM, Etienne Kneuss wrote: > On Thu, Oct 6, 2011 at 17:31, Daniel K. wrote: >> The patch still applies to trunk, and I think it should be applied to >> the 5.3 and 5.4 branches as well. > > The new patch seems to be indeed better. My only concern is whether it > covers all thos

Re: [PHP-DEV] [PATCH] Fix for bug #55754

2011-10-06 Thread Daniel K.
On 10/06/2011 06:15 PM, Johannes Schlüter wrote: > But please extend the test a bit. The current > one will pass even if the process segfaults. At least print something at > the end. Ah, so that's why some of the tests have 'echo "DONE";' at the end. New test-case uploaded, and attached. Daniel

Re: [PHP-DEV] Re: is_a() - again - a better fix

2011-10-06 Thread Ferenc Kovacs
On Thu, Oct 6, 2011 at 2:49 PM, Jan Schneider wrote: > > Zitat von Pierre Joye : > >> On Fri, Sep 23, 2011 at 12:23 PM, Rasmus Lerdorf >> wrote: >>> >>> On 09/23/2011 12:17 PM, Pierre Joye wrote: >>> We do 2) already (while we are working on increasing the amount of apps and frameworks

[PHP-DEV] Time zone database shut down by legal threat

2011-10-06 Thread David Zülke
FYI: http://blog.joda.org/2011/10/today-time-zone-database-was-closed.html This could impact PHP as well since it bundles the database. David P.S. I hope Google/IBM/Oracle/whoever just buys those guys and then fires everyone. -- PHP Internals - PHP Runtime Development Mailing List To unsubsc

Re: [PHP-DEV] Time zone database shut down by legal threat

2011-10-06 Thread J. Adams
Perhaps we could all contact Astrolabe and voice our complaints? http://alabe.com/ On 10/6/2011 3:24 PM, David Zülke wrote: FYI: http://blog.joda.org/2011/10/today-time-zone-database-was-closed.html This could impact PHP as well since it bundles the database. David P.S. I hope Google/IBM/O

Re: [PHP-DEV] Time zone database shut down by legal threat

2011-10-06 Thread Chris Stockton
Hello, On Thu, Oct 6, 2011 at 4:45 PM, J. Adams wrote: > Perhaps we could all contact Astrolabe and voice our complaints? > > http://alabe.com/ > Not sure how copyright can apply to time? If so put me in for copyright on Mondays.. once I own them I can get rid of them forever! But really, I beli

Re: [PHP-DEV] Time zone database shut down by legal threat

2011-10-06 Thread Larry Garfield
On 10/06/2011 08:53 PM, Chris Stockton wrote: Hello, On Thu, Oct 6, 2011 at 4:45 PM, J. Adams wrote: Perhaps we could all contact Astrolabe and voice our complaints? http://alabe.com/ Not sure how copyright can apply to time? If so put me in for copyright on Mondays.. once I own them I can

RE: [PHP-DEV] Time zone database shut down by legal threat

2011-10-06 Thread John Crenshaw
> From: J. Adams [mailto:zardozro...@gmail.com] > Sent: Thursday, October 06, 2011 7:46 PM > Subject: Re: [PHP-DEV] Time zone database shut down by legal threat > > Perhaps we could all contact Astrolabe and voice our complaints? > > http://alabe.com/ Wow, someone from PR should have really sen

[PHP-DEV] is_a() fix applied to 5.4

2011-10-06 Thread Alan Knowles
Has anyone got objections to applying the 5.3 fixes to 5.4/head I can not see anyway to depreciate the existing behavior and give a E_DEPRECIATED warning to introduce in the current 5_4 behavior. If not I will sort it out next week. Patch: http://svn.php.net/viewvc/php/php-src/branches/PHP_5_