Re: [PHP-DEV] PHP 5.4.10 can not build Zend/PHP parsers with bison 2.6.5

2013-01-16 Thread Ferenc Kovacs
On Tue, Jan 15, 2013 at 9:05 PM, Dennis Clarke dcla...@blastwave.orgwrote: Unless you are hacking PHP you can ignore Bison. Check the Makefile Well, the configure output claims that something is wrong, therefore the build can not be trusted. I'm just following the defacto way to build

[PHP-DEV] Re: Fix for duplicate magic methods calls (bug #63462)

2013-01-16 Thread Dmitry Stogov
Hi Stas, I think the patch is correct and should be committed into 5.3 and above. Thanks. Dmitry. On Mon, Jan 14, 2013 at 12:20 PM, Stas Malyshev smalys...@sugarcrm.comwrote: Hi! I made a fix for bug #63462 - https://github.com/php/php-src/pull/258 - which changes a bit how we do guards by

Re: [PHP-DEV] Re: A problem related to php 5.4.10 and possibly others

2013-01-16 Thread Dennis Clarke
On 01/15/2013 09:07 PM, Dennis Clarke wrote: Number of tests : 12276 8329 Tests skipped : 3947 ( 32.2%) Tests warned:0 ( 0.0%) ( 0.0%) Tests failed:2 ( 0.0%) ( 0.0%) Expected fail : 36 ( 0.3%) ( 0.4%) Tests passed: 8291 ( 67.5%)

Re: [PHP-DEV] PHP 5.4.10 can not build Zend/PHP parsers with bison 2.6.5

2013-01-16 Thread Dennis Clarke
On 01/15/2013 12:09 PM, Dennis Clarke wrote: Of course, if 2.6.5 is verified than it should be added to bison_version_list in Zend/acinclude.m4. Feel free to regenerate the parsers with it, review the test suite results, and create a github pull request. Anything outside of release

Re: [PHP-DEV] PHP 5.4.10 can not build Zend/PHP parsers with bison 2.6.5

2013-01-16 Thread Dennis Clarke
currently we have a whitelist for supported bison versions: http://lxr.php.net/xref/PHP_5_4/Zend/acinclude.m4#6 anything else will be reported, but this doesn't mean that php wouldn't compile with that, it can also mean that nobody tested and made sure that it works. this is why Derick

[PHP-DEV] Memory leak after calling exit() when Zend MM is turned off?

2013-01-16 Thread Pascal Mathis
Hi internals! I am currently developing a Zend extension. Because the Zend MM leak reports are not really useful sometimes, I switched the memory manager off with the environment variable USE_ZEND_ALLOC=0, so that I can use valgrind. Right now I have found some kind of memory leak. You can

Re: [PHP-DEV] Memory leak after calling exit() when Zend MM is turned off?

2013-01-16 Thread Rasmus Lerdorf
On 01/16/2013 02:53 PM, Pascal Mathis wrote: When the Zend memory manager is turned on, everything is fine. Is this behavior intended? We do have some intentional leaks where we rely on the pool allocator to wipe things at the end of a request. So I am less concerned about things you see at

Re: [PHP-DEV] Memory leak after calling exit() when Zend MM is turned off?

2013-01-16 Thread Zeev Suraski
On 16 בינו 2013, at 22:00, Pascal Mathis d...@snapserv.net wrote: Hi internals! I am currently developing a Zend extension. Because the Zend MM leak reports are not really useful sometimes, I switched the memory manager off with the environment variable USE_ZEND_ALLOC=0, so that I can use

Re: [PHP-DEV] [VOTE] zend_parse_parameters() improvements

2013-01-16 Thread Gustavo Lopes
On Wed, 09 Jan 2013 17:19:10 +0100, Gustavo Lopes glo...@nebm.ist.utl.pt wrote: I've opened voting for the zend_parse_parameters() improvements RFC. You can now go to https://wiki.php.net/rfc/zpp_improv#voting The RFC was unanimously accepted. I've merged it to 5.5 in b8603035. Thank

Re: [PHP-DEV] [VOTE] zend_parse_parameters() improvements

2013-01-16 Thread Nikita Popov
On Wed, Jan 16, 2013 at 11:41 PM, Gustavo Lopes glo...@nebm.ist.utl.ptwrote: On Wed, 09 Jan 2013 17:19:10 +0100, Gustavo Lopes glo...@nebm.ist.utl.pt wrote: I've opened voting for the zend_parse_parameters() improvements RFC. You can now go to

[PHP-DEV] Re: [PHP-CVS] com php-src: Bug #63699: performance improvements for varios ext/date functions: NEWS ext/date/php_date.c ext/date/php_date.h

2013-01-16 Thread Christopher Jones
[CC'ing internals.] On 01/16/2013 03:15 PM, Paul Taulborg wrote: On Wed, Jan 16, 2013 at 4:21 PM, Nuno Lopes nlop...@php.net wrote: On Thu, Jan 10, 2013 at 4:59 PM, Nuno Lopes nlop...@php.net wrote: On 01/07/2013 07:27 AM, Paul Taulborg wrote: I would love to write this patch, I'm all in