Re: [PHP-DEV] Functional Interfaces RFC?

2016-06-01 Thread Joe Watkins
Morning, I forgot about that, I just took care of it. Cheers Joe On Thu, Jun 2, 2016 at 1:12 AM, Sara Golemon wrote: > On Wed, Jun 1, 2016 at 4:28 PM, Stanislav Malyshev > wrote: > > The voting for https://wiki.php.net/rfc/functional-interfaces

Re: [PHP-DEV] Voting period for Callable Prototypes RFC?

2016-06-01 Thread Sara Golemon
On Wed, Jun 1, 2016 at 5:07 PM, Stanislav Malyshev wrote: > The vote for https://wiki.php.net/rfc/callable-types started on May > 23th, but the RFC does not have vote end date. For minimal voting period > - 1 week - if should have already ended, unless authors have the reason

Re: [PHP-DEV] Functional Interfaces RFC?

2016-06-01 Thread Sara Golemon
On Wed, Jun 1, 2016 at 4:28 PM, Stanislav Malyshev wrote: > The voting for https://wiki.php.net/rfc/functional-interfaces should be > finished by May 29th but it's still not closed (I presume it should be > closed as declined judging by vote results). Any objections to doing

[PHP-DEV] Voting period for Callable Prototypes RFC?

2016-06-01 Thread Stanislav Malyshev
Hi! The vote for https://wiki.php.net/rfc/callable-types started on May 23th, but the RFC does not have vote end date. For minimal voting period - 1 week - if should have already ended, unless authors have the reason to extend the voting period? Thanks, -- Stas Malyshev smalys...@gmail.com --

[PHP-DEV] Functional Interfaces RFC?

2016-06-01 Thread Stanislav Malyshev
Hi! The voting for https://wiki.php.net/rfc/functional-interfaces should be finished by May 29th but it's still not closed (I presume it should be closed as declined judging by vote results). Any objections to doing it? -- Stas Malyshev smalys...@gmail.com -- PHP Internals - PHP Runtime

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Stanislav Malyshev
Hi! > Please take a look into the proposal. > > > https://wiki.php.net/rfc/too_few_args > > > The RFC is extremely simple (both proposal and implementation) and almost > completely described by the email subject. Looks fine to me. I don't think having undef function parameters is a very

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Aaron Piotrowski
> On Jun 1, 2016, at 3:56 PM, Rowan Collins wrote: > > On 01/06/2016 19:36, Aaron Piotrowski wrote: >> While this might be considered a BC break, I can't imagine there's an actual >> code out there relying on suppressing the warning just to call a function >> without

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Stanislav Malyshev
Hi! > Note that func_get_args() should die too since we have variadic > arguments now. It should not. There is nothing wrong with this function, the fact that some of it's functionality is covered by variadic args notwithstanding. -- Stas Malyshev smalys...@gmail.com -- PHP Internals - PHP

Re: [PHP-DEV] Set object properties inline

2016-06-01 Thread Lester Caine
On 01/06/16 22:09, Rasmus Schultz wrote: > This tendency to "defend" the dynamic side of the language, as though > static features were somehow an "attack" on dynamic features, befuddles me. > > These two sides of the language do not compete with each other - they > complement each other. That

Re: [PHP-DEV] [RFC][VOTE] Closure from callable

2016-06-01 Thread Dan Ackroyd
> On 15 May 2016, at 20:29, Dan Ackroyd wrote: > Hello, > > I've opened the voting for the Closure from callable RFC - > https://wiki.php.net/rfc/closurefromcallable Voting was closed, the RFC has passed 40-0. Thanks again to Bob, for helping with (aka doing most of) the

Re: [PHP-DEV] Set object properties inline

2016-06-01 Thread Rasmus Schultz
> The drive to make everything as 'static' as possible misses > the whole point that PHP is a DYNAMIC scripting system. I think that line of argumentation is pretty outdated - it may have been valid many years ago, but by now, PHP is not purely dynamic; far from it. It's a gradually-typed

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Rowan Collins
On 01/06/2016 19:36, Aaron Piotrowski wrote: While this might be considered a BC break, I can't imagine there's an actual code out there relying on suppressing the warning just to call a function without enough arguments. I see no problem putting this change in 7.1. I think you're

Re: [PHP-DEV] Set object properties inline

2016-06-01 Thread Lester Caine
On 01/06/16 21:09, Jesse Schalken wrote: > On Wed, Jun 1, 2016 at 7:40 PM, Lester Caine wrote: > >> Morphed into simply passing an array to the constructor ... >> >> $static1 = new Data\StaticVariable( array( >> 'name' => 'variable name', >>

Re: [PHP-DEV] Set object properties inline

2016-06-01 Thread Jesse Schalken
On Thu, Jun 2, 2016 at 12:38 AM, guilhermebla...@gmail.com < guilhermebla...@gmail.com> wrote: > Hi, > > I very much liked the proposal, specially if we do consider a potential > reusability if anyone ever decide to revisit Attributes RFC. It's out of > scope how I'd see this implemented, so let

Re: [PHP-DEV] Set object properties inline

2016-06-01 Thread Jesse Schalken
On Wed, Jun 1, 2016 at 7:49 PM, Peter Cowburn wrote: > > While it's not as concise as your example, anonymous classes can do this > already after a fashion. > > $this->fooMethod( > $arg1, > $arg2, > new class() extends FooParams { > // Constructor

Re: [PHP-DEV] Set object properties inline

2016-06-01 Thread Jesse Schalken
On Wed, Jun 1, 2016 at 7:40 PM, Lester Caine wrote: > Morphed into simply passing an array to the constructor ... > > $static1 = new Data\StaticVariable( array( > 'name' => 'variable name', > 'value'=> $unknown1, >

Re: [PHP-DEV] [RFC] Libsodium - Discussion

2016-06-01 Thread Ronald Chmara
On Wed, Jun 1, 2016 at 10:26 AM, Fleshgrinder wrote: > On 6/1/2016 12:48 PM, Marco Pivetta wrote: >> I also agree with Remi on naming: let's avoid calling the extension >> `libsodium`. > On 6/1/2016 12:48 PM, Marco Pivetta wrote: >> 1. is there a particular reason why

Re: [PHP-DEV] [RFC] Libsodium - Discussion

2016-06-01 Thread Niklas Keller
Fleshgrinder schrieb am Mi., 1. Juni 2016 19:26: > On 6/1/2016 12:48 PM, Marco Pivetta wrote: > > > I also agree with Remi on naming: let's avoid calling the extension > > `libsodium`. > > > > I agree here too. > > On 6/1/2016 12:48 PM, Marco Pivetta wrote: > > 1. is

Re: [PHP-DEV] Set object properties inline

2016-06-01 Thread Alex Duchesne
On 2016-05-31 22:15, Jesse Schalken wrote: Hi internals, I often have code dealing with plain old PHP objects with properties and no methods, either as a substitute for keyword arguments, or to represent a JSON or YAML document for a web service, configuration file or schemaless database. At

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Nikita Popov
On Wed, Jun 1, 2016 at 8:24 PM, Dmitry Stogov wrote: > In the SSA optimisation framework (part of opcache), we predict and > propagate types of variables. > > We also may detect situations when some variables may be undefined. > > If variable can't be "undefined", we may avoid

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Aaron Piotrowski
> > On Jun 1, 2016, at 5:55 AM, Dmitry Stogov wrote: > > hi, > > > Please take a look into the proposal. > > > https://wiki.php.net/rfc/too_few_args > > > The RFC is extremely simple (both proposal and implementation) and almost > completely described by the email

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Dmitry Stogov
In the SSA optimisation framework (part of opcache), we predict and propagate types of variables. We also may detect situations when some variables may be undefined. If variable can't be "undefined", we may avoid unnecessary run-time checks (e.g .like in ZEND_ADD_LONG handler). Local

Re: [PHP-DEV] [RFC] Libsodium - Discussion

2016-06-01 Thread Fleshgrinder
On 6/1/2016 7:53 PM, Scott Arciszewski wrote: > ​Well, for what it's worth, I did write https://github.com/paragonie/halite > ​ as a high-level abstraction. > This looks over engineered too me, no offense! On 6/1/2016 7:53 PM, Scott Arciszewski wrote: > The goal of this RFC is to get the

Re: [PHP-DEV] [RFC] Libsodium - Discussion

2016-06-01 Thread Scott Arciszewski
On Wed, Jun 1, 2016 at 1:26 PM, Fleshgrinder wrote: > On 6/1/2016 12:48 PM, Marco Pivetta wrote: > > > I also agree with Remi on naming: let's avoid calling the extension > > `libsodium`. > > > > I agree here too. > > On 6/1/2016 12:48 PM, Marco Pivetta wrote: > > 1. is

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Joe Watkins
Evening, Could you expand on the "obvious optimization opportunities" in the document ? They are not obvious to me, and even if they were, this document is part of the history of this change, so a little more detail would be nice. Cheers Joe On Wed, Jun 1, 2016 at 11:55 AM, Dmitry

Re: [PHP-DEV] Set object properties inline

2016-06-01 Thread Fleshgrinder
On 6/1/2016 5:47 PM, Ryan Pallas wrote: > On Wed, Jun 1, 2016 at 9:37 AM, Matt Fonda wrote: >> >> >> Hi Jesse, >> >> It's fairly straightforward to implement a function that does this in >> userland, for example something like the following: >> >> function f($fqcn, $args)

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Fleshgrinder
On 6/1/2016 1:33 PM, Rowan Collins wrote: > I like the concept behind this, but I worry it might have a rather large > BC impact. Like removing call-time pass-by-reference, there may be a lot > of long-untouched code that needs fixing to work within this constraint. > I'm not even sure how easy it

Re: [PHP-DEV] [RFC] Libsodium - Discussion

2016-06-01 Thread Fleshgrinder
On 6/1/2016 12:48 PM, Marco Pivetta wrote: > I also agree with Remi on naming: let's avoid calling the extension > `libsodium`. > I agree here too. On 6/1/2016 12:48 PM, Marco Pivetta wrote: > 1. is there a particular reason why abbreviations are used? For instance, > why

Re: [PHP-DEV] Set object properties inline

2016-06-01 Thread Ryan Pallas
On Wed, Jun 1, 2016 at 9:37 AM, Matt Fonda wrote: > > > Hi Jesse, > > It's fairly straightforward to implement a function that does this in > userland, for example something like the following: > > function f($fqcn, $args) { > $instance = new $fqcn; > foreach

Re: [PHP-DEV] Set object properties inline

2016-06-01 Thread Matt Fonda
On Tue, May 31, 2016 at 7:15 PM, Jesse Schalken wrote: > Hi internals, > > I often have code dealing with plain old PHP objects with properties and no > methods, either as a substitute for keyword arguments, or to represent a > JSON or YAML document for a web service,

Re: [PHP-DEV] Set object properties inline

2016-06-01 Thread guilhermebla...@gmail.com
Hi, I very much liked the proposal, specially if we do consider a potential reusability if anyone ever decide to revisit Attributes RFC. It's out of scope how I'd see this implemented, so let me focus on the proposal only. There're some edge cases that need to be discussed and considered here.

Re: [PHP-DEV] [RFC] Libsodium - Discussion

2016-06-01 Thread Scott Arciszewski
On Wed, Jun 1, 2016 at 9:46 AM, Marco Pivetta wrote: > On 1 June 2016 at 15:45, Scott Arciszewski wrote: > >> On Wed, Jun 1, 2016 at 6:48 AM, Marco Pivetta wrote: >> >>> Hey Scott, >>> >>> On 1 June 2016 at 09:49, Scott Arciszewski

Re: [PHP-DEV] [RFC] Libsodium - Discussion

2016-06-01 Thread Scott Arciszewski
On Wed, Jun 1, 2016 at 9:46 AM, Marco Pivetta wrote: > On 1 June 2016 at 15:45, Scott Arciszewski wrote: > >> On Wed, Jun 1, 2016 at 6:48 AM, Marco Pivetta wrote: >> >>> Hey Scott, >>> >>> On 1 June 2016 at 09:49, Scott Arciszewski

Re: [PHP-DEV] [RFC] Libsodium - Discussion

2016-06-01 Thread Marco Pivetta
On 1 June 2016 at 15:45, Scott Arciszewski wrote: > On Wed, Jun 1, 2016 at 6:48 AM, Marco Pivetta wrote: > >> Hey Scott, >> >> On 1 June 2016 at 09:49, Scott Arciszewski wrote: >> >>> Hi PHP Internals Team, >>> >>> Let's begin

Re: [PHP-DEV] [RFC] Libsodium - Discussion

2016-06-01 Thread Scott Arciszewski
On Wed, Jun 1, 2016 at 6:48 AM, Marco Pivetta wrote: > Hey Scott, > > On 1 June 2016 at 09:49, Scott Arciszewski wrote: > >> Hi PHP Internals Team, >> >> Let's begin discussing the prospect of adding libsodium as a core >> extension >> in PHP 7.1. I've

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Rowan Collins
On 01/06/2016 11:55, Dmitry Stogov wrote: hi, Please take a look into the proposal. https://wiki.php.net/rfc/too_few_args The RFC is extremely simple (both proposal and implementation) and almost completely described by the email subject. I think, this mini-RFC doesn't need 2-weeks

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Dmitry Stogov
func_get_args() useful, when we pass more actual parameters than expected. This case is unaffected. Thanks. Dmitry. From: Florian Anderiasch Sent: Wednesday, June 1, 2016 2:08:09 PM To: Dmitry Stogov; PHP internals Cc: Nikita Popov

Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Florian Anderiasch
On 06/01/2016 12:55 PM, Dmitry Stogov wrote: > hi, > Please take a look into the proposal. > > https://wiki.php.net/rfc/too_few_args My first thought went into how people use func_get_args() as this is (in a sense) the opposite thereof. That said I couldn't think of a good reason to disagree,

[PHP-DEV] GOOD Benchmark Results for PHP Master 2016-06-01

2016-06-01 Thread lp_benchmark_robot
Results for project PHP master, build date 2016-06-01 06:28:21+03:00 commit: 51b3be7 previous commit:b111da9 revision date: 2016-05-31 22:41:37+00:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

[PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception

2016-06-01 Thread Dmitry Stogov
hi, Please take a look into the proposal. https://wiki.php.net/rfc/too_few_args The RFC is extremely simple (both proposal and implementation) and almost completely described by the email subject. I think, this mini-RFC doesn't need 2-weeks discussion period, so I'm going to start the

Re: [PHP-DEV] [RFC] Libsodium - Discussion

2016-06-01 Thread Marco Pivetta
Hey Scott, On 1 June 2016 at 09:49, Scott Arciszewski wrote: > Hi PHP Internals Team, > > Let's begin discussing the prospect of adding libsodium as a core extension > in PHP 7.1. I've updated the RFC to explain why this would be a good idea > and the benefits it offers. >

Re: [PHP-DEV] Set object properties inline

2016-06-01 Thread Peter Cowburn
On 1 June 2016 at 03:15, Jesse Schalken wrote: > Hi internals, > > I often have code dealing with plain old PHP objects with properties and no > methods, either as a substitute for keyword arguments, or to represent a > JSON or YAML document for a web service,

Re: [PHP-DEV] Set object properties inline

2016-06-01 Thread Lester Caine
On 01/06/16 03:15, Jesse Schalken wrote: > For large structures, this gets verbose very quick. There is a good example > of this here > > involving > 18 unnecessarily

Re: [PHP-DEV] [RFC] Libsodium - Discussion

2016-06-01 Thread Remi Collet
Le 01/06/2016 à 09:49, Scott Arciszewski a écrit : > Hi PHP Internals Team, > > Let's begin discussing the prospect of adding libsodium as a core extension > in PHP 7.1. I've updated the RFC to explain why this would be a good idea > and the benefits it offers. > >

Re: [PHP-DEV] [RFC] Libsodium - Discussion

2016-06-01 Thread Julien Pauli
On Wed, Jun 1, 2016 at 9:49 AM, Scott Arciszewski wrote: > Hi PHP Internals Team, > > Let's begin discussing the prospect of adding libsodium as a core extension > in PHP 7.1. I've updated the RFC to explain why this would be a good idea > and the benefits it offers. > >

[PHP-DEV] [RFC] Libsodium - Discussion

2016-06-01 Thread Scott Arciszewski
Hi PHP Internals Team, Let's begin discussing the prospect of adding libsodium as a core extension in PHP 7.1. I've updated the RFC to explain why this would be a good idea and the benefits it offers. https://wiki.php.net/rfc/libsodium If the subsequent discussion goes smoothly, I would like to