Re: [PHP-DEV] [RFC] Enable strict_types checking for curl_setopt()

2017-04-28 Thread Sara Golemon
On Fri, Apr 28, 2017 at 6:05 PM, Rowan Collins wrote: >>I reject the idea of making a worse API for the sake of an artificial >>purity standard which has long since been violated elsewhere. > > Personally, I think if we were designing from scratch, having a > setHeaders method which took an array

Re: [PHP-DEV] [RFC] Enable strict_types checking for curl_setopt()

2017-04-28 Thread Rowan Collins
On 28 April 2017 22:30:35 BST, Sara Golemon wrote: >On Fri, Apr 28, 2017 at 2:29 PM, Rowan Collins > wrote: >> On 28 April 2017 18:54:09 BST, Sara Golemon wrote: >>>On Fri, Apr 28, 2017 at 9:34 AM, Markus Fischer >>>wrote: To me the intention of strict types is clearly on the functions >>>p

[PHP-DEV] GOOD Benchmark Results for PHP Master 2017-04-27

2017-04-28 Thread lp_benchmark_robot
Results for project PHP master, build date 2017-04-27 19:26:30-07:00 commit: 1466a0f previous commit:67b701a revision date: 2017-04-27 15:46:17+01:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] [RFC] Enable strict_types checking for curl_setopt()

2017-04-28 Thread Sara Golemon
On Fri, Apr 28, 2017 at 2:29 PM, Rowan Collins wrote: > On 28 April 2017 18:54:09 BST, Sara Golemon wrote: >>On Fri, Apr 28, 2017 at 9:34 AM, Markus Fischer >>wrote: >>> To me the intention of strict types is clearly on the functions >>publicly >>> visible contract, i.e. it's reflectable paramet

Re: [PHP-DEV] [RFC] Enable strict_types checking for curl_setopt()

2017-04-28 Thread Rowan Collins
On 28 April 2017 18:54:09 BST, Sara Golemon wrote: >On Fri, Apr 28, 2017 at 9:34 AM, Markus Fischer >wrote: >> To me the intention of strict types is clearly on the functions >publicly >> visible contract, i.e. it's reflectable parameters and not some >business >> logic hidden inside a function.

Re: [PHP-DEV] [RFC] Enable strict_types checking for curl_setopt()

2017-04-28 Thread Sara Golemon
On Fri, Apr 28, 2017 at 9:34 AM, Markus Fischer wrote: > To me the intention of strict types is clearly on the functions publicly > visible contract, i.e. it's reflectable parameters and not some business > logic hidden inside a function. > So you feel that declare(strict_types=1); should never ap

Re: [PHP-DEV] [RFC] Enable strict_types checking for curl_setopt()

2017-04-28 Thread Markus Fischer
Hi, On 22.04.17 13:40, Colin O'Dell wrote: Hello internals, I'd like to propose an enhancement to curl_setopt() which is used to configure a given curl session. The second argument of this function defines which option to set and the third ar

[PHP-DEV] PHP 7.0.19RC1 is available for testing

2017-04-28 Thread Anatol Belski
Hi, PHP 7.0.19 RC1 was just released and can be downloaded from: https://downloads.php.net/~ab/ The Windows binaries are available at http://windows.php.net/qa/ This release contains a number of bugfixes. For the list of bugfixes that you can target in your testing, please refer to th

Re: [PHP-DEV] [RFC] concept: further improvement of filter extension, "generalising" filter definitons while adding new callback filter type

2017-04-28 Thread Dan Ackroyd
On 28 April 2017 at 03:49, Martin "eto" Misuth wrote: > would make maintaining such library much easier No. Maintaining stuff in PHP core is much more difficult than maintaining it in userland. 'Maintaining' doesn't just mean fixing bugs, it includes thinking about how any changes to APIs get ro