Re: [PHP-DEV] re2c version(s)

2018-07-13 Thread Sara Golemon
> On Jul 14, 2018, at 00:02, Jan Ehrhardt wrote: > > Stanislav Malyshev in php.internals (Fri, 13 Jul 2018 11:40:12 -0700): >>> re2c is widely available on Linux distros nowadays (probably >> >> On Linux distros on common platforms (Intel/AMD) - sure. But what if you >> need an uncommon

Re: [PHP-DEV] re2c version(s)

2018-07-13 Thread Jan Ehrhardt
Stanislav Malyshev in php.internals (Fri, 13 Jul 2018 11:40:12 -0700): >> re2c is widely available on Linux distros nowadays (probably > >On Linux distros on common platforms (Intel/AMD) - sure. But what if you >need an uncommon platform, or one that does not run Linux? It's those >platforms where

Re: [PHP-DEV] [VOTE] array_key_first(), array_key_last(), array_value_first(), array_value_last()

2018-07-13 Thread Levi Morrison
On Fri, Jul 13, 2018 at 4:48 PM Levi Morrison wrote: > > On Mon, Jul 9, 2018 at 5:17 AM Woortmann, Enno wrote: > > > > Hi, > > > > as the discussion got no new contributions I'd like to start the voting > > for the RFC fo add new functions for the handling of outer array elements. > > > >

Re: [PHP-DEV] [VOTE] array_key_first(), array_key_last(), array_value_first(), array_value_last()

2018-07-13 Thread Levi Morrison
On Mon, Jul 9, 2018 at 5:17 AM Woortmann, Enno wrote: > > Hi, > > as the discussion got no new contributions I'd like to start the voting > for the RFC fo add new functions for the handling of outer array elements. > > https://wiki.php.net/rfc/array_key_first_last > > To have a better separation

Re: [PHP-DEV] re2c version(s)

2018-07-13 Thread Alice Wonder
On 07/13/2018 01:27 PM, Sara Golemon wrote: On Fri, Jul 13, 2018 at 3:08 PM, Anatol Belski wrote: *snip* Well, whichever version we've settled on, I've updated sgolemon/php-release to allow using arbitrary versions of re2c.

RE: [PHP-DEV] re2c version(s)

2018-07-13 Thread Zeev Suraski
> -Original Message- > From: Nikita Popov [mailto:nikita@gmail.com] > Sent: Friday, July 13, 2018 12:26 PM > To: Dmitry Stogov > Cc: PHP internals list ; Stanislav Malyshev > ; der...@derickrethans.nl; Christoph M. Becker > > Subject: Re: [PHP-DEV] re2c version(s) > > On Fri, Jul

Re: [PHP-DEV] re2c version(s)

2018-07-13 Thread Christoph M. Becker
On 13.07.2018 at 21:07, Sara Golemon wrote: > **Checks snaps.php.net** > wait, is this not a thing anymore? IIRC, that was already gone before I got my php.net account. Nowadays users are supposed to checkout from Git. -- Christoph M. Becker -- PHP Internals - PHP Runtime Development

RE: [PHP-DEV] re2c version(s)

2018-07-13 Thread Anatol Belski
> -Original Message- > From: p...@golemon.com On Behalf Of Sara Golemon > Sent: Friday, July 13, 2018 10:27 PM > To: Anatol Belski > Cc: Dmitry Stogov ; Nikita Popov ; > PHP internals list ; Stanislav Malyshev > ; der...@derickrethans.nl; Christoph M. Becker > > Subject: Re: [PHP-DEV]

Re: [PHP-DEV] re2c version(s)

2018-07-13 Thread Sara Golemon
On Fri, Jul 13, 2018 at 3:08 PM, Anatol Belski wrote: >> I ask, because my release builder for 7.2 (and 7.1 if Joe is using >> Davey's builder) is using re2c 0.13.5 . I don't imagine the risk of >> updating re2c mid-relase is particularly high, but it is non-zero. >> > Normally RMs would define

RE: [PHP-DEV] re2c version(s)

2018-07-13 Thread Anatol Belski
> -Original Message- > From: Stanislav Malyshev > Sent: Friday, July 13, 2018 8:46 PM > To: Nikita Popov ; Dmitry Stogov > Cc: PHP internals list ; der...@derickrethans.nl; > Christoph M. Becker > Subject: Re: [PHP-DEV] re2c version(s) > > Hi! > > > On Linux distros on common

Re: [PHP-DEV] re2c version(s)

2018-07-13 Thread Nikita Popov
On Fri, Jul 13, 2018 at 8:40 PM, Stanislav Malyshev wrote: > Hi! > > > re2c is widely available on Linux distros nowadays (probably > > On Linux distros on common platforms (Intel/AMD) - sure. But what if you > need an uncommon platform, or one that does not run Linux? It's those > platforms

RE: [PHP-DEV] re2c version(s)

2018-07-13 Thread Anatol Belski
Hi, > -Original Message- > From: p...@golemon.com On Behalf Of Sara Golemon > Sent: Friday, July 13, 2018 8:22 PM > To: Dmitry Stogov > Cc: Nikita Popov ; PHP internals list > ; Stanislav Malyshev ; > der...@derickrethans.nl; Christoph M. Becker > Subject: Re: [PHP-DEV] re2c version(s)

Re: [PHP-DEV] re2c version(s)

2018-07-13 Thread Sara Golemon
On Fri, Jul 13, 2018 at 2:40 PM, Stanislav Malyshev wrote: >> re2c is widely available on Linux distros nowadays (probably > > On Linux distros on common platforms (Intel/AMD) - sure. But what if you > need an uncommon platform, or one that does not run Linux? It's those > platforms where you'd

Re: [PHP-DEV] re2c version(s)

2018-07-13 Thread Stanislav Malyshev
Hi! > On Linux distros on common platforms (Intel/AMD) - sure. But what if you > need an uncommon platform, or one that does not run Linux? It's those > platforms where you'd have to build PHP from source (after all, PHP is > also widely available as a package on Linux distros anyway) and adding

Re: [PHP-DEV] re2c version(s)

2018-07-13 Thread Stanislav Malyshev
Hi! > the timelib files *must* be generated with 0.15.3: > https://github.com/mongodb/mongo/blob/master/src/third_party/scripts/timelib_get_sources.sh#L10-L11 That comment says 0.16 was problematic. Is it still true for 1.0.*? Was it reported to re2c? -- Stas Malyshev smalys...@gmail.com --

Re: [PHP-DEV] re2c version(s)

2018-07-13 Thread Stanislav Malyshev
Hi! > re2c is widely available on Linux distros nowadays (probably On Linux distros on common platforms (Intel/AMD) - sure. But what if you need an uncommon platform, or one that does not run Linux? It's those platforms where you'd have to build PHP from source (after all, PHP is also widely

Re: [PHP-DEV] re2c version(s)

2018-07-13 Thread Sara Golemon
On Fri, Jul 13, 2018 at 7:00 AM, Dmitry Stogov wrote: > OK. Dropping files and requirement for re2c 1.0.0. Right? > +1 to removing them from git (except timelib as Derick noted). The minimum requirement is reasonable in terms of reproducibility, but should that be specific to master/7.3? I ask,

Re: [PHP-DEV] re2c version(s)

2018-07-13 Thread Christoph M. Becker
On 13.07.2018 at 11:26, Nikita Popov wrote: > On Fri, Jul 13, 2018 at 11:13 AM, Dmitry Stogov wrote: > >> I propose, to change build scripts (in master and PHP-7.3) to require at >> least re2c version 1.0.0 (it seems 1.0.0-1.0.3 produce the same result) and >> suppress version output into the

Re: [PHP-DEV] re2c version(s)

2018-07-13 Thread Dmitry Stogov
Hi Nikita, OK. Dropping files and requirement for re2c 1.0.0. Right? Thanks. Dmitry. From: Nikita Popov Sent: Friday, July 13, 2018 12:26:22 PM To: Dmitry Stogov Cc: PHP internals list; Stanislav Malyshev; der...@derickrethans.nl; Christoph M. Becker

Re: [PHP-DEV] [RFC] Typed Properties

2018-07-13 Thread Rowan Collins
On 11 July 2018 at 14:44, Levi Morrison wrote: > > My logic is quite simple: > > 1. Something as big as Typed Properties shouldn't be a last minute, > rushed > > RFC. Really - any RFC shouldn't - but in particular major language > changes. > > I have seen this sentiment expressed elsewhere. I

Re: [PHP-DEV] re2c version(s)

2018-07-13 Thread Derick Rethans
On Fri, 13 Jul 2018, Nikita Popov wrote: > On Fri, Jul 13, 2018 at 11:13 AM, Dmitry Stogov wrote: > > > I think, many core developers saw unexpected changes in > > "zend_labguages_scanner.c" or "var_unserializer.c" after rebuilds. > > > > This occurs, because we use different versions of re2c,

Re: [PHP-DEV] re2c version(s)

2018-07-13 Thread Nikita Popov
On Fri, Jul 13, 2018 at 11:13 AM, Dmitry Stogov wrote: > Hi, > > > I think, many core developers saw unexpected changes in > "zend_labguages_scanner.c" or "var_unserializer.c" after rebuilds. > > This occurs, because we use different versions of re2c, and some of them > produce really different

[PHP-DEV] re2c version(s)

2018-07-13 Thread Dmitry Stogov
Hi, I think, many core developers saw unexpected changes in "zend_labguages_scanner.c" or "var_unserializer.c" after rebuilds. This occurs, because we use different versions of re2c, and some of them produce really different code. They also embed version number into the generate source.