Re: [PHP-DEV] Re: Finishing AVIF support in getimagesize()

On Thu, Dec 9, 2021, 18:56 Christoph M. Becker wrote: > On 09.12.2021 at 20:59, Flávio Heleno wrote: > > > On Thu, Dec 9, 2021 at 4:46 PM Nikita Popov > wrote: > > > >> On Wed, Dec 8, 2021 at 12:41 PM Christoph M. Becker > >> wrote: > >> > >>> On 01.12.2021 at 00:52, Ben Morss via internals wro

Re: [PHP-DEV] Why do PHP 8.1 extensions need PHP headers during make install (worked in <8.1)?

Ahhh okay that explains where this change is coming from. Thanks a lot, Dan! I wonder if this side effect ("all dependencies are iterated also during "make install") is intentional. Maybe Niki can chime in on GitHub; I'll ping him there, as well as the original author. Thanks a lot! David P.S.

Re: [PHP-DEV] Why do PHP 8.1 extensions need PHP headers during make install (worked in <8.1)?

Thanks for your response! I'm not removing PHP before *compiling*, I am removing it before *installing*: 1) download/extract PHP (as a build dependency) to $PREFIX 2) phpize 3) ./configure --prefix=$PREFIX 4) make 5) remove PHP from $PREFIX 6) make install The purpose is to have a clean $PREFIX d

Re: [PHP-DEV] Re: Finishing AVIF support in getimagesize()

On 09.12.2021 at 20:59, Flávio Heleno wrote: > On Thu, Dec 9, 2021 at 4:46 PM Nikita Popov wrote: > >> On Wed, Dec 8, 2021 at 12:41 PM Christoph M. Becker >> wrote: >> >>> On 01.12.2021 at 00:52, Ben Morss via internals wrote: >>> Earlier this year, I added support for AVIF images

Re: [PHP-DEV] Re: Finishing AVIF support in getimagesize()

Thanks for the discussion, everyone! Fortunately there are no licensing concerns, as the author is making this code available to be copied and pasted freely. And we've already got the build flag for avif. I'll be excited to see getimagesize() actually return the size for AVIF images ☺️ On Thu,

[PHP-DEV] Discussion array_get_type()

Hello, since there are currently no type declarations for specific arrays (int[], string[], MyClass[], etc.), I'd like to ask if it would make sense to have a function array_get_type() in php core? As I'm not a C developer, I can only ask for your help for the implementation. I think having it

Re: [PHP-DEV] Allow default parameters before non-default ones?

On 09/12/2021 21:07, Rowan Tommins wrote: For some reason, the CI build failed on that PR, but on unrelated files, so I'm not sure if it's my fault or not. Ah no, it was me. Build passing now. -- Rowan Tommins [IMSoP] -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe,

Re: [PHP-DEV] Allow default parameters before non-default ones?

On 09/12/2021 12:45, Christoph M. Becker wrote: The new behavior has been introduced[1] quite a while after this mail had been sent. I agree with the idea outlined in the commit message. I suggest to document that in the migration guide, and in the manual proper. Good spot. I guess it does m

[PHP-DEV] [RFC] User Defined Operator Overloads (v0.6)

Hello internals, I last brought this RFC up for discussion in August, and there was certainly interesting discussion. Since then there have been many improvements, and I'd like to re-open discussion on this RFC. I mentioned in the first email to the list that I was planning on taking a while befor

Re: [PHP-DEV] Automatic implementation of Stringable may conflict with old, untyped arginfo declarations

On Wed, 8 Dec 2021 at 16:02, Jeremy Mikola wrote: > > > We haven't explored using stubs, but I'll keep that in mind. ... > (which we plan to do since we finally dropped support for PHP > 7.1). > FYI, the stub files maintain #ifdef info through their processing, which allows some useful shenaniga

Re: [PHP-DEV] Re: Finishing AVIF support in getimagesize()

On Thu, Dec 9, 2021 at 4:46 PM Nikita Popov wrote: > On Wed, Dec 8, 2021 at 12:41 PM Christoph M. Becker > wrote: > > > On 01.12.2021 at 00:52, Ben Morss via internals wrote: > > > > > Earlier this year, I added support for AVIF images > > > to libgd > >

Re: [PHP-DEV] Re: Finishing AVIF support in getimagesize()

On Wed, Dec 8, 2021 at 12:41 PM Christoph M. Becker wrote: > On 01.12.2021 at 00:52, Ben Morss via internals wrote: > > > Earlier this year, I added support for AVIF images > > to libgd > > . My ultimate goal was to bring s

Re: [PHP-DEV] Why do PHP 8.1 extensions need PHP headers during make install (worked in <8.1)?

On Thu, 9 Dec 2021 at 19:28, Dan Ackroyd wrote: > > Is this intentional? If so, could someone explain the purpose of the > > change? > > Probably to make the build process less flaky, by explicitly checking > dependencies, so that there are fewer instances of "stuffs not > working.I guess I'

Re: [PHP-DEV] Why do PHP 8.1 extensions need PHP headers during make install (worked in <8.1)?

On Wed, 8 Dec 2021 at 15:25, David Zuelke via internals wrote: > > That doesn't work with PHP 8.1 anymore - the Makefile generated by > phpize now contains an include directive at the top level (near the > bottom), e.g.: > > -include src/php_raphf_api.dep The file src/php_raphf_api.dep is created

Re: [PHP-DEV] Why do PHP 8.1 extensions need PHP headers during make install (worked in <8.1)?

See my previous messages; there's step by step output where I trigger it with your extension by renaming the directory containing the PHP it's built against (this obviously requires you have a PHP that's built with --prefix=/usr/local/myphpbuild or whatever). I suppose the solution for now is to u

Re: [PHP-DEV] Why do PHP 8.1 extensions need PHP headers during make install (worked in <8.1)?

Right. > configure && make && make install works. For my personal information : Now which command should I use to get the error ? Le jeu. 9 déc. 2021 à 17:34, David Zuelke a écrit : > Of course a 'make && make install' works. That is *not* what's broken > since 8.1, and not what I'm talking ab

Re: [PHP-DEV] Why do PHP 8.1 extensions need PHP headers during make install (worked in <8.1)?

Of course a 'make && make install' works. That is *not* what's broken since 8.1, and not what I'm talking about. On Thu, Dec 9, 2021 at 4:53 PM Glash Gnome wrote: > > Thanks a lot. > I use PHP 8.2.0-dev (cli) (built: Dec 8 2021 23:53:19) (NTS) > And I can't reproduce the error with my build pro

Re: [PHP-DEV] Why do PHP 8.1 extensions need PHP headers during make install (worked in <8.1)?

Thanks a lot. I use PHP 8.2.0-dev (cli) (built: Dec 8 2021 23:53:19) (NTS) And I can't reproduce the error with my build procedure. But, if I use "make -d install' insteadof *"make && make install'* I get errors. Can you confirm it ? Le jeu. 9 déc. 2021 à 03:19, David Zuelke a écrit : > Ye

Re: [PHP-DEV] Allow default parameters before non-default ones?

On 09.12.2021 at 13:03, Rowan Tommins wrote: > On 09/12/2021 05:22, André Hänsel wrote: > >> If I try the same thing in PHP 8.0 I get a Deprecated warning and if I >> try >> it in PHP 8.1 I get something that I don't understand: >> https://3v4l.org/cg4DA > > There are two diagnostics showing in 8.

Re: [PHP-DEV] Allow default parameters before non-default ones?

On 09/12/2021 05:22, André Hänsel wrote: If I try the same thing in PHP 8.0 I get a Deprecated warning and if I try it in PHP 8.1 I get something that I don't understand: https://3v4l.org/cg4DA There are two diagnostics showing in 8.1, the deprecation on the declaration, and a fatal error on

Re: [PHP-DEV] Re: Allow default parameters before non-default ones?

On Thu, Dec 9, 2021 at 6:48 AM Mark Randall wrote: > On 09/12/2021 05:22, André Hänsel wrote: > > This is very useful because I can add an optional parameter to a function > > and prevent users of my function from using the parameter in a positional > > way. This way I don't have to make a compat