Re: [PHP-DEV] [Discussion] Expand deprecation notice scope for partially supported callables

2022-05-30 Thread Guilliam Xavier
Hi Dan, just an error in this part: > Or if support for less than PHP 8.1 can be dropped, using the first > class callable syntax > https://wiki.php.net/rfc/first_class_callable_syntax : > > if (is_callable(static::methodName(...))) { > static::methodName(); > } > > or > > $fn =

Re: [PHP-DEV] [Discussion] Expand deprecation notice scope for partially supported callables

2022-05-29 Thread Juliette Reinders Folmer
Hi Dan, On 29-5-2022 17:34, Dan Ackroyd wrote: Actually, I've just realised there is an error in the code in the RFC, which might be based on a misconception caused by how terrible callables are. In the code: if (is_callable('static::methodName')) { // For valid callbacks, this call will

Re: [PHP-DEV] [Discussion] Expand deprecation notice scope for partially supported callables

2022-05-29 Thread Dan Ackroyd
On Sun, 29 May 2022 at 16:34, Dan Ackroyd wrote: > > *an incorrect name* Apologies for writing your name incorrectly. That should of course have been addressed to Juliette. cheers Dan Ack -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit:

Re: [PHP-DEV] [Discussion] Expand deprecation notice scope for partially supported callables

2022-05-29 Thread Dan Ackroyd
Hi Julie, On Sat, 28 May 2022 at 09:22, Juliette Reinders Folmer wrote: > > I admit, I puzzled over this for a little and wanted to take the time to > respond properly before opening the vote, so I'm delaying the start of the > vote until beginning of the upcoming week. Cool. Actually, I've

Re: [PHP-DEV] [Discussion] Expand deprecation notice scope for partially supported callables

2022-05-28 Thread Juliette Reinders Folmer
On 26-5-2022 20:23, Dan Ackroyd wrote: Hey Julie, On Thu, 26 May 2022 at 12:45, Juliette Reinders Folmer wrote: I propose to open the vote on this RFC tomorrow. Before you open the vote, please could you split the voting into two, one for the is_callable, and one for the callable type check?

Re: [PHP-DEV] Re: ***SPAM*** [PHP-DEV] [Discussion] Expand deprecation notice scope for partially supported callables

2022-05-26 Thread Dan Ackroyd
Hey Julie, On Thu, 26 May 2022 at 12:45, Juliette Reinders Folmer wrote: > > I propose to open the vote on this RFC tomorrow. Before you open the vote, please could you split the voting into two, one for the is_callable, and one for the callable type check? Rowan wrote in

[PHP-DEV] Re: ***SPAM*** [PHP-DEV] [Discussion] Expand deprecation notice scope for partially supported callables

2022-05-26 Thread Juliette Reinders Folmer
On 12-5-2022 18:54, Juliette Reinders Folmer wrote: After the prior discussion about the same topic: https://externals.io/message/117342, I have created an RFC to expand the scope of the deprecation notices being thrown for the deprecated partially supported callables to include is_callable()

Re: [PHP-DEV] [Discussion] Expand deprecation notice scope for partially supported callables

2022-05-12 Thread Juliette Reinders Folmer
On 12-5-2022 23:30, Claude Pache wrote: Le 12 mai 2022 à 23:11, Larry Garfield a écrit : For the `callable` type declaration, I'm not opposed but is it redundant with the existing deprecation? When would you pass a callable to something and not end up calling it anyway, which would

Re: [PHP-DEV] [Discussion] Expand deprecation notice scope for partially supported callables

2022-05-12 Thread Claude Pache
> Le 12 mai 2022 à 23:11, Larry Garfield a écrit : > > For the `callable` type declaration, I'm not opposed but is it redundant with > the existing deprecation? When would you pass a callable to something and > not end up calling it anyway, which would trigger the existing deprecation? >

Re: [PHP-DEV] [Discussion] Expand deprecation notice scope for partially supported callables

2022-05-12 Thread Larry Garfield
On Thu, May 12, 2022, at 11:54 AM, Juliette Reinders Folmer wrote: > After the prior discussion about the same topic: > https://externals.io/message/117342, I have created an RFC to expand the > scope of the deprecation notices being thrown for the deprecated > partially supported callables to

[PHP-DEV] [Discussion] Expand deprecation notice scope for partially supported callables

2022-05-12 Thread Juliette Reinders Folmer
After the prior discussion about the same topic: https://externals.io/message/117342, I have created an RFC to expand the scope of the deprecation notices being thrown for the deprecated partially supported callables to include is_callable() and the callable type in PHP 8.2. With this email