Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-19 Thread Tim Düsterhus
Hi On 4/19/24 20:47, Bilge wrote: Not that my opinion counts for much, but I have to say I find this very odd. Good class names: Id // Identifier ID // Identity Document I understand the distinction you wish to make here, between an acronym and abbreviation, but I think it's a meaningless dist

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-19 Thread Lynn
On Fri, Apr 19, 2024 at 8:50 PM Bilge wrote: > On 19/04/2024 18:42, Tim Düsterhus wrote: > > The two weeks of discussion are over now, the RFC didn't receive any > substantial changes after the initial proposal, and neither was there any > significant content-related feedback after the first few

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-19 Thread Bilge
On 19/04/2024 18:42, Tim Düsterhus wrote: The two weeks of discussion are over now, the RFC didn't receive any substantial changes after the initial proposal, and neither was there any significant content-related feedback after the first few days. As such, I plan to open the vote early next we

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-19 Thread Tim Düsterhus
Hi On 4/5/24 19:00, Tim Düsterhus wrote: RFC: https://wiki.php.net/rfc/class-naming-acronyms Previous ML discussion: https://externals.io/message/120959#120959 Related discussion in PHP-FIG: https://github.com/php-fig/per-coding-style/issues/83 The two weeks of discussion are over now, the RF

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-19 Thread Tim Düsterhus
Hi On 4/16/24 18:13, Derick Rethans wrote: None, yet. This RFC will result in changes to: The https://github.com/php/php-src/blob/536305436f44e91731bc5c86e06f137e44a01109/CODING_STANDARDS.md#L173-L211 document should probably be folded into https://github.com/php/policies/blob/main/codi

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-16 Thread Derick Rethans
On Fri, 5 Apr 2024, Tim Düsterhus wrote: > Hi > > I've just written up the follow-up RFC to my previous “Casing of acronyms in > class and method names” thread and I'm officially opening up the discussion > period for it. One example is the PCGOneseq128XSLRR64 mentioned above That is pr

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-14 Thread Tim Düsterhus
Hi On 4/12/24 15:53, Saki Takamachi wrote: This isn't a BC Break in theory as class names are, for the time being, case-insensitive. Strictly speaking, this can be considered a BC Break because the string returned by `::class` changes. However, I'm not sure how much of an impact it will have

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-12 Thread Saki Takamachi
Hi Gina, > This isn't a BC Break in theory as class names are, for the time being, > case-insensitive. Strictly speaking, this can be considered a BC Break because the string returned by `::class` changes. However, I'm not sure how much of an impact it will have. Regards, Saki

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-12 Thread Gina P. Banyard
On Friday, 5 April 2024 at 18:00, Tim Düsterhus wrote: > Hi > > I've just written up the follow-up RFC to my previous “Casing of > acronyms in class and method names” thread and I'm officially opening up > the discussion period for it. > > Please find the following links for your convenience: >

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-07 Thread Tim Düsterhus
Hi On 4/7/24 06:37, Juliette Reinders Folmer wrote: I forwarded your questions from above verbatim to Nicolas and this was his response (also quoted verbatim): Thank you. > So, this one is interesting. > Sure, if you look at these extremes, stringing them back to back all in a uppercase,

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-06 Thread Juliette Reinders Folmer
On 6-4-2024 14:55, Tim Düsterhus wrote: Hi On 4/5/24 23:32, Juliette Reinders Folmer wrote: I also took the liberty to ask accessibility expert Nicolas Steenhout [1] for his opinion on this topic and he has given me permission to quote his reply: > From a human readability and an accessibili

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-06 Thread Saki Takamachi
Hi Tim, > Hi > > On 4/6/24 17:54, Saki Takamachi wrote: >> However, in the example from "RFC: Namespaces in bundled PHP extensions", >> the acronyms are not camelcased. e.g. `FFI\FFI`, `OpenSSL` >> In other words, the RFC can be interpreted as "excluding acronyms" >> implicitly. > > This is c

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-06 Thread Tim Düsterhus
Hi On 4/6/24 17:54, Saki Takamachi wrote: However, in the example from "RFC: Namespaces in bundled PHP extensions", the acronyms are not camelcased. e.g. `FFI\FFI`, `OpenSSL` In other words, the RFC can be interpreted as "excluding acronyms" implicitly. This is correct, because the current cl

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-06 Thread Saki Takamachi
Hi Tim, >> Strictly speaking, namespace is neither a class nor a method, so isn't it >> outside the scope of this RFC? In fact, RFC: Class Naming makes no mention >> of namespace naming conventions at all. I asked this because there was >> mention of namespaces in the `DOM`. >> If I'm not misun

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-06 Thread Tim Düsterhus
Hi On 4/6/24 17:16, Saki Takamachi wrote: Strictly speaking, namespace is neither a class nor a method, so isn't it outside the scope of this RFC? In fact, RFC: Class Naming makes no mention of namespace naming conventions at all. I asked this because there was mention of namespaces in the `D

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-06 Thread Saki Takamachi
Hi Tim, > I've just written up the follow-up RFC to my previous “Casing of acronyms in > class and method names” thread and I'm officially opening up the discussion > period for it. > > Please find the following links for your convenience: > > RFC: https://wiki.php.net/rfc/class-naming-acronym

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-06 Thread Tim Düsterhus
Hi On 4/5/24 23:32, Juliette Reinders Folmer wrote: I also took the liberty to ask accessibility expert Nicolas Steenhout [1] for his opinion on this topic and he has given me permission to quote his reply: > From a human readability and an accessibility perspective, Camel Case are best when

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-05 Thread Juliette Reinders Folmer
On 5-4-2024 22:55, Larry Garfield wrote: On Fri, Apr 5, 2024, at 7:15 PM, Tim Düsterhus wrote: Hi On 4/5/24 20:01, Juliette Reinders Folmer wrote: In the "It decreases readability" section you make a sweeping statement about accessibility, but don't back that up with research. Please back your

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-05 Thread Larry Garfield
On Fri, Apr 5, 2024, at 7:15 PM, Tim Düsterhus wrote: > Hi > > On 4/5/24 20:01, Juliette Reinders Folmer wrote: >> In the "It decreases readability" section you make a sweeping statement >> about accessibility, but don't back that up with research. Please back >> your statement up as based on my un

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-05 Thread Tim Düsterhus
Hi On 4/5/24 20:01, Juliette Reinders Folmer wrote: In the "It decreases readability" section you make a sweeping statement about accessibility, but don't back that up with research. Please back your statement up as based on my understanding, the opposite is true. For context: This paragraph w

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-05 Thread Niels Dossche
Hi Juliette On 05/04/2024 20:01, Juliette Reinders Folmer wrote: > On 5-4-2024 19:48, Niels Dossche wrote: >>> I support this proposal. >>> If accepted, I'll make the necessary changes to ext-dom and ext-xsl to >>> comply with the new policy. > Niels: just wondering what changes you are referring

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-05 Thread Juliette Reinders Folmer
On 5-4-2024 19:48, Niels Dossche wrote: On 05/04/2024 19:00, Tim Düsterhus wrote: I've just written up the follow-up RFC to my previous “Casing of acronyms in class and method names” thread and I'm officially opening up the discussion period for it. Please find the following links for your co

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-05 Thread Niels Dossche
On 05/04/2024 19:00, Tim Düsterhus wrote: > Hi > > I've just written up the follow-up RFC to my previous “Casing of acronyms in > class and method names” thread and I'm officially opening up the discussion > period for it. > > Please find the following links for your convenience: > > RFC: http

[PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-05 Thread Tim Düsterhus
Hi I've just written up the follow-up RFC to my previous “Casing of acronyms in class and method names” thread and I'm officially opening up the discussion period for it. Please find the following links for your convenience: RFC: https://wiki.php.net/rfc/class-naming-acronyms Previous ML dis