[PHP-DEV] Expose mysqlnd API through all MySQL extensions

2012-04-24 Thread jpauli
Hi all, I'm actually putting my head into ext/mysqlnd and I noticed weird things about its API. As you should know, ext/mysqlnd is a replacement for libmysql, that is, all our 3 MySQL-related extensions may use it, and it is done by default for 5.4 branch. However, I've been surprised that

Re: [PHP-DEV] Expose mysqlnd API through all MySQL extensions

2012-04-24 Thread Johannes Schlüter
On Tue, 2012-04-24 at 13:35 +0200, jpauli wrote: - mysqli_get_client_stats() - mysqli_get_connection_stats() - mysqli_get_cache_stats() Those three functions are ext/mysqlnd related, they are #ifdef 'ed in the source code of ext/mysqli and not defined if ext/mysqli has been compiled

Re: [PHP-DEV] Expose mysqlnd API through all MySQL extensions

2012-04-24 Thread jpauli
2012/4/24 Johannes Schlüter johannes.schlue...@oracle.com: On Tue, 2012-04-24 at 13:35 +0200, jpauli wrote: - mysqli_get_client_stats() - mysqli_get_connection_stats() - mysqli_get_cache_stats() Those three functions are ext/mysqlnd related, they are #ifdef 'ed in the source code of

Re: [PHP-DEV] Expose mysqlnd API through all MySQL extensions

2012-04-24 Thread Ulf Wendel
Am 24.04.2012 14:27, schrieb jpauli: I understand your thoughts, but I disagree as I think it would be much more clean to expose it via mysqlnd_***() API than through each MySQL ext (and for PDO that would be even more dirty). That would as well add more and more #ifdef MYSQLND inside their

Re: [PHP-DEV] Expose mysqlnd API through all MySQL extensions

2012-04-24 Thread Johannes Schlüter
On Tue, 2012-04-24 at 14:27 +0200, jpauli wrote: Aha, I like when an internals guy teach me internals stuff :) So, OK for 5.3 , what about supporting that for =5.4 ? Maybe. ;-) The other reason is that one idea for mysqlnd was that it doesn't expose anything to the userland while

Re: [PHP-DEV] Expose mysqlnd API through all MySQL extensions

2012-04-24 Thread jpauli
On Tue, Apr 24, 2012 at 2:34 PM, Ulf Wendel ulf.wen...@oracle.com wrote: Am 24.04.2012 14:27, schrieb jpauli: I understand your thoughts, but I disagree as I think it would be much more clean to expose it via mysqlnd_***() API than through each MySQL ext (and for PDO that would be even more

Re: [PHP-DEV] Expose mysqlnd API through all MySQL extensions

2012-04-24 Thread jpauli
2012/4/24 Johannes Schlüter johannes.schlue...@oracle.com: On Tue, 2012-04-24 at 14:27 +0200, jpauli wrote: Aha, I like when an internals guy teach me internals stuff :) So, OK for 5.3 , what about supporting that for =5.4 ? Maybe. ;-) I can start working on ideas/patches The other

Re: [PHP-DEV] Expose mysqlnd API through all MySQL extensions

2012-04-24 Thread Andrey Hristov
Hi, On 04/24/2012 03:32 PM, jpauli wrote: On Tue, Apr 24, 2012 at 2:34 PM, Ulf Wendelulf.wen...@oracle.com wrote: Am 24.04.2012 14:27, schrieb jpauli: I understand your thoughts, but I disagree as I think it would be much more clean to expose it via mysqlnd_***() API than through each MySQL