Re: [PHP-DEV] Re: Finishing AVIF support in getimagesize()

On Thu, Dec 9, 2021, 18:56 Christoph M. Becker wrote: > On 09.12.2021 at 20:59, Flávio Heleno wrote: > > > On Thu, Dec 9, 2021 at 4:46 PM Nikita Popov > wrote: > > > >> On Wed, Dec 8, 2021 at 12:41 PM Christoph M. Becker > >> wrote: > >> > >>> On 01.12.2021 at 00:52, Ben Morss via internals

Re: [PHP-DEV] Re: Finishing AVIF support in getimagesize()

On 09.12.2021 at 20:59, Flávio Heleno wrote: > On Thu, Dec 9, 2021 at 4:46 PM Nikita Popov wrote: > >> On Wed, Dec 8, 2021 at 12:41 PM Christoph M. Becker >> wrote: >> >>> On 01.12.2021 at 00:52, Ben Morss via internals wrote: >>> Earlier this year, I added support for AVIF images

Re: [PHP-DEV] Re: Finishing AVIF support in getimagesize()

Thanks for the discussion, everyone! Fortunately there are no licensing concerns, as the author is making this code available to be copied and pasted freely. And we've already got the build flag for avif. I'll be excited to see getimagesize() actually return the size for AVIF images ☺️ On Thu,

Re: [PHP-DEV] Re: Finishing AVIF support in getimagesize()

On Thu, Dec 9, 2021 at 4:46 PM Nikita Popov wrote: > On Wed, Dec 8, 2021 at 12:41 PM Christoph M. Becker > wrote: > > > On 01.12.2021 at 00:52, Ben Morss via internals wrote: > > > > > Earlier this year, I added support for AVIF images > > > to libgd >

Re: [PHP-DEV] Re: Finishing AVIF support in getimagesize()

On Wed, Dec 8, 2021 at 12:41 PM Christoph M. Becker wrote: > On 01.12.2021 at 00:52, Ben Morss via internals wrote: > > > Earlier this year, I added support for AVIF images > > to libgd > > . My ultimate goal was to bring

Re: [PHP-DEV] Re: Finishing AVIF support in getimagesize()

On 08.12.2021 at 19:22, Yannis Guyon via internals wrote: >> On a general principle, I understood that bundling libs should be avoided. > > libavifinfo was designed more as a copy-pastable snippet than a library. Thanks for clarifying. > Unfortunately AVIF is complex and avifinfo.c is lengthier

Re: [PHP-DEV] Re: Finishing AVIF support in getimagesize()

> > On a general principle, I understood that bundling libs should be avoided. > libavifinfo was designed more as a copy-pastable snippet than a library. Unfortunately AVIF is complex and avifinfo.c is lengthier than expected, although I believe 700 lines are still reasonable and way below a

Re: [PHP-DEV] Re: Finishing AVIF support in getimagesize()

Good evening, On Wed, Dec 8, 2021, 6:40 PM Christoph M. Becker wrote: > On 01.12.2021 at 00:52, Ben Morss via internals wrote: > > l > > Thanks for your and your colleague's work! It's highly appreciated. > > Anyhow, a respective PR[1] has been submitted now, and I'm in favor of > bundling

[PHP-DEV] Re: Finishing AVIF support in getimagesize()

On 01.12.2021 at 00:52, Ben Morss via internals wrote: > Earlier this year, I added support for AVIF images > to libgd > . My ultimate goal was to bring support for > this new image format to PHP, so that the world's top