Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-05 Thread guilhermebla...@gmail.com
Hi Rasmus, Thanks for the highlight. My biggest concern about all this breakage done for NG could somehow be minimized by providing possible alternate implementations that could work both backwards compatible and forwards compatible? I just don't want to work on extensions I support that would nev

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-05 Thread Lester Caine
On 05/02/15 22:28, Rasmus Lerdorf wrote: > https://gist.github.com/anonymous/15cbc9947edb4f0a71fd > > Any suggestions for how to handle annotating it? We could turn it into a > fake PR and mark it up using github's PR comments. But is there > something more suited for this out there? A few extr

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-05 Thread Rasmus Lerdorf
On Feb 5, 2015, at 17:41, "guilhermebla...@gmail.com" wrote: > > Hi Rasmus, > > Thanks for the highlight. > My biggest concern about all this breakage done for NG could somehow be > minimized by providing possible alternate implementations that could work > both backwards compatible and forwa

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-05 Thread Yasuo Ohgaki
Hi Rasmus, On Fri, Feb 6, 2015 at 7:28 AM, Rasmus Lerdorf wrote: > Having just finished porting php-memcached (with help from Xinchen) to > PHP7 I was wondering if it wouldn't be worthwhile to annotate the diff > and explain why each change was made. The extension is complicated > enough to cove

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-05 Thread Xinchen Hui
Sent from my iPhone > On Feb 6, 2015, at 9:38 AM, Yasuo Ohgaki wrote: > > Hi Rasmus, > >> On Fri, Feb 6, 2015 at 7:28 AM, Rasmus Lerdorf wrote: >> >> Having just finished porting php-memcached (with help from Xinchen) to >> PHP7 I was wondering if it wouldn't be worthwhile to annotate the d

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-05 Thread Florian Margaine
Hi Rasmus, Rasmus Lerdorf writes: > It looks like this: > > https://gist.github.com/anonymous/15cbc9947edb4f0a71fd > > Any suggestions for how to handle annotating it? We could turn it into a > fake PR and mark it up using github's PR comments. But is there > something more suited for this out

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-06 Thread Yasuo Ohgaki
Hi Xinchen, On Fri, Feb 6, 2015 at 12:00 PM, Xinchen Hui wrote: > > On Feb 6, 2015, at 9:38 AM, Yasuo Ohgaki wrote: > > > > Hi Rasmus, > > > >> On Fri, Feb 6, 2015 at 7:28 AM, Rasmus Lerdorf > wrote: > >> > >> Having just finished porting php-memcached (with help from Xinchen) to > >> PHP7 I w

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-06 Thread Xinchen Hui
Hey: On Fri, Feb 6, 2015 at 7:06 PM, Yasuo Ohgaki wrote: > Hi Xinchen, > > On Fri, Feb 6, 2015 at 12:00 PM, Xinchen Hui wrote: >> >> > On Feb 6, 2015, at 9:38 AM, Yasuo Ohgaki wrote: >> > >> > Hi Rasmus, >> > >> >> On Fri, Feb 6, 2015 at 7:28 AM, Rasmus Lerdorf >> >> wrote: >> >> >> >> Having

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-06 Thread Dan Ackroyd
On 5 February 2015 at 22:28, Rasmus Lerdorf wrote: > Any suggestions for how to handle annotating it? We could turn it into a > fake PR and mark it up using github's PR comments. I think that's a good idea. It is very easy for people to ask questions about any change that they don't understand on

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-06 Thread Lester Caine
On 06/02/15 16:16, Dan Ackroyd wrote: > Also, I found it useful when converting Imagick to have a checklist of > everything that needed to be done, in a simple format, rather than the > full explanation of the changes at Is that in a publishable format Dan? I'm looking to pull magickwand up as wel

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-06 Thread Anatol Belski
Hi Dan, On Fri, February 6, 2015 17:16, Dan Ackroyd wrote: > On 5 February 2015 at 22:28, Rasmus Lerdorf wrote: > >> Any suggestions for how to handle annotating it? We could turn it into >> a fake PR and mark it up using github's PR comments. > > I think that's a good idea. It is very easy for p

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-06 Thread Pierre Joye
On Feb 6, 2015 6:45 AM, "Rasmus Lerdorf" wrote: > > On Feb 5, 2015, at 17:41, "guilhermebla...@gmail.com" < guilhermebla...@gmail.com> wrote: > > > > Hi Rasmus, > > > > Thanks for the highlight. > > My biggest concern about all this breakage done for NG could somehow be minimized by providing poss

RE: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-06 Thread François Laupretre
> De : Pierre Joye [mailto:pierre@gmail.com] > What do you think about the creation of an example extension covering > almost everything one would do in an extension? > > The class, methods or functions do not have to be useful but to have simple > clear examples to display the differences wit

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-06 Thread Pierre Joye
On Sat, Feb 7, 2015 at 9:57 AM, François Laupretre wrote: >> De : Pierre Joye [mailto:pierre@gmail.com] >> What do you think about the creation of an example extension covering >> almost everything one would do in an extension? >> >> The class, methods or functions do not have to be useful but

RE: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-07 Thread François Laupretre
> De : Pierre Joye [mailto:pierre@gmail.com] > Not sure it will help. It is really about showing cases for deref, > duplicate, convert, iterate, etc. The zpp, return values or > functions/class/methods declaration are really the easy part here. I understand. I thought it would be a nice way to

RE: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-07 Thread Pierre Joye
On Feb 7, 2015 5:57 PM, "François Laupretre" wrote: > > > De : Pierre Joye [mailto:pierre@gmail.com] > > Not sure it will help. It is really about showing cases for deref, > > duplicate, convert, iterate, etc. The zpp, return values or > > functions/class/methods declaration are really the eas

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-08 Thread Jakub Zelenka
On Thu, Feb 5, 2015 at 10:41 PM, guilhermebla...@gmail.com < guilhermebla...@gmail.com> wrote: > > My biggest concern about all this breakage done for NG could somehow be > minimized by providing possible alternate implementations that could work > both backwards compatible and forwards compatible?

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-09 Thread Jan Ehrhardt
Dan Ackroyd in php.internals (Fri, 6 Feb 2015 16:16:09 +): >On 5 February 2015 at 22:28, Rasmus Lerdorf wrote: >> Any suggestions for how to handle annotating it? We could turn it into a >> fake PR and mark it up using github's PR comments. (...) >An incomplete checklist for migrating an exten

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-09 Thread Lester Caine
On 09/02/15 15:03, Jan Ehrhardt wrote: > Despite the extensive list of changes, imagick does not compile anymore > with the current PHP7 git head (Win32 VC11). OK another day wasted but I am getting the development platform stable. http://lsces.org.uk/phpinfo.php is my production copy, but has a

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-09 Thread Lester Caine
On 09/02/15 15:03, Jan Ehrhardt wrote: > Despite the extensive list of changes, imagick does not compile anymore > with the current PHP7 git head (Win32 VC11). Jan ... try the latest code from Dan ... Just got both php7 and php5.6.5 running including a populated phpinfo on each so I'm moving on ..

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-10 Thread Jan Ehrhardt
Lester Caine in php.internals (Mon, 09 Feb 2015 21:39:16 +): >On 09/02/15 15:03, Jan Ehrhardt wrote: >> Despite the extensive list of changes, imagick does not compile anymore >> with the current PHP7 git head (Win32 VC11). > >Jan ... try the latest code from Dan ... >Just got both php7 and php

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-10 Thread Yasuo Ohgaki
Hi all, On Fri, Feb 6, 2015 at 10:38 AM, Yasuo Ohgaki wrote: > It looks like this: >> >> https://gist.github.com/anonymous/15cbc9947edb4f0a71fd >> > > It uses session save handler uses PS_MOD() which is legacy. > I may help to adopt PS_MOD_TIMESTAMP(). > It eliminates writes and boost session

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-10 Thread Xinchen Hui
Hey: On Wed, Feb 11, 2015 at 2:07 PM, Yasuo Ohgaki wrote: > Hi all, > > On Fri, Feb 6, 2015 at 10:38 AM, Yasuo Ohgaki wrote: > >> It looks like this: >>> >>> https://gist.github.com/anonymous/15cbc9947edb4f0a71fd >>> >> >> It uses session save handler uses PS_MOD() which is legacy. >> I may he

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-10 Thread Yasuo Ohgaki
Hi Xinchen, On Wed, Feb 11, 2015 at 3:27 PM, Xinchen Hui wrote: > The fails must be know... relates to key name checking > > the leaks needs to be take care, I will look into it. > > anyway, these should not affects your work, > I think so. I'll start working :) Regards, -- Yasuo Ohgaki yohg.

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-11 Thread Yasuo Ohgaki
Hi all, On Wed, Feb 11, 2015 at 3:51 PM, Yasuo Ohgaki wrote: > On Wed, Feb 11, 2015 at 3:27 PM, Xinchen Hui wrote: > >> The fails must be know... relates to key name checking >> >> the leaks needs to be take care, I will look into it. >> >> anyway, these should not affects your work, >> > > I t

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-11 Thread Xinchen Hui
On Thu, Feb 12, 2015 at 10:05 AM, Yasuo Ohgaki wrote: > Hi all, > > On Wed, Feb 11, 2015 at 3:51 PM, Yasuo Ohgaki wrote: >> >> On Wed, Feb 11, 2015 at 3:27 PM, Xinchen Hui wrote: >>> >>> The fails must be know... relates to key name checking >>> >>> the leaks needs to be take care, I will look i

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-11 Thread Yasuo Ohgaki
Hi Xinchen, On Thu, Feb 12, 2015 at 12:37 PM, Xinchen Hui wrote: > > lazy_write=On: Requests per second:2218.55 [#/sec] (mean) > > lazy_write=Off: Requests per second:24.58 [#/sec] (mean) > I feel...that might be something wrong :< I do think so. It's Core i7 with 32GB memory and S

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-11 Thread Xinchen Hui
Hey: On Thu, Feb 12, 2015 at 1:35 PM, Yasuo Ohgaki wrote: > Hi Xinchen, > > On Thu, Feb 12, 2015 at 12:37 PM, Xinchen Hui wrote: >> >> > lazy_write=On: Requests per second:2218.55 [#/sec] (mean) >> > lazy_write=Off: Requests per second:24.58 [#/sec] (mean) >> I feel...that might be s

Re: [PHP-DEV] Annotated PHP 5->7 extension diff

2015-02-21 Thread Jan Ehrhardt
Dan Ackroyd in php.internals (Fri, 6 Feb 2015 16:16:09 +): >An incomplete checklist for migrating an extension to PHP7 php_imagick (phpseven branch) once again does not compile, this time because MAKE_STD_ZVAL has been removed and you added it in imagickkernel_class.c with this commit: https:/