Re: [PHP-DEV] magic quotes finale

2008-05-20 Thread Pierre Joye
hi Philip, On Tue, May 20, 2008 at 9:55 PM, Philip Olson <[EMAIL PROTECTED]> wrote: > Hello everyone- > > PHP 5.3 is approaching fast, so let's conclude our dealings with magical > quotes... this should be the last time. Please have a look at the following > RFC and discuss it within this thread.

Re: [PHP-DEV] magic quotes finale

2008-05-20 Thread Philip Olson
On 20 May 2008, at 13:53, Pierre Joye wrote: hi Philip, On Tue, May 20, 2008 at 9:55 PM, Philip Olson <[EMAIL PROTECTED]> wrote: Hello everyone- PHP 5.3 is approaching fast, so let's conclude our dealings with magical quotes... this should be the last time. Please have a look at the fo

Re: [PHP-DEV] magic quotes finale

2008-05-20 Thread Pierre Joye
On Tue, May 20, 2008 at 11:00 PM, Philip Olson <[EMAIL PROTECTED]> wrote: > > On 20 May 2008, at 13:53, Pierre Joye wrote: > >> hi Philip, >> >> On Tue, May 20, 2008 at 9:55 PM, Philip Olson <[EMAIL PROTECTED]> wrote: >>> >>> Hello everyone- >>> >>> PHP 5.3 is approaching fast, so let's conclude ou

Re: [PHP-DEV] magic quotes finale

2008-05-20 Thread Lester Caine
Philip Olson wrote: PHP 5.3 is approaching fast, so let's conclude our dealings with magical quotes... this should be the last time. Please have a look at the following RFC and discuss it within this thread. Magic Quotes in PHP 5.3 and beyond - http://wiki.php.net/rfc/magicquotes It recommend

RE: [PHP-DEV] magic quotes finale

2008-05-20 Thread Jonathan Bond-Caron
+1 here A summary: PHP6 MUST not allow setting magic quotes PHP6 MUST trigger a fatal error when attempting to set magic quotes (php.ini or set_magic_quotes_runtime()) PHP6 MUST allow getting magic quotes info (always false) PHP5.3 MUST allow setting magic quotes PHP5.3 MUST trigger an E_DEPREC

Re: [PHP-DEV] magic quotes finale

2008-05-21 Thread Richard Quadling
2008/5/20 Jonathan Bond-Caron <[EMAIL PROTECTED]>: > +1 here > > A summary: > > PHP6 MUST not allow setting magic quotes > PHP6 MUST trigger a fatal error when attempting to set magic quotes (php.ini > or set_magic_quotes_runtime()) > PHP6 MUST allow getting magic quotes info (always false) > > PHP

Re: [PHP-DEV] magic quotes finale

2008-05-22 Thread Lars Strojny
[ forgot to sent that to the list ] Hi Philip, Am Dienstag, den 20.05.2008, 12:55 -0700 schrieb Philip Olson: [...] > PHP 5.3 is approaching fast, so let's conclude our dealings with > magical quotes... this should be the last time. Please have a look at > the following RFC and discuss it wit

Re: [PHP-DEV] magic quotes finale

2008-05-22 Thread David Coallier
> cu, Lars > P.S.: Silence agrees doesn't work, silence is void. Well, if silence is void: TAKE IT OFF!!! (+1 ... once again on this subject) -- Slan, David -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] magic quotes finale

2008-05-22 Thread Lars Strojny
Hi David, Am Donnerstag, den 22.05.2008, 18:14 -0400 schrieb David Coallier: > > cu, Lars > > P.S.: Silence agrees doesn't work, silence is void. > > Well, if silence is void: TAKE IT OFF!!! (+1 ... once again on this #subject) You've spotted that the proposal is not about the question if they s

Re: [PHP-DEV] magic quotes finale

2008-05-22 Thread Rasmus Lerdorf
Lars Strojny wrote: [ forgot to sent that to the list ] Hi Philip, Am Dienstag, den 20.05.2008, 12:55 -0700 schrieb Philip Olson: [...] PHP 5.3 is approaching fast, so let's conclude our dealings with magical quotes... this should be the last time. Please have a look at the following RFC an

Re: [PHP-DEV] magic quotes finale

2008-05-22 Thread Philip Olson
PHP 5.3 is approaching fast, so let's conclude our dealings with magical quotes... this should be the last time. Please have a look at the following RFC and discuss it within this thread. Magic Quotes in PHP 5.3 and beyond - http://wiki.php.net/rfc/magicquotes It recommends changes to both

Re: [PHP-DEV] magic quotes finale

2008-05-22 Thread Pierre Joye
Hi Rasmus, On Fri, May 23, 2008 at 1:35 AM, Rasmus Lerdorf <[EMAIL PROTECTED]> wrote: > Lars Strojny wrote: >> >> [ forgot to sent that to the list ] >> >> Hi Philip, >> >> Am Dienstag, den 20.05.2008, 12:55 -0700 schrieb Philip Olson: >> [...] >>> >>> PHP 5.3 is approaching fast, so let's conclud

Re: [PHP-DEV] magic quotes finale

2008-05-22 Thread Stan Vassilev | FM
Hi, Just making sure I understood it well. Get isn't deprecated (good), set is (good), but what happens if I try to set magic quotes runtime *off* if it was *on* from the config. I couldn't see anything about the PHP config setting being ignored/removed or throwing error in the RFC. For c

Re: [PHP-DEV] magic quotes finale

2008-05-22 Thread Arvids Godjuks
+1 for this. Just clean the code once and for all. 2008/5/23 Lars Strojny <[EMAIL PROTECTED]>: > [ forgot to sent that to the list ] > > Hi Philip, > > Am Dienstag, den 20.05.2008, 12:55 -0700 schrieb Philip Olson: > [...] > > PHP 5.3 is approaching fast, so let's conclude our dealings with > > m

Re: [PHP-DEV] magic quotes finale

2008-05-22 Thread Hannes Magnusson
On Fri, May 23, 2008 at 12:09 AM, Lars Strojny <[EMAIL PROTECTED]> wrote: > Why should we leave get_magic_quotes_gpc()? If someone wants to be > backwards compatible, just use Excuse me? The users should change their code to be forward compatible? We should ofcourse make it easier for our users and

Re: [PHP-DEV] magic quotes finale

2008-05-23 Thread Philip Olson
We have covered this a bunch of times already. magic_quotes_gpc are gone, but we leave in the function that tells userspace code that they are off. get_magic_quotes_gpc() will always return false which means that thousands of applications out there will run unchanged and will simply take th

Re: [PHP-DEV] magic quotes finale

2008-05-23 Thread Gregory Beaver
Rasmus Lerdorf wrote: > I see absolutely no reason to force people to go through and change: > > if(!get_magic_quotes_gpc()) > > to: > > if (!function_exists('get_magic_quotes_gpc') || !get_magic_quotes_gpc()) > > when there is no technical reason to force them to do so. It is slower, > more v

Re: [PHP-DEV] magic quotes finale

2008-05-23 Thread Rasmus Lerdorf
Gregory Beaver wrote: Rasmus Lerdorf wrote: I see absolutely no reason to force people to go through and change: if(!get_magic_quotes_gpc()) to: if (!function_exists('get_magic_quotes_gpc') || !get_magic_quotes_gpc()) when there is no technical reason to force them to do so. It is slower, m

Re: [PHP-DEV] magic quotes finale

2008-05-24 Thread Pierre Joye
On Sat, May 24, 2008 at 4:03 AM, Rasmus Lerdorf <[EMAIL PROTECTED]> wrote: > Right, I guess I wasn't absolutely explicit. There is no point in spewing > an E_DEPRECATED on get_magic_quotes_gpc(). Such warnings should be for > people actually using a deprecated feature, not for functions that che