[jira] [Commented] (CALCITE-1241) Add a freemarker variable for adding non reserved keywords to Parser.jj template

2016-05-18 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289896#comment-15289896 ] Julian Hyde commented on CALCITE-1241: -- Yes, please add a test to SqlParserTest as part of the

[jira] [Commented] (CALCITE-1241) Add a freemarker variable for adding non reserved keywords to Parser.jj template

2016-05-18 Thread Venki Korukanti (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289879#comment-15289879 ] Venki Korukanti commented on CALCITE-1241: -- I think it makes sense to have a test in Calcite to

[jira] [Commented] (CALCITE-1241) Add a freemarker variable for adding non reserved keywords to Parser.jj template

2016-05-18 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289805#comment-15289805 ] Julian Hyde commented on CALCITE-1241: -- The list of reserved keywords doesn't change very often

[jira] [Commented] (CALCITE-1241) Add a freemarker variable for adding non reserved keywords to Parser.jj template

2016-05-18 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289779#comment-15289779 ] Julian Hyde commented on CALCITE-1241: -- SQL syntax unfortunately allows expressions and queries in

[jira] [Commented] (CALCITE-1241) Add a freemarker variable for adding non reserved keywords to Parser.jj template

2016-05-18 Thread Venki Korukanti (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289584#comment-15289584 ] Venki Korukanti commented on CALCITE-1241: -- This is the most common issue, I have seen. One

[jira] [Commented] (CALCITE-1241) Add a freemarker variable for adding non reserved keywords to Parser.jj template

2016-05-18 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289546#comment-15289546 ] Julian Hyde commented on CALCITE-1241: -- It makes sense, and the patch looks good. But I wonder,