[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-21 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623992#comment-16623992 ] Julian Hyde commented on CALCITE-2535: -- [~zhztheplayer] Yes CALCITE-535 is perfect

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-21 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623414#comment-16623414 ] Hongze Zhang commented on CALCITE-2535: --- [~vladimirsitnikov] {quote}I don't quite

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-21 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623404#comment-16623404 ] Hongze Zhang commented on CALCITE-2535: --- [~julianhyde] Sorry for late reply, and

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-16 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617119#comment-16617119 ] Vladimir Sitnikov commented on CALCITE-2535: [~zhztheplayer], I don't quit

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-16 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16616974#comment-16616974 ] Julian Hyde commented on CALCITE-2535: -- Reviewing now. > Runtime failure check no

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-12 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612131#comment-16612131 ] Hongze Zhang commented on CALCITE-2535: --- [~julianhyde] Please correct me if I am

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-12 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611728#comment-16611728 ] Julian Hyde commented on CALCITE-2535: -- It seems that constant folding is not a co

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-11 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611539#comment-16611539 ] Hongze Zhang commented on CALCITE-2535: --- [~julianhyde] Thank you very much for th

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-11 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611365#comment-16611365 ] Julian Hyde commented on CALCITE-2535: -- I wouldn't disable the constant folding. I

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-11 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610214#comment-16610214 ] Hongze Zhang commented on CALCITE-2535: --- [~vladimirsitnikov] {quote}select coales

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-11 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610180#comment-16610180 ] Vladimir Sitnikov commented on CALCITE-2535: Oh, I think I know an example:

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-10 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610161#comment-16610161 ] Vladimir Sitnikov commented on CALCITE-2535: [~zhztheplayer], while I agree

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-10 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610114#comment-16610114 ] Hongze Zhang commented on CALCITE-2535: --- {quote}FNL-3 was to implement exceptions

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-10 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610088#comment-16610088 ] Julian Hyde commented on CALCITE-2535: -- FNL-3 was to implement exceptions in a run

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-10 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610077#comment-16610077 ] Hongze Zhang commented on CALCITE-2535: --- [~julianhyde] Thanks for you explanation

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-10 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609706#comment-16609706 ] Vladimir Sitnikov commented on CALCITE-2535: [~zhztheplayer], note your com

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-10 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609574#comment-16609574 ] Julian Hyde commented on CALCITE-2535: -- The {{ExceptionInInitializerError}} is kin

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-10 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609492#comment-16609492 ] Hongze Zhang commented on CALCITE-2535: --- [~vladimirsitnikov] Thank you very much

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-10 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609246#comment-16609246 ] Vladimir Sitnikov commented on CALCITE-2535: [~zhztheplayer], have you trie

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-10 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609178#comment-16609178 ] Hongze Zhang commented on CALCITE-2535: --- bq. I meant unwrapping ExceptionInInitia

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-10 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608957#comment-16608957 ] Vladimir Sitnikov commented on CALCITE-2535: A site note: I see you split S

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-10 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608913#comment-16608913 ] Vladimir Sitnikov commented on CALCITE-2535: {quote}But just put the testin

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-10 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608909#comment-16608909 ] Hongze Zhang commented on CALCITE-2535: ---   {quote}Well, if the only issue is Exce

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-10 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608889#comment-16608889 ] Vladimir Sitnikov commented on CALCITE-2535: {quote} It could be better to

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-10 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608887#comment-16608887 ] Vladimir Sitnikov commented on CALCITE-2535: {quote}This is to expose origi

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-10 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608877#comment-16608877 ] Hongze Zhang commented on CALCITE-2535: --- [~vladimirsitnikov] Thanks for your comm

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-09 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608413#comment-16608413 ] Vladimir Sitnikov commented on CALCITE-2535: [~zhztheplayer], would you ple

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-06 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605764#comment-16605764 ] Hongze Zhang commented on CALCITE-2535: --- A PR is submitted at [PR-821|https://git

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-05 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604765#comment-16604765 ] Hongze Zhang commented on CALCITE-2535: --- [~julianhyde] Thanks for your suggestion

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-05 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604752#comment-16604752 ] Hongze Zhang commented on CALCITE-2535: --- A possible fix work is at [my repo](htt

[jira] [Commented] (CALCITE-2535) Runtime failure check not working in SqlTesterImpl.java

2018-09-05 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604736#comment-16604736 ] Julian Hyde commented on CALCITE-2535: -- Agreed. In order to get those tests to pas