[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

CarbonDataQA2 commented on pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#issuecomment-739480249 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4041: [CARBONDATA-4068] handled set long string on MT for column on which SI is already created.

CarbonDataQA2 commented on pull request #4041: URL: https://github.com/apache/carbondata/pull/4041#issuecomment-739480242 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5049/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4042: [CARBONDATA-4069] handled set streaming for SI table or table having SI.

CarbonDataQA2 commented on pull request #4042: URL: https://github.com/apache/carbondata/pull/4042#issuecomment-739480243 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3290/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator

CarbonDataQA2 commented on pull request #4039: URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739480240 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4032: [WIP][CARBONDATA-4065] Support MERGE INTO SQL Command

CarbonDataQA2 commented on pull request #4032: URL: https://github.com/apache/carbondata/pull/4032#issuecomment-739480239 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3295/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4037: [CARBONDATA-4070] Added FT for SI and handled missed scenario.

CarbonDataQA2 commented on pull request #4037: URL: https://github.com/apache/carbondata/pull/4037#issuecomment-739480241 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4040: [WIP][CI TEST]

CarbonDataQA2 commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739480247 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4031: [CARBONDATA-4073] Added FT for missing scenarios in Presto

CarbonDataQA2 commented on pull request #4031: URL: https://github.com/apache/carbondata/pull/4031#issuecomment-739480248 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3296/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

CarbonDataQA2 commented on pull request #4013: URL: https://github.com/apache/carbondata/pull/4013#issuecomment-739480246 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3297/

[GitHub] [carbondata] QiangCai closed pull request #4013: [CARBONDATA-4062] Make clean files as data trash manager

QiangCai closed pull request #4013: URL: https://github.com/apache/carbondata/pull/4013 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] Indhumathi27 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator

Indhumathi27 commented on pull request #4039: URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739483872 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator

CarbonDataQA2 commented on pull request #4039: URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739486393 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3301/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator

CarbonDataQA2 commented on pull request #4039: URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739486536 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5058/ -

[GitHub] [carbondata] Kejian-Li commented on pull request #4011: [CARBONDATA-4003] Improve IUD Concurrency

Kejian-Li commented on pull request #4011: URL: https://github.com/apache/carbondata/pull/4011#issuecomment-739488366 retest this please This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator

CarbonDataQA2 commented on pull request #4039: URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739492660 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5082/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator

CarbonDataQA2 commented on pull request #4039: URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739492808 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3325/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4011: [CARBONDATA-4003] Improve IUD Concurrency

CarbonDataQA2 commented on pull request #4011: URL: https://github.com/apache/carbondata/pull/4011#issuecomment-739492980 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5083/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4011: [CARBONDATA-4003] Improve IUD Concurrency

CarbonDataQA2 commented on pull request #4011: URL: https://github.com/apache/carbondata/pull/4011#issuecomment-739493108 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5059/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4011: [CARBONDATA-4003] Improve IUD Concurrency

CarbonDataQA2 commented on pull request #4011: URL: https://github.com/apache/carbondata/pull/4011#issuecomment-739493161 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3326/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4011: [CARBONDATA-4003] Improve IUD Concurrency

CarbonDataQA2 commented on pull request #4011: URL: https://github.com/apache/carbondata/pull/4011#issuecomment-739493182 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3302/

[GitHub] [carbondata] Kejian-Li opened a new pull request #4043: IUD Concurrency Improvement

Kejian-Li opened a new pull request #4043: URL: https://github.com/apache/carbondata/pull/4043 Why is this PR needed? Improve concurrency for Insert/Update/Delete What changes were proposed in this PR? Remove update lock in Update and Delete Command and lock the segments operar

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4043: IUD Concurrency Improvement

CarbonDataQA2 commented on pull request #4043: URL: https://github.com/apache/carbondata/pull/4043#issuecomment-739523165 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [carbondata] marchpure commented on a change in pull request #4043: IUD Concurrency Improvement

marchpure commented on a change in pull request #4043: URL: https://github.com/apache/carbondata/pull/4043#discussion_r537066618 ## File path: core/src/main/java/org/apache/carbondata/core/mutate/CarbonUpdateUtil.java ## @@ -341,8 +341,11 @@ public static boolean updateTableM

[GitHub] [carbondata] marchpure commented on pull request #4043: IUD Concurrency Improvement

marchpure commented on pull request #4043: URL: https://github.com/apache/carbondata/pull/4043#issuecomment-739523754 CI fails. Please fix the CI failures This is an automated message from the Apache Git Service. To respond t

[GitHub] [carbondata] marchpure commented on a change in pull request #4043: IUD Concurrency Improvement

marchpure commented on a change in pull request #4043: URL: https://github.com/apache/carbondata/pull/4043#discussion_r537069006 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/iud/IUDConcurrencyTestCase.scala ## @@ -0,0 +1,474 @@ +/* + * L

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4043: IUD Concurrency Improvement

CarbonDataQA2 commented on pull request #4043: URL: https://github.com/apache/carbondata/pull/4043#issuecomment-739539209 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [carbondata] QiangCai opened a new pull request #4044: [CARBONDATA-4062] Refactor clean files feature

QiangCai opened a new pull request #4044: URL: https://github.com/apache/carbondata/pull/4044 ### Why is this PR needed? To prevent accidental deletion of data, carbon will introduce trash data management. It will provide buffer time for accidental deletion of data to roll back the de

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739547241 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5085/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739547305 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3304/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739562913 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [carbondata] shenjiayu17 commented on pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

shenjiayu17 commented on pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#issuecomment-739609378 retest this please This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [carbondata] Zhangshunyu commented on pull request #4040: [WIP][CI TEST]

Zhangshunyu commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739609664 retest this please This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [carbondata] Zhangshunyu closed pull request #4040: [WIP][CI TEST]

Zhangshunyu closed pull request #4040: URL: https://github.com/apache/carbondata/pull/4040 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [carbondata] Zhangshunyu commented on pull request #4043: IUD Concurrency Improvement

Zhangshunyu commented on pull request #4043: URL: https://github.com/apache/carbondata/pull/4043#issuecomment-739612930 retest this please This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [carbondata] QiangCai commented on pull request #4029: refact carbon util

QiangCai commented on pull request #4029: URL: https://github.com/apache/carbondata/pull/4029#issuecomment-739614278 please rebase and perfect the title This is an automated message from the Apache Git Service. To respond to

[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r533974578 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolylineListExpression.java ## @@ -0,0 +1,202 @@ +/* + * Licensed to the

[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r533974578 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolylineListExpression.java ## @@ -0,0 +1,202 @@ +/* + * Licensed to the

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4043: IUD Concurrency Improvement

CarbonDataQA2 commented on pull request #4043: URL: https://github.com/apache/carbondata/pull/4043#issuecomment-739619817 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3329/

[GitHub] [carbondata] shenjiayu17 commented on a change in pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

shenjiayu17 commented on a change in pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#discussion_r533974578 ## File path: geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolylineListExpression.java ## @@ -0,0 +1,202 @@ +/* + * Licensed to the

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4029: [HOTFIX] Refact Carbon Util

CarbonDataQA2 commented on pull request #4029: URL: https://github.com/apache/carbondata/pull/4029#issuecomment-739620454 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3331/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4040: [WIP][CI TEST]

CarbonDataQA2 commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739620657 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3306/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

CarbonDataQA2 commented on pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#issuecomment-739620889 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4043: IUD Concurrency Improvement

CarbonDataQA2 commented on pull request #4043: URL: https://github.com/apache/carbondata/pull/4043#issuecomment-739620866 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4029: [HOTFIX] Refact Carbon Util

CarbonDataQA2 commented on pull request #4029: URL: https://github.com/apache/carbondata/pull/4029#issuecomment-739620953 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5088/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4040: [WIP][CI TEST]

CarbonDataQA2 commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739620979 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5087/ -

[GitHub] [carbondata] Zhangshunyu commented on pull request #4040: [WIP][CI TEST]

Zhangshunyu commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739621621 retest this please This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4043: IUD Concurrency Improvement

CarbonDataQA2 commented on pull request #4043: URL: https://github.com/apache/carbondata/pull/4043#issuecomment-739634097 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5062/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4040: [WIP][CI TEST]

CarbonDataQA2 commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739634188 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5068/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739634201 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4029: [HOTFIX] Refact Carbon Util

CarbonDataQA2 commented on pull request #4029: URL: https://github.com/apache/carbondata/pull/4029#issuecomment-739634371 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3307/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739635141 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4040: [WIP][CI TEST]

CarbonDataQA2 commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739635257 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3310/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4040: [WIP][CI TEST]

CarbonDataQA2 commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739635308 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5067/ -

[GitHub] [carbondata] QiangCai commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

QiangCai commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739642960 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

CarbonDataQA2 commented on pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#issuecomment-739648470 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5065/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739648471 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3334/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4029: [HOTFIX] Refact Carbon Util

CarbonDataQA2 commented on pull request #4029: URL: https://github.com/apache/carbondata/pull/4029#issuecomment-739648475 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5064/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4040: [WIP][CI TEST]

CarbonDataQA2 commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739648469 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3330/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4040: [WIP][CI TEST]

CarbonDataQA2 commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739648788 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3335/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4040: [WIP][CI TEST]

CarbonDataQA2 commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739648939 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5091/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4040: [WIP][CI TEST]

CarbonDataQA2 commented on pull request #4040: URL: https://github.com/apache/carbondata/pull/4040#issuecomment-739649028 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5070/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4012: [CARBONDATA-4051] Geo spatial index algorithm improvement and UDFs enhancement

CarbonDataQA2 commented on pull request #4012: URL: https://github.com/apache/carbondata/pull/4012#issuecomment-739649371 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3308/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4032: [WIP][CARBONDATA-4065] Support MERGE INTO SQL Command

CarbonDataQA2 commented on pull request #4032: URL: https://github.com/apache/carbondata/pull/4032#issuecomment-739649832 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3312/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739649949 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5071/ -

[GitHub] [carbondata] Indhumathi27 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator

Indhumathi27 commented on pull request #4039: URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739660102 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

vikramahuja1001 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537230288 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -163,8 +164,13 @@ private static void getStaleSegme

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

vikramahuja1001 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537230866 ## File path: integration/spark/src/main/scala/org/apache/carbondata/api/CarbonStore.scala ## @@ -19,13 +19,13 @@ package org.apache.carbondat

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739664259 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3311/

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

vikramahuja1001 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537232374 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,168 @@ +/* + * Licensed to the

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739664837 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5092/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator

CarbonDataQA2 commented on pull request #4039: URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739664975 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3313/

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

vikramahuja1001 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537235165 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,168 @@ +/* + * Licensed to the

[GitHub] [carbondata] kunal642 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

kunal642 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537236952 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -163,8 +164,13 @@ private static void getStaleSegmentFiles

[GitHub] [carbondata] ajantha-bhat commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739671395 @kunal642 , @vikramahuja1001 , @akashrn5 : I think we all 4 are reviewing this PR. Give comments once you find it. don't give all at the end. so that we can avoid duplic

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

akashrn5 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537230858 ## File path: core/src/main/java/org/apache/carbondata/core/mutate/CarbonUpdateUtil.java ## @@ -482,176 +482,6 @@ public boolean accept(CarbonFile fi

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

akashrn5 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537245017 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

vikramahuja1001 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537245787 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,168 @@ +/* + * Licensed to the

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

vikramahuja1001 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537245787 ## File path: integration/spark/src/main/scala/org/apache/carbondata/trash/DataTrashManager.scala ## @@ -0,0 +1,168 @@ +/* + * Licensed to the

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537248198 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -163,8 +164,13 @@ private static void getStaleSegmentF

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537248838 ## File path: core/src/main/java/org/apache/carbondata/core/util/CleanFilesUtil.java ## @@ -163,8 +164,13 @@ private static void getStaleSegmentF

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739687261 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3336/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4032: [WIP][CARBONDATA-4065] Support MERGE INTO SQL Command

CarbonDataQA2 commented on pull request #4032: URL: https://github.com/apache/carbondata/pull/4032#issuecomment-739687262 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4032: [WIP][CARBONDATA-4065] Support MERGE INTO SQL Command

CarbonDataQA2 commented on pull request #4032: URL: https://github.com/apache/carbondata/pull/4032#issuecomment-739687365 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5072/ -

[GitHub] [carbondata] ydvpankaj99 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ydvpankaj99 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739687768 retest this please This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator

CarbonDataQA2 commented on pull request #4039: URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739688329 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3338/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4039: [WIP] Refactor and Fix Insert into partition issue with FileMergeSortComparator

CarbonDataQA2 commented on pull request #4039: URL: https://github.com/apache/carbondata/pull/4039#issuecomment-739688118 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5073/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739688814 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5095/ -

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

akashrn5 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537252406 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/events/CleanFilesPostEventListener.scala ## @@ -48,30 +50,61 @@ cl

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

akashrn5 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537252530 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/events/CleanFilesPostEventListener.scala ## @@ -48,30 +50,61 @@ cl

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4044: [CARBONDATA-4062] Refactor clean files feature

CarbonDataQA2 commented on pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#issuecomment-739689562 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3314/

[GitHub] [carbondata] akashrn5 commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

akashrn5 commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537252858 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/events/CleanFilesPostEventListener.scala ## @@ -48,30 +50,61 @@ cl

[GitHub] [carbondata] CarbonDataQA2 closed pull request #4016: Qa test2

CarbonDataQA2 closed pull request #4016: URL: https://github.com/apache/carbondata/pull/4016 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [carbondata] CarbonDataQA2 closed pull request #4014: qa test

CarbonDataQA2 closed pull request #4014: URL: https://github.com/apache/carbondata/pull/4014 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537258139 ## File path: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ## @@ -2123,29 +2123,35 @@ public int getMaxSIRepairLimit(

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537259682 ## File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java ## @@ -192,20 +192,20 @@ public static void emptyTrash(String tabl

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537259682 ## File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java ## @@ -192,20 +192,20 @@ public static void emptyTrash(String tabl

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537260678 ## File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java ## @@ -192,20 +192,20 @@ public static void emptyTrash(String tabl

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537264650 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ## @@ -263,15 +249,7 @@ object CarbonDa

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537264650 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ## @@ -263,15 +249,7 @@ object CarbonDa

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4044: [CARBONDATA-4062] Refactor clean files feature

ajantha-bhat commented on a change in pull request #4044: URL: https://github.com/apache/carbondata/pull/4044#discussion_r537266114 ## File path: integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ## @@ -577,38 +556,46 @@ object CarbonD

  1   2   >