[GitHub] carbondata pull request #2966: [CARBONDATA-3162][CARBONDATA-3163][CARBONDATA...

2018-12-13 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2966#discussion_r241643126 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -501,6 +502,17 @@ public CarbonLoadModel

[GitHub] carbondata pull request #2966: [CARBONDATA-3162][CARBONDATA-3163][CARBONDATA...

2018-12-13 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2966#discussion_r241642790 --- Diff: integration/spark2/src/test/scala/org/apache/spark/carbondata/restructure/AlterTableValidationTestCase.scala --- @@ -523,7 +523,8

[GitHub] carbondata pull request #2966: [CARBONDATA-3162][CARBONDATA-3163][CARBONDATA...

2018-12-13 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2966#discussion_r241642755 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -501,6 +502,17 @@ public CarbonLoadModel

[GitHub] carbondata pull request #2899: [CARBONDATA-3073][CARBONDATA-3044] Support co...

2018-12-13 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2899#discussion_r241334135 --- Diff: store/CSDK/test/main.cpp --- @@ -645,6 +653,278 @@ bool testWriteData(JNIEnv *env, char *path, int argc, char *argv

[GitHub] carbondata pull request #2899: [CARBONDATA-3073][CARBONDATA-3044] Support co...

2018-12-13 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2899#discussion_r241333995 --- Diff: store/CSDK/test/main.cpp --- @@ -645,6 +653,278 @@ bool testWriteData(JNIEnv *env, char *path, int argc, char *argv

[GitHub] carbondata pull request #2899: [CARBONDATA-3073][CARBONDATA-3044] Support co...

2018-12-13 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2899#discussion_r241328653 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CSVCarbonWriterTest.java --- @@ -543,4 +543,42 @@ public void

[GitHub] carbondata pull request #2899: [CARBONDATA-3073][CARBONDATA-3044] Support co...

2018-12-13 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2899#discussion_r241327234 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -199,6 +203,22 @@ public CarbonWriterBuilder

[GitHub] carbondata pull request #2899: [CARBONDATA-3073][CARBONDATA-3044] Support co...

2018-12-13 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2899#discussion_r241322296 --- Diff: store/CSDK/src/CarbonWriter.cpp --- @@ -58,6 +58,35 @@ void CarbonWriter::outputPath(char *path) { carbonWriterBuilderObject

[GitHub] carbondata pull request #2899: [CARBONDATA-3073][CARBONDATA-3044] Support co...

2018-12-13 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2899#discussion_r241321530 --- Diff: store/CSDK/src/CarbonWriter.cpp --- @@ -98,6 +127,158 @@ void CarbonWriter::withHadoopConf(char *key, char *value

[GitHub] carbondata pull request #2899: [CARBONDATA-3073][CARBONDATA-3044] Support co...

2018-12-13 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2899#discussion_r241320959 --- Diff: store/CSDK/src/CarbonWriter.cpp --- @@ -98,6 +127,158 @@ void CarbonWriter::withHadoopConf(char *key, char *value

[GitHub] carbondata pull request #2899: [CARBONDATA-3073][CARBONDATA-3044] Support co...

2018-12-13 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2899#discussion_r241318527 --- Diff: store/CSDK/src/CarbonWriter.cpp --- @@ -98,6 +127,158 @@ void CarbonWriter::withHadoopConf(char *key, char *value

[GitHub] carbondata pull request #2899: [CARBONDATA-3073][CARBONDATA-3044] Support co...

2018-12-13 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2899#discussion_r241318351 --- Diff: store/CSDK/src/CarbonWriter.cpp --- @@ -98,6 +127,158 @@ void CarbonWriter::withHadoopConf(char *key, char *value

[GitHub] carbondata pull request #2899: [CARBONDATA-3073][CARBONDATA-3044] Support co...

2018-12-13 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2899#discussion_r241315209 --- Diff: store/CSDK/src/CarbonWriter.cpp --- @@ -58,6 +58,35 @@ void CarbonWriter::outputPath(char *path) { carbonWriterBuilderObject

[GitHub] carbondata pull request #2899: [CARBONDATA-3073][CARBONDATA-3044] Support co...

2018-12-13 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2899#discussion_r241313087 --- Diff: docs/csdk-guide.md --- @@ -214,6 +226,122 @@ release the memory and destroy JVM. void withHadoopConf(char *key, char *value

[GitHub] carbondata pull request #2899: [CARBONDATA-3073][CARBONDATA-3044] Support co...

2018-12-13 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2899#discussion_r241311890 --- Diff: docs/csdk-guide.md --- @@ -214,6 +226,122 @@ release the memory and destroy JVM. void withHadoopConf(char *key, char *value

[GitHub] carbondata pull request #2982: [CARBONDATA-3158] support presto-carbon to re...

2018-12-12 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2982#discussion_r241286067 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java --- @@ -364,23 +355,38 @@ private CarbonTable

[GitHub] carbondata issue #2983: [CARBONDATA-3119] Fixed SDK Write for Complex Array ...

2018-12-12 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2983 retest this please ---

[GitHub] carbondata pull request #2949: [CARBONDATA-3118] support parallel block prun...

2018-12-11 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2949#discussion_r240900313 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java --- @@ -205,26 +195,53 @@ public BlockletDetailsFetcher

[GitHub] carbondata issue #2983: [CARBONDATA-3119] Fixed SDK Write for Complex Array ...

2018-12-11 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2983 retest this please ---

[GitHub] carbondata issue #2983: [CARBONDATA-3119] Fixed SDK Write for Complex Array ...

2018-12-11 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2983 @ravipesala , @chenliang613 : please add @shivamasn to whitelist ---

[GitHub] carbondata pull request #2983: [CARBONDATA-3119] Fixed SDK Write for Complex...

2018-12-11 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2983#discussion_r240889253 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -2072,4 +1797,35 @@ public void

[GitHub] carbondata pull request #2983: [CARBONDATA-3119] Fixed SDK Write for Complex...

2018-12-11 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2983#discussion_r240889185 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -23,8 +23,11 @@ import java.util

[GitHub] carbondata pull request #2983: [CARBONDATA-3119] Fixed SDK Write for Complex...

2018-12-11 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2983#discussion_r240889074 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType/TestComplexDataType.scala

[GitHub] carbondata pull request #2983: [CARBONDATA-3119] Fixed SDK Write for Complex...

2018-12-11 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2983#discussion_r240889108 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType/TestComplexDataType.scala

[jira] [Created] (CARBONDATA-3163) If table has different time format, for no_sort columns data goes as bad record (null) for second table when loaded after first table.

2018-12-11 Thread Ajantha Bhat (JIRA)
Ajantha Bhat created CARBONDATA-3163: Summary: If table has different time format, for no_sort columns data goes as bad record (null) for second table when loaded after first table. Key: CARBONDATA-3163 URL

[jira] [Created] (CARBONDATA-3164) During no_sort, excpetion happend at converter step is not reached to user. same problem in SDK and spark file format flow also.

2018-12-11 Thread Ajantha Bhat (JIRA)
Ajantha Bhat created CARBONDATA-3164: Summary: During no_sort, excpetion happend at converter step is not reached to user. same problem in SDK and spark file format flow also. Key: CARBONDATA-3164 URL: https

[jira] [Created] (CARBONDATA-3162) Range filters doesn't remove null values for no_sort direct dictionary dimension columns.

2018-12-11 Thread Ajantha Bhat (JIRA)
Ajantha Bhat created CARBONDATA-3162: Summary: Range filters doesn't remove null values for no_sort direct dictionary dimension columns. Key: CARBONDATA-3162 URL: https://issues.apache.org/jira/browse

[GitHub] carbondata issue #2982: [CARBONDATA-3158] support presto-carbon to read sdk ...

2018-12-10 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2982 @ravipesala , @jackylk : PR is ready. please review ---

[GitHub] carbondata pull request #2982: [CARBONDATA-3158] support presto-carbon to re...

2018-12-10 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2982#discussion_r240477368 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java --- @@ -364,23 +355,38 @@ private CarbonTable

[GitHub] carbondata pull request #2982: [CARBONDATA-3158] support presto-carbon to re...

2018-12-10 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2982#discussion_r240475287 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java --- @@ -364,23 +355,38 @@ private CarbonTable

[GitHub] carbondata pull request #2982: [CARBONDATA-3158] support presto-carbon to re...

2018-12-10 Thread ajantha-bhat
GitHub user ajantha-bhat opened a pull request: https://github.com/apache/carbondata/pull/2982 [CARBONDATA-3158] support presto-carbon to read sdk cabron files **problem:** Currently, carbon SDK files output (files without metadata folder and its contents) are read by spark

[jira] [Created] (CARBONDATA-3158) support presto-carbon to read sdk cabron files

2018-12-10 Thread Ajantha Bhat (JIRA)
Ajantha Bhat created CARBONDATA-3158: Summary: support presto-carbon to read sdk cabron files Key: CARBONDATA-3158 URL: https://issues.apache.org/jira/browse/CARBONDATA-3158 Project: CarbonData

[GitHub] carbondata issue #2966: [WIP] test and check no sort by default

2018-11-30 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2966 retest this please ---

[GitHub] carbondata pull request #2966: [WIP] test and check no sort by default

2018-11-29 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2966#discussion_r237747880 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datamap/DataMapWriterSuite.scala --- @@ -156,8

[GitHub] carbondata pull request #2966: [WIP] test and check no sort by default

2018-11-29 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2966#discussion_r237747693 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datamap/DataMapWriterSuite.scala --- @@ -156,8

[GitHub] carbondata pull request #2964: [HOTFIX] Fix ArrayOutOfBound exception when d...

2018-11-29 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2964#discussion_r237548880 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -575,7 +575,7 @@ public void testReadColumnTwice

[GitHub] carbondata pull request #2966: [WIP] test and check no sort by default

2018-11-29 Thread ajantha-bhat
GitHub user ajantha-bhat opened a pull request: https://github.com/apache/carbondata/pull/2966 [WIP] test and check no sort by default [WIP] test and check no sort by default Be sure to do all of the following checklist to help us incorporate your contribution quickly

[GitHub] carbondata issue #2964: [HOTFIX] Fix ArrayOutOfBound exception when duplicat...

2018-11-29 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2964 @kunal642 , @kumarvishal09 : please check this ---

[GitHub] carbondata pull request #2964: [HOTFIX] Fix ArrayOutOfBound exception when d...

2018-11-29 Thread ajantha-bhat
GitHub user ajantha-bhat opened a pull request: https://github.com/apache/carbondata/pull/2964 [HOTFIX] Fix ArrayOutOfBound exception when duplicate measure in projection column problem: ArrayOutOfBound exception when duplicate measure in the projection column cause

[GitHub] carbondata pull request #2936: [CARBONDATA-3118] Parallelize block pruning o...

2018-11-28 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2936#discussion_r237174006 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java --- @@ -63,6 +75,8 @@ private

[GitHub] carbondata pull request #2936: [CARBONDATA-3118] Parallelize block pruning o...

2018-11-28 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2936#discussion_r237173860 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1399,6 +1399,17 @@ private

[GitHub] carbondata pull request #2936: [CARBONDATA-3118] Parallelize block pruning o...

2018-11-28 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2936#discussion_r237173725 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1399,6 +1399,17 @@ private

[GitHub] carbondata pull request #2936: [CARBONDATA-3118] Parallelize block pruning o...

2018-11-28 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2936#discussion_r237173126 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonInputFormat.java --- @@ -487,6 +487,8 @@ private int getBlockCount(List

[GitHub] carbondata issue #2962: [CARBONDATA-3138] Fix random count mismatch with mul...

2018-11-28 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2962 @ravipesala , @kumarvishal09 : please check this ---

[GitHub] carbondata pull request #2962: [CARBONDATA-3138] Fix random count mismatch w...

2018-11-28 Thread ajantha-bhat
GitHub user ajantha-bhat opened a pull request: https://github.com/apache/carbondata/pull/2962 [CARBONDATA-3138] Fix random count mismatch with multi-thread block pruning problem: Random count mismatch in query in multi-thread block-pruning scenario. cause: Existing prune

[jira] [Created] (CARBONDATA-3138) Random count mismatch in query in multi-thread block-pruning scenario

2018-11-28 Thread Ajantha Bhat (JIRA)
Ajantha Bhat created CARBONDATA-3138: Summary: Random count mismatch in query in multi-thread block-pruning scenario Key: CARBONDATA-3138 URL: https://issues.apache.org/jira/browse/CARBONDATA-3138

[GitHub] carbondata pull request #2949: [WIP] support parallel block pruning for non-...

2018-11-27 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2949#discussion_r236746764 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMap.java --- @@ -70,4 +70,6 @@ void init(DataMapModel dataMapModel

[GitHub] carbondata pull request #2958: [CARBONDATA-3136] JVM crash with preaggregate...

2018-11-27 Thread ajantha-bhat
GitHub user ajantha-bhat opened a pull request: https://github.com/apache/carbondata/pull/2958 [CARBONDATA-3136] JVM crash with preaggregate datamap when average of decimal column is taken with orderby. problem: JVM crash with preaggregate datamap when average of decimal column

[jira] [Updated] (CARBONDATA-3136) JVM crash with preaggregate datamap

2018-11-27 Thread Ajantha Bhat (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat updated CARBONDATA-3136: - Description: JVM crash with preaggregate datamap. callstack: Stack

[jira] [Created] (CARBONDATA-3136) JVM crash with preaggregate datamap

2018-11-27 Thread Ajantha Bhat (JIRA)
Ajantha Bhat created CARBONDATA-3136: Summary: JVM crash with preaggregate datamap Key: CARBONDATA-3136 URL: https://issues.apache.org/jira/browse/CARBONDATA-3136 Project: CarbonData

[GitHub] carbondata issue #2936: [CARBONDATA-3118] Parallelize block pruning of defau...

2018-11-23 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2936 retest this please ---

[GitHub] carbondata issue #2936: [CARBONDATA-3118] Parallelize block pruning of defau...

2018-11-23 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2936 did a conflict resolve with documentation file. Let the build run again ---

[GitHub] carbondata pull request #2949: [WIP] support parallel block pruning for non-...

2018-11-23 Thread ajantha-bhat
GitHub user ajantha-bhat opened a pull request: https://github.com/apache/carbondata/pull/2949 [WIP] support parallel block pruning for non-default datamaps [WIP] support parallel block pruning for non-default datamaps This PR dependent on #2936 Be sure to do all

[GitHub] carbondata issue #2936: [CARBONDATA-3118] Parallelize block pruning of defau...

2018-11-23 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2936 @ravipesala : PR is ready. please check ---

[GitHub] carbondata pull request #2936: [CARBONDATA-3118] Parallelize block pruning o...

2018-11-22 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2936#discussion_r235846200 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java --- @@ -120,37 +132,166 @@ public BlockletDetailsFetcher

[GitHub] carbondata pull request #2936: [CARBONDATA-3118] Parallelize block pruning o...

2018-11-22 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2936#discussion_r235842114 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java --- @@ -120,37 +132,166 @@ public BlockletDetailsFetcher

[GitHub] carbondata pull request #2936: [CARBONDATA-3118] Parallelize block pruning o...

2018-11-22 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2936#discussion_r235774840 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java --- @@ -120,37 +132,166 @@ public BlockletDetailsFetcher

[GitHub] carbondata pull request #2936: [CARBONDATA-3118] Parallelize block pruning o...

2018-11-21 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2936#discussion_r235615112 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java --- @@ -120,37 +132,166 @@ public BlockletDetailsFetcher

[GitHub] carbondata issue #2936: [CARBONDATA-3118] Parallelize block pruning of defau...

2018-11-21 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2936 retest this please ---

[GitHub] carbondata issue #2936: [CARBONDATA-3118] Parallelize block pruning of defau...

2018-11-21 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2936 @manishgupta88 , @ravipesala : please review ---

[jira] [Created] (CARBONDATA-3118) Parallelize block pruning of default datamap in driver for filter query processing

2018-11-21 Thread Ajantha Bhat (JIRA)
Ajantha Bhat created CARBONDATA-3118: Summary: Parallelize block pruning of default datamap in driver for filter query processing Key: CARBONDATA-3118 URL: https://issues.apache.org/jira/browse/CARBONDATA

[GitHub] carbondata pull request #2936: [WIP] Parallelize block pruning of default da...

2018-11-20 Thread ajantha-bhat
GitHub user ajantha-bhat opened a pull request: https://github.com/apache/carbondata/pull/2936 [WIP] Parallelize block pruning of default datamap in driver for filter query processing Be sure to do all of the following checklist to help us incorporate your contribution quickly

[GitHub] carbondata issue #2921: Removed unnecessary configuration in BlockletDataMap...

2018-11-15 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2921 @ravipesala , @chenliang613 : please add @NamanRastogi to whiteList ---

[GitHub] carbondata issue #2921: Removed unnecessary configuration in BlockletDataMap...

2018-11-15 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2921 retest this please ---

[GitHub] carbondata issue #2895: [HOTFIX] Fix NPE in spark, when same vector reads fi...

2018-11-13 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2895 retest this please ---

[GitHub] carbondata issue #2895: [HOTFIX] Fix NPE in spark, when same vector reads fi...

2018-11-12 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2895 retest this please ---

[GitHub] carbondata issue #2895: [HOTFIX] Fix NPE in spark, when same vector reads fi...

2018-11-11 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2895 retest this please ---

[GitHub] carbondata issue #2895: [HOTFIX] Fix NPE in spark, when same vector reads fi...

2018-11-11 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2895 @manishgupta88 : please check. same 2.3 build has passed without any code changes before run. It is random failure. ---

[GitHub] carbondata issue #2895: [HOTFIX] Fix NPE in spark, when same vector reads fi...

2018-11-06 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2895 retest this please ---

[GitHub] carbondata issue #2895: [HOTFIX] Fix NPE in spark, when same vector reads fi...

2018-11-06 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2895 retest this please ---

[GitHub] carbondata pull request #2895: [HOTFIX] Fix NPE in spark, when same vector r...

2018-11-05 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2895#discussion_r231001948 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/LocalDictDimensionDataChunkStore.java --- @@ -61,10 +61,7

[GitHub] carbondata pull request #2895: [HOTFIX] Fix NPE in spark, when same vector r...

2018-11-05 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2895#discussion_r230997947 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/LocalDictDimensionDataChunkStore.java --- @@ -61,10 +61,7

[GitHub] carbondata issue #2816: [CARBONDATA-3003] Suppor read batch row in CSDK

2018-11-05 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2816 LGTM ---

[GitHub] carbondata pull request #2895: [HOTFIX] Fix NPE in spark, when same vector r...

2018-11-05 Thread ajantha-bhat
GitHub user ajantha-bhat opened a pull request: https://github.com/apache/carbondata/pull/2895 [HOTFIX] Fix NPE in spark, when same vector reads files with local dictionary and without local dictionary problem: NPE in spark, when same vector reads files with local dictionary

[GitHub] carbondata issue #2888: [CARBONDATA-3066]add documentation for writtenBy and...

2018-11-02 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2888 LGTM ---

[GitHub] carbondata pull request #2850: [CARBONDATA-3056] Added concurrent reading th...

2018-11-01 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2850#discussion_r230272267 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java --- @@ -114,6 +115,57 @@ public static CarbonReaderBuilder

[GitHub] carbondata pull request #2888: [CARBONDATA-3066]add documentation for writte...

2018-10-31 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2888#discussion_r229733657 --- Diff: docs/sdk-guide.md --- @@ -686,6 +695,16 @@ Find example code at [CarbonReaderExample](https://github.com/apache/carbondata

[GitHub] carbondata pull request #2888: [CARBONDATA-3066]add documentation for writte...

2018-10-31 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2888#discussion_r229733094 --- Diff: docs/sdk-guide.md --- @@ -429,6 +429,15 @@ public CarbonWriterBuilder withAvroInput(org.apache.avro.Schema avroSchema); public

[GitHub] carbondata pull request #2816: [CARBONDATA-3003] Suppor read batch row in CS...

2018-10-31 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2816#discussion_r229629760 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/result/RowBatch.java --- @@ -100,4 +100,19 @@ public int getSize() { counter

[GitHub] carbondata issue #2807: [CARBONDATA-2997] Support read schema from index fil...

2018-10-31 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2807 LGTM. Let one more reviewer review. ---

[GitHub] carbondata pull request #2804: [CARBONDATA-2996] CarbonSchemaReader support ...

2018-10-31 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2804#discussion_r229583983 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java --- @@ -64,11 +66,70 @@ public static Schema

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Changes for improving carbo...

2018-10-30 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r229298501 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java --- @@ -1737,4 +1738,89 @@ public void

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Changes for improving carbo...

2018-10-30 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r229284011 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonVectorizedRecordReader.java --- @@ -0,0 +1,194 @@ +/* + * Licensed

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Changes for improving carbo...

2018-10-30 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r229254647 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonVectorizedRecordReader.java --- @@ -0,0 +1,194 @@ +/* + * Licensed

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Changes for improving carbo...

2018-10-30 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r229248603 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java --- @@ -180,6 +235,11 @@ public CarbonTable

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Changes for improving carbo...

2018-10-30 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r229246953 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java --- @@ -145,9 +158,33 @@ public CarbonTable

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Changes for improving carbo...

2018-10-30 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r229243919 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputSplit.java --- @@ -138,6 +138,19 @@ public CarbonInputSplit(String

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Changes for improving carbo...

2018-10-30 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r229247445 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java --- @@ -145,9 +158,33 @@ public CarbonTable

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Changes for improving carbo...

2018-10-30 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r229218201 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/CarbonColumnVectorImpl.java --- @@ -305,7 +301,7 @@ public void

[GitHub] carbondata pull request #2876: [CARBONDATA-3054] Fix Dictionary file cannot ...

2018-10-30 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2876#discussion_r229237604 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDictionaryDecoder.scala --- @@ -137,14 +139,15 @@ case class

[GitHub] carbondata pull request #2876: [CARBONDATA-3054] Fix Dictionary file cannot ...

2018-10-30 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2876#discussion_r229237654 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDictionaryDecoder.scala --- @@ -557,16 +561,20 @@ class CarbonDecoderRDD

[GitHub] carbondata pull request #2869: [CARBONDATA-3057] Changes for improving carbo...

2018-10-30 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2869#discussion_r229193317 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeVariableLengthDimensionDataChunkStore.java

[GitHub] carbondata pull request #2850: [WIP] Added concurrent reading through SDK

2018-10-29 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2850#discussion_r229183542 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/ConcurrentSdkReaderTest.java --- @@ -0,0 +1,153 @@ +/* + * Licensed

[GitHub] carbondata pull request #2850: [WIP] Added concurrent reading through SDK

2018-10-29 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2850#discussion_r229183179 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java --- @@ -114,6 +117,43 @@ public static CarbonReaderBuilder

[GitHub] carbondata pull request #2850: [WIP] Added concurrent reading through SDK

2018-10-29 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2850#discussion_r229179978 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java --- @@ -114,6 +117,43 @@ public static CarbonReaderBuilder

[GitHub] carbondata pull request #2850: [WIP] Added concurrent reading through SDK

2018-10-29 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2850#discussion_r229179713 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java --- @@ -114,6 +117,43 @@ public static CarbonReaderBuilder

[GitHub] carbondata pull request #2850: [WIP] Added concurrent reading through SDK

2018-10-29 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2850#discussion_r229179428 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java --- @@ -114,6 +117,43 @@ public static CarbonReaderBuilder

[GitHub] carbondata issue #2876: [CARBONDATA-3054] Fix Dictionary file cannot be read...

2018-10-29 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2876 retest this please ---

[GitHub] carbondata pull request #2804: [CARBONDATA-2996] CarbonSchemaReader support ...

2018-10-29 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2804#discussion_r229173861 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonSchemaReaderTest.java --- @@ -0,0 +1,170 @@ +/* + * Licensed

[GitHub] carbondata pull request #2804: [CARBONDATA-2996] CarbonSchemaReader support ...

2018-10-29 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2804#discussion_r229173916 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java --- @@ -59,11 +60,30 @@ public static Schema

<    1   2   3   4   5   6   7   8   9   10   >