Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2982#discussion_r241282108
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java
---
@@ -364,23 +355,38 @@ private CarbonTable
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2979
@manishnalla1994 Please fix the checkstyle
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2949
@ajantha-bhat Please rebase
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2949#discussion_r241279768
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMap.java ---
@@ -70,4 +70,8 @@ void init(DataMapModel dataMapModel
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2949#discussion_r241279625
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java
---
@@ -436,4 +436,9 @@ public String
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2983
add to whitelist
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2976
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2977
LGTM
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2978#discussion_r240558221
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/ColumnarVectorWrapperDirect.java
---
@@ -0,0 +1,320
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2978#discussion_r240558189
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/ColumnarVectorWrapperDirect.java
---
@@ -0,0 +1,320
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2978#discussion_r240558250
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/ColumnarVectorWrapperDirect.java
---
@@ -0,0 +1,320
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2978#discussion_r240557669
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/ColumnarVectorWrapperDirect.java
---
@@ -0,0 +1,320
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2978#discussion_r240554909
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/ColumnarVectorWrapperDirect.java
---
@@ -0,0 +1,320
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2978#discussion_r240554851
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/ColumnarVectorWrapperDirect.java
---
@@ -0,0 +1,320
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2978#discussion_r240553968
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/ColumnarVectorWrapperDirect.java
---
@@ -0,0 +1,320
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2978#discussion_r240553500
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/CarbonColumnVectorImpl.java
---
@@ -367,7 +378,14 @@ public void
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2978#discussion_r240553152
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/AbstractNonDictionaryVectorFiller.java
---
@@ -83,20 +84,37
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2978#discussion_r240552207
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/AbstractNonDictionaryVectorFiller.java
---
@@ -83,20 +84,37
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2978#discussion_r240551915
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/directread/SequentialFill.java
---
@@ -0,0 +1,33
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2978
retest this please
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2977#discussion_r240215937
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala
---
@@ -111,6 +113,29
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2976
This PR supports compaction only for STRUCT and ARRAY. Please raise another
jira and PR to support MAP type as well.
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2976#discussion_r240215007
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java
---
@@ -371,9 +374,25 @@ public static
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2976#discussion_r240214729
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java
---
@@ -407,6 +426,81 @@ public static
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2976#discussion_r240213617
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java
---
@@ -407,6 +426,81 @@ public static
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2976#discussion_r240212600
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java
---
@@ -407,6 +426,81 @@ public static
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2976#discussion_r240212283
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java
---
@@ -407,6 +426,81 @@ public static
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2976#discussion_r240209202
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/CarbonCompactionUtil.java
---
@@ -337,6 +342,25 @@ public static void
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2976#discussion_r240210882
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java
---
@@ -371,9 +374,25 @@ public static
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2975
LGTM
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2978#discussion_r240204662
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/ColumnarVectorWrapperDirect.java
---
@@ -0,0 +1,321
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2977#discussion_r239345454
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala
---
@@ -111,6 +113,29
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2977#discussion_r239344495
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/AggregateDataMapCompactor.scala
---
@@ -79,9 +79,20 @@ class
GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/2978
[WIP] Added lazy load and direct vector fill support to Presto
This PR is on top of https://github.com/apache/carbondata/pull/2972
Be sure to do all of the following checklist
GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/2972
[CARBONDATA-3143] Fixed local dictionary in presto
Problem:
Currently, local dictionary columns are not working for presto as it is not
handled in the integration layer
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2967
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2964
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2948
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2958
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2953
LGTM
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2953#discussion_r236640610
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonMergerRDD.scala
---
@@ -401,7 +401,11 @@ class
GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/2957
[DOCUMENT] Added filter push handling parameter in documents.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2945#discussion_r236538593
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
@@ -66,9 +63,6 @@
this.readers = readers
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2952
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2936
retest this please
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2943
add to whitelist
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2945
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2944
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2936
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2923
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2933
LGTM
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2936#discussion_r235612449
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java ---
@@ -120,37 +132,166 @@ public BlockletDetailsFetcher
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2936#discussion_r235611698
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java ---
@@ -120,37 +132,166 @@ public BlockletDetailsFetcher
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2936#discussion_r235611496
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java ---
@@ -120,37 +132,166 @@ public BlockletDetailsFetcher
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2939
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2920
LGTM
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2923#discussion_r235270774
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/standardpartition/StandardPartitionTableQueryTestCase.scala
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2927
retest this please
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2921
add to whitelist
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2927
retest this please
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2907
LGTM
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2872#discussion_r234125610
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/ReusableDataBuffer.java
---
@@ -0,0 +1,33 @@
+/*
+ * Licensed
GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/2926
[HOTFIX] Reduce blocklet minimum configurable size
In case of point queries, it would be better to create less blocklet size
to read less data. So reducing the minimum blocklet size limit
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2908#discussion_r233759450
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
---
@@ -1214,16 +1232,22 @@ public String getFormat
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2872#discussion_r233321330
--- Diff:
integration/spark-datasource/src/main/spark2.1andspark2.2/org/apache/spark/sql/CarbonVectorProxy.java
---
@@ -454,7 +458,11 @@ public
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2898
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2886
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2898
retest this please
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2904
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2896
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2904
@jackylk , it seems to build failed during coverage report after the build.
There are few references of `store/search` in the spark-common-test module pom.
Please check and remove
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2913
@sujith71955 this check is required otherwise, Update/Delete does not work.
`filteredRows` got initialized in `VectorizedCarbonRecordReader` and it is
updated
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2886
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2898
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2898
@manishgupta88 I am referring to `DataMapFactory.getDataMaps(List
segments)` . If already cached with old table then who invalidates them. For
new table also it gets the old datamaps right.
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2902
@kunal642 Please check PR https://github.com/apache/carbondata/pull/2863 .
This issue should not happen there. Please verify once
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2898
@manishgupta88 it solves part of the problem (schema mismatch issue). But
when you call getDataMaps it will give stale datamaps to you right. How those
can be updated?
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2886
ok, its fine
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2886#discussion_r230653013
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/TestNoInvertedIndexLoadAndQuery.scala
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2863#discussion_r230625720
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPageByteUtil.java
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2863#discussion_r230625583
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java
---
@@ -224,135 +239,134
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2863#discussion_r230625603
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveDeltaFloatingCodec.java
---
@@ -244,59 +243,56
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2863#discussion_r230625574
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/PrimitivePageStatsCollector.java
---
@@ -243,6 +244,11 @@ private
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2863#discussion_r230625480
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPageValueConverter.java
---
@@ -37,5 +40,6 @@
double
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2850
retest this please
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230299553
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
---
@@ -51,6 +54,7 @@
private Expression
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2850#discussion_r230297864
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
@@ -114,6 +115,57 @@ public static CarbonReaderBuilder
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2886
@akashrn5 Please expose these properties from SDK and fileformat as well.
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2877
LGTM , Please fix the CI
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2715
LGTM
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230252544
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java
---
@@ -88,6 +99,50 @@ public CarbonTable
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230251863
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonVectorizedRecordReader.java
---
@@ -0,0 +1,194 @@
+/*
+ * Licensed
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230251542
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java
---
@@ -88,6 +99,50 @@ public CarbonTable
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230247574
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java
---
@@ -347,9 +347,7 @@ private
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2869#discussion_r230247332
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/AbstractDFSCarbonFile.java
---
@@ -524,6 +524,22 @@ public
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2850#discussion_r230246531
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
@@ -114,6 +115,57 @@ public static CarbonReaderBuilder
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2850#discussion_r230244674
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java ---
@@ -114,6 +115,57 @@ public static CarbonReaderBuilder
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2870
LGTM
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2867
LGTM
---
GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/2873
[WIP] Fix partition load issue when custom location is added.
Problem:
Load files from carbonfile format when custom partition location is added
Reason:
Carbon has its own
101 - 200 of 8676 matches
Mail list logo
