[GitHub] incubator-carbondata pull request #810: [CARBONDATA-935] Define PartitionInf...

2017-04-18 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/810#discussion_r112102662 --- Diff: format/src/main/thrift/schema.thrift --- @@ -121,6 +127,27 @@ struct SchemaEvolution{ } /** + * One partition

[GitHub] incubator-carbondata pull request #810: [CARBONDATA-935] Define PartitionInf...

2017-04-18 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/810#discussion_r112102773 --- Diff: format/src/main/thrift/schema.thrift --- @@ -121,6 +127,27 @@ struct SchemaEvolution{ } /** + * One partition

[GitHub] incubator-carbondata pull request #810: [CARBONDATA-935] Define PartitionInf...

2017-04-18 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/810#discussion_r112102257 --- Diff: format/src/main/thrift/schema.thrift --- @@ -121,6 +127,27 @@ struct SchemaEvolution{ } /** + * One partition

[GitHub] incubator-carbondata pull request #810: [CARBONDATA-935] Define PartitionInf...

2017-04-18 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/810#discussion_r112102312 --- Diff: format/src/main/thrift/schema.thrift --- @@ -121,6 +127,27 @@ struct SchemaEvolution{ } /** + * One partition

[GitHub] incubator-carbondata pull request #810: [CARBONDATA-935] Define PartitionInf...

2017-04-18 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/810#discussion_r112102353 --- Diff: format/src/main/thrift/schema.thrift --- @@ -121,6 +127,27 @@ struct SchemaEvolution{ } /** + * One partition

[GitHub] incubator-carbondata issue #795: [CARBONDATA-923]fix issue of insertInto rea...

2017-04-18 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/795 @gvramana I moved test case to spark 2.1. And spark 1.6 doesn't support it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Created] (CARBONDATA-941) 7. Compaction of Partition Table

2017-04-17 Thread QiangCai (JIRA)
QiangCai created CARBONDATA-941: --- Summary: 7. Compaction of Partition Table Key: CARBONDATA-941 URL: https://issues.apache.org/jira/browse/CARBONDATA-941 Project: CarbonData Issue Type: Sub

[jira] [Created] (CARBONDATA-939) 5. Partition tables join on partition column

2017-04-17 Thread QiangCai (JIRA)
QiangCai created CARBONDATA-939: --- Summary: 5. Partition tables join on partition column Key: CARBONDATA-939 URL: https://issues.apache.org/jira/browse/CARBONDATA-939 Project: CarbonData Issue

[jira] [Created] (CARBONDATA-940) 6. Alter table add/drop partition

2017-04-17 Thread QiangCai (JIRA)
QiangCai created CARBONDATA-940: --- Summary: 6. Alter table add/drop partition Key: CARBONDATA-940 URL: https://issues.apache.org/jira/browse/CARBONDATA-940 Project: CarbonData Issue Type: Sub

[GitHub] incubator-carbondata pull request #795: [CARBONDATA-923]fix issue of insertI...

2017-04-13 Thread QiangCai
GitHub user QiangCai opened a pull request: https://github.com/apache/incubator-carbondata/pull/795 [CARBONDATA-923]fix issue of insertInto read from OneRowRelation Reproduce: create table OneRowTable(col1 string, col2 string, col3 int, col4 double) stored by 'carbondata

[jira] [Created] (CARBONDATA-923) InserInto read from one row not working

2017-04-13 Thread QiangCai (JIRA)
QiangCai created CARBONDATA-923: --- Summary: InserInto read from one row not working Key: CARBONDATA-923 URL: https://issues.apache.org/jira/browse/CARBONDATA-923 Project: CarbonData Issue Type

[GitHub] incubator-carbondata pull request #784: [WIP]Pr730

2017-04-12 Thread QiangCai
Github user QiangCai closed the pull request at: https://github.com/apache/incubator-carbondata/pull/784 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-carbondata issue #784: [WIP]Pr730

2017-04-11 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/784 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-carbondata issue #765: [CARBONDATA-887]lazy rdd iterator for Inser...

2017-04-10 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/765 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-carbondata issue #765: [CARBONDATA-887]lazy rdd iterator for Inser...

2017-04-10 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/765 @gvramana This pr will fix memory issue of InsertInto. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-carbondata issue #767: fix sort_columns issue(12-dev)

2017-04-10 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/767 @jackylk please review again --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-carbondata issue #767: fix sort_columns issue(12-dev)

2017-04-10 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/767 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-carbondata pull request #767: fix sort_columns issue(12-dev)

2017-04-10 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/767#discussion_r110694824 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/resolver/RowLevelRangeFilterResolverImpl.java --- @@ -147,12 +148,16

[GitHub] incubator-carbondata pull request #767: fix sort_columns issue(12-dev)

2017-04-10 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/767#discussion_r110694868 --- Diff: core/src/main/java/org/apache/carbondata/core/util/ByteUtil.java --- @@ -540,7 +543,7 @@ public static int toInt(byte[] bytes, int

[GitHub] incubator-carbondata issue #765: [CARBONDATA-887]lazy rdd iterator for Inser...

2017-04-10 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/765 @jackylk please review again --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-carbondata pull request #765: [CARBONDATA-887]lazy rdd iterator fo...

2017-04-10 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/765#discussion_r110675207 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala --- @@ -504,3 +500,66 @@ class

[GitHub] incubator-carbondata pull request #765: [CARBONDATA-887]lazy rdd iterator fo...

2017-04-10 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/765#discussion_r110675205 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala --- @@ -504,3 +500,66 @@ class

[GitHub] incubator-carbondata pull request #765: [CARBONDATA-887]lazy rdd iterator fo...

2017-04-10 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/765#discussion_r110675213 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala --- @@ -504,3 +500,66 @@ class

[GitHub] incubator-carbondata pull request #767: fix batch no issue for CarbonRowData...

2017-04-08 Thread QiangCai
GitHub user QiangCai opened a pull request: https://github.com/apache/incubator-carbondata/pull/767 fix batch no issue for CarbonRowDataWriterProcessorStepImpl(12-dev) fix batch no issue for CarbonRowDataWriterProcessorStepImpl(12-dev) You can merge this pull request into a Git

[GitHub] incubator-carbondata pull request #765: [CARBONDATA-887]lazy rdd iterator fo...

2017-04-07 Thread QiangCai
GitHub user QiangCai opened a pull request: https://github.com/apache/incubator-carbondata/pull/765 [CARBONDATA-887]lazy rdd iterator for InsertInto Previously we also called the rdd.iterator method for all partitions, and released the resources after all partitions were executed

[jira] [Created] (CARBONDATA-887) lazy rdd iterator for InsertInto

2017-04-07 Thread QiangCai (JIRA)
QiangCai created CARBONDATA-887: --- Summary: lazy rdd iterator for InsertInto Key: CARBONDATA-887 URL: https://issues.apache.org/jira/browse/CARBONDATA-887 Project: CarbonData Issue Type

[GitHub] incubator-carbondata pull request #764: [CARBONDATA-886]remove all redundant...

2017-04-07 Thread QiangCai
GitHub user QiangCai opened a pull request: https://github.com/apache/incubator-carbondata/pull/764 [CARBONDATA-886]remove all redundant local variable(12-dev) remove all redundant local variable You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-carbondata pull request #760: [CARBONDATA-886]remove all redundant...

2017-04-07 Thread QiangCai
Github user QiangCai closed the pull request at: https://github.com/apache/incubator-carbondata/pull/760 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-carbondata issue #760: [CARBONDATA-886]remove all redundant local ...

2017-04-07 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/760 close this pr and raise another to 12-dev branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-carbondata issue #759: [WIP]lazy rdd iterator during insert into

2017-04-07 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/759 close this pr and raise another to 12-dev branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-carbondata pull request #759: [WIP]lazy rdd iterator during insert...

2017-04-07 Thread QiangCai
Github user QiangCai closed the pull request at: https://github.com/apache/incubator-carbondata/pull/759 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-carbondata pull request #762: clean java/scala doc issue

2017-04-07 Thread QiangCai
GitHub user QiangCai opened a pull request: https://github.com/apache/incubator-carbondata/pull/762 clean java/scala doc issue clean java/scala doc issue You can merge this pull request into a Git repository by running: $ git pull https://github.com/QiangCai/incubator

[GitHub] incubator-carbondata pull request #761: clean company information

2017-04-07 Thread QiangCai
GitHub user QiangCai opened a pull request: https://github.com/apache/incubator-carbondata/pull/761 clean company information You can merge this pull request into a Git repository by running: $ git pull https://github.com/QiangCai/incubator-carbondata cleancode Alternatively

[GitHub] incubator-carbondata pull request #741: [CARBONDATA-842]implement CarbonRowD...

2017-04-07 Thread QiangCai
Github user QiangCai closed the pull request at: https://github.com/apache/incubator-carbondata/pull/741 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[jira] [Created] (CARBONDATA-886) remove all redundant local variable

2017-04-07 Thread QiangCai (JIRA)
QiangCai created CARBONDATA-886: --- Summary: remove all redundant local variable Key: CARBONDATA-886 URL: https://issues.apache.org/jira/browse/CARBONDATA-886 Project: CarbonData Issue Type

[GitHub] incubator-carbondata pull request #760: [CARBONDATA-886]remove all redundant...

2017-04-07 Thread QiangCai
GitHub user QiangCai opened a pull request: https://github.com/apache/incubator-carbondata/pull/760 [CARBONDATA-886]remove all redundant local variable remove all redundant local variable You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-carbondata pull request #759: [WIP]lazy rdd iterator during insert...

2017-04-07 Thread QiangCai
GitHub user QiangCai opened a pull request: https://github.com/apache/incubator-carbondata/pull/759 [WIP]lazy rdd iterator during insert into You can merge this pull request into a Git repository by running: $ git pull https://github.com/QiangCai/incubator-carbondata

[GitHub] incubator-carbondata pull request #751: [CARBONDATA-816] Added Example for H...

2017-04-07 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/751#discussion_r110371730 --- Diff: integration/hive/pom.xml --- @@ -95,7 +168,9

[GitHub] incubator-carbondata pull request #751: [CARBONDATA-816] Added Example for H...

2017-04-07 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/751#discussion_r110371806 --- Diff: integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala --- @@ -0,0 +1,146

[GitHub] incubator-carbondata pull request #751: [CARBONDATA-816] Added Example for H...

2017-04-07 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/751#discussion_r110371979 --- Diff: integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala --- @@ -0,0 +1,146

[GitHub] incubator-carbondata pull request #757: [CARBONDATA-782]support SORT_COLUMNS

2017-04-07 Thread QiangCai
GitHub user QiangCai opened a pull request: https://github.com/apache/incubator-carbondata/pull/757 [CARBONDATA-782]support SORT_COLUMNS The tasks of SORT_COLUMNS: Support create table with sort_columns property. e.g. tblproperties('sort_columns' = 'col7,col3

[GitHub] incubator-carbondata issue #752: [CARBONDATA-879] Clear driver side dict cac...

2017-04-06 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/752 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-carbondata pull request #750: revert pom.xml for hive branch

2017-04-06 Thread QiangCai
GitHub user QiangCai opened a pull request: https://github.com/apache/incubator-carbondata/pull/750 revert pom.xml for hive branch You can merge this pull request into a Git repository by running: $ git pull https://github.com/QiangCai/incubator-carbondata hive_optimize

[jira] [Assigned] (CARBONDATA-841) improve the compress encoding for numeric type column to give good performance

2017-04-06 Thread QiangCai (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] QiangCai reassigned CARBONDATA-841: --- Assignee: QiangCai > improve the compress encoding for numeric type column to give g

[jira] [Assigned] (CARBONDATA-842) when SORT_COLUMN is empty, no need to sort data.

2017-04-06 Thread QiangCai (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] QiangCai reassigned CARBONDATA-842: --- Assignee: QiangCai > when SORT_COLUMN is empty, no need to sort d

[GitHub] incubator-carbondata issue #740: [CARBONDATA-815] add hive integration for c...

2017-04-05 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/740 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-carbondata pull request #741: [CARBONDATA-782]implement NoSortData...

2017-04-05 Thread QiangCai
GitHub user QiangCai opened a pull request: https://github.com/apache/incubator-carbondata/pull/741 [CARBONDATA-782]implement NoSortDataWriterProcessorStepImpl for no SORT_COLUMN When SORT_COLUMNS is empty, the table is unsorted 1. remove NoSortProcessorStepImpl.java 2

[GitHub] incubator-carbondata pull request #722: [CARBONDATA-782]support unsorted tab...

2017-04-05 Thread QiangCai
Github user QiangCai closed the pull request at: https://github.com/apache/incubator-carbondata/pull/722 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-carbondata pull request #722: [CARBONDATA-782]support unsorted tab...

2017-04-05 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/722#discussion_r109867883 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/steps/NoSortProcessorStepImpl.java --- @@ -0,0 +1,123

[GitHub] incubator-carbondata pull request #722: [CARBONDATA-782]support unsorted tab...

2017-04-05 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/722#discussion_r109867759 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/impl/btree/BTreeDataRefNodeFinder.java --- @@ -51,16 +51,15

[GitHub] incubator-carbondata pull request #722: [CARBONDATA-782]support unsorted tab...

2017-04-05 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/722#discussion_r109867836 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -490,8 +490,20 @@ abstract

[GitHub] incubator-carbondata pull request #722: [CARBONDATA-782]support unsorted tab...

2017-04-05 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/722#discussion_r109867805 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/sortcolumns/TestSortColumns.scala

[GitHub] incubator-carbondata pull request #722: [CARBONDATA-782]support unsorted tab...

2017-04-05 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/722#discussion_r109867776 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentProperties.java --- @@ -54,6 +54,8

[GitHub] incubator-carbondata pull request #723: [CARBONDATA-845] Insert Select Into ...

2017-04-03 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/723#discussion_r109574552 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/hive/CarbonPreInsertionCasts.scala --- @@ -0,0 +1,62 @@ +/* --- End

[GitHub] incubator-carbondata pull request #722: [CARBONDATA-782]support unsorted tab...

2017-04-02 Thread QiangCai
GitHub user QiangCai opened a pull request: https://github.com/apache/incubator-carbondata/pull/722 [CARBONDATA-782]support unsorted table (when SORT_COLUMNS is empty) When SORT_COLUMNS of a table is empty or the table doesn't have dimensions(besides complex type column

[GitHub] incubator-carbondata issue #715: [CARBONDATA-782]support SORT_COLUMNS

2017-04-01 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/715 This PR was merged, so I close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-carbondata pull request #715: [CARBONDATA-782]support SORT_COLUMNS...

2017-04-01 Thread QiangCai
Github user QiangCai closed the pull request at: https://github.com/apache/incubator-carbondata/pull/715 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-carbondata issue #715: [CARBONDATA-782]support SORT_COLUMNS

2017-03-31 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/715 done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[jira] [Created] (CARBONDATA-842) when SORT_COLUMN is empty, no need to sort data.

2017-03-31 Thread QiangCai (JIRA)
QiangCai created CARBONDATA-842: --- Summary: when SORT_COLUMN is empty, no need to sort data. Key: CARBONDATA-842 URL: https://issues.apache.org/jira/browse/CARBONDATA-842 Project: CarbonData

[jira] [Created] (CARBONDATA-841) improve the compress encoding for numeric type column to give good performance

2017-03-31 Thread QiangCai (JIRA)
QiangCai created CARBONDATA-841: --- Summary: improve the compress encoding for numeric type column to give good performance Key: CARBONDATA-841 URL: https://issues.apache.org/jira/browse/CARBONDATA-841

[GitHub] incubator-carbondata issue #715: [CARBONDATA-782]support SORT_COLUMNS

2017-03-30 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/715 @ravipesala @jackylk I raised this new pr based on 12-dev branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-carbondata issue #715: [CARBONDATA-782]support SORT_COLUMNS

2017-03-30 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/715 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-carbondata pull request #635: [CARBONDATA-782]support SORT_COLUMNS

2017-03-30 Thread QiangCai
Github user QiangCai closed the pull request at: https://github.com/apache/incubator-carbondata/pull/635 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-carbondata issue #635: [CARBONDATA-782]support SORT_COLUMNS

2017-03-30 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/635 close this pr. I will raise another pr to merge to 12-dev branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-carbondata pull request #715: [CARBONDATA-782]support SORT_COLUMNS...

2017-03-30 Thread QiangCai
GitHub user QiangCai opened a pull request: https://github.com/apache/incubator-carbondata/pull/715 [CARBONDATA-782]support SORT_COLUMNS The tasks of SORT_COLUMNS: Support create table with sort_columns property. e.g. tblproperties('sort_columns' = 'col7,col3

[GitHub] incubator-carbondata issue #635: [CARBONDATA-782]support SORT_COLUMNS

2017-03-30 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/635 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-carbondata issue #659: [CARBONDATA-781] Store one SegmentPropertie...

2017-03-27 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/659 @kumarvishal09 dump picture is driver tree. @watermen this pr only implement to reuse segment properties in driver side. can you try to do it in executor side? About the building

[GitHub] incubator-carbondata pull request #659: [CARBONDATA-781] Store one SegmentPr...

2017-03-27 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/659#discussion_r108146058 --- Diff: core/src/test/java/org/apache/carbondata/core/datastore/block/SegmentTaskIndexTest.java --- @@ -58,7 +58,9 @@ @Mock

[GitHub] incubator-carbondata pull request #659: [CARBONDATA-781] Store one SegmentPr...

2017-03-25 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/659#discussion_r108033699 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentTaskIndex.java --- @@ -16,30 +16,52 @@ */ package

[GitHub] incubator-carbondata issue #696: [CARBONDATA-818] Make the file_name in carb...

2017-03-25 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/696 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-carbondata issue #691: [CARBONDATA-783] Fixed message fails with o...

2017-03-24 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/691 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-carbondata issue #691: [CARBONDATA-783] Fixed message fails with o...

2017-03-24 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/691 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-carbondata issue #694: [CARBONDATA-814] bad record log file writin...

2017-03-24 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/694 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-carbondata pull request #697: [CARBONDATA-708] Fixed Between and L...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/697#discussion_r107919139 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/CarbonFilters.scala --- @@ -111,16 +111,24 @@ object

[GitHub] incubator-carbondata pull request #697: [CARBONDATA-708] Fixed Between and L...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/697#discussion_r107918771 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/CarbonFilters.scala --- @@ -111,16 +111,24 @@ object

[GitHub] incubator-carbondata pull request #697: [CARBONDATA-708] Fixed Between and L...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/697#discussion_r107920260 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/CarbonFilters.scala --- @@ -111,16 +111,24 @@ object

[GitHub] incubator-carbondata issue #696: [CARBONDATA-818] Make the file_name in carb...

2017-03-24 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/696 @watermen It is unnecessary to store carbondata file path in carbonindex file. During btree building, just use carbondata file name to sort tableblockinfos. please check

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107893281 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java --- @@ -0,0 +1,99

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107862312 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonArrayInspector.java --- @@ -0,0 +1,191

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107886267 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonHiveSerDe.java --- @@ -0,0 +1,232 @@ +/* + * Licensed

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107875522 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonHiveRecordReader.java --- @@ -0,0 +1,249

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107863523 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonArrayInspector.java --- @@ -0,0 +1,191

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107894484 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java --- @@ -0,0 +1,99

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107881262 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonHiveRecordReader.java --- @@ -0,0 +1,249

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107862824 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonArrayInspector.java --- @@ -0,0 +1,191

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107863410 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonArrayInspector.java --- @@ -0,0 +1,191

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107873741 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java --- @@ -0,0 +1,99

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107890848 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonOutputFormat.java --- @@ -0,0 +1,49

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107863484 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonArrayInspector.java --- @@ -0,0 +1,191

[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...

2017-03-24 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107841211 --- Diff: dev/java-code-format-template.xml --- @@ -34,8 +34,8

[GitHub] incubator-carbondata pull request #635: [CARBONDATA-782]support SORT_COLUMNS

2017-03-20 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/635#discussion_r106844177 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/NonDictionaryFieldConverterImpl.java

[GitHub] incubator-carbondata pull request #635: [CARBONDATA-782]support SORT_COLUMNS

2017-03-20 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/635#discussion_r106844180 --- Diff: processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/SortDataRows.java --- @@ -193,20 +193,42

[GitHub] incubator-carbondata pull request #635: [CARBONDATA-782]support SORT_COLUMNS

2017-03-20 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/635#discussion_r106844183 --- Diff: processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/SortDataRows.java --- @@ -193,20 +193,42

[GitHub] incubator-carbondata pull request #635: [CARBONDATA-782]support SORT_COLUMNS

2017-03-20 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/635#discussion_r106844188 --- Diff: processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/SortDataRows.java --- @@ -460,22 +482,46

[GitHub] incubator-carbondata pull request #635: [CARBONDATA-782]support SORT_COLUMNS

2017-03-20 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/635#discussion_r106844171 --- Diff: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java --- @@ -320,6 +320,80 @@ public static Object

[GitHub] incubator-carbondata issue #635: [CARBONDATA-782]support SORT_COLUMNS

2017-03-16 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/635 Data Records : 1 * 1000 * 1000 ``` SORT BY ALL DIMENSION: c1,c2,c3,c4,c5 CREATE TABLE IF NOT EXISTS default.carbon_perftest_table (c1 STRING, c2 STRING, c3 STRING

[GitHub] incubator-carbondata issue #635: [WIP]support SORT_COLUMNS

2017-03-15 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/incubator-carbondata/pull/635 @kumarvishal09 1. If user has not mentioned any sort column then it will go to old flow, sorting based on all dimension column 2. yes 3. During dataloading, the start/end

[jira] [Created] (CARBONDATA-782) Support SORT_COLUMNS

2017-03-15 Thread QiangCai (JIRA)
QiangCai created CARBONDATA-782: --- Summary: Support SORT_COLUMNS Key: CARBONDATA-782 URL: https://issues.apache.org/jira/browse/CARBONDATA-782 Project: CarbonData Issue Type: New Feature

[jira] [Updated] (CARBONDATA-763) Add L5 loading support, global sorting like HBase

2017-03-13 Thread QiangCai (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] QiangCai updated CARBONDATA-763: Issue Type: New Feature (was: Bug) > Add L5 loading support, global sorting like HB

[jira] [Created] (CARBONDATA-765) dataframe wirter need to first drop table unless loading said table not found

2017-03-13 Thread QiangCai (JIRA)
QiangCai created CARBONDATA-765: --- Summary: dataframe wirter need to first drop table unless loading said table not found Key: CARBONDATA-765 URL: https://issues.apache.org/jira/browse/CARBONDATA-765

  1   2   3   >