Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/594
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r101462875
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/sort/Sorter.java
---
@@ -39,11 +39,13 @@
* Sorts the dat
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r101460125
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/sort/Sorter.java
---
@@ -39,11 +39,13 @@
* Sorts the dat
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r101443741
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/sort/Sorter.java
---
@@ -39,11 +39,13 @@
* Sorts the d
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r101436986
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -641,7 +641,7 @@
/**
* CA
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r101436963
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/SortDataRows.java
---
@@ -375,6 +376,9 @@ privat
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r101436969
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/IntermediateFileMerger.java
---
@@ -116,8 +116,1
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r101432953
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/IntermediateFileMerger.java
---
@@ -116,8 +116,1
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r101432584
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/sort/impl/ParallelReadMergeSorterImpl.java
---
@@ -86,11 +88,10
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r100721876
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/SortDataRows.java
---
@@ -375,6 +376,9 @@ priv
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r100721771
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/IntermediateFileMerger.java
---
@@ -116,8 +116
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r100721427
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/sort/impl/ParallelReadMergeSorterImpl.java
---
@@ -86,11 +88,1
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r100721258
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -641,7 +641,7 @@
/**
*
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r100695668
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/row/CarbonRowBatch.java
---
@@ -17,27 +17,40 @@
p
14 matches
Mail list logo
