[
https://issues.apache.org/jira/browse/LANG-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803375#comment-17803375
]
Gary D. Gregory commented on LANG-1726:
---
Since we don't want to break binary compatibility, the best
[
https://issues.apache.org/jira/browse/LANG-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803352#comment-17803352
]
Niall Pemberton commented on LANG-1726:
---
Václav has identified the main issue. It looks like the
garydgregory commented on PR #254:
URL: https://github.com/apache/commons-bcel/pull/254#issuecomment-1877907283
Also note that out test coverage is not great
(https://commons.apache.org/proper/commons-bcel/jacoco/index.html), so any help
there would be appreciated
--
This is an
garydgregory commented on PR #254:
URL: https://github.com/apache/commons-bcel/pull/254#issuecomment-1877883989
In general, I feel it's best not to edit changes.xml as it could create
conflicts with other PRs.
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/LANG-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803335#comment-17803335
]
Václav Haisman edited comment on LANG-1726 at 1/4/24 9:50 PM:
--
After looking
[
https://issues.apache.org/jira/browse/LANG-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803335#comment-17803335
]
Václav Haisman commented on LANG-1726:
--
After looking at this more recruflly, there are more problems
gtoison commented on PR #254:
URL: https://github.com/apache/commons-bcel/pull/254#issuecomment-1877760451
Thanks for checking @JuditKnoll
I think I could come up with something sensible for
[
https://issues.apache.org/jira/browse/LANG-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803326#comment-17803326
]
Gary D. Gregory commented on LANG-1726:
---
What do you think the comment should read?
>
[
https://issues.apache.org/jira/browse/LANG-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803316#comment-17803316
]
Václav Haisman commented on LANG-1726:
--
The change fixes my issue. But the wrong comment still
[
https://issues.apache.org/jira/browse/LANG-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved LANG-1726.
---
Fix Version/s: 3.15.0
Resolution: Fixed
[~wilx]
Thank you for your report. Good
JuditKnoll commented on PR #254:
URL: https://github.com/apache/commons-bcel/pull/254#issuecomment-1877654007
Thank you very much for your PR @gtoison!
I looked at the usages of `Const.CONSTANT_Integer`, and found two functions
where `Const.CONSTANT_Dynamic` is not handled, but I think
garydgregory commented on PR #1153:
URL: https://github.com/apache/commons-lang/pull/1153#issuecomment-1877508477
> Besides, would you, please, complete the PR by adding yourself as a
contributor to pom.xml, and update src/changes/changes.xml?
I do not recommend that in general
jochenw commented on PR #1153:
URL: https://github.com/apache/commons-lang/pull/1153#issuecomment-1877492550
Besides, would you, please, complete the PR by adding yourself as a
contributor to pom.xml, and update src/changes/changes.xml?
--
This is an automated message from the
[
https://issues.apache.org/jira/browse/LANG-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Václav Haisman updated LANG-1726:
-
Description:
I have been doing pass over deprecated warning in our code and one of them is
that
Václav Haisman created LANG-1726:
Summary: ExceptionUtils.asRuntimeException is not a good
replacement for deprecated ExceptionUtils.rethrow
Key: LANG-1726
URL: https://issues.apache.org/jira/browse/LANG-1726
spyrkob commented on PR #82:
URL: https://github.com/apache/commons-beanutils/pull/82#issuecomment-1877330200
Update the PR to resolve the conflict. Is there anything I can do to help
get this fix merged?
--
This is an automated message from the Apache Git Service.
To respond to the
gtoison commented on code in PR #254:
URL: https://github.com/apache/commons-bcel/pull/254#discussion_r1441908638
##
src/main/java/org/apache/bcel/generic/LDC.java:
##
@@ -89,6 +89,8 @@ public Type getType(final ConstantPoolGen cpg) {
return Type.INT;
case
garydgregory commented on code in PR #254:
URL: https://github.com/apache/commons-bcel/pull/254#discussion_r1441898238
##
src/main/java/org/apache/bcel/generic/LDC.java:
##
@@ -89,6 +89,8 @@ public Type getType(final ConstantPoolGen cpg) {
return Type.INT;
garydgregory commented on code in PR #254:
URL: https://github.com/apache/commons-bcel/pull/254#discussion_r1441898238
##
src/main/java/org/apache/bcel/generic/LDC.java:
##
@@ -89,6 +89,8 @@ public Type getType(final ConstantPoolGen cpg) {
return Type.INT;
garydgregory commented on PR #254:
URL: https://github.com/apache/commons-bcel/pull/254#issuecomment-1877276951
I would also ask @gtoison and others for a full code base scan to see if
there are other switch (or cascading if-else) statements that fall through to
an error condition that
garydgregory commented on PR #254:
URL: https://github.com/apache/commons-bcel/pull/254#issuecomment-1877270405
@gtoison
Note that I'm OK and would actually prefer splitting out `LDC2_W` work into
a separate PR. I'd also prefer we nail this PR down first, and get it merged.
The PR
garydgregory commented on PR #553:
URL: https://github.com/apache/commons-io/pull/553#issuecomment-1877263402
Note that we should not treat ~ in any special way since it is a Unix-like
shell utility and not a file system functionality.
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/IO-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803198#comment-17803198
]
Elliotte Rusty Harold commented on IO-836:
--
Also what should happen with Unix a root path, a single
elharo commented on code in PR #553:
URL: https://github.com/apache/commons-io/pull/553#discussion_r1441847412
##
src/main/java/org/apache/commons/io/FilenameUtils.java:
##
@@ -669,7 +669,7 @@ public static String getFullPath(final String fileName) {
* ~-- ~
Elliotte Rusty Harold created IO-836:
Summary: FileNameUtils.getFullPathNoEndSeparator Javadoc is unclear
Key: IO-836
URL: https://issues.apache.org/jira/browse/IO-836
Project: Commons IO
gtoison commented on PR #254:
URL: https://github.com/apache/commons-bcel/pull/254#issuecomment-1877205250
Hum, you're right: I misread and thought it was only for long and double
constants but it was also modified for dynamic constants.
Currently `LDC2_W.getValue()` returns a `Number`
garydgregory commented on code in PR #553:
URL: https://github.com/apache/commons-io/pull/553#discussion_r1441830149
##
src/main/java/org/apache/commons/io/FilenameUtils.java:
##
@@ -669,7 +669,7 @@ public static String getFullPath(final String fileName) {
* ~
garydgregory commented on code in PR #553:
URL: https://github.com/apache/commons-io/pull/553#discussion_r1441830149
##
src/main/java/org/apache/commons/io/FilenameUtils.java:
##
@@ -669,7 +669,7 @@ public static String getFullPath(final String fileName) {
* ~
[
https://issues.apache.org/jira/browse/IO-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801816#comment-17801816
]
Elliotte Rusty Harold edited comment on IO-807 at 1/4/24 2:27 PM:
--
After
[
https://issues.apache.org/jira/browse/IO-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801816#comment-17801816
]
Elliotte Rusty Harold edited comment on IO-807 at 1/4/24 2:25 PM:
--
After
garydgregory commented on code in PR #254:
URL: https://github.com/apache/commons-bcel/pull/254#discussion_r1441773107
##
src/main/java/org/apache/bcel/generic/LDC.java:
##
@@ -109,6 +111,9 @@ public Object getValue(final ConstantPoolGen cpg) {
final int nameIndex
garydgregory commented on PR #254:
URL: https://github.com/apache/commons-bcel/pull/254#issuecomment-1877072612
Hm, what about `LDC2_W`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
garydgregory commented on PR #1153:
URL: https://github.com/apache/commons-lang/pull/1153#issuecomment-1876948961
Hello @KUTEJiang
This PR does not have a unit test to proove the changes are needed. This
means the change could be undone in the future and no one would know if
anything
KUTEJiang opened a new pull request, #1153:
URL: https://github.com/apache/commons-lang/pull/1153
Hello,
This PR fixes 3 violations of Sonarqube Rule java:S2184 : ['Math operands
should be cast before
assignment'](https://rules.sonarsource.com/java/RSPEC-2184).
For more details,
Claudenw commented on PR #216:
URL: https://github.com/apache/commons-cli/pull/216#issuecomment-1876901039
@garydgregory I think this might be ready for prime time now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Philzen opened a new pull request, #552:
URL: https://github.com/apache/commons-io/pull/552
Not sure if this is is a bug or a feature – what i can confirm is that in
v2.4 it worked as it said in the description:
```java
@Test void
36 matches
Mail list logo
