[jira] Commented: (EMAIL-75) Email.setFrom, addTo should use Email.charset

2008-04-11 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/EMAIL-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587877#action_12587877 ] Ben Speakmon commented on EMAIL-75: --- Agree. Can you provide a patch against the trunk? > E

[jira] Commented: (EMAIL-69) HtmlEmail generated email don't display in Macos X Mail.app

2008-02-13 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/EMAIL-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568820#action_12568820 ] Ben Speakmon commented on EMAIL-69: --- Bjorn, can you throw a fix in for this? > HtmlEmail g

[jira] Commented: (VALIDATOR-240) Support the 65 prefix for Discover Card

2007-12-05 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548729 ] Ben Speakmon commented on VALIDATOR-240: 'Wikipedia is pretty much the definition of "untrusted source" fo

[jira] Commented: (VALIDATOR-197) Copy remaining Validation Routines to the new routines package

2007-12-01 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547568 ] Ben Speakmon commented on VALIDATOR-197: Think I agree that GenericValidator should be deprecated and remo

[jira] Commented: (VALIDATOR-240) Support the 65 prefix for Discover Card

2007-12-01 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547566 ] Ben Speakmon commented on VALIDATOR-240: I can't find another source for this -- Wikipedia has an unattrib

[jira] Commented: (VALIDATOR-249) Add Diners card validation to CreditCardValidator

2007-12-01 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547567 ] Ben Speakmon commented on VALIDATOR-249: Is this done now? > Add Diners card validation to CreditCardVali

[jira] Commented: (VALIDATOR-247) Move CreditCardValidator to routines package and refactor to use new CodeValidator

2007-12-01 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547563 ] Ben Speakmon commented on VALIDATOR-247: Looks solid. I'm okay with resolving this one. > Move CreditCard

[jira] Commented: (VALIDATOR-250) Banking CheckDigit implementations: ABA, CUSIP, IBAN, ISIN and Sedol

2007-12-01 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547562 ] Ben Speakmon commented on VALIDATOR-250: These look good, Niall. Is there any reason not to put them in ro

[jira] Resolved: (VALIDATOR-252) Performance improvement of DomainValidator by change the regular expression

2007-12-01 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon resolved VALIDATOR-252. Resolution: Fixed Assignee: Ben Speakmon Patch applied. Thanks! $ svn ci -m "VALI

[jira] Commented: (VALIDATOR-252) Performance improvement of DomainValidator by change the regular expression

2007-11-28 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546561 ] Ben Speakmon commented on VALIDATOR-252: Looks right to me. Can you supply a full-fledged patch? > Perfor

[jira] Commented: (EMAIL-70) Email.setMailSession() discards provided session if using authentication

2007-11-21 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/EMAIL-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544583 ] Ben Speakmon commented on EMAIL-70: --- Thanks for the report -- can you provide a test case and a patch? That'll make

[jira] Updated: (EMAIL-70) Email.setMailSession() discards provided session if using authentication

2007-11-21 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/EMAIL-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon updated EMAIL-70: -- Affects Version/s: 1.1 > Email.setMailSession() discards provided session if using authentication > -

[jira] Commented: (EMAIL-69) HtmlEmail generated email don't display in Macos X Mail.app

2007-11-20 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/EMAIL-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544120 ] Ben Speakmon commented on EMAIL-69: --- I'm on vacation this week, so I can't get to this before the beginning of Decem

[jira] Commented: (LANG-377) Perhaps add containsAny() methods?

2007-11-16 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/LANG-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543189 ] Ben Speakmon commented on LANG-377: --- Agree also; makes me wish containsAny() had been the original form. I certainly

[jira] Updated: (LANG-377) Perhaps add containsAny() methods?

2007-11-16 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/LANG-377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon updated LANG-377: -- Priority: Minor (was: Major) Pushing down to minor priority, which I assume is uncontroversial; please

[jira] Commented: (VALIDATOR-248) Add an option to allow 'localhost' as a valid hostname part in the URL

2007-11-14 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542529 ] Ben Speakmon commented on VALIDATOR-248: I forgot about RegexValidator being able to contain multiple patt

[jira] Commented: (VALIDATOR-242) Move EmailValidator to routines package

2007-11-14 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542466 ] Ben Speakmon commented on VALIDATOR-242: I think you need to spell it out for me -- I know we can just del

[jira] Commented: (LANG-338) truncateNicely method which avoids truncating in the middle of a word

2007-11-13 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/LANG-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542168 ] Ben Speakmon commented on LANG-338: --- I also like abbreviate better. > truncateNicely method which avoids truncating

[jira] Commented: (LANG-197) [lang] Extending VariableFormatter to use FormatPatterns

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/LANG-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542032 ] Ben Speakmon commented on LANG-197: --- Looks like the changes to StrSubstitutor in and around LANG-362 gives you prett

[jira] Updated: (LANG-338) truncateNicely method which avoids truncating in the middle of a word

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/LANG-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon updated LANG-338: -- Attachment: LANG-338-cleaned.patch Concur on the value; +1 for inclusion. Attaching a cleaned-up patch wi

[jira] Commented: (LANG-333) ArrayUtils.toClass

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/LANG-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542021 ] Ben Speakmon commented on LANG-333: --- Looks pretty straightforward. +1 for inclusion. > ArrayUtils.toClass >

[jira] Updated: (LANG-322) ClassUtils.getShortClassName(String) inefficient

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/LANG-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon updated LANG-322: -- Attachment: LANG-322.patch Looks good here. Attaching patch. > ClassUtils.getShortClassName(String) inef

[jira] Commented: (LANG-350) New RandomDateUtils class in the lang.time package

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/LANG-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542010 ] Ben Speakmon commented on LANG-350: --- Looks simple enough, and shouldn't be a pain to support. Can't think of why you

[jira] Commented: (LANG-321) [patch] Add toArray() method to IntRange and LongRange classes

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/LANG-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542006 ] Ben Speakmon commented on LANG-321: --- Looks good to me. Attaching a cleaned-up patch. > [patch] Add toArray() method

[jira] Updated: (LANG-321) [patch] Add toArray() method to IntRange and LongRange classes

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/LANG-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon updated LANG-321: -- Attachment: LANG-321.patch > [patch] Add toArray() method to IntRange and LongRange classes > ---

[jira] Commented: (LANG-354) Implementation of a CloneBuilder Class

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/LANG-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541995 ] Ben Speakmon commented on LANG-354: --- A neat idea. Problems: 1) I don't like calling it CloneBuilder. Cloning is asso

[jira] Commented: (LANG-331) Fix for LANG-259 broke ValuedEnum.compareTo() on subclassed enumerations

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/LANG-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541949 ] Ben Speakmon commented on LANG-331: --- It's just ugly in there... :( I agree with Stephen that it was a Bad Idea; that

[jira] Commented: (LANG-360) Why does appendIdentityToString return null?

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/LANG-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541940 ] Ben Speakmon commented on LANG-360: --- Looks good. +1. > Why does appendIdentityToString return null? > --

[jira] Commented: (LANG-76) [lang] EnumUtils.getEnum() doesn't work well in 1.5

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/LANG-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541933 ] Ben Speakmon commented on LANG-76: -- Gotta agree with Paul. 1.5's behavior is to spec, so it's correct by definition. S

[jira] Commented: (LANG-369) ExceptionUtils not thread-safe

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/LANG-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541917 ] Ben Speakmon commented on LANG-369: --- Patch looks safe. > ExceptionUtils not thread-safe > --

[jira] Commented: (VALIDATOR-240) Support the 65 prefix for Discover Card

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541902 ] Ben Speakmon commented on VALIDATOR-240: Niall, can you slip this into your CreditCardValidator work? > S

[jira] Resolved: (VALIDATOR-221) DateValidator considers "02/29" with format "MM/dd" invalid

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon resolved VALIDATOR-221. Resolution: Won't Fix Resolving as wontfix per comments. > DateValidator considers "02/

[jira] Resolved: (VALIDATOR-192) Adding ISBNValidator to GenericValidator

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon resolved VALIDATOR-192. Resolution: Won't Fix Resolving as wontfix per Niall's comment. > Adding ISBNValidator

[jira] Commented: (VALIDATOR-228) allow to cite the offending value if a validation fails as argument (Trusted-Input vs. Filter Concept)

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541867 ] Ben Speakmon commented on VALIDATOR-228: Not sure I understand -- if you call EmailValidator.isValid() wit

[jira] Updated: (VALIDATOR-244) Validator post-processing

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon updated VALIDATOR-244: --- Fix Version/s: (was: 1.4) Validator2 This sounds like something tha

[jira] Commented: (VALIDATOR-205) Improve handling of ; in paths

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541862 ] Ben Speakmon commented on VALIDATOR-205: Far as I can tell, the semicolon is handled properly in the new U

[jira] Commented: (VALIDATOR-197) Copy remaining Validation Routines to the new routines package

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541861 ] Ben Speakmon commented on VALIDATOR-197: Only thing remaining here is the CreditCardValidator, which Niall

[jira] Commented: (VALIDATOR-191) Remove the dependency on Jakarta ORO (move to JDK 1.4 regular expression support)

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541858 ] Ben Speakmon commented on VALIDATOR-191: Niall, I think we're done on this. You okay with resolving? > Re

[jira] Commented: (VALIDATOR-203) Refactor UrlValidator - especially the line 370-ish TODO.

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541859 ] Ben Speakmon commented on VALIDATOR-203: Patterns changed. We okay with resolving this? > Refactor UrlVal

[jira] Resolved: (VALIDATOR-248) Add an option to allow 'localhost' as a valid hostname part in the URL

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon resolved VALIDATOR-248. Resolution: Fixed $ svn ci -m "VALIDATOR-248: add MANUAL_AUTHORITY_VALIDATION feature an

[jira] Commented: (VALIDATOR-248) Add an option to allow 'localhost' as a valid hostname part in the URL

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541836 ] Ben Speakmon commented on VALIDATOR-248: nah -- the conversation happened here, so the fix should go here.

[jira] Commented: (VALIDATOR-248) Add an option to allow 'localhost' as a valid hostname part in the URL

2007-11-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541827 ] Ben Speakmon commented on VALIDATOR-248: So, revised plan: - add an option MANUAL_SCHEME_VALIDATION - pro

[jira] Resolved: (VALIDATOR-242) Move EmailValidator to routines package

2007-11-08 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon resolved VALIDATOR-242. Resolution: Fixed Yay, another issue slain! > Move EmailValidator to routines package >

[jira] Commented: (VALIDATOR-242) Move EmailValidator to routines package

2007-11-07 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540933 ] Ben Speakmon commented on VALIDATOR-242: Niall, you okay with resolving this now? > Move EmailValidator t

[jira] Commented: (VALIDATOR-248) Add an option to allow 'localhost' as a valid hostname part in the URL

2007-11-06 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540633 ] Ben Speakmon commented on VALIDATOR-248: DomainValidator does support labels with dashes in them: "my-mach

[jira] Commented: (VALIDATOR-248) Add an option to allow 'localhost' as a valid hostname part in the URL

2007-11-06 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540604 ] Ben Speakmon commented on VALIDATOR-248: Assuming that we're talking about the new UrlValidator/DomainVali

[jira] Commented: (VALIDATOR-248) Add an option to allow 'localhost' as a valid hostname part in the URL

2007-11-06 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540554 ] Ben Speakmon commented on VALIDATOR-248: The only reason I can think of for making it an option is if you

[jira] Commented: (VALIDATOR-248) Add an option to allow 'localhost' as a valid hostname part in the URL

2007-11-06 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540547 ] Ben Speakmon commented on VALIDATOR-248: You're quite right, Sergey. I'll look at this. > Add an option t

[jira] Commented: (VALIDATOR-247) Move CreditCardValidator to routines package and refactor

2007-11-02 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539783 ] Ben Speakmon commented on VALIDATOR-247: It's simple, which I'm a big fan of. The only concern I have is w

[jira] Updated: (VALIDATOR-247) Move CreditCardValidator to routines package and refactor

2007-11-02 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon updated VALIDATOR-247: --- Component/s: Routines > Move CreditCardValidator to routines package and refactor > --

[jira] Created: (VALIDATOR-247) Move CreditCardValidator to routines package and refactor

2007-11-02 Thread Ben Speakmon (JIRA)
Move CreditCardValidator to routines package and refactor - Key: VALIDATOR-247 URL: https://issues.apache.org/jira/browse/VALIDATOR-247 Project: Commons Validator Issue Type: Task

[jira] Created: (VALIDATOR-246) EmailValidator should be able to recognize and remove comments

2007-11-02 Thread Ben Speakmon (JIRA)
EmailValidator should be able to recognize and remove comments -- Key: VALIDATOR-246 URL: https://issues.apache.org/jira/browse/VALIDATOR-246 Project: Commons Validator Issue Type:

[jira] Commented: (VALIDATOR-242) Move EmailValidator to routines package

2007-11-02 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539728 ] Ben Speakmon commented on VALIDATOR-242: VALIDATOR-246 created to address the comment issue. > Move Email

[jira] Commented: (VALIDATOR-242) Move EmailValidator to routines package

2007-11-02 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539727 ] Ben Speakmon commented on VALIDATOR-242: I'd probably wind up throwing it out and starting over anyway, so

[jira] Resolved: (VALIDATOR-193) Removing ORO dep. from GenericValidator

2007-11-02 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon resolved VALIDATOR-193. Resolution: Fixed Assignee: Ben Speakmon Resolving as discussed. > Removing ORO d

[jira] Commented: (VALIDATOR-193) Removing ORO dep. from GenericValidator

2007-11-02 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539698 ] Ben Speakmon commented on VALIDATOR-193: Niall, since oro has now been removed from GenericValidator and t

[jira] Commented: (VALIDATOR-203) Refactor UrlValidator - especially the line 370-ish TODO.

2007-11-02 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539692 ] Ben Speakmon commented on VALIDATOR-203: Yep -- like I said in VALIDATOR-242, no problem turning the Patte

[jira] Commented: (VALIDATOR-242) Move EmailValidator to routines package

2007-11-02 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539691 ] Ben Speakmon commented on VALIDATOR-242: The stripComments() is going to be hard to deal with. That regexp

[jira] Resolved: (VALIDATOR-218) UrlValidator fail when path contains "(" / ")"

2007-10-31 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon resolved VALIDATOR-218. Resolution: Fixed Fixed in the new UrlValidator: $ svn ci Sending src/main/java

[jira] Commented: (VALIDATOR-230) Enum validator

2007-10-31 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539286 ] Ben Speakmon commented on VALIDATOR-230: Attachment still forthcoming? :) > Enum validator >

[jira] Resolved: (VALIDATOR-242) Move EmailValidator to routines package

2007-10-31 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon resolved VALIDATOR-242. Resolution: Fixed Move completed, tests ready, and refactoring done, so this is done. >

[jira] Resolved: (VALIDATOR-243) Create standalone domain validator routine

2007-10-31 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon resolved VALIDATOR-243. Resolution: Fixed DomainValidator is complete and Email/UrlValidator are using it, so th

[jira] Resolved: (VALIDATOR-216) UrlValidator rejects top-level domains (TLDs) with more than 4 characters

2007-10-31 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon resolved VALIDATOR-216. Resolution: Fixed This has been addressed in the new UrlValidator. I chose not to use th

[jira] Resolved: (VALIDATOR-220) EmailValidator fails with ArrayIndexOutOfBoundsException on domain names longer than 10 segments

2007-10-31 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon resolved VALIDATOR-220. Resolution: Fixed Resolving since the new EmailValidator is complete and is verified not

[jira] Resolved: (VALIDATOR-241) New InetAdress Validator implementation

2007-10-31 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon resolved VALIDATOR-241. Resolution: Fixed Fixed the svn props and completed the refactorings of other classes to

[jira] Resolved: (VALIDATOR-232) Add script attribute to control script generation

2007-10-30 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon resolved VALIDATOR-232. Resolution: Fixed Assignee: Ben Speakmon Committed per Paul's request. $ svn ci S

[jira] Commented: (LANG-360) Why does appendIdentityToString return null?

2007-10-30 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/LANG-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538854 ] Ben Speakmon commented on LANG-360: --- I like Henri's second suggestion better. Between that and deprecating the old m

[jira] Commented: (LANG-360) Why does appendIdentityToString return null?

2007-10-29 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/LANG-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538690 ] Ben Speakmon commented on LANG-360: --- It's unfortunate that the API here forces the user to null-protect his paramete

[jira] Commented: (VALIDATOR-203) Refactor UrlValidator - especially the line 370-ish TODO.

2007-10-29 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538684 ] Ben Speakmon commented on VALIDATOR-203: I've taken out the domain name and IP validating and delegated th

[jira] Created: (VALIDATOR-243) Create standalone domain validator routine

2007-10-28 Thread Ben Speakmon (JIRA)
Create standalone domain validator routine -- Key: VALIDATOR-243 URL: https://issues.apache.org/jira/browse/VALIDATOR-243 Project: Commons Validator Issue Type: Task Components: Routines

[jira] Commented: (VALIDATOR-242) Move EmailValidator to routines package

2007-10-25 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537687 ] Ben Speakmon commented on VALIDATOR-242: Ah, thanks for that. Makes much more sense. > Move EmailValidato

[jira] Created: (VALIDATOR-242) Move EmailValidator to routines package

2007-10-24 Thread Ben Speakmon (JIRA)
Move EmailValidator to routines package --- Key: VALIDATOR-242 URL: https://issues.apache.org/jira/browse/VALIDATOR-242 Project: Commons Validator Issue Type: Task Components: Framework, Routines

[jira] Commented: (VALIDATOR-241) New InetAdress Validator implementation

2007-10-19 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536382 ] Ben Speakmon commented on VALIDATOR-241: svn ci -m "- VALIDATOR-241: refactor UrlValidator to use routine

[jira] Commented: (VALIDATOR-241) New InetAdress Validator implementation

2007-10-19 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536370 ] Ben Speakmon commented on VALIDATOR-241: svn ci -m "- VALIDATOR-241: refactor EmailValidator to use routi

[jira] Commented: (VALIDATOR-241) New InetAdress Validator implementation

2007-10-19 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536363 ] Ben Speakmon commented on VALIDATOR-241: I intended the new validator to also support IPv6 validation in t

[jira] Commented: (IO-127) Move to a minimum of JDK 1.4

2007-10-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/IO-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534387 ] Ben Speakmon commented on IO-127: - This is your lucky day, Stephen: http://alumnus.caltech.edu/~leif/opensource/bcver/Bc

[jira] Updated: (EMAIL-65) MIME layout generated by HtmlEmail causes trouble

2007-09-12 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/EMAIL-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon updated EMAIL-65: -- Fix Version/s: (was: 1.1) 2.0 I can't really do any of these cases without rewriti

[jira] Commented: (EMAIL-65) MIME layout generated by HtmlEmail causes trouble

2007-08-21 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/EMAIL-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521600 ] Ben Speakmon commented on EMAIL-65: --- The current plan is to try to implement and test cases 2 and 3 above. Hopefully

[jira] Resolved: (EMAIL-6) [email] Errors when sending MultiPartEmail with another email as an attachment

2007-08-08 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/EMAIL-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon resolved EMAIL-6. -- Resolution: Won't Fix Resolving as a wontfix due to lack of interest. > [email] Errors when sending Multi

[jira] Closed: (EMAIL-67) Create e-mail attachment using an OutputStream

2007-08-08 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/EMAIL-67?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon closed EMAIL-67. - Resolution: Invalid Closing as invalid only because there isn't a "request for help" resolution. > Create

[jira] Commented: (EMAIL-67) Create e-mail attachment using an OutputStream

2007-08-08 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/EMAIL-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518535 ] Ben Speakmon commented on EMAIL-67: --- Correct. You may also try it now with one of the nightly 1.1 snapshot builds --

[jira] Commented: (EMAIL-67) Create e-mail attachment using an OutputStream

2007-08-07 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/EMAIL-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518258 ] Ben Speakmon commented on EMAIL-67: --- Yes -- JavaMail attachments need to be DataSources. We provide a ByteArrayDataS

[jira] Updated: (EMAIL-67) Create e-mail attachment using an OutputStream

2007-08-07 Thread Ben Speakmon (JIRA)
[ https://issues.apache.org/jira/browse/EMAIL-67?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Speakmon updated EMAIL-67: -- Fix Version/s: 1.1 Assignee: Ben Speakmon Affects Version/s: 1.0 > Create e-mail att