[GitHub] flink pull request: [FLINK-2243] [storm-compat] Added finite spout...

2015-06-22 Thread szape
Github user szape commented on a diff in the pull request: https://github.com/apache/flink/pull/853#discussion_r32913023 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/util/FiniteStormFileSpout.java

[jira] [Commented] (FLINK-2243) Add finite spout functionality to Storm compatibility layer

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595485#comment-14595485 ] ASF GitHub Bot commented on FLINK-2243: --- Github user szape commented on a diff in th

[GitHub] flink pull request: [FLINK-2243] [storm-compat] Added finite spout...

2015-06-22 Thread szape
Github user szape commented on a diff in the pull request: https://github.com/apache/flink/pull/853#discussion_r32913535 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/wordcount/SpoutSourceWordCount

[jira] [Commented] (FLINK-2243) Add finite spout functionality to Storm compatibility layer

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595497#comment-14595497 ] ASF GitHub Bot commented on FLINK-2243: --- Github user szape commented on a diff in th

[GitHub] flink pull request: Modified the equals method in all the Value ty...

2015-06-22 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/850#issuecomment-114038819 Merging. Thanks for the PR. Going for getClass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[jira] [Commented] (FLINK-2229) Data sets involving non-primitive arrays cannot be unioned

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595505#comment-14595505 ] ASF GitHub Bot commented on FLINK-2229: --- Github user uce commented on the pull reque

[GitHub] flink pull request: [FLINK-2229] add equals(...) and hashCode() to...

2015-06-22 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/842#issuecomment-114039557 +1, merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request: [scripts] cleanup release script and make it m...

2015-06-22 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/811#issuecomment-114039683 Is there anything blocking this? If not, feel free to go ahead and merge this. :) --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] flink pull request: [FLINK-2243] [storm-compat] Added finite spout...

2015-06-22 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/853#discussion_r32914310 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/wordcount/SpoutSourceWordCount

[jira] [Commented] (FLINK-2243) Add finite spout functionality to Storm compatibility layer

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595508#comment-14595508 ] ASF GitHub Bot commented on FLINK-2243: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2155] Enforce import restriction on usa...

2015-06-22 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/790#issuecomment-114039753 Good fix, thx. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[jira] [Commented] (FLINK-2155) Add an additional checkstyle validation for illegal imports

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595507#comment-14595507 ] ASF GitHub Bot commented on FLINK-2155: --- Github user uce commented on the pull reque

[GitHub] flink pull request: [FLINK-1818] Added api to cancel job from clie...

2015-06-22 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/642#issuecomment-114040994 Another ping. @mjsax would you like to pick it up? There is a test in TaskCancelTest#cancelJob, which implements this for a test as a static method. Would be nice to refactor

[jira] [Commented] (FLINK-1818) Provide API to cancel running job

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595511#comment-14595511 ] ASF GitHub Bot commented on FLINK-1818: --- Github user uce commented on the pull reque

[GitHub] flink pull request: [FLINK-938] Auomatically configure the jobmana...

2015-06-22 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/248#issuecomment-114042530 OK going to merge and adding the warning. Makes it more comfortable to run a stand-alone cluster in the cloud. :) Thanks for the PR. --- If your project is set up for it, yo

[jira] [Commented] (FLINK-2245) Programs that contain collect() reported as multiple jobs in the Web frontend

2015-06-22 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595514#comment-14595514 ] Maximilian Michels commented on FLINK-2245: --- Yes, the way it would currently wor

[jira] [Commented] (FLINK-938) Change start-cluster.sh script so that users don't have to configure the JobManager address

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595513#comment-14595513 ] ASF GitHub Bot commented on FLINK-938: -- Github user uce commented on the pull request:

[GitHub] flink pull request: [FLINK-1085] Unnecessary failing of GroupReduc...

2015-06-22 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/854#issuecomment-114043020 I think this code actually simply drops oversized records, or am I overlooking something? Also, outputting oversized records on WARN debug level seems heavy,

[jira] [Commented] (FLINK-1085) Unnecessary failing of GroupReduceCombineDriver

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595518#comment-14595518 ] ASF GitHub Bot commented on FLINK-1085: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-1818] Added api to cancel job from clie...

2015-06-22 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/642#issuecomment-114043438 @rainiraj replied, that he is still on it (see https://issues.apache.org/jira/browse/FLINK-1818) --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (FLINK-1818) Provide API to cancel running job

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595521#comment-14595521 ] ASF GitHub Bot commented on FLINK-1818: --- Github user mjsax commented on the pull req

[jira] [Commented] (FLINK-2242) Deprecate RemoteCollector

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595523#comment-14595523 ] ASF GitHub Bot commented on FLINK-2242: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2242] deprecate RemoteCollector interfa...

2015-06-22 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/852#issuecomment-114043900 +1 I would go as far as to remove it, as this will work in a very limited way and requires direct client to TaskManager communication. `DataSet.colle

[GitHub] flink pull request: [FLINK-1818] Added api to cancel job from clie...

2015-06-22 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/642#issuecomment-114044225 Ah, didn't check the JIRA. Thanks for pointing this out. @rainiraj, can you look at the test I've mentioned and remove the code there and use your new feature? :) --- If yo

[jira] [Commented] (FLINK-1818) Provide API to cancel running job

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595526#comment-14595526 ] ASF GitHub Bot commented on FLINK-1818: --- Github user uce commented on the pull reque

[jira] [Commented] (FLINK-2248) Allow disabling of sdtout logging output

2015-06-22 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595527#comment-14595527 ] Maximilian Michels commented on FLINK-2248: --- +1 it would be cool to have a {{-q}

[jira] [Commented] (FLINK-2124) FromElementsFunction is not really Serializable

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595528#comment-14595528 ] ASF GitHub Bot commented on FLINK-2124: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request: [FLINK-2124] [streaming] Fix behavior of FromE...

2015-06-22 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/848#discussion_r32915439 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/FromElementsFunction.java --- @

[GitHub] flink pull request: [FLINK-2124] [streaming] Fix behavior of FromE...

2015-06-22 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/848#discussion_r32915549 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/FromElementsFunction.java --- @

[jira] [Commented] (FLINK-2242) Deprecate RemoteCollector

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595529#comment-14595529 ] ASF GitHub Bot commented on FLINK-2242: --- Github user uce commented on the pull reque

[jira] [Commented] (FLINK-2124) FromElementsFunction is not really Serializable

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595530#comment-14595530 ] ASF GitHub Bot commented on FLINK-2124: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request: [FLINK-2242] deprecate RemoteCollector interfa...

2015-06-22 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/852#issuecomment-114044528 I've opened the issue to deprecate, but I think removing is good. +1 to remove as well. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-2124] [streaming] Fix behavior of FromE...

2015-06-22 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/848#issuecomment-114044907 I think a good addition would be to remember the number of elements in the set, and use that to validate that the deserialization worked properly. Serializers may be

[jira] [Commented] (FLINK-2124) FromElementsFunction is not really Serializable

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595534#comment-14595534 ] ASF GitHub Bot commented on FLINK-2124: --- Github user StephanEwen commented on the pu

[jira] [Commented] (FLINK-2214) ALS predict and empiricalRisk function can cause hash join function to exceed maximum number of recursions

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595536#comment-14595536 ] ASF GitHub Bot commented on FLINK-2214: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2214] [ml] Fixes prediction join operat...

2015-06-22 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/844#issuecomment-114045049 The build side hinted here is also the constant (loop invariant) side, correct? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: New operator state interfaces

2015-06-22 Thread gyfora
Github user gyfora commented on a diff in the pull request: https://github.com/apache/flink/pull/747#discussion_r32916035 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/state/PartitionedStreamOperatorState.java --- @@ -0,0

[GitHub] flink pull request: check in if clause in LongValue.java

2015-06-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/849 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: [FLINK-2124] [streaming] Fix behavior of FromE...

2015-06-22 Thread jreiffers
Github user jreiffers commented on a diff in the pull request: https://github.com/apache/flink/pull/848#discussion_r32916185 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/FromElementsFunction.java --- @@

[jira] [Commented] (FLINK-2124) FromElementsFunction is not really Serializable

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595545#comment-14595545 ] ASF GitHub Bot commented on FLINK-2124: --- Github user jreiffers commented on a diff i

[GitHub] flink pull request: [FLINK-2124] [streaming] Fix behavior of FromE...

2015-06-22 Thread jreiffers
Github user jreiffers commented on a diff in the pull request: https://github.com/apache/flink/pull/848#discussion_r32916320 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/FromElementsFunction.java --- @@

[jira] [Commented] (FLINK-2161) Flink Scala Shell does not support external jars (e.g. Gelly, FlinkML)

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595550#comment-14595550 ] ASF GitHub Bot commented on FLINK-2161: --- Github user StephanEwen commented on the pu

[jira] [Commented] (FLINK-2124) FromElementsFunction is not really Serializable

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595548#comment-14595548 ] ASF GitHub Bot commented on FLINK-2124: --- Github user jreiffers commented on a diff i

[GitHub] flink pull request: New operator state interfaces

2015-06-22 Thread gyfora
Github user gyfora commented on a diff in the pull request: https://github.com/apache/flink/pull/747#discussion_r32916334 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/state/PartitionedStreamOperatorState.java --- @@ -0,0

[GitHub] flink pull request: [FLINK-2229] add equals(...) and hashCode() to...

2015-06-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/842 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: [FLINK-2161] modified Scala shell start script...

2015-06-22 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/805#issuecomment-114046659 To add more jars to the Classpath, you can write the test in the following way: The test itself is just a wrapper that instantiates a custom classloader with your ext

[jira] [Resolved] (FLINK-2229) Data sets involving non-primitive arrays cannot be unioned

2015-06-22 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi resolved FLINK-2229. Resolution: Fixed Fix Version/s: 0.10 Fixed via c0d3fed. > Data sets involving non-primitive

[jira] [Commented] (FLINK-2229) Data sets involving non-primitive arrays cannot be unioned

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595551#comment-14595551 ] ASF GitHub Bot commented on FLINK-2229: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-2124] [streaming] Fix behavior of FromE...

2015-06-22 Thread jreiffers
Github user jreiffers commented on a diff in the pull request: https://github.com/apache/flink/pull/848#discussion_r32916595 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/FromElementsFunction.java --- @@

[jira] [Commented] (FLINK-2124) FromElementsFunction is not really Serializable

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595557#comment-14595557 ] ASF GitHub Bot commented on FLINK-2124: --- Github user jreiffers commented on a diff i

[GitHub] flink pull request: [FLINK-297] [web frontend] First part of JobMa...

2015-06-22 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/677#issuecomment-114049969 Does this subsume #297? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[jira] [Commented] (FLINK-297) Redesign GUI client-server model

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595571#comment-14595571 ] ASF GitHub Bot commented on FLINK-297: -- Github user uce commented on the pull request:

[GitHub] flink pull request: [FLINK-2155] Enforce import restriction on usa...

2015-06-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/790 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Resolved] (FLINK-2155) Add an additional checkstyle validation for illegal imports

2015-06-22 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi resolved FLINK-2155. Resolution: Fixed Fix Version/s: 0.10 Fixed via ab40e5d. > Add an additional checkstyle vali

[jira] [Commented] (FLINK-2155) Add an additional checkstyle validation for illegal imports

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595572#comment-14595572 ] ASF GitHub Bot commented on FLINK-2155: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [contrib] Storm compatibility

2015-06-22 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/764#issuecomment-114054802 Sure. Why not. Let's discuss tomorrow at the Meetup. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-2243] [storm-compat] Added finite spout...

2015-06-22 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/853#discussion_r32919318 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/singlejoin/SingleJoinTopology.

[jira] [Commented] (FLINK-2243) Add finite spout functionality to Storm compatibility layer

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595706#comment-14595706 ] ASF GitHub Bot commented on FLINK-2243: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2242] deprecate RemoteCollector interfa...

2015-06-22 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/852#issuecomment-114058851 I would prefer deprecating it first and removing it in the next major release. If we would do so we should create a JIRA issue to keep track of removing it for the future rel

[jira] [Commented] (FLINK-2242) Deprecate RemoteCollector

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595720#comment-14595720 ] ASF GitHub Bot commented on FLINK-2242: --- Github user mxm commented on the pull reque

[jira] [Commented] (FLINK-2193) Partial shuffling

2015-06-22 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595725#comment-14595725 ] Stephan Ewen commented on FLINK-2193: - I think there is currently no partition functio

[jira] [Commented] (FLINK-2198) BlobManager tests fail on Windows

2015-06-22 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595738#comment-14595738 ] Stephan Ewen commented on FLINK-2198: - The approach to disallow folder creation is sue

[GitHub] flink pull request: [streaming] Properly forward rich window funct...

2015-06-22 Thread mbalassi
GitHub user mbalassi opened a pull request: https://github.com/apache/flink/pull/855 [streaming] Properly forward rich window function calls to wrapped fu… …nctions Open and close were not called, because of the wrapping in windowing. I should have realized this when fi

[jira] [Commented] (FLINK-1956) Runtime context not initialized in RichWindowMapFunction

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595769#comment-14595769 ] ASF GitHub Bot commented on FLINK-1956: --- GitHub user mbalassi opened a pull request:

[GitHub] flink pull request: [FLINK-2243] [storm-compat] Added finite spout...

2015-06-22 Thread szape
Github user szape commented on a diff in the pull request: https://github.com/apache/flink/pull/853#discussion_r32925004 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/singlejoin/SingleJoinTopology.

[jira] [Commented] (FLINK-2243) Add finite spout functionality to Storm compatibility layer

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595800#comment-14595800 ] ASF GitHub Bot commented on FLINK-2243: --- Github user szape commented on a diff in th

[jira] [Commented] (FLINK-2243) Add finite spout functionality to Storm compatibility layer

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595813#comment-14595813 ] ASF GitHub Bot commented on FLINK-2243: --- Github user mjsax commented on a diff in th

[GitHub] flink pull request: [FLINK-2243] [storm-compat] Added finite spout...

2015-06-22 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/853#discussion_r32925744 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/singlejoin/SingleJoinTopology.

[jira] [Commented] (FLINK-2190) Enhance stream decoration/compression extensibility

2015-06-22 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595818#comment-14595818 ] Stephan Ewen commented on FLINK-2190: - Sounds good! > Enhance stream decoration/compr

[GitHub] flink pull request: [FLINK-2143] Added ReduceFunctionWithInverse

2015-06-22 Thread ggevay
GitHub user ggevay opened a pull request: https://github.com/apache/flink/pull/856 [FLINK-2143] Added ReduceFunctionWithInverse (The first commit is the same as the second commit in PR 684) I didn't add an overload to reduce, but instead created ReduceFunctionWithInverse as

[jira] [Commented] (FLINK-2143) Add an overload to reduceWindow which takes the inverse of the reduceFunction as a second parameter

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595824#comment-14595824 ] ASF GitHub Bot commented on FLINK-2143: --- GitHub user ggevay opened a pull request:

[GitHub] flink pull request: Modified the equals method in all the Value ty...

2015-06-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/850 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Created] (FLINK-2256) Handling Broker failures on the KafkaSink side

2015-06-22 Thread JIRA
Márton Balassi created FLINK-2256: - Summary: Handling Broker failures on the KafkaSink side Key: FLINK-2256 URL: https://issues.apache.org/jira/browse/FLINK-2256 Project: Flink Issue Type: Im

[GitHub] flink pull request: [FLINK-2194] [type extractor] Treats Writable ...

2015-06-22 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/814#issuecomment-114080543 I am unsure of where this leads us. The purpose of `Writable` is to make sure that we can use the Writable's custom serialization. If the type `Writable` itself is no

[jira] [Commented] (FLINK-2194) Type extractor does not support Writable type

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595827#comment-14595827 ] ASF GitHub Bot commented on FLINK-2194: --- Github user StephanEwen commented on the pu

[jira] [Commented] (FLINK-2197) Scala API is not working when using batch and streaming API in the same program

2015-06-22 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595830#comment-14595830 ] Stephan Ewen commented on FLINK-2197: - How can we solve this? Can we change the packag

[jira] [Created] (FLINK-2257) Open and close of RichWindowFunctions is not called

2015-06-22 Thread JIRA
Márton Balassi created FLINK-2257: - Summary: Open and close of RichWindowFunctions is not called Key: FLINK-2257 URL: https://issues.apache.org/jira/browse/FLINK-2257 Project: Flink Issue Typ

[GitHub] flink pull request: [streaming] Properly forward rich window funct...

2015-06-22 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/855#issuecomment-114082949 Add reference to FLINK-2257 when merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-2257) Open and close of RichWindowFunctions is not called

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595836#comment-14595836 ] ASF GitHub Bot commented on FLINK-2257: --- Github user mbalassi commented on the pull

[GitHub] flink pull request: [streaming] Fast calculation of medians of win...

2015-06-22 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/684#issuecomment-114083769 Concerning my comment about where to put the code: There is so much code being added to Flink right now. The committers have to be ultimately the ones that ma

[GitHub] flink pull request: [streaming] Fast calculation of medians of win...

2015-06-22 Thread ggevay
Github user ggevay commented on the pull request: https://github.com/apache/flink/pull/684#issuecomment-114086691 I see your point, no problem. Although, I would like to put my next pull request (856) to the core, because that code would be very awkward to put into contrib. Bu

[GitHub] flink pull request: [FLINK-2255] [streaming] Fixed a bug in TopSpe...

2015-06-22 Thread ggevay
GitHub user ggevay opened a pull request: https://github.com/apache/flink/pull/857 [FLINK-2255] [streaming] Fixed a bug in TopSpeedWindowing examples Added the *1000, and modified the reference output of the ITCases. You can merge this pull request into a Git repository by running:

[jira] [Updated] (FLINK-1723) Add cross validation for model evaluation

2015-06-22 Thread Theodore Vasiloudis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Theodore Vasiloudis updated FLINK-1723: --- Summary: Add cross validation for model evaluation (was: Add cross validation for par

[jira] [Commented] (FLINK-2255) In the TopSpeedWindowing examples, every window contains only 1 element, because event time is in millisec, but eviction is in sec

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595879#comment-14595879 ] ASF GitHub Bot commented on FLINK-2255: --- GitHub user ggevay opened a pull request:

[jira] [Updated] (FLINK-1723) Add cross validation for model evaluation

2015-06-22 Thread Theodore Vasiloudis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Theodore Vasiloudis updated FLINK-1723: --- Description: Cross validation [1] is a standard tool to estimate the test error for a

[jira] [Updated] (FLINK-1723) Add cross validation for model evaluation

2015-06-22 Thread Theodore Vasiloudis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Theodore Vasiloudis updated FLINK-1723: --- Description: Cross validation [1] is a standard tool to select to estimate the test er

[jira] [Updated] (FLINK-1723) Add cross validation for model evaluation

2015-06-22 Thread Theodore Vasiloudis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Theodore Vasiloudis updated FLINK-1723: --- Description: Cross validation [1] is a standard tool to select to estimate the test er

[jira] [Created] (FLINK-2258) Add hyperparameter optimization to FlinkML

2015-06-22 Thread Theodore Vasiloudis (JIRA)
Theodore Vasiloudis created FLINK-2258: -- Summary: Add hyperparameter optimization to FlinkML Key: FLINK-2258 URL: https://issues.apache.org/jira/browse/FLINK-2258 Project: Flink Issue Ty

[jira] [Commented] (FLINK-2099) Add a SQL API

2015-06-22 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595886#comment-14595886 ] Stephan Ewen commented on FLINK-2099: - +1, very nice idea We can still have a way to

[jira] [Commented] (FLINK-2204) Tez ConnectedComponentsStepITCase fails spuriously on Travis

2015-06-22 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595910#comment-14595910 ] Stephan Ewen commented on FLINK-2204: - Hmm, looks again like a Tez issue. No Flink c

[jira] [Assigned] (FLINK-2157) Create evaluation framework for ML library

2015-06-22 Thread Mikio Braun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikio Braun reassigned FLINK-2157: -- Assignee: (was: Mikio Braun) > Create evaluation framework for ML library > ---

[jira] [Created] (FLINK-2259) Support training Estimators using a (train, validation, test) split of the available data

2015-06-22 Thread Theodore Vasiloudis (JIRA)
Theodore Vasiloudis created FLINK-2259: -- Summary: Support training Estimators using a (train, validation, test) split of the available data Key: FLINK-2259 URL: https://issues.apache.org/jira/browse/FLINK-225

[jira] [Assigned] (FLINK-2157) Create evaluation framework for ML library

2015-06-22 Thread Mikio Braun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikio Braun reassigned FLINK-2157: -- Assignee: Mikio Braun > Create evaluation framework for ML library > --

[jira] [Commented] (FLINK-2111) Add "terminate" signal to cleanly stop streaming jobs

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595933#comment-14595933 ] ASF GitHub Bot commented on FLINK-2111: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-2111] Add "terminate" signal to cleanly...

2015-06-22 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-114109425 I had a look at your code. A lot of it looks good. The one thing I would really like to change is the modification of the execution graph state machine. That

[GitHub] flink pull request: [FLINK-2116] [ml] Reusing predict operation fo...

2015-06-22 Thread thvasilo
Github user thvasilo commented on the pull request: https://github.com/apache/flink/pull/772#issuecomment-114117337 OK so as I understand it this PR is about splitting the prediction with Vector and LabeledVector input into two functions instead of one as it is now. This allow

[jira] [Commented] (FLINK-2116) Make pipeline extension require less coding

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595956#comment-14595956 ] ASF GitHub Bot commented on FLINK-2116: --- Github user thvasilo commented on the pull

[jira] [Created] (FLINK-2260) Have a complete model evaluation and selection framework for FlinkML

2015-06-22 Thread Theodore Vasiloudis (JIRA)
Theodore Vasiloudis created FLINK-2260: -- Summary: Have a complete model evaluation and selection framework for FlinkML Key: FLINK-2260 URL: https://issues.apache.org/jira/browse/FLINK-2260 Projec

[GitHub] flink pull request: [FLINK-2111] Add "terminate" signal to cleanly...

2015-06-22 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/750#issuecomment-114123970 I agree that extending the state graph is critical. However, IMHO it is the right way to go. I would rather spend more time on getting it right in the first place, than int

[jira] [Commented] (FLINK-2111) Add "terminate" signal to cleanly stop streaming jobs

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595969#comment-14595969 ] ASF GitHub Bot commented on FLINK-2111: --- Github user mjsax commented on the pull req

  1   2   >