[GitHub] flink pull request: [FLINK-3226] Translation of scalar function su...

2016-02-24 Thread twalthr
Github user twalthr commented on the pull request: https://github.com/apache/flink/pull/1679#issuecomment-188655499 If there are no objections, I would like to merge this later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-3226) Translate optimized logical Table API plans into physical plans representing DataSet programs

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166872#comment-15166872 ] ASF GitHub Bot commented on FLINK-3226: --- Github user twalthr commented on the pull request:

[GitHub] flink pull request: [FLINK-3463] implement calc translation

2016-02-24 Thread twalthr
Github user twalthr commented on the pull request: https://github.com/apache/flink/pull/1696#issuecomment-188654410 Forwarding the expected type is not an option, because you don't know what the previous operator produces. If the previous operator produces `Tuple5` and you force it

[jira] [Commented] (FLINK-3463) Implement Calc Support

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166868#comment-15166868 ] ASF GitHub Bot commented on FLINK-3463: --- Github user twalthr commented on the pull request:

[jira] [Created] (FLINK-3507) PruneEmptyRules does not prune empty node as expected.

2016-02-24 Thread Chengxiang Li (JIRA)
Chengxiang Li created FLINK-3507: Summary: PruneEmptyRules does not prune empty node as expected. Key: FLINK-3507 URL: https://issues.apache.org/jira/browse/FLINK-3507 Project: Flink Issue

[jira] [Created] (FLINK-3506) ReduceExpressionsRule does not remove duplicate expression in Filter

2016-02-24 Thread Chengxiang Li (JIRA)
Chengxiang Li created FLINK-3506: Summary: ReduceExpressionsRule does not remove duplicate expression in Filter Key: FLINK-3506 URL: https://issues.apache.org/jira/browse/FLINK-3506 Project: Flink

[jira] [Updated] (FLINK-3486) Use Project to rename all record fields would fail following Project.

2016-02-24 Thread Chengxiang Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chengxiang Li updated FLINK-3486: - Summary: Use Project to rename all record fields would fail following Project. (was: [SQL] Use

[jira] [Updated] (FLINK-3502) AggregateProjectPullUpConstantsRule fails on certain group keys order.

2016-02-24 Thread Chengxiang Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chengxiang Li updated FLINK-3502: - Summary: AggregateProjectPullUpConstantsRule fails on certain group keys order. (was: [SQL]

[jira] [Updated] (FLINK-3486) [SQL] Use Project to rename all record fields would fail following Project.

2016-02-24 Thread Chengxiang Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chengxiang Li updated FLINK-3486: - Component/s: Table API > [SQL] Use Project to rename all record fields would fail following

[jira] [Updated] (FLINK-3487) [SQL] FilterAggregateTransposeRule does not transform logical plan as desired.

2016-02-24 Thread Chengxiang Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chengxiang Li updated FLINK-3487: - Component/s: Table API > [SQL] FilterAggregateTransposeRule does not transform logical plan as

[jira] [Updated] (FLINK-3503) ProjectJoinTransposeRule fails to push down project.

2016-02-24 Thread Chengxiang Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chengxiang Li updated FLINK-3503: - Summary: ProjectJoinTransposeRule fails to push down project. (was: [SQL]

[jira] [Updated] (FLINK-3487) FilterAggregateTransposeRule does not transform logical plan as desired.

2016-02-24 Thread Chengxiang Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chengxiang Li updated FLINK-3487: - Summary: FilterAggregateTransposeRule does not transform logical plan as desired. (was: [SQL]

[jira] [Created] (FLINK-3505) JoinUnionTransposeRule fails to push Join past Union.

2016-02-24 Thread Chengxiang Li (JIRA)
Chengxiang Li created FLINK-3505: Summary: JoinUnionTransposeRule fails to push Join past Union. Key: FLINK-3505 URL: https://issues.apache.org/jira/browse/FLINK-3505 Project: Flink Issue

[jira] [Updated] (FLINK-3503) [SQL] ProjectJoinTransposeRule fails to push down project.

2016-02-24 Thread Chengxiang Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chengxiang Li updated FLINK-3503: - Component/s: Table API > [SQL] ProjectJoinTransposeRule fails to push down project. >

[jira] [Updated] (FLINK-3504) Join fails while have expression inside join condition.

2016-02-24 Thread Chengxiang Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chengxiang Li updated FLINK-3504: - Summary: Join fails while have expression inside join condition. (was: [SQL] Join fails while

[jira] [Created] (FLINK-3504) [SQL] Join fails while have expression inside join condition.

2016-02-24 Thread Chengxiang Li (JIRA)
Chengxiang Li created FLINK-3504: Summary: [SQL] Join fails while have expression inside join condition. Key: FLINK-3504 URL: https://issues.apache.org/jira/browse/FLINK-3504 Project: Flink

[jira] [Updated] (FLINK-3487) [SQL] FilterAggregateTransposeRule does not transform logical plan as desired.

2016-02-24 Thread Chengxiang Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chengxiang Li updated FLINK-3487: - Issue Type: Improvement (was: Bug) > [SQL] FilterAggregateTransposeRule does not transform

[jira] [Created] (FLINK-3503) [SQL] ProjectJoinTransposeRule fails to push down project.

2016-02-24 Thread Chengxiang Li (JIRA)
Chengxiang Li created FLINK-3503: Summary: [SQL] ProjectJoinTransposeRule fails to push down project. Key: FLINK-3503 URL: https://issues.apache.org/jira/browse/FLINK-3503 Project: Flink

[jira] [Created] (FLINK-3502) [SQL] AggregateProjectPullUpConstantsRule fails on certain group keys order.

2016-02-24 Thread Chengxiang Li (JIRA)
Chengxiang Li created FLINK-3502: Summary: [SQL] AggregateProjectPullUpConstantsRule fails on certain group keys order. Key: FLINK-3502 URL: https://issues.apache.org/jira/browse/FLINK-3502 Project:

[jira] [Created] (FLINK-3501) flink-runtime-0.10.2-hadoop-1 jar problem

2016-02-24 Thread Paul Harris (JIRA)
Paul Harris created FLINK-3501: -- Summary: flink-runtime-0.10.2-hadoop-1 jar problem Key: FLINK-3501 URL: https://issues.apache.org/jira/browse/FLINK-3501 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-3485) The SerializedListAccumulator value doest seem to be right

2016-02-24 Thread sahitya pavurala (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166425#comment-15166425 ] sahitya pavurala commented on FLINK-3485: - I attached the screenshot. For primitive types, the

[jira] [Closed] (FLINK-3500) ExecutionGraphRestartTest testFailingExecutionAfterRestart fails

2016-02-24 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-3500. -- Resolution: Fixed Fixed in e811e6e. > ExecutionGraphRestartTest testFailingExecutionAfterRestart fails

[jira] [Commented] (FLINK-3500) ExecutionGraphRestartTest testFailingExecutionAfterRestart fails

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15165698#comment-15165698 ] ASF GitHub Bot commented on FLINK-3500: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request: [FLINK-3500] [test] Fix possible instability i...

2016-02-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1708 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3500) ExecutionGraphRestartTest testFailingExecutionAfterRestart fails

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15165695#comment-15165695 ] ASF GitHub Bot commented on FLINK-3500: --- Github user uce commented on the pull request:

[jira] [Resolved] (FLINK-3435) Change interplay of Ingestion Time and Event Time

2016-02-24 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger resolved FLINK-3435. --- Resolution: Fixed Fixed in http://git-wip-us.apache.org/repos/asf/flink/commit/ceb64248 >

[GitHub] flink pull request: [hotfix] Expose current watermark to Triggers

2016-02-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1706 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [hotfix] Expose current watermark to Triggers

2016-02-24 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1706#issuecomment-188451606 Merging & including this one into the RC1 as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request: [FLINK-3435] Proparly separate IngestionTime a...

2016-02-24 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1699#issuecomment-188451115 I'll merge this one as it is the last blocker of the 1.0.0 RC1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [hotfix] Expose current watermark to Triggers

2016-02-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1706#issuecomment-188450931 Okay, makes sense. +1 from my side --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: FLINK-3179 Combiner is not injected if Reduce ...

2016-02-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1553#discussion_r53998405 --- Diff: flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/GroupReduceITCase.java --- @@ -434,6 +431,95 @@ public void

[GitHub] flink pull request: [docs] Move state and windows guide to separat...

2016-02-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1705 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-3435] Proparly separate IngestionTime a...

2016-02-24 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1699#issuecomment-188431435 There's also some commented out code but I guess we'll leave that in until we fix the timestamp handling? --- If your project is set up for it, you can reply to this

[jira] [Commented] (FLINK-3499) Possible ghost references in ZooKeeper completed checkpoint store

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163702#comment-15163702 ] ASF GitHub Bot commented on FLINK-3499: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-3499) Possible ghost references in ZooKeeper completed checkpoint store

2016-02-24 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-3499. -- Resolution: Fixed Fix Version/s: 1.0.0 Fixed in af2091c. > Possible ghost references in

[GitHub] flink pull request: [FLINK-3499] [runtime] Clear ZooKeeper referen...

2016-02-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1707 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [docs] Move state and windows guide to separat...

2016-02-24 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1705#issuecomment-188430308 The changes look good to me and make a lot of sense. +1 to merge. In the long run, we should make the discussion of time independent of windows, but this can be

[jira] [Commented] (FLINK-3499) Possible ghost references in ZooKeeper completed checkpoint store

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163590#comment-15163590 ] ASF GitHub Bot commented on FLINK-3499: --- Github user uce commented on the pull request:

[jira] [Commented] (FLINK-3435) Change interplay of Ingestion Time and Event Time

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163588#comment-15163588 ] ASF GitHub Bot commented on FLINK-3435: --- Github user aljoscha commented on the pull request:

[GitHub] flink pull request: [FLINK-3435] Proparly separate IngestionTime a...

2016-02-24 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1699#issuecomment-188424651 That's fine with me. As I said, that's just personal preferences. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-3500) ExecutionGraphRestartTest testFailingExecutionAfterRestart fails

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163586#comment-15163586 ] ASF GitHub Bot commented on FLINK-3500: --- GitHub user uce opened a pull request:

[GitHub] flink pull request: [FLINK-3499] [runtime] Clear ZooKeeper referen...

2016-02-24 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1707#issuecomment-188424801 Failed test is unrelated and I think fixed by #1708. I'm merging this for the release. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: [FLINK-3500] [test] Fix possible instability i...

2016-02-24 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/1708 [FLINK-3500] [test] Fix possible instability in ExecutionGraphRestartTest After restart of the execution graph, the test driver waits for the graph to assign the new executions in a loop. If

[jira] [Commented] (FLINK-3435) Change interplay of Ingestion Time and Event Time

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163583#comment-15163583 ] ASF GitHub Bot commented on FLINK-3435: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-3435] Proparly separate IngestionTime a...

2016-02-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1699#issuecomment-188424117 Thanks for the review. I would like to keep the name `setAbsoluteTimestamp()` on the `TimestampedCollector`. For the `IngestionTimeExtractor`, what

[jira] [Commented] (FLINK-3435) Change interplay of Ingestion Time and Event Time

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163579#comment-15163579 ] ASF GitHub Bot commented on FLINK-3435: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3435] Proparly separate IngestionTime a...

2016-02-24 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1699#discussion_r53994466 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TimestampedCollector.java --- @@ -51,17 +48,19 @@ public

[jira] [Commented] (FLINK-3491) HDFSCopyUtilitiesTest fails on Windows

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163577#comment-15163577 ] ASF GitHub Bot commented on FLINK-3491: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3491] Prevent failure of HDFSCopyUtilit...

2016-02-24 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1703#discussion_r53994155 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/util/HDFSCopyUtilitiesTest.java --- @@ -35,6 +37,11 @@ @Rule

[jira] [Commented] (FLINK-1159) Case style anonymous functions not supported by Scala API

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163540#comment-15163540 ] ASF GitHub Bot commented on FLINK-1159: --- Github user stefanobaghino commented on the pull request:

[GitHub] flink pull request: [FLINK-1159] Case style anonymous functions no...

2016-02-24 Thread stefanobaghino
Github user stefanobaghino commented on the pull request: https://github.com/apache/flink/pull/1704#issuecomment-188409068 This should cover the missing implementations. I also included the tests I used to test the functionality, let me know if you prefer a wider coverage. I'll

[GitHub] flink pull request: [FLINK-3435] Proparly separate IngestionTime a...

2016-02-24 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1699#issuecomment-188406380 +1 changes look good, I had some minor comments but that's just naming preferences. Btw, this PR also removes the distinction between `EventTimeSourceFunction`

[jira] [Commented] (FLINK-3435) Change interplay of Ingestion Time and Event Time

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163529#comment-15163529 ] ASF GitHub Bot commented on FLINK-3435: --- Github user aljoscha commented on the pull request:

[GitHub] flink pull request: [FLINK-3435] Proparly separate IngestionTime a...

2016-02-24 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1699#discussion_r53986228 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TimestampedCollector.java --- @@ -51,17 +48,19 @@ public

[jira] [Commented] (FLINK-3435) Change interplay of Ingestion Time and Event Time

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163505#comment-15163505 ] ASF GitHub Bot commented on FLINK-3435: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3435] Proparly separate IngestionTime a...

2016-02-24 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1699#discussion_r53985747 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/IngestionTimeExtractor.java --- @@ -0,0 +1,40 @@ +/* + *

[jira] [Commented] (FLINK-3435) Change interplay of Ingestion Time and Event Time

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163491#comment-15163491 ] ASF GitHub Bot commented on FLINK-3435: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3435] Proparly separate IngestionTime a...

2016-02-24 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1699#discussion_r53985590 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java --- @@ -572,7 +577,7 @@ public JobGraph getJobGraph()

[jira] [Commented] (FLINK-3435) Change interplay of Ingestion Time and Event Time

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163492#comment-15163492 ] ASF GitHub Bot commented on FLINK-3435: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3435] Proparly separate IngestionTime a...

2016-02-24 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1699#discussion_r53985538 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java --- @@ -572,7 +577,7 @@ public JobGraph getJobGraph() {

[GitHub] flink pull request: [FLINK-3435] Proparly separate IngestionTime a...

2016-02-24 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1699#discussion_r53985422 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java --- @@ -572,7 +577,7 @@ public JobGraph getJobGraph() {

[jira] [Commented] (FLINK-3435) Change interplay of Ingestion Time and Event Time

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163490#comment-15163490 ] ASF GitHub Bot commented on FLINK-3435: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3435] Proparly separate IngestionTime a...

2016-02-24 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/1699#discussion_r53984915 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/IngestionTimeExtractor.java --- @@ -0,0 +1,40 @@ +/* + *

[jira] [Commented] (FLINK-3435) Change interplay of Ingestion Time and Event Time

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163483#comment-15163483 ] ASF GitHub Bot commented on FLINK-3435: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request: FLINK-3179 Combiner is not injected if Reduce ...

2016-02-24 Thread ramkrish86
Github user ramkrish86 commented on a diff in the pull request: https://github.com/apache/flink/pull/1553#discussion_r53978205 --- Diff: flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/GroupReduceITCase.java --- @@ -434,6 +431,95 @@ public void

[jira] [Commented] (FLINK-3179) Combiner is not injected if Reduce or GroupReduce input is explicitly partitioned

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163421#comment-15163421 ] ASF GitHub Bot commented on FLINK-3179: --- Github user ramkrish86 commented on a diff in the pull

[jira] [Commented] (FLINK-3500) ExecutionGraphRestartTest testFailingExecutionAfterRestart fails

2016-02-24 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163388#comment-15163388 ] Ufuk Celebi commented on FLINK-3500: >From FLINK-3490: See

[jira] [Created] (FLINK-3500) ExecutionGraphRestartTest testFailingExecutionAfterRestart fails

2016-02-24 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-3500: -- Summary: ExecutionGraphRestartTest testFailingExecutionAfterRestart fails Key: FLINK-3500 URL: https://issues.apache.org/jira/browse/FLINK-3500 Project: Flink

[jira] [Resolved] (FLINK-3470) EventTime WindowAssigners should error on negative timestamps

2016-02-24 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-3470. - Resolution: Won't Fix After further discussion, we will go for a different approach. See

[jira] [Resolved] (FLINK-3468) Change Timestamp Extractors to not support negative timestamps

2016-02-24 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-3468. - Resolution: Invalid > Change Timestamp Extractors to not support negative timestamps >

[jira] [Commented] (FLINK-3499) Possible ghost references in ZooKeeper completed checkpoint store

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163328#comment-15163328 ] ASF GitHub Bot commented on FLINK-3499: --- GitHub user uce opened a pull request:

[GitHub] flink pull request: [FLINK-3499] [runtime] Clear ZooKeeper referen...

2016-02-24 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/1707 [FLINK-3499] [runtime] Clear ZooKeeper references on recovery Adds a missing clear call to the ZooKeeperCompletedCheckpointStore. Before, it could have happened that on multiple calls to recovery after

[jira] [Commented] (FLINK-1159) Case style anonymous functions not supported by Scala API

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163318#comment-15163318 ] ASF GitHub Bot commented on FLINK-1159: --- Github user stefanobaghino commented on the pull request:

[GitHub] flink pull request: [docs] Move state and windows guide to separat...

2016-02-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1705#issuecomment-188352526 I like this a lot! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [FLINK-1159] Case style anonymous functions no...

2016-02-24 Thread stefanobaghino
Github user stefanobaghino commented on the pull request: https://github.com/apache/flink/pull/1704#issuecomment-188352497 @tillrohrmann I got mixed up reading your proposal and just got what you meant with the `extensions.acceptPartialFunctions` implicit conversion, thanks for the

[GitHub] flink pull request: [hotfix] Expose current watermark to Triggers

2016-02-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1706#issuecomment-188352346 What is the implication of this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [hotfix] Expose current watermark to Triggers

2016-02-24 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1706 [hotfix] Expose current watermark to Triggers You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink window-watermark-in-trigger

[jira] [Commented] (FLINK-1159) Case style anonymous functions not supported by Scala API

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163298#comment-15163298 ] ASF GitHub Bot commented on FLINK-1159: --- Github user stefanobaghino commented on the pull request:

[GitHub] flink pull request: [FLINK-1159] Case style anonymous functions no...

2016-02-24 Thread stefanobaghino
Github user stefanobaghino commented on the pull request: https://github.com/apache/flink/pull/1704#issuecomment-188343795 :+1: @StephanEwen I started working on the extension before the removal, will fix this as well, thanks for the feedback. --- If your project is set up for it,

[GitHub] flink pull request: [FLINK-1159] Case style anonymous functions no...

2016-02-24 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1704#issuecomment-188335368 Looks very nice in my opinion. Could you remove the `ClassTag` context bounds? We recently removed them from `DataStream`, because they are not needed.

[jira] [Commented] (FLINK-1159) Case style anonymous functions not supported by Scala API

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163278#comment-15163278 ] ASF GitHub Bot commented on FLINK-1159: --- Github user StephanEwen commented on the pull request:

[jira] [Created] (FLINK-3499) Possible ghost references in ZooKeeper completed checkpoint store

2016-02-24 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-3499: -- Summary: Possible ghost references in ZooKeeper completed checkpoint store Key: FLINK-3499 URL: https://issues.apache.org/jira/browse/FLINK-3499 Project: Flink

[GitHub] flink pull request: [FLINK-1159] Case style anonymous functions no...

2016-02-24 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1704#issuecomment-188329671 Of course, you're right. Also in the batch guide :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-1159) Case style anonymous functions not supported by Scala API

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163269#comment-15163269 ] ASF GitHub Bot commented on FLINK-1159: --- Github user tillrohrmann commented on the pull request:

[jira] [Commented] (FLINK-1159) Case style anonymous functions not supported by Scala API

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163252#comment-15163252 ] ASF GitHub Bot commented on FLINK-1159: --- Github user stefanobaghino commented on the pull request:

[GitHub] flink pull request: [FLINK-1159] Case style anonymous functions no...

2016-02-24 Thread stefanobaghino
Github user stefanobaghino commented on the pull request: https://github.com/apache/flink/pull/1704#issuecomment-188325067 Just the streaming guide? Not on both the streaming and batch? --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-3435) Change interplay of Ingestion Time and Event Time

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163249#comment-15163249 ] ASF GitHub Bot commented on FLINK-3435: --- Github user aljoscha commented on the pull request:

[jira] [Commented] (FLINK-3435) Change interplay of Ingestion Time and Event Time

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163248#comment-15163248 ] ASF GitHub Bot commented on FLINK-3435: --- Github user aljoscha commented on the pull request:

[GitHub] flink pull request: [FLINK-3435] Proparly separate IngestionTime a...

2016-02-24 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1699#issuecomment-188322569 About not allowing negative timestamps/watermarks and so on. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-3435] Proparly separate IngestionTime a...

2016-02-24 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1699#issuecomment-188322336 The comment above is not valid anymore, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-1159] Case style anonymous functions no...

2016-02-24 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1704#issuecomment-188320230 How do you want to do the implicit conversion if you return a `DataSet[T]`. If it makes the code more readable, then I think it's a good idea :-) We should

[jira] [Commented] (FLINK-1159) Case style anonymous functions not supported by Scala API

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163236#comment-15163236 ] ASF GitHub Bot commented on FLINK-1159: --- Github user tillrohrmann commented on the pull request:

[jira] [Commented] (FLINK-3445) make JDBCInputFormat implement ResultTypeQueryable

2016-02-24 Thread Ken Geis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163206#comment-15163206 ] Ken Geis commented on FLINK-3445: - Unfortunately for this, I've fallen back on working with Spark for my

[jira] [Commented] (FLINK-1159) Case style anonymous functions not supported by Scala API

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163168#comment-15163168 ] ASF GitHub Bot commented on FLINK-1159: --- Github user stefanobaghino commented on the pull request:

[GitHub] flink pull request: [FLINK-1159] Case style anonymous functions no...

2016-02-24 Thread stefanobaghino
Github user stefanobaghino commented on the pull request: https://github.com/apache/flink/pull/1704#issuecomment-188301093 Thanks @tillrohrmann, I'll fix the errors in the comments and add the missing methods and extensions. Regarding the import mode, I agree with you. I

[jira] [Commented] (FLINK-1159) Case style anonymous functions not supported by Scala API

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163154#comment-15163154 ] ASF GitHub Bot commented on FLINK-1159: --- Github user stefanobaghino commented on a diff in the pull

[GitHub] flink pull request: [FLINK-1159] Case style anonymous functions no...

2016-02-24 Thread stefanobaghino
Github user stefanobaghino commented on a diff in the pull request: https://github.com/apache/flink/pull/1704#discussion_r53950863 --- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/extensions/acceptPartialFunctions/package.scala --- @@ -0,0

[jira] [Commented] (FLINK-1159) Case style anonymous functions not supported by Scala API

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163153#comment-15163153 ] ASF GitHub Bot commented on FLINK-1159: --- Github user stefanobaghino commented on a diff in the pull

[GitHub] flink pull request: [FLINK-1159] Case style anonymous functions no...

2016-02-24 Thread stefanobaghino
Github user stefanobaghino commented on a diff in the pull request: https://github.com/apache/flink/pull/1704#discussion_r53950747 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/extensions/acceptPartialFunctions/package.scala --- @@ -0,0 +1,174 @@ +/* + *

[jira] [Commented] (FLINK-1159) Case style anonymous functions not supported by Scala API

2016-02-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163135#comment-15163135 ] ASF GitHub Bot commented on FLINK-1159: --- Github user tillrohrmann commented on the pull request:

  1   2   3   >