[jira] [Created] (FLINK-3561) ExecutionConfig's timestampsEnabled is unused

2016-03-02 Thread Maximilian Michels (JIRA)
Maximilian Michels created FLINK-3561: - Summary: ExecutionConfig's timestampsEnabled is unused Key: FLINK-3561 URL: https://issues.apache.org/jira/browse/FLINK-3561 Project: Flink Issue T

[GitHub] flink pull request: [FLINK-3560] [examples] Remove unchecked outpu...

2016-03-02 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1752#issuecomment-191159732 That is a good point @vasia. Will add the missing `ProgramDescriptions`. --- If your project is set up for it, you can reply to this email and have your reply appea

[jira] [Commented] (FLINK-3560) Examples shouldn't always print usage statement

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175353#comment-15175353 ] ASF GitHub Bot commented on FLINK-3560: --- Github user tillrohrmann commented on the p

[jira] [Commented] (FLINK-3560) Examples shouldn't always print usage statement

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175389#comment-15175389 ] ASF GitHub Bot commented on FLINK-3560: --- Github user tillrohrmann commented on the p

[GitHub] flink pull request: [FLINK-3560] [examples] Remove unchecked outpu...

2016-03-02 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1752#issuecomment-191171356 Added the missing `ProgramDescriptions`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[jira] [Created] (FLINK-3562) Update docs in the course of EventTimeSourceFunction removal

2016-03-02 Thread Maximilian Michels (JIRA)
Maximilian Michels created FLINK-3562: - Summary: Update docs in the course of EventTimeSourceFunction removal Key: FLINK-3562 URL: https://issues.apache.org/jira/browse/FLINK-3562 Project: Flink

[GitHub] flink pull request: [build] Consolidate scala checkstyle usage and...

2016-03-02 Thread mbalassi
GitHub user mbalassi opened a pull request: https://github.com/apache/flink/pull/1753 [build] Consolidate scala checkstyle usage and update version to 0.8.0 Consolidation is done via plugin management, so that configuration is done in one central location. Version update is

[GitHub] flink pull request: [FLINK-3474] support partial aggregate

2016-03-02 Thread ChengXiangLi
Github user ChengXiangLi commented on a diff in the pull request: https://github.com/apache/flink/pull/1746#discussion_r54706319 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/Aggregate.scala --- @@ -17,26 +17,77 @@ */

[jira] [Commented] (FLINK-3474) Partial aggregate interface design and sort-based implementation

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175412#comment-15175412 ] ASF GitHub Bot commented on FLINK-3474: --- Github user ChengXiangLi commented on a dif

[GitHub] flink pull request: [FLINK-3474] support partial aggregate

2016-03-02 Thread ChengXiangLi
Github user ChengXiangLi commented on the pull request: https://github.com/apache/flink/pull/1746#issuecomment-191186632 Hi, @fhueske , i've update the PR based on your comments, except object reusing in `AggregateGroupCombineFunction`. I found `GroupReduceOperator` would transform i

[jira] [Commented] (FLINK-3474) Partial aggregate interface design and sort-based implementation

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175430#comment-15175430 ] ASF GitHub Bot commented on FLINK-3474: --- Github user ChengXiangLi commented on the p

[jira] [Commented] (FLINK-2941) Implement a neo4j - Flink/Gelly connector

2016-03-02 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175434#comment-15175434 ] Vasia Kalavri commented on FLINK-2941: -- Hey [~mju], thanks for working on this! I'm v

[jira] [Created] (FLINK-3563) .returns() doesn't compile when using .map() with a custom MapFunction

2016-03-02 Thread Simone Robutti (JIRA)
Simone Robutti created FLINK-3563: - Summary: .returns() doesn't compile when using .map() with a custom MapFunction Key: FLINK-3563 URL: https://issues.apache.org/jira/browse/FLINK-3563 Project: Flink

[jira] [Commented] (FLINK-2941) Implement a neo4j - Flink/Gelly connector

2016-03-02 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175453#comment-15175453 ] Chesnay Schepler commented on FLINK-2941: - does neo4j have something akin to our f

[jira] [Created] (FLINK-3564) Implement distinct() for Table API

2016-03-02 Thread Timo Walther (JIRA)
Timo Walther created FLINK-3564: --- Summary: Implement distinct() for Table API Key: FLINK-3564 URL: https://issues.apache.org/jira/browse/FLINK-3564 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-3564) Implement distinct() for Table API

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175522#comment-15175522 ] ASF GitHub Bot commented on FLINK-3564: --- GitHub user twalthr opened a pull request:

[GitHub] flink pull request: [FLINK-3564] [table] Implement distinct() for ...

2016-03-02 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/1754 [FLINK-3564] [table] Implement distinct() for Table API Implements some syntactic sugar. Another step towards a SQL-like API. You can merge this pull request into a Git repository by running: $

[jira] [Commented] (FLINK-3152) Support all comparisons for Date type

2016-03-02 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175564#comment-15175564 ] Dawid Wysakowicz commented on FLINK-3152: - Hi, I would happily try to work on this

[jira] [Commented] (FLINK-3152) Support all comparisons for Date type

2016-03-02 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175570#comment-15175570 ] Timo Walther commented on FLINK-3152: - Hi Dawid, thanks for your interest. We are curr

[jira] [Comment Edited] (FLINK-3152) Support all comparisons for Date type

2016-03-02 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175570#comment-15175570 ] Timo Walther edited comment on FLINK-3152 at 3/2/16 1:21 PM: -

[jira] [Commented] (FLINK-3152) Support all comparisons for Date type

2016-03-02 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175590#comment-15175590 ] Dawid Wysakowicz commented on FLINK-3152: - Thanks Timo, Sure, I will happily work

[jira] [Created] (FLINK-3565) FlinkKafkaConsumer does not work with Scala 2.11

2016-03-02 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-3565: --- Summary: FlinkKafkaConsumer does not work with Scala 2.11 Key: FLINK-3565 URL: https://issues.apache.org/jira/browse/FLINK-3565 Project: Flink Issue T

[jira] [Assigned] (FLINK-3565) FlinkKafkaConsumer does not work with Scala 2.11

2016-03-02 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels reassigned FLINK-3565: - Assignee: Maximilian Michels > FlinkKafkaConsumer does not work with Scala 2.11

[jira] [Commented] (FLINK-2941) Implement a neo4j - Flink/Gelly connector

2016-03-02 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175600#comment-15175600 ] Robert Metzger commented on FLINK-2941: --- Have a look at this discussion at the gene.

[jira] [Commented] (FLINK-3152) Support all comparisons for Date type

2016-03-02 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175603#comment-15175603 ] Timo Walther commented on FLINK-3152: - I think a subtask of [FLINK-3497] would be a go

[jira] [Commented] (FLINK-3565) FlinkKafkaConsumer does not work with Scala 2.11

2016-03-02 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175609#comment-15175609 ] Maximilian Michels commented on FLINK-3565: --- Problem: flink-parent contains the

[jira] [Commented] (FLINK-3561) ExecutionConfig's timestampsEnabled is unused

2016-03-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175613#comment-15175613 ] Aljoscha Krettek commented on FLINK-3561: - I think so, yes. [~StephanEwen] must ha

[jira] [Commented] (FLINK-3565) FlinkKafkaConsumer does not work with Scala 2.11

2016-03-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175616#comment-15175616 ] Aljoscha Krettek commented on FLINK-3565: - I think 2) is the way to go, yes. > Fl

[jira] [Commented] (FLINK-3563) .returns() doesn't compile when using .map() with a custom MapFunction

2016-03-02 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175641#comment-15175641 ] Timo Walther commented on FLINK-3563: - As far as I know, mixing of Scala and Java API

[jira] [Comment Edited] (FLINK-3563) .returns() doesn't compile when using .map() with a custom MapFunction

2016-03-02 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175641#comment-15175641 ] Timo Walther edited comment on FLINK-3563 at 3/2/16 2:11 PM: -

[jira] [Commented] (FLINK-3152) Support all comparisons for Date type

2016-03-02 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175657#comment-15175657 ] Fabian Hueske commented on FLINK-3152: -- Yes, a subtask of FLINK-3497 sounds good. I w

[jira] [Commented] (FLINK-3554) Bounded sources should emit a Max Watermark when they are done

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175663#comment-15175663 ] ASF GitHub Bot commented on FLINK-3554: --- Github user aljoscha commented on the pull

[GitHub] flink pull request: [FLINK-3554] [streaming] Emit a MAX Watermark ...

2016-03-02 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1750#issuecomment-191260012 Hi, what are you referring to? The watermark does not interact with count windows. --- If your project is set up for it, you can reply to this email and have your

[jira] [Created] (FLINK-3566) Input type validation often fails on custom TypeInfo implementations

2016-03-02 Thread Gyula Fora (JIRA)
Gyula Fora created FLINK-3566: - Summary: Input type validation often fails on custom TypeInfo implementations Key: FLINK-3566 URL: https://issues.apache.org/jira/browse/FLINK-3566 Project: Flink

[jira] [Commented] (FLINK-3566) Input type validation often fails on custom TypeInfo implementations

2016-03-02 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175770#comment-15175770 ] Gyula Fora commented on FLINK-3566: --- Another example with KeySelectors and interfaces:

[GitHub] flink pull request: [FLINK-3422][streaming][api-breaking] Scramble...

2016-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1685 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-3422) Scramble HashPartitioner hashes

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175883#comment-15175883 ] ASF GitHub Bot commented on FLINK-3422: --- Github user asfgit closed the pull request

[jira] [Resolved] (FLINK-3422) Scramble HashPartitioner hashes

2016-03-02 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-3422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi resolved FLINK-3422. --- Resolution: Fixed Fixed via 0ff286d and f0f93c2. > Scramble HashPartitioner hashes >

[jira] [Commented] (FLINK-3565) FlinkKafkaConsumer does not work with Scala 2.11

2016-03-02 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176007#comment-15176007 ] Maximilian Michels commented on FLINK-3565: --- Thanks to [~till.rohrmann], I've co

[jira] [Commented] (FLINK-3565) FlinkKafkaConsumer does not work with Scala 2.11

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176012#comment-15176012 ] ASF GitHub Bot commented on FLINK-3565: --- GitHub user mxm opened a pull request:

[GitHub] flink pull request: [FLINK-3565] add module to force execution of ...

2016-03-02 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/1755 [FLINK-3565] add module to force execution of Shade plugin This ensures that all properties of the root pom are properly resolved by running the Shade plugin. Thus, our root pom does not have to

[jira] [Assigned] (FLINK-3322) MemoryManager creates too much GC pressure with iterative jobs

2016-03-02 Thread Gabor Horvath (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Horvath reassigned FLINK-3322: Assignee: Gabor Horvath > MemoryManager creates too much GC pressure with iterative jobs >

[jira] [Commented] (FLINK-3498) Implement TRIM, SUBSTRING as reference design for Table API

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176050#comment-15176050 ] ASF GitHub Bot commented on FLINK-3498: --- Github user fhueske commented on the pull r

[jira] [Commented] (FLINK-3474) Partial aggregate interface design and sort-based implementation

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176059#comment-15176059 ] ASF GitHub Bot commented on FLINK-3474: --- Github user fhueske commented on the pull r

[jira] [Commented] (FLINK-3565) FlinkKafkaConsumer does not work with Scala 2.11

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176060#comment-15176060 ] ASF GitHub Bot commented on FLINK-3565: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-3474] support partial aggregate

2016-03-02 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1746#issuecomment-191343405 Yes, you are right. We need a `RichCombineToGroupCombineWrapper` and inject it as a temporary fix until we have dedicated drivers for `CombineFunction`. --- If yo

[jira] [Commented] (FLINK-3474) Partial aggregate interface design and sort-based implementation

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176085#comment-15176085 ] ASF GitHub Bot commented on FLINK-3474: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-3474] support partial aggregate

2016-03-02 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1746#discussion_r54761986 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/Aggregate.scala --- @@ -17,26 +17,77 @@ */ packa

[jira] [Commented] (FLINK-3474) Partial aggregate interface design and sort-based implementation

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176104#comment-15176104 ] ASF GitHub Bot commented on FLINK-3474: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-3474] support partial aggregate

2016-03-02 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1746#discussion_r54763270 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateReduceGroupFunction.scala --- @@ -0,0 +1,198 @@

[GitHub] flink pull request: [FLINK-3565] add module to force execution of ...

2016-03-02 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1755#issuecomment-191343477 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] flink pull request: [FLINK-3565] add module to force execution of ...

2016-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1755 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-3565) FlinkKafkaConsumer does not work with Scala 2.11

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176241#comment-15176241 ] ASF GitHub Bot commented on FLINK-3565: --- Github user asfgit closed the pull request

[jira] [Resolved] (FLINK-3565) FlinkKafkaConsumer does not work with Scala 2.11

2016-03-02 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger resolved FLINK-3565. --- Resolution: Fixed Fix Version/s: 1.1.0 1.0.0 Resolved for 1.0 in htt

[GitHub] flink pull request: [FLINK-3498] Implement TRIM, SUBSTRING as refe...

2016-03-02 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1747#issuecomment-191341765 OK, I see. Sounds good to me. +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] flink pull request: [FLINK-3564] [table] Implement distinct() for ...

2016-03-02 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1754#discussion_r54808671 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/table/test/DistinctITCase.java --- @@ -0,0 +1,92 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-3564) Implement distinct() for Table API

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176672#comment-15176672 ] ASF GitHub Bot commented on FLINK-3564: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-3564] [table] Implement distinct() for ...

2016-03-02 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1754#discussion_r54808793 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/table/test/DistinctITCase.java --- @@ -0,0 +1,92 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-3564) Implement distinct() for Table API

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176674#comment-15176674 ] ASF GitHub Bot commented on FLINK-3564: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-3564] [table] Implement distinct() for ...

2016-03-02 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1754#discussion_r54814006 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/table/test/DistinctITCase.java --- @@ -0,0 +1,92 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-3564) Implement distinct() for Table API

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176735#comment-15176735 ] ASF GitHub Bot commented on FLINK-3564: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-3486] [tableAPI] Fix broken renaming of...

2016-03-02 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1738#issuecomment-191502994 Will merge this to `tableOnCalcite` branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[jira] [Commented] (FLINK-3486) Use Project to rename all record fields would fail following Project.

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176766#comment-15176766 ] ASF GitHub Bot commented on FLINK-3486: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-3498] Implement TRIM, SUBSTRING as refe...

2016-03-02 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1747#issuecomment-191503064 Will merge this to `tableOnCalcite` branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[jira] [Commented] (FLINK-3498) Implement TRIM, SUBSTRING as reference design for Table API

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176768#comment-15176768 ] ASF GitHub Bot commented on FLINK-3498: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-3554] [streaming] Emit a MAX Watermark ...

2016-03-02 Thread wenlonglwl
Github user wenlonglwl commented on the pull request: https://github.com/apache/flink/pull/1750#issuecomment-191534452 just want to remind, this dose not completely solve the problem of loss of pending windows over finite sources~ looking forward to the solutions~ --- If your project

[jira] [Commented] (FLINK-3554) Bounded sources should emit a Max Watermark when they are done

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176939#comment-15176939 ] ASF GitHub Bot commented on FLINK-3554: --- Github user wenlonglwl commented on the pul

[GitHub] flink pull request: [docs] fix javascript exception caused by disq...

2016-03-02 Thread wuchong
GitHub user wuchong opened a pull request: https://github.com/apache/flink/pull/1756 [docs] fix javascript exception caused by disqus As we comment `` but not the disqus javascript. It will cause a exception like this: ![image](https://cloud.githubusercontent.com/assets/53

[GitHub] flink pull request: [FLINK-3474] support partial aggregate

2016-03-02 Thread ChengXiangLi
Github user ChengXiangLi commented on a diff in the pull request: https://github.com/apache/flink/pull/1746#discussion_r54838441 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateReduceGroupFunction.scala --- @@ -0,0 +1,198

[GitHub] flink pull request: [FLINK-3474] support partial aggregate

2016-03-02 Thread ChengXiangLi
Github user ChengXiangLi commented on a diff in the pull request: https://github.com/apache/flink/pull/1746#discussion_r54838416 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/Aggregate.scala --- @@ -17,26 +17,77 @@ */

[jira] [Commented] (FLINK-3474) Partial aggregate interface design and sort-based implementation

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177259#comment-15177259 ] ASF GitHub Bot commented on FLINK-3474: --- Github user ChengXiangLi commented on a dif

[jira] [Commented] (FLINK-3474) Partial aggregate interface design and sort-based implementation

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177260#comment-15177260 ] ASF GitHub Bot commented on FLINK-3474: --- Github user ChengXiangLi commented on a dif

[jira] [Updated] (FLINK-3473) Add partial aggregate support in Flink

2016-03-02 Thread Chengxiang Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chengxiang Li updated FLINK-3473: - Attachment: PartialAggregateinFlink_v2.pdf > Add partial aggregate support in Flink >

[GitHub] flink pull request: [FLINK-3474] support partial aggregate

2016-03-02 Thread ChengXiangLi
Github user ChengXiangLi commented on the pull request: https://github.com/apache/flink/pull/1746#issuecomment-191621309 Hi, @fhueske , i found 2 test failure due to the input data of `AggregateMapFunction` is `Tuple` instead of `Row` while table config is `EFFICIENT`. I thought `Tupl

[jira] [Commented] (FLINK-3474) Partial aggregate interface design and sort-based implementation

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177390#comment-15177390 ] ASF GitHub Bot commented on FLINK-3474: --- Github user ChengXiangLi commented on the p

[GitHub] flink pull request: FLINK-3529 Add template for pull requests

2016-03-02 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/1729#issuecomment-191639327 Should be a link from CONTRIBUTING page to this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-3529) Add pull request template

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177442#comment-15177442 ] ASF GitHub Bot commented on FLINK-3529: --- Github user hsaputra commented on the pull