[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551169#comment-15551169 ] ASF GitHub Bot commented on FLINK-4691: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82129916 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/scala/table/expressionDsl.scala --- @@ -325,33 +337,42 @@ trait ImplicitExpressionO

[GitHub] flink issue #2397: [FLINK-4439] Validate 'bootstrap.servers' config in flink...

Github user gheo21 commented on the issue: https://github.com/apache/flink/pull/2397 Hi guys @StephanEwen @rmetzger , I've rebased once again the branch and fixed the merge conflicts. The travis build has two failed builds but one is connection reset by maven and the other one is comi

[jira] [Commented] (FLINK-4439) Error message KafkaConsumer08 when all 'bootstrap.servers' are invalid

[ https://issues.apache.org/jira/browse/FLINK-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551201#comment-15551201 ] ASF GitHub Bot commented on FLINK-4439: --- Github user gheo21 commented on the issue:

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551211#comment-15551211 ] ASF GitHub Bot commented on FLINK-4691: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82131749 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala --- @@ -0,0 +1,777 @@ +/* + * Li

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82132349 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala --- @@ -0,0 +1,777 @@ +/* + * Li

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551226#comment-15551226 ] ASF GitHub Bot commented on FLINK-4691: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82132367 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala --- @@ -0,0 +1,777 @@ +/* + * Li

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551224#comment-15551224 ] ASF GitHub Bot commented on FLINK-4691: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #2571: [FLINK-4348] Simplify logic of SlotManager

Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/2571#discussion_r82132624 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -136,53 +127,34 @@ public SlotRequestReg

[jira] [Commented] (FLINK-4348) Implement slot allocation protocol with TaskExecutor

[ https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551229#comment-15551229 ] ASF GitHub Bot commented on FLINK-4348: --- Github user KurtYoung commented on a diff i

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82133014 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala --- @@ -0,0 +1,777 @@ +/* + * Li

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551233#comment-15551233 ] ASF GitHub Bot commented on FLINK-4691: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #2571: [FLINK-4348] Simplify logic of SlotManager

Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/2571#discussion_r82134273 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -416,15 +333,14 @@ private boolean isReq

[jira] [Commented] (FLINK-4348) Implement slot allocation protocol with TaskExecutor

[ https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551249#comment-15551249 ] ASF GitHub Bot commented on FLINK-4348: --- Github user KurtYoung commented on a diff i

[GitHub] flink pull request #2571: [FLINK-4348] Simplify logic of SlotManager

Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/2571#discussion_r82134943 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java --- @@ -245,22 +255,26 @@ public TaskExecutorGateway ca

[jira] [Commented] (FLINK-4348) Implement slot allocation protocol with TaskExecutor

[ https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551263#comment-15551263 ] ASF GitHub Bot commented on FLINK-4348: --- Github user KurtYoung commented on a diff i

[GitHub] flink pull request #2571: [FLINK-4348] Simplify logic of SlotManager

Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/2571#discussion_r82135948 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -118,9 +109,9 @@ public void setupResou

[jira] [Commented] (FLINK-4348) Implement slot allocation protocol with TaskExecutor

[ https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551284#comment-15551284 ] ASF GitHub Bot commented on FLINK-4348: --- Github user KurtYoung commented on a diff i

[jira] [Created] (FLINK-4752) Improve session window documentation

Till Rohrmann created FLINK-4752: Summary: Improve session window documentation Key: FLINK-4752 URL: https://issues.apache.org/jira/browse/FLINK-4752 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551333#comment-15551333 ] ASF GitHub Bot commented on FLINK-4691: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82140542 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/stream/table/GroupWindowITCase.scala --- @@ -0,0 +1,777 @@ +/* + * Li

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82141352 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -55,28 +56,27 @@ case class Project(proje

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551341#comment-15551341 ] ASF GitHub Bot commented on FLINK-4691: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #2600: [FLINK-4751] [futures] Add thenCombineAsync functi...

Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2600#discussion_r82142626 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/impl/FlinkFuture.java --- @@ -232,6 +244,40 @@ public R recover(Throwable failure) thro

[jira] [Commented] (FLINK-4751) Extend Flink's futures to support combining two futures

[ https://issues.apache.org/jira/browse/FLINK-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551359#comment-15551359 ] ASF GitHub Bot commented on FLINK-4751: --- Github user uce commented on a diff in the

[GitHub] flink pull request #2600: [FLINK-4751] [futures] Add thenCombineAsync functi...

Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2600#discussion_r82142194 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/impl/FlinkFuture.java --- @@ -232,6 +242,40 @@ public R recover(Throwable failure) thro

[GitHub] flink pull request #2600: [FLINK-4751] [futures] Add thenCombineAsync functi...

Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2600#discussion_r82141826 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/impl/FlinkFuture.java --- @@ -190,7 +191,16 @@ public R recover(Throwable failure) thro

[jira] [Commented] (FLINK-4751) Extend Flink's futures to support combining two futures

[ https://issues.apache.org/jira/browse/FLINK-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551361#comment-15551361 ] ASF GitHub Bot commented on FLINK-4751: --- Github user uce commented on a diff in the

[jira] [Commented] (FLINK-4751) Extend Flink's futures to support combining two futures

[ https://issues.apache.org/jira/browse/FLINK-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551360#comment-15551360 ] ASF GitHub Bot commented on FLINK-4751: --- Github user uce commented on a diff in the

[GitHub] flink issue #2600: [FLINK-4751] [futures] Add thenCombineAsync function to F...

Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2600 Thanks for the review @uce. I will address your comments and then merge the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[jira] [Commented] (FLINK-4751) Extend Flink's futures to support combining two futures

[ https://issues.apache.org/jira/browse/FLINK-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551406#comment-15551406 ] ASF GitHub Bot commented on FLINK-4751: --- Github user tillrohrmann commented on the i

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551417#comment-15551417 ] ASF GitHub Bot commented on FLINK-4691: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82146791 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -497,3 +501,95 @@ case class LogicalRelNo

[GitHub] flink issue #2589: FLINK-3932 State Backend Security

Github user mxm commented on the issue: https://github.com/apache/flink/pull/2589 Thanks for the PR @vijikarthi. The changes look good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[jira] [Commented] (FLINK-3932) Implement State Backend Security

[ https://issues.apache.org/jira/browse/FLINK-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551433#comment-15551433 ] ASF GitHub Bot commented on FLINK-3932: --- Github user mxm commented on the issue:

[GitHub] flink pull request #2600: [FLINK-4751] [futures] Add thenCombineAsync functi...

Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2600#discussion_r82148748 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/impl/FlinkFuture.java --- @@ -232,6 +244,40 @@ public R recover(Throwable failure) thro

[jira] [Commented] (FLINK-4751) Extend Flink's futures to support combining two futures

[ https://issues.apache.org/jira/browse/FLINK-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551449#comment-15551449 ] ASF GitHub Bot commented on FLINK-4751: --- Github user uce commented on a diff in the

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82149863 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/Resolvable.scala --- @@ -0,0 +1,26 @@ +/* + * Licensed t

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82149847 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/Resolvable.scala --- @@ -0,0 +1,26 @@ +/* + * Licensed t

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551460#comment-15551460 ] ASF GitHub Bot commented on FLINK-4691: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551459#comment-15551459 ] ASF GitHub Bot commented on FLINK-4691: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82150850 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/groupWindows.scala --- @@ -0,0 +1,242 @@ +/* + * License

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82150960 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/groupWindows.scala --- @@ -0,0 +1,242 @@ +/* + * License

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551475#comment-15551475 ] ASF GitHub Bot commented on FLINK-4691: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551476#comment-15551476 ] ASF GitHub Bot commented on FLINK-4691: --- Github user twalthr commented on a diff in

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551505#comment-15551505 ] Anton Mushin commented on FLINK-4604: - I have some problem. I added rule in {{org.apa

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82147461 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala --- @@ -0,0 +1,261 @@ +/*

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82151146 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateReduceCombineFunction.scala --- @@ -0,0 +1,132 @@

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82147584 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala --- @@ -0,0 +1,261 @@ +/*

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551528#comment-15551528 ] ASF GitHub Bot commented on FLINK-4691: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551530#comment-15551530 ] ASF GitHub Bot commented on FLINK-4691: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551527#comment-15551527 ] ASF GitHub Bot commented on FLINK-4691: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82151050 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateReduceCombineFunction.scala --- @@ -0,0 +1,132 @@

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82152829 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala --- @@ -0,0 +1,261 @@ +/*

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82147669 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala --- @@ -0,0 +1,261 @@ +/*

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551526#comment-15551526 ] ASF GitHub Bot commented on FLINK-4691: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551524#comment-15551524 ] ASF GitHub Bot commented on FLINK-4691: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551522#comment-15551522 ] ASF GitHub Bot commented on FLINK-4691: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82144274 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala --- @@ -0,0 +1,261 @@ +/*

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551525#comment-15551525 ] ASF GitHub Bot commented on FLINK-4691: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551529#comment-15551529 ] ASF GitHub Bot commented on FLINK-4691: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551523#comment-15551523 ] ASF GitHub Bot commented on FLINK-4691: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82147739 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala --- @@ -0,0 +1,261 @@ +/*

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82151066 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AggregateReduceCombineFunction.scala --- @@ -0,0 +1,132 @@

[GitHub] flink pull request #2571: [FLINK-4348] Simplify logic of SlotManager

Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2571#discussion_r82155453 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -118,9 +109,9 @@ public void setupResourceMan

[jira] [Commented] (FLINK-4348) Implement slot allocation protocol with TaskExecutor

[ https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551532#comment-15551532 ] ASF GitHub Bot commented on FLINK-4348: --- Github user mxm commented on a diff in the

[GitHub] flink pull request #2571: [FLINK-4348] Simplify logic of SlotManager

Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2571#discussion_r82155691 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -205,46 +177,64 @@ public void handleSlotRequ

[jira] [Commented] (FLINK-4348) Implement slot allocation protocol with TaskExecutor

[ https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551536#comment-15551536 ] ASF GitHub Bot commented on FLINK-4348: --- Github user mxm commented on a diff in the

[jira] [Closed] (FLINK-4699) Convert Kafka TableSource/TableSink tests to unit tests

[ https://issues.apache.org/jira/browse/FLINK-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-4699. --- Resolution: Duplicate > Convert Kafka TableSource/TableSink tests to unit tests >

[GitHub] flink pull request #2571: [FLINK-4348] Simplify logic of SlotManager

Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2571#discussion_r82156547 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -416,15 +333,14 @@ private boolean isRequestDu

[jira] [Commented] (FLINK-4348) Implement slot allocation protocol with TaskExecutor

[ https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551547#comment-15551547 ] ASF GitHub Bot commented on FLINK-4348: --- Github user mxm commented on a diff in the

[GitHub] flink pull request #2571: [FLINK-4348] Simplify logic of SlotManager

Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2571#discussion_r82157384 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -136,53 +127,34 @@ public SlotRequestRegistere

[jira] [Commented] (FLINK-4348) Implement slot allocation protocol with TaskExecutor

[ https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551557#comment-15551557 ] ASF GitHub Bot commented on FLINK-4348: --- Github user mxm commented on a diff in the

[GitHub] flink issue #2571: [FLINK-4348] Simplify logic of SlotManager

Github user mxm commented on the issue: https://github.com/apache/flink/pull/2571 Thanks for the comments @KurtYoung. I've updated the PR. No worries, four eyes always see more than two and it is natural that ideas progress over time :) --- If your project is set up for it, you can r

[jira] [Commented] (FLINK-4348) Implement slot allocation protocol with TaskExecutor

[ https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551563#comment-15551563 ] ASF GitHub Bot commented on FLINK-4348: --- Github user mxm commented on the issue:

[jira] [Created] (FLINK-4753) Kafka 0.8 connector's Periodic Offset Committer should synchronize on checkpoint lock

Tzu-Li (Gordon) Tai created FLINK-4753: -- Summary: Kafka 0.8 connector's Periodic Offset Committer should synchronize on checkpoint lock Key: FLINK-4753 URL: https://issues.apache.org/jira/browse/FLINK-4753

[GitHub] flink pull request #2602: [hotfix] Re-register restored processing time time...

GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/2602 [hotfix] Re-register restored processing time timers. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink hotfix_reregister Alternatively y

[GitHub] flink pull request #2603: [FLINK-4745] [table] Convert KafkaTableSource test...

GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/2603 [FLINK-4745] [table] Convert KafkaTableSource test to unit tests This PR replaces IT cases with unit tests. You can merge this pull request into a Git repository by running: $ git pull https://

[jira] [Commented] (FLINK-4745) Convert KafkaTableSource test to unit tests

[ https://issues.apache.org/jira/browse/FLINK-4745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551679#comment-15551679 ] ASF GitHub Bot commented on FLINK-4745: --- GitHub user twalthr opened a pull request:

[jira] [Closed] (FLINK-4751) Extend Flink's futures to support combining two futures

[ https://issues.apache.org/jira/browse/FLINK-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-4751. Resolution: Fixed Added via 98710ead59305fc067cb8fdfab2c47d3bdc2e3fc > Extend Flink's futures to su

[GitHub] flink pull request #2600: [FLINK-4751] [futures] Add thenCombineAsync functi...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2600 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-4751) Extend Flink's futures to support combining two futures

[ https://issues.apache.org/jira/browse/FLINK-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551688#comment-15551688 ] ASF GitHub Bot commented on FLINK-4751: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551706#comment-15551706 ] Timo Walther commented on FLINK-4604: - Your implementation looks good so far. The outp

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82170078 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/windows.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache So

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551712#comment-15551712 ] ASF GitHub Bot commented on FLINK-4691: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82170972 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/windows.scala --- @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache So

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551720#comment-15551720 ] ASF GitHub Bot commented on FLINK-4691: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2562#discussion_r82171490 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/datastream/DataStreamAggregate.scala --- @@ -0,0 +1,261 @@ +/*

[jira] [Commented] (FLINK-4691) Add group-windows for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551734#comment-15551734 ] ASF GitHub Bot commented on FLINK-4691: --- Github user twalthr commented on a diff in

[jira] [Created] (FLINK-4754) Make number of retained checkpoints user configurable

Ufuk Celebi created FLINK-4754: -- Summary: Make number of retained checkpoints user configurable Key: FLINK-4754 URL: https://issues.apache.org/jira/browse/FLINK-4754 Project: Flink Issue Type: I

[GitHub] flink pull request #2583: [FLINK-4730] Introduce checkpoint meta data

Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2583#discussion_r82173079 --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java --- @@ -127

[GitHub] flink pull request #2583: [FLINK-4730] Introduce checkpoint meta data

Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2583#discussion_r82173119 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointMetaData.java --- @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache So

[jira] [Commented] (FLINK-4730) Introduce CheckpointMetaData

[ https://issues.apache.org/jira/browse/FLINK-4730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551766#comment-15551766 ] ASF GitHub Bot commented on FLINK-4730: --- Github user uce commented on a diff in the

[jira] [Commented] (FLINK-4730) Introduce CheckpointMetaData

[ https://issues.apache.org/jira/browse/FLINK-4730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551765#comment-15551765 ] ASF GitHub Bot commented on FLINK-4730: --- Github user uce commented on a diff in the

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551768#comment-15551768 ] Anton Mushin commented on FLINK-4604: - I'm use {{RelOptUtil.toString(relNode)}} for ge

[GitHub] flink pull request #2583: [FLINK-4730] Introduce checkpoint meta data

Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/2583#discussion_r82173351 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointMetaData.java --- @@ -0,0 +1,140 @@ +/* + * Licensed to th

[jira] [Commented] (FLINK-4730) Introduce CheckpointMetaData

[ https://issues.apache.org/jira/browse/FLINK-4730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551770#comment-15551770 ] ASF GitHub Bot commented on FLINK-4730: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #2583: [FLINK-4730] Introduce checkpoint meta data

Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/2583#discussion_r82174054 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointMetaData.java --- @@ -0,0 +1,113 @@ +/* + * Licensed to th

  1   2   >