Stephan Ewen created FLINK-5630:
---
Summary: Followups to AggregationFunction
Key: FLINK-5630
URL: https://issues.apache.org/jira/browse/FLINK-5630
Project: Flink
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/FLINK-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen resolved FLINK-4917.
-
Resolution: Fixed
Fix Version/s: 1.3.0
1.2.0
Fixed in
- 1.2.0 via
[
https://issues.apache.org/jira/browse/FLINK-5577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836399#comment-15836399
]
ASF GitHub Bot commented on FLINK-5577:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-5577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen closed FLINK-5577.
---
> Each time application is submitted to yarn, application id increases by two
>
[
https://issues.apache.org/jira/browse/FLINK-5577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen resolved FLINK-5577.
-
Resolution: Fixed
Fix Version/s: 1.3.0
Fixed via 84064c969a31fe44579b4b1da588d5b117eb4c7d
[
https://issues.apache.org/jira/browse/FLINK-5247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen closed FLINK-5247.
---
> Fix incorrect check in allowedLateness() method. Make it a no-op for
> non-event time windows.
>
[
https://issues.apache.org/jira/browse/FLINK-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836398#comment-15836398
]
ASF GitHub Bot commented on FLINK-4905:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen closed FLINK-4917.
---
> Deprecate "CheckpointedAsynchronously" interface
>
>
>
[
https://issues.apache.org/jira/browse/FLINK-5247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen resolved FLINK-5247.
-
Resolution: Fixed
Fix Version/s: 1.3.0
1.2.0
Fixed in
- 1.2.0 via
[
https://issues.apache.org/jira/browse/FLINK-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836448#comment-15836448
]
ASF GitHub Bot commented on FLINK-4905:
---
Github user StephanEwen commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836397#comment-15836397
]
ASF GitHub Bot commented on FLINK-4917:
---
Github user asfgit closed the pull request at:
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3035
@BrainLogic I'll incorporate your comment into a followup commit...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3173
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3035
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3087
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3200#discussion_r97591827
--- Diff:
flink-runtime/src/main/java/org/apache/flink/migration/MigrationNamespaceSerializerProxy.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3200#discussion_r97593753
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredBackendStateMetaInfo.java
---
@@ -92,10 +94,9 @@ public boolean
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3200#discussion_r97591863
--- Diff:
flink-runtime/src/main/java/org/apache/flink/migration/MigrationNamespaceSerializerProxy.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3200#discussion_r97591922
--- Diff:
flink-runtime/src/main/java/org/apache/flink/migration/MigrationNamespaceSerializerProxy.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/3201
[FLINK-5620] Fix unstable ContinuousFileProcessingTest
This fixes at least one possible problem that may render the test unstable,
which is that all the tests in the class create files with the same
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3182
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3198#discussion_r97558004
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractStateBackend.java
---
@@ -66,4 +66,9 @@ public OperatorStateBackend
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3049
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3198#discussion_r97554901
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractStateBackend.java
---
@@ -66,4 +66,9 @@ public OperatorStateBackend
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3049
I fixed the mentioned issues in
http://git-wip-us.apache.org/repos/asf/flink/commit/5f0d8c9d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3198#discussion_r97553270
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -773,12
Github user sachingoel0101 commented on the issue:
https://github.com/apache/flink/pull/3192
/cc @skonto @thvasilo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/3200
[FLINK-5602] migration namespace serializer
This PR fixes FLINK-5602. We introduce an artificial namespace serializer
instead of `null` so that checkpoints can run even before the user
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3194
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3194
Thanks for addressing the comments, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3198
I changed my PR as suggested by @uce and @tillrohrmann.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3049#discussion_r97540542
--- Diff: tools/create_release_files.sh ---
@@ -201,19 +274,34 @@ prepare
make_source_release
-make_binary_release "hadoop2" "" 2.10
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3049#discussion_r97540513
--- Diff: tools/create_release_files.sh ---
@@ -117,10 +184,13 @@ make_source_release() {
perl -pi -e "s#^version_short: .*#version_short:
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3198#discussion_r97540391
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -245,14
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3198#discussion_r97540340
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractStateBackend.java
---
@@ -66,4 +66,9 @@ public OperatorStateBackend
Github user BrainLogic commented on the issue:
https://github.com/apache/flink/pull/3035
Thanks for help and explanation.
But in this approach an unlikely bug will be still occurred:
`zkHandler.prepareAndCommitOffsets(offsets);` throws important exception
when running is true
Github user gyfora closed the pull request at:
https://github.com/apache/flink/pull/3199
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user gyfora commented on the issue:
https://github.com/apache/flink/pull/3199
Thanks for looking into this Ufuk, I missed the previous discussion.
I guess you can work around this as long as you are running on single yarn
sessions and always generate the flink-conf files
Github user NickolayVasilishin commented on the issue:
https://github.com/apache/flink/pull/2870
Hi, @twalthr
I'm afraid I'm busy now with another project, so the task is now pending
until Alexander Chermenin will continue working on it with my possible
assistance.
---
Github user ramkrish86 commented on the issue:
https://github.com/apache/flink/pull/3149
@fhueske , @tonycox , @wuchong
I have updated the PR based on all the feedbacks here. Now you could see
that we now support CompoisteRowType and we are able to specify multiple column
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3198#discussion_r97525648
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractStateBackend.java
---
@@ -66,4 +66,9 @@ public OperatorStateBackend
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3182
I've merged the PR to the `release-1.2` branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3198#discussion_r97524989
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractStateBackend.java
---
@@ -66,4 +66,9 @@ public OperatorStateBackend
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3198#discussion_r97524568
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -245,14 +235,15
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3199
Hey Gyula! I fully agree that this is currently in a semi-weird state where
you can only activate externalized checkpoints in the program, but have to
specify the directory in the config. When I opened
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3198#discussion_r97523685
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractStateBackend.java
---
@@ -66,4 +66,9 @@ public OperatorStateBackend
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3198#discussion_r97522787
--- Diff: flink-core/src/main/java/org/apache/flink/util/IOUtils.java ---
@@ -216,9 +215,52 @@ public static void closeSocket(final Socket sock) {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3198#discussion_r97520420
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -148,16
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3198#discussion_r97521501
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -345,7
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3198#discussion_r97523023
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractStateBackend.java
---
@@ -66,4 +66,9 @@ public OperatorStateBackend
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3198#discussion_r97520822
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -148,16
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3198#discussion_r97521254
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -201,12
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2766
Sorry for the very long delay on this one. I really like the idea of
deduping code at that level, but I don't think that we can merge this as it is.
What's the current state of the things that depend on
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3054
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3054
Thanks for the PR. Looks good to me. Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user gyfora closed the pull request at:
https://github.com/apache/flink/pull/2129
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3116
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3185
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user gyfora opened a pull request:
https://github.com/apache/flink/pull/3199
[streaming] [checkpoints] Allow job specific external checkpoint dir
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gyfora/flink
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2572
manually merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/2572
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3112
Rebased to resolve conflicts in documentation changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3185
@aljoscha thank you for the review. I'll address the inline comment and
merge this to `master` and `release-1.2`
---
If your project is set up for it, you can reply to this email and have your
Github user Xazax-hun commented on the issue:
https://github.com/apache/flink/pull/2211
Hi Ufuk!
I have some good news. With this version the code distribution is a solved
problem. I did experience some problem with the checkpointing though, but I
think that shouldn't be too hard
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3185#discussion_r97507114
--- Diff: docs/dev/event_time.md ---
@@ -142,7 +143,7 @@ to use timestamp assignment and watermark generation in
the Flink DataStream API
# Event
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2801
Rebased on latest master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3116
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2267
Hey @doflink! Do you think you will have time to address Till's comments?
If not I think it's best to close this.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2211
Cool proposal! I didn't look at the code, but have a more general question:
Since this was done as part of a now finished GSoC, I'm wondering what your
plans are (given that this part is reviewed etc.)
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/1890
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/3198
cc @tillrohrmann
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/3198
[FLINK-5626] Improved resource deallocation in RocksDBKeyedStateBackend
This PR improves some cases of resource deallocation for RocksDB under
exceptions. On top of that, I gave some
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2153
Now that some time has passed, I feel like we should really cover this in
the docs first. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2129
I think this is superseded with the current work on dynamic scaling as part
of FLIP-6. Can we close this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2066
+1 to close this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user uce commented on the issue:
https://github.com/apache/flink/pull/1890
Still like the idea, but we didn't get any feedback and the TDD changed in
the mean time. The number of arguments also decreased to 10. I think it's best
to close this PR.
---
If your project is set
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3194#discussion_r97500318
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/query/QueryableStateITCaseRocksDBBackend.java
---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3194#discussion_r97500347
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/query/QueryableStateITCaseFsBackend.java
---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3189
How come the state of tasks is no longer shown?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3189
Thanks for the PR. I also sometimes had the bad experience while testing
that the cancel button was not visible. This change definitely solves it. I
tested it and it works as expected. I made some
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3195
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3182
Changes look good. Travis passed. Merging this PR. Thanks for your work
@StefanRRichter :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3134
I've merged it to 1.2 and 1.3:
https://issues.apache.org/jira/browse/FLINK-5450?focusedCommentId=15834503=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15834503
---
If
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3049
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
101 - 184 of 184 matches
Mail list logo
