Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4238#discussion_r125404358
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobCache.java ---
@@ -107,146 +133,268 @@ public BlobCache(
this.n
[
https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073226#comment-16073226
]
ASF GitHub Bot commented on FLINK-7057:
---
Github user NicoK commented on a diff in th
Github user uce commented on the issue:
https://github.com/apache/flink/pull/4213
Just ran into this as well. This was so annoying. Thank you very much for
the fix... I spent an hour assuming it was a problem on my side. Merging now...
---
If your project is set up for it, you can re
[
https://issues.apache.org/jira/browse/FLINK-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073231#comment-16073231
]
ASF GitHub Bot commented on FLINK-7032:
---
Github user uce commented on the issue:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4213
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073235#comment-16073235
]
ASF GitHub Bot commented on FLINK-7032:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-6995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073237#comment-16073237
]
mingleizhang commented on FLINK-6995:
-
[~alpinegizmo] I will create another JIRA for w
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4244
@Adebski thanks for the fix.
Yes I think this qualifies as a trivial fix and doesn't require a JIRA. For
these kind of fixes we usually prefix the commit message with a `[hotfix]`.
LGTM,
[
https://issues.apache.org/jira/browse/FLINK-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ufuk Celebi closed FLINK-7032.
--
Resolution: Fixed
Fix Version/s: 1.3.2
1.4.0
Fixed in 5f4296e (release-1.3), d
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4229
LGTM, merging ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4238#discussion_r125406639
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/execution/librarycache/BlobServerLibraryManager.java
---
@@ -0,0 +1,55 @@
+/*
+ * Licen
[
https://issues.apache.org/jira/browse/FLINK-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073243#comment-16073243
]
ASF GitHub Bot commented on FLINK-7038:
---
Github user tzulitai commented on the issue
[
https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073244#comment-16073244
]
ASF GitHub Bot commented on FLINK-7057:
---
Github user NicoK commented on a diff in th
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/4213
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
[
https://issues.apache.org/jira/browse/FLINK-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073248#comment-16073248
]
ASF GitHub Bot commented on FLINK-7032:
---
Github user pnowojski commented on the issu
mingleizhang created FLINK-7094:
---
Summary: Update outdated doc release 1.2 to latest stable release
1.3
Key: FLINK-7094
URL: https://issues.apache.org/jira/browse/FLINK-7094
Project: Flink
Iss
[
https://issues.apache.org/jira/browse/FLINK-7094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mingleizhang updated FLINK-7094:
Issue Type: Sub-task (was: Bug)
Parent: FLINK-6995
> Update outdated doc release 1.2 to lat
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4206#discussion_r125411227
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaProducerTestBase.java
---
@@ -172,6 +1
[
https://issues.apache.org/jira/browse/FLINK-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073276#comment-16073276
]
ASF GitHub Bot commented on FLINK-6996:
---
Github user tzulitai commented on a diff in
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4206#discussion_r125411707
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaProducerTestBase.java
---
@@ -172,6 +1
[
https://issues.apache.org/jira/browse/FLINK-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073280#comment-16073280
]
ASF GitHub Bot commented on FLINK-6996:
---
Github user tzulitai commented on a diff in
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4206#discussion_r125411974
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironment.java
---
@@ -80,6 +82,
[
https://issues.apache.org/jira/browse/FLINK-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073283#comment-16073283
]
ASF GitHub Bot commented on FLINK-6996:
---
Github user tzulitai commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073284#comment-16073284
]
ASF GitHub Bot commented on FLINK-6996:
---
Github user tzulitai commented on the issue
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4206
Thanks for the fixups @pnowojski!
I have some final minor comments, other than that this LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user zjureel commented on the issue:
https://github.com/apache/flink/pull/4220
@tillrohrmann Thank you for your review, I have remove
`restart(ExecutionGraph executionGraph)`, and use `ScheduledExecutor` instead
of `ScheduledExecutorService` you metioned. Thanks
---
If your
[
https://issues.apache.org/jira/browse/FLINK-6665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073299#comment-16073299
]
ASF GitHub Bot commented on FLINK-6665:
---
Github user zjureel commented on the issue:
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4251
[FLINK-7093] [tm] Send SlotReport as part of the heartbeat payload to the
ResourceManager
The TaskManager sends the SlotReport as part of the heartbeat payload to
the ResourceManager.
That
[
https://issues.apache.org/jira/browse/FLINK-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073306#comment-16073306
]
ASF GitHub Bot commented on FLINK-7093:
---
GitHub user tillrohrmann opened a pull requ
[
https://issues.apache.org/jira/browse/FLINK-7074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann reassigned FLINK-7074:
Assignee: Till Rohrmann
> Add entry point for TaskManagerRunner
> -
[
https://issues.apache.org/jira/browse/FLINK-7074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann updated FLINK-7074:
-
Labels: flip-6 (was: )
> Add entry point for TaskManagerRunner
>
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/4206
@tzulitai applied changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wi
[
https://issues.apache.org/jira/browse/FLINK-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073313#comment-16073313
]
ASF GitHub Bot commented on FLINK-6996:
---
Github user pnowojski commented on the issu
[
https://issues.apache.org/jira/browse/FLINK-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073315#comment-16073315
]
ASF GitHub Bot commented on FLINK-6996:
---
Github user pnowojski commented on a diff i
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4206#discussion_r125416757
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaProducerTestBase.java
---
@@ -172,6 +
Github user zjureel commented on the issue:
https://github.com/apache/flink/pull/4184
@aljoscha Thank you for merging it, I will close it, thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user zjureel closed the pull request at:
https://github.com/apache/flink/pull/4184
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
[
https://issues.apache.org/jira/browse/FLINK-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073323#comment-16073323
]
ASF GitHub Bot commented on FLINK-6310:
---
Github user zjureel commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073325#comment-16073325
]
ASF GitHub Bot commented on FLINK-6310:
---
Github user zjureel closed the pull request
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4130
Thanks for the review @tillrohrmann! I will address your comments and
proceed with merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
[
https://issues.apache.org/jira/browse/FLINK-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073331#comment-16073331
]
ASF GitHub Bot commented on FLINK-6773:
---
Github user StefanRRichter commented on the
[
https://issues.apache.org/jira/browse/FLINK-7094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger updated FLINK-7094:
--
Component/s: Documentation
> Update outdated doc release 1.2 to latest stable release 1.3
>
Github user StefanRRichter closed the pull request at:
https://github.com/apache/flink/pull/4130
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
[
https://issues.apache.org/jira/browse/FLINK-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073334#comment-16073334
]
ASF GitHub Bot commented on FLINK-6773:
---
Github user StefanRRichter closed the pull
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/4130
Merged in 5171513a3c.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wis
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4241
Also, for actually doing the changes I suggest separate steps, i.e.
separate commits. With possibly separate PRs to make reviewing easier and to
make the changes more isolated:
- Rename `S
[
https://issues.apache.org/jira/browse/FLINK-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073335#comment-16073335
]
ASF GitHub Bot commented on FLINK-6773:
---
Github user StefanRRichter commented on the
[
https://issues.apache.org/jira/browse/FLINK-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073336#comment-16073336
]
ASF GitHub Bot commented on FLINK-7015:
---
Github user aljoscha commented on the issue
[
https://issues.apache.org/jira/browse/FLINK-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Richter closed FLINK-6773.
-
Resolution: Implemented
Merged in 5171513a3c. Documentation in 41806ba681.
> Use compression (e.g
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4249
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
[
https://issues.apache.org/jira/browse/FLINK-7070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073344#comment-16073344
]
ASF GitHub Bot commented on FLINK-7070:
---
Github user zentol commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4249
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
[
https://issues.apache.org/jira/browse/FLINK-7070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073345#comment-16073345
]
ASF GitHub Bot commented on FLINK-7070:
---
Github user zentol commented on the issue:
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4157#discussion_r125423153
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/queryConfig.scala
---
@@ -37,6 +37,13 @@ class BatchQueryConfig priva
[
https://issues.apache.org/jira/browse/FLINK-6649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073356#comment-16073356
]
ASF GitHub Bot commented on FLINK-6649:
---
Github user sunjincheng121 commented on a d
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4157#discussion_r125423783
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunctionWithUpdateInterval.scala
---
@@
[
https://issues.apache.org/jira/browse/FLINK-6649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073358#comment-16073358
]
ASF GitHub Bot commented on FLINK-6649:
---
Github user sunjincheng121 commented on a d
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4157#discussion_r125424099
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunctionWithUpdateInterval.scala
---
@@
[
https://issues.apache.org/jira/browse/FLINK-6649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073361#comment-16073361
]
ASF GitHub Bot commented on FLINK-6649:
---
Github user sunjincheng121 commented on a d
[
https://issues.apache.org/jira/browse/FLINK-6880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073382#comment-16073382
]
ASF GitHub Bot commented on FLINK-6880:
---
Github user zentol commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4098
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
[
https://issues.apache.org/jira/browse/FLINK-6877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073384#comment-16073384
]
ASF GitHub Bot commented on FLINK-6877:
---
Github user zentol commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4095
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
[
https://issues.apache.org/jira/browse/FLINK-6821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073387#comment-16073387
]
ASF GitHub Bot commented on FLINK-6821:
---
Github user zentol commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4063
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4064#discussion_r125429424
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/plugable/ReusingDeserializationDelegate.java
---
@@ -16,33 +16,31 @@
* limitations under
[
https://issues.apache.org/jira/browse/FLINK-6822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073389#comment-16073389
]
ASF GitHub Bot commented on FLINK-6822:
---
Github user zentol commented on a diff in t
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4222
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4238#discussion_r125430028
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java ---
@@ -162,105 +164,116 @@ static File initStorageDirectory(String
storage
[
https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073391#comment-16073391
]
ASF GitHub Bot commented on FLINK-7057:
---
Github user NicoK commented on a diff in th
[
https://issues.apache.org/jira/browse/FLINK-7039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073390#comment-16073390
]
ASF GitHub Bot commented on FLINK-7039:
---
Github user zentol commented on the issue:
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4238#discussion_r125430786
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServerConnection.java
---
@@ -477,97 +406,96 @@ else if (contentAddressable == CONTENT
[
https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073394#comment-16073394
]
ASF GitHub Bot commented on FLINK-7057:
---
Github user NicoK commented on a diff in th
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4068
@greghogan fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
[
https://issues.apache.org/jira/browse/FLINK-6823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073404#comment-16073404
]
ASF GitHub Bot commented on FLINK-6823:
---
Github user zentol commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4064
@greghogan fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4065
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
[
https://issues.apache.org/jira/browse/FLINK-6822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073406#comment-16073406
]
ASF GitHub Bot commented on FLINK-6822:
---
Github user zentol commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073407#comment-16073407
]
ASF GitHub Bot commented on FLINK-6826:
---
Github user zentol commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-6991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tzu-Li (Gordon) Tai updated FLINK-6991:
---
Component/s: Project Website
> Inaccessible link under Gelly document
> --
Till Rohrmann created FLINK-7095:
Summary: Add proper command line parsing tool to
TaskManagerRunner.main
Key: FLINK-7095
URL: https://issues.apache.org/jira/browse/FLINK-7095
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-7095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann updated FLINK-7095:
-
Priority: Minor (was: Major)
> Add proper command line parsing tool to TaskManagerRunner.main
> -
[
https://issues.apache.org/jira/browse/FLINK-6991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tzu-Li (Gordon) Tai resolved FLINK-6991.
Resolution: Fixed
Fixed for asf-site via 7b21e3ed77faf66e61e50f522a5b910217699690.
[
https://issues.apache.org/jira/browse/FLINK-6665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073437#comment-16073437
]
ASF GitHub Bot commented on FLINK-6665:
---
Github user StephanEwen commented on the is
Till Rohrmann created FLINK-7096:
Summary: Adapt start-up scripts to start Flip-6 cluster
Key: FLINK-7096
URL: https://issues.apache.org/jira/browse/FLINK-7096
Project: Flink
Issue Type: Bug
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4220
We have to also consider anther aspect: Changing this from a synchronous
call to an asynchronous callback makes new types of races possible, against
which we need to guard.
We need to ma
Till Rohrmann created FLINK-7097:
Summary: Start TaskExecutor via start-up script
Key: FLINK-7097
URL: https://issues.apache.org/jira/browse/FLINK-7097
Project: Flink
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/FLINK-7096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann updated FLINK-7096:
-
Labels: flip-6 (was: )
> Adapt start-up scripts to start Flip-6 cluster
> ---
Till Rohrmann created FLINK-7098:
Summary: Start standalone cluster entry point via start-up script
Key: FLINK-7098
URL: https://issues.apache.org/jira/browse/FLINK-7098
Project: Flink
Issue
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4206
LGTM, merging ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
[
https://issues.apache.org/jira/browse/FLINK-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073441#comment-16073441
]
ASF GitHub Bot commented on FLINK-6996:
---
Github user tzulitai commented on the issue
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4232
Thanks for the fixups @aljoscha :-D
The last Travis run was successful, the test name rename should not affect
anything.
Merging this ..
---
If your project is set up for it, you can reply
[
https://issues.apache.org/jira/browse/FLINK-7041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073448#comment-16073448
]
ASF GitHub Bot commented on FLINK-7041:
---
Github user tzulitai commented on the issue
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4228#discussion_r125445059
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -117,12 +11
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4228#discussion_r125445000
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -117,12 +11
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4228#discussion_r125445183
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -117,12 +11
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4228#discussion_r125445109
--- Diff: docs/dev/connectors/kinesis.md ---
@@ -72,12 +72,80 @@ Before consuming data from Kinesis streams, make sure
that all streams are creat
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3583
@tillrohrmann Thanks for the review, will add the null check to
`failGlobal` and merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
[
https://issues.apache.org/jira/browse/FLINK-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073476#comment-16073476
]
ASF GitHub Bot commented on FLINK-6043:
---
Github user zentol commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4146
merging,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
1 - 100 of 364 matches
Mail list logo
