[GitHub] flink issue #5915: [FLINK-9243][tests] fix flaky SuccessAfterNetworkBuffersF...

2018-04-25 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/5915 The points is already `rebalance()` in line 131, so it is no need to `rebalance()` again in line 137? ---

[jira] [Commented] (FLINK-9243) SuccessAfterNetworkBuffersFailureITCase#testSuccessfulProgramAfterFailure is unstable

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453569#comment-16453569 ] ASF GitHub Bot commented on FLINK-9243: --- Github user zhijiangW commented on the issu

[jira] [Created] (FLINK-9260) Introduce a friendly way to resume the job from externalized checkpoints automatically

2018-04-25 Thread Sihua Zhou (JIRA)
Sihua Zhou created FLINK-9260: - Summary: Introduce a friendly way to resume the job from externalized checkpoints automatically Key: FLINK-9260 URL: https://issues.apache.org/jira/browse/FLINK-9260 Projec

[jira] [Comment Edited] (FLINK-9259) The implementation of the SourceFunction is not serializable.

2018-04-25 Thread Bob Lau (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453430#comment-16453430 ] Bob Lau edited comment on FLINK-9259 at 4/26/18 5:28 AM: - [~mingle

[jira] [Comment Edited] (FLINK-9259) The implementation of the SourceFunction is not serializable.

2018-04-25 Thread Bob Lau (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453430#comment-16453430 ] Bob Lau edited comment on FLINK-9259 at 4/26/18 4:39 AM: - [~mingle

[jira] [Commented] (FLINK-9259) The implementation of the SourceFunction is not serializable.

2018-04-25 Thread Bob Lau (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453430#comment-16453430 ] Bob Lau commented on FLINK-9259: [~mingleizhang] I wont use parameter like inputStream ( g

[jira] [Commented] (FLINK-9259) The implementation of the SourceFunction is not serializable.

2018-04-25 Thread Bob Lau (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453414#comment-16453414 ] Bob Lau commented on FLINK-9259: TableSource with RowTypeInfo, and I wont transform the Da

[jira] [Commented] (FLINK-9259) The implementation of the SourceFunction is not serializable.

2018-04-25 Thread yuqi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453402#comment-16453402 ] yuqi commented on FLINK-9259: - More detail are needed, you can paste more about your code [~bo

[jira] [Commented] (FLINK-9008) End-to-end test: Quickstarts

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453397#comment-16453397 ] ASF GitHub Bot commented on FLINK-9008: --- Github user zhangminglei commented on the i

[GitHub] flink issue #5823: [FLINK-9008] [e2e] Implements quickstarts end to end test

2018-04-25 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5823 Hi, @zentol I have updated the code and the patch is available to have another review now. ---

[jira] [Commented] (FLINK-9259) The implementation of the SourceFunction is not serializable.

2018-04-25 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453379#comment-16453379 ] mingleizhang commented on FLINK-9259: - I would not think it is a bug since {{SourceFun

[jira] [Updated] (FLINK-9259) The implementation of the SourceFunction is not serializable.

2018-04-25 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingleizhang updated FLINK-9259: Description: The exception stack is as follows: {code:java} //Code placeholder org.apache.flink.api.

[jira] [Created] (FLINK-9259) The implementation of the SourceFunction is not serializable.

2018-04-25 Thread Bob Lau (JIRA)
Bob Lau created FLINK-9259: -- Summary: The implementation of the SourceFunction is not serializable. Key: FLINK-9259 URL: https://issues.apache.org/jira/browse/FLINK-9259 Project: Flink Issue Type:

[jira] [Commented] (FLINK-9188) Provide a mechanism to configure AmazonKinesisClient in FlinkKinesisConsumer

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453192#comment-16453192 ] ASF GitHub Bot commented on FLINK-9188: --- Github user tweise commented on a diff in t

[GitHub] flink pull request #5889: [FLINK-9188] [kinesis] Generic mechanism to set Cl...

2018-04-25 Thread tweise
Github user tweise commented on a diff in the pull request: https://github.com/apache/flink/pull/5889#discussion_r184224413 --- Diff: flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyTest.java --- @@ -86,4 +86,1

[jira] [Commented] (FLINK-9188) Provide a mechanism to configure AmazonKinesisClient in FlinkKinesisConsumer

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453174#comment-16453174 ] ASF GitHub Bot commented on FLINK-9188: --- Github user tweise commented on a diff in t

[GitHub] flink pull request #5889: [FLINK-9188] [kinesis] Generic mechanism to set Cl...

2018-04-25 Thread tweise
Github user tweise commented on a diff in the pull request: https://github.com/apache/flink/pull/5889#discussion_r184220854 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@ -186,7 +186,10

[jira] [Commented] (FLINK-9188) Provide a mechanism to configure AmazonKinesisClient in FlinkKinesisConsumer

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453164#comment-16453164 ] ASF GitHub Bot commented on FLINK-9188: --- Github user tweise commented on a diff in t

[GitHub] flink pull request #5889: [FLINK-9188] [kinesis] Generic mechanism to set Cl...

2018-04-25 Thread tweise
Github user tweise commented on a diff in the pull request: https://github.com/apache/flink/pull/5889#discussion_r184218974 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@ -186,7 +186,10

[jira] [Commented] (FLINK-9243) SuccessAfterNetworkBuffersFailureITCase#testSuccessfulProgramAfterFailure is unstable

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453152#comment-16453152 ] ASF GitHub Bot commented on FLINK-9243: --- Github user asfgit closed the pull request

[GitHub] flink pull request #5915: [FLINK-9243][tests] fix flaky SuccessAfterNetworkB...

2018-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5915 ---

[jira] [Closed] (FLINK-9243) SuccessAfterNetworkBuffersFailureITCase#testSuccessfulProgramAfterFailure is unstable

2018-04-25 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-9243. --- Resolution: Fixed master: 0113ee2b33e3f86bb6a3de2ecf60d8e7bf554be2 1.5: 687278d791a10b7b8e3eed

[jira] [Commented] (FLINK-9243) SuccessAfterNetworkBuffersFailureITCase#testSuccessfulProgramAfterFailure is unstable

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453146#comment-16453146 ] ASF GitHub Bot commented on FLINK-9243: --- Github user zentol commented on the issue:

[GitHub] flink issue #5915: [FLINK-9243][tests] fix flaky SuccessAfterNetworkBuffersF...

2018-04-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5915 merging. ---

[jira] [Commented] (FLINK-8841) Duplicate MapSerializer and HashMapSerializer.

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453099#comment-16453099 ] ASF GitHub Bot commented on FLINK-8841: --- Github user bowenli86 commented on the issu

[GitHub] flink issue #5910: [FLINK-8841] [state] Remove HashMapSerializer and use Map...

2018-04-25 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5910 +1 ---

[jira] [Commented] (FLINK-9258) ConcurrentModificationException in ComponentMetricGroup.getAllVariables

2018-04-25 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453095#comment-16453095 ] Chesnay Schepler commented on FLINK-9258: - This should only be possible if {{getAl

[jira] [Commented] (FLINK-9249) Add convenience profile for skipping non-essential plugins

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453089#comment-16453089 ] ASF GitHub Bot commented on FLINK-9249: --- Github user bowenli86 commented on the issu

[jira] [Updated] (FLINK-9258) ConcurrentModificationException in ComponentMetricGroup.getAllVariables

2018-04-25 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-9258: Fix Version/s: 1.4.3 1.5.0 > ConcurrentModificationException in Component

[jira] [Assigned] (FLINK-9258) ConcurrentModificationException in ComponentMetricGroup.getAllVariables

2018-04-25 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-9258: --- Assignee: Chesnay Schepler > ConcurrentModificationException in ComponentMetricGroup.

[GitHub] flink issue #5904: [FLINK-9249][build] Add convenience profile for skipping ...

2018-04-25 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5904 +1 ---

[jira] [Created] (FLINK-9258) ConcurrentModificationException in ComponentMetricGroup.getAllVariables

2018-04-25 Thread Narayanan Arunachalam (JIRA)
Narayanan Arunachalam created FLINK-9258: Summary: ConcurrentModificationException in ComponentMetricGroup.getAllVariables Key: FLINK-9258 URL: https://issues.apache.org/jira/browse/FLINK-9258

[jira] [Commented] (FLINK-9243) SuccessAfterNetworkBuffersFailureITCase#testSuccessfulProgramAfterFailure is unstable

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452840#comment-16452840 ] ASF GitHub Bot commented on FLINK-9243: --- GitHub user NicoK opened a pull request:

[GitHub] flink pull request #5915: [FLINK-9243][tests] fix flaky SuccessAfterNetworkB...

2018-04-25 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/5915 [FLINK-9243][tests] fix flaky SuccessAfterNetworkBuffersFailureITCase this adds some `rebalance()` operations into `SuccessAfterNetworkBuffersFailureITCase#runKMeans` which should be set up to fail a

[jira] [Commented] (FLINK-8135) Add description to MessageParameter

2018-04-25 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452681#comment-16452681 ] Chesnay Schepler commented on FLINK-8135: - [~Poluliakh] should work now. > Add de

[jira] [Commented] (FLINK-9256) NPE in SingleInputGate#updateInputChannel() for non-credit based flow control

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452597#comment-16452597 ] ASF GitHub Bot commented on FLINK-9256: --- GitHub user NicoK opened a pull request:

[jira] [Commented] (FLINK-2435) Add support for custom CSV field parsers

2018-04-25 Thread Dmitrii Kober (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452600#comment-16452600 ] Dmitrii Kober commented on FLINK-2435: -- Excess changes are removed, please review. >

[GitHub] flink pull request #5914: [FLINK-9256][network] fix NPE in SingleInputGate#u...

2018-04-25 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/5914 [FLINK-9256][network] fix NPE in SingleInputGate#updateInputChannel() for non-credit based flow control ## What is the purpose of the change `SingleInputGate#updateInputChannel()` fails to up

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452590#comment-16452590 ] ASF GitHub Bot commented on FLINK-8689: --- Github user walterddr commented on a diff i

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452592#comment-16452592 ] ASF GitHub Bot commented on FLINK-8689: --- Github user walterddr commented on a diff i

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452591#comment-16452591 ] ASF GitHub Bot commented on FLINK-8689: --- Github user walterddr commented on a diff i

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-25 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184115873 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -151,8 +157,36 @@ class Aggregat

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-25 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184125030 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAccumulator.scala --- @@ -0,0 +1,106 @@ +/*

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-25 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184115947 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -151,8 +157,36 @@ class Aggregat

[jira] [Commented] (FLINK-8135) Add description to MessageParameter

2018-04-25 Thread Andrei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452584#comment-16452584 ] Andrei commented on FLINK-8135: --- [~Zentol] seems like I can't :( > Add description to Messa

[jira] [Updated] (FLINK-8686) Improve basic embedded SQL client

2018-04-25 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-8686: Description: This issue describes follow-up issues that should be fixes in order to make the SQL cl

[jira] [Updated] (FLINK-8686) Improve basic embedded SQL client

2018-04-25 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-8686: Fix Version/s: (was: 1.5.0) > Improve basic embedded SQL client > -

[jira] [Commented] (FLINK-8686) Improve basic embedded SQL client

2018-04-25 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452520#comment-16452520 ] Timo Walther commented on FLINK-8686: - Parts of this issue have been fixed: in 1.6.0:

[jira] [Commented] (FLINK-8686) Improve basic embedded SQL client

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452521#comment-16452521 ] ASF GitHub Bot commented on FLINK-8686: --- Github user asfgit closed the pull request

[GitHub] flink pull request #5867: [FLINK-8686] [sql-client] Improve basic embedded S...

2018-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5867 ---

[jira] [Commented] (FLINK-8715) RocksDB does not propagate reconfiguration of serializer to the states

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452492#comment-16452492 ] ASF GitHub Bot commented on FLINK-8715: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #5885: [FLINK-8715] Remove usage of StateDescriptor in st...

2018-04-25 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5885#discussion_r184104126 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java --- @@ -185,36 +188,44 @@ public HeapKeyedStateB

[jira] [Commented] (FLINK-8715) RocksDB does not propagate reconfiguration of serializer to the states

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452457#comment-16452457 ] ASF GitHub Bot commented on FLINK-8715: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #5885: [FLINK-8715] Remove usage of StateDescriptor in st...

2018-04-25 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5885#discussion_r184101616 --- Diff: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@

[jira] [Commented] (FLINK-8686) Improve basic embedded SQL client

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452455#comment-16452455 ] ASF GitHub Bot commented on FLINK-8686: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5867: [FLINK-8686] [sql-client] Improve basic embedded S...

2018-04-25 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5867#discussion_r184099775 --- Diff: flink-dist/src/main/resources/flink-conf.yaml --- @@ -229,17 +229,26 @@ web.port: 8081 # Directory to upload completed jobs to. Add this

[jira] [Commented] (FLINK-8686) Improve basic embedded SQL client

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452453#comment-16452453 ] ASF GitHub Bot commented on FLINK-8686: --- Github user twalthr commented on the issue:

[GitHub] flink issue #5867: [FLINK-8686] [sql-client] Improve basic embedded SQL clie...

2018-04-25 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5867 Thank you for the feedback. I will merge the first 5 commits and will open a new PR for an additional configuration file. ---

[jira] [Commented] (FLINK-9138) Enhance BucketingSink to also flush data by time interval

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452451#comment-16452451 ] ASF GitHub Bot commented on FLINK-9138: --- Github user glaksh100 commented on the issu

[jira] [Commented] (FLINK-8686) Improve basic embedded SQL client

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452449#comment-16452449 ] ASF GitHub Bot commented on FLINK-8686: --- Github user twalthr commented on a diff in

[GitHub] flink issue #5860: [FLINK-9138][filesystem-connectors] Implement time based ...

2018-04-25 Thread glaksh100
Github user glaksh100 commented on the issue: https://github.com/apache/flink/pull/5860 @fhueske Thank you for reviewing. I have incorporated the changes that include update to the [documentation](https://ci.apache.org/projects/flink/flink-docs-master/dev/connectors/filesystem_sink.ht

[GitHub] flink pull request #5867: [FLINK-8686] [sql-client] Improve basic embedded S...

2018-04-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5867#discussion_r184098778 --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java --- @@ -91,6 +92,22 @@ public Deployment getD

[jira] [Commented] (FLINK-8715) RocksDB does not propagate reconfiguration of serializer to the states

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452444#comment-16452444 ] ASF GitHub Bot commented on FLINK-8715: --- Github user StefanRRichter commented on a d

[jira] [Commented] (FLINK-8686) Improve basic embedded SQL client

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452445#comment-16452445 ] ASF GitHub Bot commented on FLINK-8686: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #5885: [FLINK-8715] Remove usage of StateDescriptor in st...

2018-04-25 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5885#discussion_r184098081 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java --- @@ -185,36 +188,44 @@ public HeapKeyedStateB

[GitHub] flink pull request #5867: [FLINK-8686] [sql-client] Improve basic embedded S...

2018-04-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5867#discussion_r184098177 --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java --- @@ -91,6 +92,22 @@ public Deployment getD

[jira] [Commented] (FLINK-8686) Improve basic embedded SQL client

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452430#comment-16452430 ] ASF GitHub Bot commented on FLINK-8686: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #5867: [FLINK-8686] [sql-client] Improve basic embedded S...

2018-04-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5867#discussion_r184096235 --- Diff: flink-dist/src/main/resources/flink-conf.yaml --- @@ -229,17 +229,26 @@ web.port: 8081 # Directory to upload completed jobs to. Add this

[jira] [Commented] (FLINK-9229) Fix literal handling in code generation

2018-04-25 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452424#comment-16452424 ] Timo Walther commented on FLINK-9229: - Fixed in 1.4.3: 963f14e266e5347d98388552014c2be

[jira] [Updated] (FLINK-9229) Fix literal handling in code generation

2018-04-25 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-9229: Fix Version/s: 1.4.3 > Fix literal handling in code generation > ---

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-25 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184041497 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -207,112 +241,164 @@ class Aggrega

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452418#comment-16452418 ] ASF GitHub Bot commented on FLINK-8689: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8715) RocksDB does not propagate reconfiguration of serializer to the states

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452421#comment-16452421 ] ASF GitHub Bot commented on FLINK-8715: --- Github user StefanRRichter commented on a d

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452419#comment-16452419 ] ASF GitHub Bot commented on FLINK-8689: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452415#comment-16452415 ] ASF GitHub Bot commented on FLINK-8689: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-25 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184041109 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -207,112 +241,164 @@ class Aggrega

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452412#comment-16452412 ] ASF GitHub Bot commented on FLINK-8689: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452413#comment-16452413 ] ASF GitHub Bot commented on FLINK-8689: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452417#comment-16452417 ] ASF GitHub Bot commented on FLINK-8689: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-25 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184040988 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -207,112 +241,164 @@ class Aggrega

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452409#comment-16452409 ] ASF GitHub Bot commented on FLINK-8689: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452420#comment-16452420 ] ASF GitHub Bot commented on FLINK-8689: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452408#comment-16452408 ] ASF GitHub Bot commented on FLINK-8689: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-25 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184040192 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAccumulator.scala --- @@ -0,0 +1,106 @@ +/*

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-25 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184041605 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -207,112 +241,164 @@ class Aggrega

[GitHub] flink pull request #5885: [FLINK-8715] Remove usage of StateDescriptor in st...

2018-04-25 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5885#discussion_r184093390 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapFoldingState.java --- @@ -103,17 +104,17 @@ public void add(T value) th

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452416#comment-16452416 ] ASF GitHub Bot commented on FLINK-8689: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-25 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184036382 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -151,8 +157,36 @@ class Aggregatio

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-25 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184075230 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -481,14 +622,34 @@ class Aggregati

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452414#comment-16452414 ] ASF GitHub Bot commented on FLINK-8689: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-25 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184048806 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -417,13 +548,23 @@ class Aggregati

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452411#comment-16452411 ] ASF GitHub Bot commented on FLINK-8689: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452410#comment-16452410 ] ASF GitHub Bot commented on FLINK-8689: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-25 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184036079 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -151,8 +157,36 @@ class Aggregatio

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-25 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184037303 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -151,8 +157,36 @@ class Aggregatio

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-25 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184092223 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala --- @@ -50,6 +50,155 @@ class OverWind

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-25 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184085613 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/DistinctAccumulator.scala --- @@ -0,0 +1,106 @@ +/*

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-25 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r184039407 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -207,112 +241,164 @@ class Aggrega

[jira] [Created] (FLINK-9257) End-to-end tests prints "All tests PASS" even if individual test-script returns non-zero exit code

2018-04-25 Thread Florian Schmidt (JIRA)
Florian Schmidt created FLINK-9257: -- Summary: End-to-end tests prints "All tests PASS" even if individual test-script returns non-zero exit code Key: FLINK-9257 URL: https://issues.apache.org/jira/browse/FLINK-92

[jira] [Resolved] (FLINK-9229) Fix literal handling in code generation

2018-04-25 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-9229. - Resolution: Fixed Fix Version/s: 1.5.0 Fixed in 1.6.0: 063aeb17d273554949632338d788597617ad

  1   2   3   4   >