[jira] [Commented] (FLINK-12502) Harden JobMasterTest#testRequestNextInputSplitWithDataSourceFailover

[ https://issues.apache.org/jira/browse/FLINK-12502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848621#comment-16848621 ] leesf commented on FLINK-12502: --- Yes [~gjy] > Harden

[GitHub] [flink] flinkbot commented on issue #8547: [FLINK-12267] Port SimpleSlotTest to new code base

flinkbot commented on issue #8547: [FLINK-12267] Port SimpleSlotTest to new code base URL: https://github.com/apache/flink/pull/8547#issuecomment-496081075 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[jira] [Updated] (FLINK-12267) Port SimpleSlotTest to new code base

[ https://issues.apache.org/jira/browse/FLINK-12267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12267: --- Labels: pull-request-available (was: ) > Port SimpleSlotTest to new code base >

[GitHub] [flink] leesf opened a new pull request #8547: [FLINK-12267] Port SimpleSlotTest to new code base

leesf opened a new pull request #8547: [FLINK-12267] Port SimpleSlotTest to new code base URL: https://github.com/apache/flink/pull/8547 ## What is the purpose of the change *Get rid of Instance in SimpleSlotTest* ## Brief change log Return a new SimpleSlot in

[GitHub] [flink] Aitozi commented on issue #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

Aitozi commented on issue #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#issuecomment-496077999 Hi, @zhijiangW thanks for your detail explanation, I make a conclusion below

[GitHub] [flink] lirui-apache commented on a change in pull request #8536: [FLINK-12568][hive] Implement TableSink and OutputFormat to write Hive tables

lirui-apache commented on a change in pull request #8536: [FLINK-12568][hive] Implement TableSink and OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#discussion_r287640985 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@

[GitHub] [flink] zhijiangW commented on issue #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

zhijiangW commented on issue #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#issuecomment-496069672 Thanks for the confirmation and good suggestions. @pnowojski > > In other

[GitHub] [flink] JingsongLi commented on a change in pull request #8536: [FLINK-12568][hive] Implement TableSink and OutputFormat to write Hive tables

JingsongLi commented on a change in pull request #8536: [FLINK-12568][hive] Implement TableSink and OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#discussion_r287639913 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@

[GitHub] [flink] Aitozi commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox)

Aitozi commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox) URL: https://github.com/apache/flink/pull/8523#discussion_r287637082 ## File path:

[GitHub] [flink] sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add connection and socket timeouts for the blob client

sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add connection and socket timeouts for the blob client URL: https://github.com/apache/flink/pull/8484#discussion_r287633012 ## File path:

[GitHub] [flink] sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add connection and socket timeouts for the blob client

sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add connection and socket timeouts for the blob client URL: https://github.com/apache/flink/pull/8484#discussion_r287633012 ## File path:

[GitHub] [flink] sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add connection and socket timeouts for the blob client

sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add connection and socket timeouts for the blob client URL: https://github.com/apache/flink/pull/8484#discussion_r287638025 ## File path:

[GitHub] [flink] sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add connection and socket timeouts for the blob client

sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add connection and socket timeouts for the blob client URL: https://github.com/apache/flink/pull/8484#discussion_r287637335 ## File path:

[GitHub] [flink] sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add connection and socket timeouts for the blob client

sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add connection and socket timeouts for the blob client URL: https://github.com/apache/flink/pull/8484#discussion_r287635535 ## File path:

[GitHub] [flink] sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add connection and socket timeouts for the blob client

sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add connection and socket timeouts for the blob client URL: https://github.com/apache/flink/pull/8484#discussion_r287635709 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8536: [FLINK-12568][hive] Implement TableSink and OutputFormat to write Hive tables

KurtYoung commented on a change in pull request #8536: [FLINK-12568][hive] Implement TableSink and OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#discussion_r287636685 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@

[GitHub] [flink] sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add connection and socket timeouts for the blob client

sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add connection and socket timeouts for the blob client URL: https://github.com/apache/flink/pull/8484#discussion_r287635709 ## File path:

[GitHub] [flink] sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add connection and socket timeouts for the blob client

sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add connection and socket timeouts for the blob client URL: https://github.com/apache/flink/pull/8484#discussion_r287635535 ## File path:

[GitHub] [flink] lirui-apache commented on a change in pull request #8536: [FLINK-12568][hive] Implement TableSink and OutputFormat to write Hive tables

lirui-apache commented on a change in pull request #8536: [FLINK-12568][hive] Implement TableSink and OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#discussion_r287635284 ## File path:

[GitHub] [flink] lirui-apache commented on a change in pull request #8536: [FLINK-12568][hive] Implement TableSink and OutputFormat to write Hive tables

lirui-apache commented on a change in pull request #8536: [FLINK-12568][hive] Implement TableSink and OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#discussion_r287634504 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@

[GitHub] [flink] lirui-apache commented on a change in pull request #8536: [FLINK-12568][hive] Implement TableSink and OutputFormat to write Hive tables

lirui-apache commented on a change in pull request #8536: [FLINK-12568][hive] Implement TableSink and OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#discussion_r287633517 ## File path:

[GitHub] [flink] lirui-apache commented on a change in pull request #8536: [FLINK-12568][hive] Implement TableSink and OutputFormat to write Hive tables

lirui-apache commented on a change in pull request #8536: [FLINK-12568][hive] Implement TableSink and OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#discussion_r287633298 ## File path:

[GitHub] [flink] sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add connection and socket timeouts for the blob client

sunhaibotb commented on a change in pull request #8484: [FLINK-12547] Add connection and socket timeouts for the blob client URL: https://github.com/apache/flink/pull/8484#discussion_r287633012 ## File path:

[GitHub] [flink] flinkbot commented on issue #8546: [FLINK-12621]. Use MiniCluster instead of JobExecutor

flinkbot commented on issue #8546: [FLINK-12621]. Use MiniCluster instead of JobExecutor URL: https://github.com/apache/flink/pull/8546#issuecomment-496059964 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[GitHub] [flink] zjffdu commented on issue #8546: [FLINK-12621]. Use MiniCluster instead of JobExecutor

zjffdu commented on issue #8546: [FLINK-12621]. Use MiniCluster instead of JobExecutor URL: https://github.com/apache/flink/pull/8546#issuecomment-496059883 @tillrohrmann Could you help review it ? I notice you are original author of `JobExecutor`.

[jira] [Updated] (FLINK-12621) Use MiniCluster instead of JobExecutor

[ https://issues.apache.org/jira/browse/FLINK-12621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12621: --- Labels: pull-request-available (was: ) > Use MiniCluster instead of JobExecutor >

[GitHub] [flink] KurtYoung commented on a change in pull request #8527: [FLINK-12610] [table-planner-blink] Introduce planner rules about aggregate

KurtYoung commented on a change in pull request #8527: [FLINK-12610] [table-planner-blink] Introduce planner rules about aggregate URL: https://github.com/apache/flink/pull/8527#discussion_r287631851 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8527: [FLINK-12610] [table-planner-blink] Introduce planner rules about aggregate

KurtYoung commented on a change in pull request #8527: [FLINK-12610] [table-planner-blink] Introduce planner rules about aggregate URL: https://github.com/apache/flink/pull/8527#discussion_r287631994 ## File path:

[GitHub] [flink] zjffdu opened a new pull request #8546: [FLINK-12621]. Use MiniCluster instead of JobExecutor

zjffdu opened a new pull request #8546: [FLINK-12621]. Use MiniCluster instead of JobExecutor URL: https://github.com/apache/flink/pull/8546 ## What is the purpose of the change This is a refactoring PR which remove `JobExecutor` and use `MiniCluster` instead. `JobExecutor` is

[GitHub] [flink] KurtYoung commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables

KurtYoung commented on a change in pull request #8522: [FLINK-12572][hive]Implement TableSource and InputFormat to read Hive tables URL: https://github.com/apache/flink/pull/8522#discussion_r287631347 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@ -58,6

[GitHub] [flink] KurtYoung commented on a change in pull request #8536: [FLINK-12568][hive] Implement TableSink and OutputFormat to write Hive tables

KurtYoung commented on a change in pull request #8536: [FLINK-12568][hive] Implement TableSink and OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#discussion_r287631136 ## File path: flink-connectors/flink-connector-hive/pom.xml ## @@

[GitHub] [flink] lirui-apache commented on a change in pull request #8536: [FLINK-12568][hive] Implement TableSink and OutputFormat to write Hive tables

lirui-apache commented on a change in pull request #8536: [FLINK-12568][hive] Implement TableSink and OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#discussion_r287631199 ## File path:

[GitHub] [flink] zjffdu commented on a change in pull request #8533: [FLINK-12596][scala-shell] Unify all kinds of cluster via ClusterClient in FlinkShell

zjffdu commented on a change in pull request #8533: [FLINK-12596][scala-shell] Unify all kinds of cluster via ClusterClient in FlinkShell URL: https://github.com/apache/flink/pull/8533#discussion_r287630879 ## File path:

[GitHub] [flink] zjffdu commented on a change in pull request #8533: [FLINK-12596][scala-shell] Unify all kinds of cluster via ClusterClient in FlinkShell

zjffdu commented on a change in pull request #8533: [FLINK-12596][scala-shell] Unify all kinds of cluster via ClusterClient in FlinkShell URL: https://github.com/apache/flink/pull/8533#discussion_r287630879 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API

zhijiangW commented on a change in pull request #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API URL: https://github.com/apache/flink/pull/8485#discussion_r287630954 ## File path:

[GitHub] [flink] lirui-apache commented on a change in pull request #8536: [FLINK-12568][hive] Implement TableSink and OutputFormat to write Hive tables

lirui-apache commented on a change in pull request #8536: [FLINK-12568][hive] Implement TableSink and OutputFormat to write Hive tables URL: https://github.com/apache/flink/pull/8536#discussion_r287630791 ## File path:

[jira] [Created] (FLINK-12629) Add integration test for scala shell in yarn mode

Jeff Zhang created FLINK-12629: -- Summary: Add integration test for scala shell in yarn mode Key: FLINK-12629 URL: https://issues.apache.org/jira/browse/FLINK-12629 Project: Flink Issue Type:

[jira] [Assigned] (FLINK-12629) Add integration test for scala shell in yarn mode

[ https://issues.apache.org/jira/browse/FLINK-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Zhang reassigned FLINK-12629: -- Assignee: Jeff Zhang > Add integration test for scala shell in yarn mode >

[jira] [Resolved] (FLINK-12167) ClusterClient doesn't unset the context class loader after program run

[ https://issues.apache.org/jira/browse/FLINK-12167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abdul Qadeer resolved FLINK-12167. -- Resolution: Fixed Fix Version/s: 1.9.0 > ClusterClient doesn't unset the context class

[GitHub] [flink] sunjincheng121 edited a comment on issue #8474: [FLINK-12409][python] Adds from_elements in TableEnvironment

sunjincheng121 edited a comment on issue #8474: [FLINK-12409][python] Adds from_elements in TableEnvironment URL: https://github.com/apache/flink/pull/8474#issuecomment-496041963 The CI throws `TypeError` for a python test case. I have been restarted it. And make sure all the test cases

[GitHub] [flink] sunjincheng121 commented on issue #8474: [FLINK-12409][python] Adds from_elements in TableEnvironment

sunjincheng121 commented on issue #8474: [FLINK-12409][python] Adds from_elements in TableEnvironment URL: https://github.com/apache/flink/pull/8474#issuecomment-496041963 The CI throws `TypeError` for a python test case. I have been restarted it. And make sure all the test cases work

[jira] [Commented] (FLINK-5243) Implement an example for BipartiteGraph

[ https://issues.apache.org/jira/browse/FLINK-5243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848548#comment-16848548 ] Greg Hogan commented on FLINK-5243: --- [~jasleenk22], new contributions are always welcomed! Do you have

[GitHub] [flink] azagrebin commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

azagrebin commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r287611055 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

azagrebin commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r287609955 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java

[jira] [Created] (FLINK-12628) Check test failure if partition has no consumers in Execution.getPartitionMaxParallelism

Andrey Zagrebin created FLINK-12628: --- Summary: Check test failure if partition has no consumers in Execution.getPartitionMaxParallelism Key: FLINK-12628 URL: https://issues.apache.org/jira/browse/FLINK-12628

[GitHub] [flink] azagrebin commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

azagrebin commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface URL: https://github.com/apache/flink/pull/8362#discussion_r287609890 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java ##

[GitHub] [flink] Aitozi commented on a change in pull request #8467: [FLINK-12535][network] Make CheckpointBarrierHandler non-blocking

Aitozi commented on a change in pull request #8467: [FLINK-12535][network] Make CheckpointBarrierHandler non-blocking URL: https://github.com/apache/flink/pull/8467#discussion_r287607989 ## File path:

[GitHub] [flink] flinkbot commented on issue #8545: [FLINK-12520] Support to provide fully-qualified domain host name in TaskManagerMetricGroup

flinkbot commented on issue #8545: [FLINK-12520] Support to provide fully-qualified domain host name in TaskManagerMetricGroup URL: https://github.com/apache/flink/pull/8545#issuecomment-496018362 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help

[jira] [Updated] (FLINK-12520) Support to provide fully-qualified domain host name in TaskManagerMetricGroup

[ https://issues.apache.org/jira/browse/FLINK-12520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12520: --- Labels: pull-request-available (was: ) > Support to provide fully-qualified domain host

[GitHub] [flink] Myasuka opened a new pull request #8545: [FLINK-12520] Support to provide fully-qualified domain host name in TaskManagerMetricGroup

Myasuka opened a new pull request #8545: [FLINK-12520] Support to provide fully-qualified domain host name in TaskManagerMetricGroup URL: https://github.com/apache/flink/pull/8545 ## What is the purpose of the change Inspired from [Chinese

[GitHub] [flink] Aitozi commented on a change in pull request #8467: [FLINK-12535][network] Make CheckpointBarrierHandler non-blocking

Aitozi commented on a change in pull request #8467: [FLINK-12535][network] Make CheckpointBarrierHandler non-blocking URL: https://github.com/apache/flink/pull/8467#discussion_r287607756 ## File path:

[GitHub] [flink] Aitozi commented on a change in pull request #8467: [FLINK-12535][network] Make CheckpointBarrierHandler non-blocking

Aitozi commented on a change in pull request #8467: [FLINK-12535][network] Make CheckpointBarrierHandler non-blocking URL: https://github.com/apache/flink/pull/8467#discussion_r287607135 ## File path:

[GitHub] [flink] Aitozi commented on a change in pull request #8467: [FLINK-12535][network] Make CheckpointBarrierHandler non-blocking

Aitozi commented on a change in pull request #8467: [FLINK-12535][network] Make CheckpointBarrierHandler non-blocking URL: https://github.com/apache/flink/pull/8467#discussion_r287607135 ## File path:

[GitHub] [flink] Aitozi commented on a change in pull request #8467: [FLINK-12535][network] Make CheckpointBarrierHandler non-blocking

Aitozi commented on a change in pull request #8467: [FLINK-12535][network] Make CheckpointBarrierHandler non-blocking URL: https://github.com/apache/flink/pull/8467#discussion_r287606004 ## File path:

[GitHub] [flink] Aitozi commented on a change in pull request #8467: [FLINK-12535][network] Make CheckpointBarrierHandler non-blocking

Aitozi commented on a change in pull request #8467: [FLINK-12535][network] Make CheckpointBarrierHandler non-blocking URL: https://github.com/apache/flink/pull/8467#discussion_r287603157 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/AsyncDataInput.java

[jira] [Closed] (FLINK-12574) using sink StreamingFileSink files are overwritten when resuming application causing data loss

[ https://issues.apache.org/jira/browse/FLINK-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yitzchak lieberman closed FLINK-12574. -- Resolution: Not A Bug > using sink StreamingFileSink files are overwritten when

[jira] [Commented] (FLINK-12574) using sink StreamingFileSink files are overwritten when resuming application causing data loss

[ https://issues.apache.org/jira/browse/FLINK-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848360#comment-16848360 ] yitzchak lieberman commented on FLINK-12574: you are right, my bad. closing the bug... >