[GitHub] [flink] curcur edited a comment on pull request #11725: [FLINK-15670][API] Provide a Kafka Source/Sink pair as KafkaShuffle

2020-04-26 Thread GitBox
curcur edited a comment on pull request #11725: URL: https://github.com/apache/flink/pull/11725#issuecomment-619703591 Sorry to write this much again. These are all good questions that I think is more clear to answer in a systematic way :-). Let's chat in detail this afternoon.

[GitHub] [flink] xintongsong commented on a change in pull request #11916: [FLINK-17390][yarn] Fix Hadoop 2.10+ compatibility for WorkerSpecContainerResourceAdapter.

2020-04-26 Thread GitBox
xintongsong commented on a change in pull request #11916: URL: https://github.com/apache/flink/pull/11916#discussion_r415529655 ## File path: flink-yarn/src/test/java/org/apache/flink/yarn/WorkerSpecContainerResourceAdapterTest.java ## @@ -194,6 +198,41 @@ public void

[GitHub] [flink] flinkbot edited a comment on pull request #11839: [FLINK-17166][dist] Modify the log4j-console.properties to also output logs into the files for WebUI

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11839: URL: https://github.com/apache/flink/pull/11839#issuecomment-617042256 ## CI report: * ab5e8324f0ace63d1e5b3f292dd6d517b056fd21 UNKNOWN * 6e097b629bafde50b88d261cd856d624cf6f89c5 Travis:

[jira] [Commented] (FLINK-15669) SQL client can't cancel flink job

2020-04-26 Thread Yu Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093025#comment-17093025 ] Yu Li commented on FLINK-15669: --- Since the fix is still good and only test reverted, I think it makes

[GitHub] [flink] flinkbot edited a comment on pull request #11897: [FLINK-16104] Translate "Streaming Aggregation" page of "Table API & SQL" into Chinese

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11897: URL: https://github.com/apache/flink/pull/11897#issuecomment-618812841 ## CI report: * 1cd0f11272e1d4013f2f09a328c8777ae32e5470 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/162046977) Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11916: [FLINK-17390][yarn] Fix Hadoop 2.10+ compatibility for WorkerSpecContainerResourceAdapter.

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11916: URL: https://github.com/apache/flink/pull/11916#issuecomment-619702040 ## CI report: * 92fb1fc93dd94819389bdedf93a13f2dc31397c7 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/162145331) Azure:

[jira] [Commented] (FLINK-17338) LocalExecutorITCase.testBatchQueryCancel test timeout

2020-04-26 Thread Yu Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093023#comment-17093023 ] Yu Li commented on FLINK-17338: --- Thanks for the analysis and clarification [~aljoscha] >

[GitHub] [flink] xintongsong commented on a change in pull request #11916: [FLINK-17390][yarn] Fix Hadoop 2.10+ compatibility for WorkerSpecContainerResourceAdapter.

2020-04-26 Thread GitBox
xintongsong commented on a change in pull request #11916: URL: https://github.com/apache/flink/pull/11916#discussion_r415523696 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/WorkerSpecContainerResourceAdapter.java ## @@ -71,52 +72,65 @@ }

[GitHub] [flink] xintongsong commented on a change in pull request #11916: [FLINK-17390][yarn] Fix Hadoop 2.10+ compatibility for WorkerSpecContainerResourceAdapter.

2020-04-26 Thread GitBox
xintongsong commented on a change in pull request #11916: URL: https://github.com/apache/flink/pull/11916#discussion_r415523468 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/WorkerSpecContainerResourceAdapter.java ## @@ -71,52 +72,65 @@ }

[GitHub] [flink] xintongsong commented on a change in pull request #11916: [FLINK-17390][yarn] Fix Hadoop 2.10+ compatibility for WorkerSpecContainerResourceAdapter.

2020-04-26 Thread GitBox
xintongsong commented on a change in pull request #11916: URL: https://github.com/apache/flink/pull/11916#discussion_r415522836 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/WorkerSpecContainerResourceAdapter.java ## @@ -71,52 +72,65 @@ }

[jira] [Created] (FLINK-17399) CsvTableSink should also extend from OverwritableTableSink

2020-04-26 Thread godfrey he (Jira)
godfrey he created FLINK-17399: -- Summary: CsvTableSink should also extend from OverwritableTableSink Key: FLINK-17399 URL: https://issues.apache.org/jira/browse/FLINK-17399 Project: Flink Issue

[GitHub] [flink] flinkbot edited a comment on pull request #11916: [FLINK-17390][yarn] Fix Hadoop 2.10+ compatibility for WorkerSpecContainerResourceAdapter.

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11916: URL: https://github.com/apache/flink/pull/11916#issuecomment-619702040 ## CI report: * 92fb1fc93dd94819389bdedf93a13f2dc31397c7 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162145331) Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11915: [FLINK-17395][python] Add the sign and sha logic for PyFlink wheel packages

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11915: URL: https://github.com/apache/flink/pull/11915#issuecomment-619697532 ## CI report: * dc1358b12a72c8fb87289083c585dd8345f41d86 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162143714) Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11897: [FLINK-16104] Translate "Streaming Aggregation" page of "Table API & SQL" into Chinese

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11897: URL: https://github.com/apache/flink/pull/11897#issuecomment-618812841 ## CI report: * 1cd0f11272e1d4013f2f09a328c8777ae32e5470 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/162046977) Azure:

[GitHub] [flink] KarmaGYZ commented on a change in pull request #11916: [FLINK-17390][yarn] Fix Hadoop 2.10+ compatibility for WorkerSpecContainerResourceAdapter.

2020-04-26 Thread GitBox
KarmaGYZ commented on a change in pull request #11916: URL: https://github.com/apache/flink/pull/11916#discussion_r415511862 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/WorkerSpecContainerResourceAdapter.java ## @@ -71,52 +72,65 @@ }

[GitHub] [flink] dianfu commented on a change in pull request #11915: [FLINK-17395][python] Add the sign and sha logic for PyFlink wheel packages

2020-04-26 Thread GitBox
dianfu commented on a change in pull request #11915: URL: https://github.com/apache/flink/pull/11915#discussion_r415511471 ## File path: tools/releasing/create_binary_release.sh ## @@ -109,14 +112,30 @@ make_python_release() { cp ${pyflink_actual_name}

[GitHub] [flink] flinkbot edited a comment on pull request #11876: [FLINK-17334] HIVE UDF BUGFIX

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11876: URL: https://github.com/apache/flink/pull/11876#issuecomment-618262946 ## CI report: * 2a7b13805feb162cf26a374609d6e03af6a58990 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/162145298) Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11839: [FLINK-17166][dist] Modify the log4j-console.properties to also output logs into the files for WebUI

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11839: URL: https://github.com/apache/flink/pull/11839#issuecomment-617042256 ## CI report: * ab5e8324f0ace63d1e5b3f292dd6d517b056fd21 UNKNOWN * 6e097b629bafde50b88d261cd856d624cf6f89c5 Travis:

[GitHub] [flink] flinkbot edited a comment on pull request #11351: [FLINK-16404][runtime] Avoid caching buffers for blocked input channels before barrier alignment

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11351: URL: https://github.com/apache/flink/pull/11351#issuecomment-596351676 ## CI report: * 715889a35cfcc3aaf1b17f39dadaa86f755cc75d UNKNOWN * 548b22258f5e87fd53b45c7f4bb6de40bfd4e6d2 UNKNOWN *

[GitHub] [flink] xintongsong commented on a change in pull request #11916: [FLINK-17390][yarn] Fix Hadoop 2.10+ compatibility for WorkerSpecContainerResourceAdapter.

2020-04-26 Thread GitBox
xintongsong commented on a change in pull request #11916: URL: https://github.com/apache/flink/pull/11916#discussion_r415508834 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/WorkerSpecContainerResourceAdapter.java ## @@ -128,12 +142,61 @@ private int

[jira] [Commented] (FLINK-17224) Precision of TIME type does not work correctly

2020-04-26 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092992#comment-17092992 ] Danny Chen commented on FLINK-17224: [~dwysakowicz] I have fixed the TIME type conversion between

[GitHub] [flink] godfreyhe commented on a change in pull request #11862: [FLINK-17251] [table] supports INSERT statement in TableEnvironment#executeSql and Table#executeInsert api

2020-04-26 Thread GitBox
godfreyhe commented on a change in pull request #11862: URL: https://github.com/apache/flink/pull/11862#discussion_r415500318 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Table.java ## @@ -1113,4 +1113,61 @@ * */

[GitHub] [flink] flinkbot edited a comment on pull request #11916: [FLINK-17390][yarn] Fix Hadoop 2.10+ compatibility for WorkerSpecContainerResourceAdapter.

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11916: URL: https://github.com/apache/flink/pull/11916#issuecomment-619702040 ## CI report: * 92fb1fc93dd94819389bdedf93a13f2dc31397c7 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162145331) Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11876: [FLINK-17334] HIVE UDF BUGFIX

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11876: URL: https://github.com/apache/flink/pull/11876#issuecomment-618262946 ## CI report: * 5dc081058c881b0165b44c37e53607ac891814f5 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161774926) Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11791: [FLINK-17210][sql-parser][hive] Implement database DDLs for Hive dialect

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11791: URL: https://github.com/apache/flink/pull/11791#issuecomment-615162346 ## CI report: * a6a3a9e51fd9ba484d1ab4ccd0646dcacc0692ff Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162072493) Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11839: [FLINK-17166][dist] Modify the log4j-console.properties to also output logs into the files for WebUI

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11839: URL: https://github.com/apache/flink/pull/11839#issuecomment-617042256 ## CI report: * 5a26fbb56d996236c296328a6d673bc01982be5f Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/161221412) Azure:

[GitHub] [flink] curcur edited a comment on pull request #11725: [FLINK-15670][API] Provide a Kafka Source/Sink pair as KafkaShuffle

2020-04-26 Thread GitBox
curcur edited a comment on pull request #11725: URL: https://github.com/apache/flink/pull/11725#issuecomment-619703591 Sorry to write this much again. These are all good questions that I think is more clear to answer in a systematic way :-). Let's chat in detail this afternoon.

[GitHub] [flink] curcur edited a comment on pull request #11725: [FLINK-15670][API] Provide a Kafka Source/Sink pair as KafkaShuffle

2020-04-26 Thread GitBox
curcur edited a comment on pull request #11725: URL: https://github.com/apache/flink/pull/11725#issuecomment-619703591 Sorry to write this much again. These are all good questions that I think is more clear to answer in a systematic way :-). Let's chat in detail this afternoon.

[GitHub] [flink] curcur edited a comment on pull request #11725: [FLINK-15670][API] Provide a Kafka Source/Sink pair as KafkaShuffle

2020-04-26 Thread GitBox
curcur edited a comment on pull request #11725: URL: https://github.com/apache/flink/pull/11725#issuecomment-619703591 Sorry to write this much again. These are all good questions that I think is more clear to answer in a systematic way :-). Let's chat in detail this afternoon.

[GitHub] [flink] curcur edited a comment on pull request #11725: [FLINK-15670][API] Provide a Kafka Source/Sink pair as KafkaShuffle

2020-04-26 Thread GitBox
curcur edited a comment on pull request #11725: URL: https://github.com/apache/flink/pull/11725#issuecomment-619703591 Sorry to write this much again. These are all good questions that I think is more clear to answer in a systematic way :-). Let's chat in detail this afternoon.

[GitHub] [flink] curcur edited a comment on pull request #11725: [FLINK-15670][API] Provide a Kafka Source/Sink pair as KafkaShuffle

2020-04-26 Thread GitBox
curcur edited a comment on pull request #11725: URL: https://github.com/apache/flink/pull/11725#issuecomment-619703591 Sorry to write this much again. These are all good questions that I think is more clear to answer in a systematic way :-). Let's chat in detail this afternoon.

[GitHub] [flink] curcur edited a comment on pull request #11725: [FLINK-15670][API] Provide a Kafka Source/Sink pair as KafkaShuffle

2020-04-26 Thread GitBox
curcur edited a comment on pull request #11725: URL: https://github.com/apache/flink/pull/11725#issuecomment-619703591 1. Change to `SinkFunction`. By "coordination", do you mean that other changes are also made upon `SinkFunction` and may need coordination? I've expected

[GitHub] [flink] curcur edited a comment on pull request #11725: [FLINK-15670][API] Provide a Kafka Source/Sink pair as KafkaShuffle

2020-04-26 Thread GitBox
curcur edited a comment on pull request #11725: URL: https://github.com/apache/flink/pull/11725#issuecomment-619703591 ## 1. Change to `SinkFunction`. By "coordination", do you mean that other changes are also made upon `SinkFunction` and may need coordination? I've expected

[GitHub] [flink] curcur edited a comment on pull request #11725: [FLINK-15670][API] Provide a Kafka Source/Sink pair as KafkaShuffle

2020-04-26 Thread GitBox
curcur edited a comment on pull request #11725: URL: https://github.com/apache/flink/pull/11725#issuecomment-619703591 ### 1. Change to `SinkFunction`. By "coordination", do you mean that other changes are also made upon `SinkFunction` and may need coordination? I've expected

[GitHub] [flink] curcur commented on pull request #11725: [FLINK-15670][API] Provide a Kafka Source/Sink pair as KafkaShuffle

2020-04-26 Thread GitBox
curcur commented on pull request #11725: URL: https://github.com/apache/flink/pull/11725#issuecomment-619703591 # 1. Change to `SinkFunction`. By "coordination", do you mean that other changes are also made upon `SinkFunction` and may need coordination? I've expected reviewers

[GitHub] [flink] flinkbot edited a comment on pull request #11876: [FLINK-17334] HIVE UDF BUGFIX

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11876: URL: https://github.com/apache/flink/pull/11876#issuecomment-618262946 ## CI report: * 5dc081058c881b0165b44c37e53607ac891814f5 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161774926) Azure:

[GitHub] [flink] flinkbot commented on pull request #11916: [FLINK-17390][yarn] Fix Hadoop 2.10+ compatibility for WorkerSpecContainerResourceAdapter.

2020-04-26 Thread GitBox
flinkbot commented on pull request #11916: URL: https://github.com/apache/flink/pull/11916#issuecomment-619702040 ## CI report: * 92fb1fc93dd94819389bdedf93a13f2dc31397c7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #11915: [FLINK-17395][python] Add the sign and sha logic for PyFlink wheel packages

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11915: URL: https://github.com/apache/flink/pull/11915#issuecomment-619697532 ## CI report: * dc1358b12a72c8fb87289083c585dd8345f41d86 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162143714) Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11791: [FLINK-17210][sql-parser][hive] Implement database DDLs for Hive dialect

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11791: URL: https://github.com/apache/flink/pull/11791#issuecomment-615162346 ## CI report: * a6a3a9e51fd9ba484d1ab4ccd0646dcacc0692ff Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162072493) Azure:

[GitHub] [flink] KarmaGYZ commented on a change in pull request #11916: [FLINK-17390][yarn] Fix Hadoop 2.10+ compatibility for WorkerSpecContainerResourceAdapter.

2020-04-26 Thread GitBox
KarmaGYZ commented on a change in pull request #11916: URL: https://github.com/apache/flink/pull/11916#discussion_r415494145 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/WorkerSpecContainerResourceAdapter.java ## @@ -128,12 +142,61 @@ private int

[GitHub] [flink] wangyang0918 edited a comment on pull request #11839: [FLINK-17166][dist] Modify the log4j-console.properties to also output logs into the files for WebUI

2020-04-26 Thread GitBox
wangyang0918 edited a comment on pull request #11839: URL: https://github.com/apache/flink/pull/11839#issuecomment-619471329 @zentol Thanks a lot for your review. I agree with you that introducing the stream redirections may take some problems. So we need to be very careful to

[GitHub] [flink] godfreyhe commented on a change in pull request #11862: [FLINK-17251] [table] supports INSERT statement in TableEnvironment#executeSql and Table#executeInsert api

2020-04-26 Thread GitBox
godfreyhe commented on a change in pull request #11862: URL: https://github.com/apache/flink/pull/11862#discussion_r415491412 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentInternal.java ## @@ -0,0 +1,56 @@ +/*

[GitHub] [flink] godfreyhe commented on a change in pull request #11862: [FLINK-17251] [table] supports INSERT statement in TableEnvironment#executeSql and Table#executeInsert api

2020-04-26 Thread GitBox
godfreyhe commented on a change in pull request #11862: URL: https://github.com/apache/flink/pull/11862#discussion_r415490512 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentInternal.java ## @@ -0,0 +1,56 @@ +/*

[GitHub] [flink] flinkbot commented on pull request #11915: [FLINK-17395][python] Add the sign and sha logic for PyFlink wheel packages

2020-04-26 Thread GitBox
flinkbot commented on pull request #11915: URL: https://github.com/apache/flink/pull/11915#issuecomment-619697532 ## CI report: * dc1358b12a72c8fb87289083c585dd8345f41d86 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #11860: [FLINK-17311][python][AZP] Add the logic of compressed in tgz before uploading artifacts

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11860: URL: https://github.com/apache/flink/pull/11860#issuecomment-617666482 ## CI report: * c94cfb4fb285019fc788b683f006b3bd233da1e0 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/162139324) Azure:

[GitHub] [flink] lirui-apache commented on a change in pull request #11791: [FLINK-17210][sql-parser][hive] Implement database DDLs for Hive dialect

2020-04-26 Thread GitBox
lirui-apache commented on a change in pull request #11791: URL: https://github.com/apache/flink/pull/11791#discussion_r415487853 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/delegation/FlinkSqlParserImplFactory.java ## @@

[GitHub] [flink] Ruan-Xin commented on pull request #11876: [FLINK-17334] HIVE UDF BUGFIX

2020-04-26 Thread GitBox
Ruan-Xin commented on pull request #11876: URL: https://github.com/apache/flink/pull/11876#issuecomment-619694919 @flinkbot run travis re-run the last Travis build @flinkbot run azure re-run the last Azure build This is

[jira] [Updated] (FLINK-17398) Filesystem support flexible path reading

2020-04-26 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-17398: - Summary: Filesystem support flexible path reading (was: Support flexible path reading) >

[jira] [Created] (FLINK-17398) Support flexible path reading

2020-04-26 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-17398: Summary: Support flexible path reading Key: FLINK-17398 URL: https://issues.apache.org/jira/browse/FLINK-17398 Project: Flink Issue Type: Sub-task

[GitHub] [flink] godfreyhe commented on a change in pull request #11892: [FLINK-17112][table] Support DESCRIBE statement in Flink SQL

2020-04-26 Thread GitBox
godfreyhe commented on a change in pull request #11892: URL: https://github.com/apache/flink/pull/11892#discussion_r415486982 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/internal/TableEnvImpl.scala ## @@ -721,6 +721,15 @@ abstract

[GitHub] [flink] flinkbot commented on pull request #11916: [FLINK-17390][yarn] Fix Hadoop 2.10+ compatibility for WorkerSpecContainerResourceAdapter.

2020-04-26 Thread GitBox
flinkbot commented on pull request #11916: URL: https://github.com/apache/flink/pull/11916#issuecomment-619694310 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Created] (FLINK-17397) Filesystem support lookup table source

2020-04-26 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-17397: Summary: Filesystem support lookup table source Key: FLINK-17397 URL: https://issues.apache.org/jira/browse/FLINK-17397 Project: Flink Issue Type: Sub-task

[jira] [Updated] (FLINK-17390) Container resource cannot be mapped on Hadoop 2.10+

2020-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-17390: --- Labels: pull-request-available (was: ) > Container resource cannot be mapped on Hadoop

[GitHub] [flink] xintongsong opened a new pull request #11916: [FLINK-17390][yarn] Fix Hadoop 2.10+ compatibility for WorkerSpecContainerResourceAdapter.

2020-04-26 Thread GitBox
xintongsong opened a new pull request #11916: URL: https://github.com/apache/flink/pull/11916 ## What is the purpose of the change This PR fix the problem that requested/allocated containers cannot be matched on Hadoop 2.10+. The problem is due to relying on the hash code of

[GitHub] [flink] docete commented on a change in pull request #11892: [FLINK-17112][table] Support DESCRIBE statement in Flink SQL

2020-04-26 Thread GitBox
docete commented on a change in pull request #11892: URL: https://github.com/apache/flink/pull/11892#discussion_r415484898 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/internal/TableEnvImpl.scala ## @@ -721,6 +721,15 @@ abstract

[GitHub] [flink] flinkbot commented on pull request #11915: [FLINK-17395][python] Add the sign and sha logic for PyFlink wheel packages

2020-04-26 Thread GitBox
flinkbot commented on pull request #11915: URL: https://github.com/apache/flink/pull/11915#issuecomment-619691350 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-17146) Support conversion between PyFlink Table and Pandas DataFrame

2020-04-26 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-17146: Fix Version/s: 1.11.0 > Support conversion between PyFlink Table and Pandas DataFrame >

[jira] [Updated] (FLINK-17395) Add the sign and sha logic for PyFlink wheel packages

2020-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-17395: --- Labels: pull-request-available (was: ) > Add the sign and sha logic for PyFlink wheel

[GitHub] [flink] HuangXingBo opened a new pull request #11915: [FLINK-17395][python] Add the sign and sha logic for PyFlink wheel packages

2020-04-26 Thread GitBox
HuangXingBo opened a new pull request #11915: URL: https://github.com/apache/flink/pull/11915 ## What is the purpose of the change *This pull request will Add the sign and sha logic for PyFlink wheel packages* ## Brief change log - *Add the sign and sha logic for

[jira] [Created] (FLINK-17396) Support SHOW MODULES in Flink SQL

2020-04-26 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-17396: --- Summary: Support SHOW MODULES in Flink SQL Key: FLINK-17396 URL: https://issues.apache.org/jira/browse/FLINK-17396 Project: Flink Issue Type: New Feature

[GitHub] [flink] flinkbot edited a comment on pull request #11860: [FLINK-17311][python][AZP] Add the logic of compressed in tgz before uploading artifacts

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11860: URL: https://github.com/apache/flink/pull/11860#issuecomment-617666482 ## CI report: * 714c695075126b455af4b8cf4d04875d597342a2 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161799608) Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11839: [FLINK-17166][dist] Modify the log4j-console.properties to also output logs into the files for WebUI

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11839: URL: https://github.com/apache/flink/pull/11839#issuecomment-617042256 ## CI report: * 5a26fbb56d996236c296328a6d673bc01982be5f Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/161221412) Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11351: [FLINK-16404][runtime] Avoid caching buffers for blocked input channels before barrier alignment

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11351: URL: https://github.com/apache/flink/pull/11351#issuecomment-596351676 ## CI report: * 715889a35cfcc3aaf1b17f39dadaa86f755cc75d UNKNOWN * 548b22258f5e87fd53b45c7f4bb6de40bfd4e6d2 UNKNOWN *

[jira] [Updated] (FLINK-17311) Add the logic of compressed in tgz before uploading artifacts

2020-04-26 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huang Xingbo updated FLINK-17311: - Summary: Add the logic of compressed in tgz before uploading artifacts (was: Add executable

[jira] [Updated] (FLINK-17311) Add executable permissions to the script in the wheel package

2020-04-26 Thread Huang Xingbo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huang Xingbo updated FLINK-17311: - Description:  Script files in packages downloaded from Azure will lose executable permissions

[GitHub] [flink] godfreyhe commented on a change in pull request #11892: [FLINK-17112][table] Support DESCRIBE statement in Flink SQL

2020-04-26 Thread GitBox
godfreyhe commented on a change in pull request #11892: URL: https://github.com/apache/flink/pull/11892#discussion_r415473253 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/internal/TableEnvImpl.scala ## @@ -721,6 +721,15 @@ abstract

[jira] [Created] (FLINK-17395) Add the sign and sha logic for PyFlink wheel packages

2020-04-26 Thread Huang Xingbo (Jira)
Huang Xingbo created FLINK-17395: Summary: Add the sign and sha logic for PyFlink wheel packages Key: FLINK-17395 URL: https://issues.apache.org/jira/browse/FLINK-17395 Project: Flink Issue

[GitHub] [flink] flinkbot edited a comment on pull request #11860: [FLINK-17311][python] Add executable permissions to the script in the wheel package

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11860: URL: https://github.com/apache/flink/pull/11860#issuecomment-617666482 ## CI report: * 714c695075126b455af4b8cf4d04875d597342a2 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161799608) Azure:

[jira] [Updated] (FLINK-17311) Add executable permissions to the script in the wheel package

2020-04-26 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-17311: Component/s: Build System / Azure Pipelines > Add executable permissions to the script in the wheel

[GitHub] [flink] flinkbot edited a comment on pull request #11839: [FLINK-17166][dist] Modify the log4j-console.properties to also output logs into the files for WebUI

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11839: URL: https://github.com/apache/flink/pull/11839#issuecomment-617042256 ## CI report: * 5a26fbb56d996236c296328a6d673bc01982be5f Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/161221412) Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11351: [FLINK-16404][runtime] Avoid caching buffers for blocked input channels before barrier alignment

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11351: URL: https://github.com/apache/flink/pull/11351#issuecomment-596351676 ## CI report: * 715889a35cfcc3aaf1b17f39dadaa86f755cc75d UNKNOWN * 548b22258f5e87fd53b45c7f4bb6de40bfd4e6d2 UNKNOWN *

[GitHub] [flink] danny0405 commented on a change in pull request #11791: [FLINK-17210][sql-parser][hive] Implement database DDLs for Hive dialect

2020-04-26 Thread GitBox
danny0405 commented on a change in pull request #11791: URL: https://github.com/apache/flink/pull/11791#discussion_r415475644 ## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/delegation/FlinkSqlParserImplFactory.java ## @@ -0,0

[GitHub] [flink] danny0405 commented on a change in pull request #11791: [FLINK-17210][sql-parser][hive] Implement database DDLs for Hive dialect

2020-04-26 Thread GitBox
danny0405 commented on a change in pull request #11791: URL: https://github.com/apache/flink/pull/11791#discussion_r415474853 ## File path: flink-table/flink-table-planner-blink/pom.xml ## @@ -100,6 +100,18 @@ under the License. +

[GitHub] [flink] leonardBang commented on a change in pull request #11909: [FLINK-16103] Translate "Configuration" page of "Table API & SQL" int…

2020-04-26 Thread GitBox
leonardBang commented on a change in pull request #11909: URL: https://github.com/apache/flink/pull/11909#discussion_r415465118 ## File path: docs/dev/table/config.zh.md ## @@ -22,29 +22,22 @@ specific language governing permissions and limitations under the License. -->

[GitHub] [flink] leonardBang commented on a change in pull request #11909: [FLINK-16103] Translate "Configuration" page of "Table API & SQL" int…

2020-04-26 Thread GitBox
leonardBang commented on a change in pull request #11909: URL: https://github.com/apache/flink/pull/11909#discussion_r415465664 ## File path: docs/dev/table/config.zh.md ## @@ -22,29 +22,22 @@ specific language governing permissions and limitations under the License. -->

[jira] [Updated] (FLINK-17392) enable configuring minicluster resources in Flink SQL in IDE

2020-04-26 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young updated FLINK-17392: --- Fix Version/s: (was: 1.11.0) > enable configuring minicluster resources in Flink SQL in IDE >

[jira] [Commented] (FLINK-17392) enable configuring minicluster resources in Flink SQL in IDE

2020-04-26 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092930#comment-17092930 ] Jingsong Lee commented on FLINK-17392: -- I don't fully understand the problem, > users cannot run

[jira] [Created] (FLINK-17394) Add RemoteEnvironment and RemoteStreamEnvironment in Python

2020-04-26 Thread Huang Xingbo (Jira)
Huang Xingbo created FLINK-17394: Summary: Add RemoteEnvironment and RemoteStreamEnvironment in Python Key: FLINK-17394 URL: https://issues.apache.org/jira/browse/FLINK-17394 Project: Flink

[jira] [Comment Edited] (FLINK-17392) enable configuring minicluster resources in Flink SQL in IDE

2020-04-26 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092930#comment-17092930 ] Jingsong Lee edited comment on FLINK-17392 at 4/27/20, 2:08 AM: Hi

[jira] [Commented] (FLINK-17289) Translate tutorials/etl.md to chinese

2020-04-26 Thread Li Ying (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092931#comment-17092931 ] Li Ying commented on FLINK-17289: - Thank you. I will finish it this week. > Translate tutorials/etl.md

[jira] [Comment Edited] (FLINK-17392) enable configuring minicluster resources in Flink SQL in IDE

2020-04-26 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092914#comment-17092914 ] Jark Wu edited comment on FLINK-17392 at 4/27/20, 1:50 AM: --- Hi

[jira] [Commented] (FLINK-17392) enable configuring minicluster resources in Flink SQL in IDE

2020-04-26 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092914#comment-17092914 ] Jark Wu commented on FLINK-17392: - Hi [~phoenixjiangnan], sorry, I'm not fully understand. > in

[jira] [Assigned] (FLINK-17311) Add executable permissions to the script in the wheel package

2020-04-26 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reassigned FLINK-17311: --- Assignee: Huang Xingbo > Add executable permissions to the script in the wheel package >

[jira] [Closed] (FLINK-17268) SourceReaderTestBase.testAddSplitToExistingFetcher deadlocks on Travis

2020-04-26 Thread Jiangjie Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin closed FLINK-17268. Resolution: Fixed Merged to master. 90a38e8292b629e3d91b55941df00568d60542de >

[jira] [Created] (FLINK-17393) Improve the `FutureCompletingBlockingQueue` to wakeup blocking put() more elegantly.

2020-04-26 Thread Jiangjie Qin (Jira)
Jiangjie Qin created FLINK-17393: Summary: Improve the `FutureCompletingBlockingQueue` to wakeup blocking put() more elegantly. Key: FLINK-17393 URL: https://issues.apache.org/jira/browse/FLINK-17393

[GitHub] [flink] becketqin commented on pull request #11856: [FLINK-17268][connector/common] Fix the bug of missing records during SplitFetcher wakeup.

2020-04-26 Thread GitBox
becketqin commented on pull request #11856: URL: https://github.com/apache/flink/pull/11856#issuecomment-619655010 > The fact that this Interruption-based flow is hard to get right looks like it is at least part of the reason for the original bug, so I think it is worth thinking about.

[GitHub] [flink] becketqin commented on pull request #11856: [FLINK-17268][connector/common] Fix the bug of missing records during SplitFetcher wakeup.

2020-04-26 Thread GitBox
becketqin commented on pull request #11856: URL: https://github.com/apache/flink/pull/11856#issuecomment-619653062 @StephanEwen Thanks for the review. You are right, the wakeup is difficult to make right. I found the major difficulty comes from the efforts to have "fine-grained" wakeup,

[GitHub] [flink] StephanEwen edited a comment on pull request #11856: [FLINK-17268][connector/common] Fix the bug of missing records during SplitFetcher wakeup.

2020-04-26 Thread GitBox
StephanEwen edited a comment on pull request #11856: URL: https://github.com/apache/flink/pull/11856#issuecomment-619636516 The changes look fine to me, +1 to merge this. Maybe some comments for separate improvements, as follow-ups: - The use of `AtomicBoolean` is a bit

[GitHub] [flink] StephanEwen commented on pull request #11856: [FLINK-17268][connector/common] Fix the bug of missing records during SplitFetcher wakeup.

2020-04-26 Thread GitBox
StephanEwen commented on pull request #11856: URL: https://github.com/apache/flink/pull/11856#issuecomment-619636516 The changes look fine to me, +1 to merge this. Maybe some comments for separate improvements, as follow-ups: - The use of `AtomicBoolean` is a bit confusing. It

[jira] [Created] (FLINK-17392) enable configuring minicluster in Flink SQL in IDE

2020-04-26 Thread Bowen Li (Jira)
Bowen Li created FLINK-17392: Summary: enable configuring minicluster in Flink SQL in IDE Key: FLINK-17392 URL: https://issues.apache.org/jira/browse/FLINK-17392 Project: Flink Issue Type:

[jira] [Updated] (FLINK-17392) enable configuring minicluster resources in Flink SQL in IDE

2020-04-26 Thread Bowen Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-17392: - Summary: enable configuring minicluster resources in Flink SQL in IDE (was: enable configuring

[GitHub] [flink] bowenli86 commented on pull request #11914: [FLINK-17385][jdbc][postgres] Handled problem of numeric with 0 precision

2020-04-26 Thread GitBox
bowenli86 commented on pull request #11914: URL: https://github.com/apache/flink/pull/11914#issuecomment-619619104 LGTM, except that can you also add array tests in PostgresCatalogITCase#testArrayTypes()? This is an

[jira] [Commented] (FLINK-17012) Expose stage of task initialization

2020-04-26 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092839#comment-17092839 ] Stephan Ewen commented on FLINK-17012: -- Given that this is not a "critically urgent" feature (at

[GitHub] [flink] flinkbot edited a comment on pull request #11906: [FLINK-17356][jdbc][postgres] Support PK and Unique constraints

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11906: URL: https://github.com/apache/flink/pull/11906#issuecomment-619214462 ## CI report: * 9d527f923222f1fdf7cb43cc634435cda1248dec Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162068781) Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11867: [FLINK-17309][e2e tests][WIP]TPC-DS fail to run data generator

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11867: URL: https://github.com/apache/flink/pull/11867#issuecomment-617863974 ## CI report: * 6d991e80c512cef7385b083446e761625507f5e4 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162072570) Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #11791: [FLINK-17210][sql-parser][hive] Implement database DDLs for Hive dialect

2020-04-26 Thread GitBox
flinkbot edited a comment on pull request #11791: URL: https://github.com/apache/flink/pull/11791#issuecomment-615162346 ## CI report: * a6a3a9e51fd9ba484d1ab4ccd0646dcacc0692ff Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162072493) Azure:

[jira] [Commented] (FLINK-16611) Datadog reporter should chunk large reports

2020-04-26 Thread Stephen Whelan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092780#comment-17092780 ] Stephen Whelan commented on FLINK-16611: Hi [~yitz589],   I was waiting to get some feedback

[jira] [Comment Edited] (FLINK-16638) Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs

2020-04-26 Thread Eduardo Winpenny Tejedor (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092761#comment-17092761 ] Eduardo Winpenny Tejedor edited comment on FLINK-16638 at 4/26/20, 4:14 PM:

[jira] [Comment Edited] (FLINK-16638) Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs

2020-04-26 Thread Eduardo Winpenny Tejedor (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092761#comment-17092761 ] Eduardo Winpenny Tejedor edited comment on FLINK-16638 at 4/26/20, 4:13 PM:

[jira] [Comment Edited] (FLINK-16638) Flink checkStateMappingCompleteness doesn't include UserDefinedOperatorIDs

2020-04-26 Thread Eduardo Winpenny Tejedor (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092761#comment-17092761 ] Eduardo Winpenny Tejedor edited comment on FLINK-16638 at 4/26/20, 4:11 PM:

  1   2   3   >